From patchwork Fri Jul 19 09:33:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13737061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 925E5C3DA5D for ; Fri, 19 Jul 2024 09:37:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2B66B009C; Fri, 19 Jul 2024 05:37:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C8B56B009D; Fri, 19 Jul 2024 05:37:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0D736B009E; Fri, 19 Jul 2024 05:37:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C46CA6B009C for ; Fri, 19 Jul 2024 05:37:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7080180569 for ; Fri, 19 Jul 2024 09:37:14 +0000 (UTC) X-FDA: 82355998788.23.469109B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf04.hostedemail.com (Postfix) with ESMTP id C273A4000A for ; Fri, 19 Jul 2024 09:37:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721381811; a=rsa-sha256; cv=none; b=z5NLwXRdabf1WCI2VLqXR1pBn/yd4bg5fGgkqqdb18n9JCKZ5hMDJ4svG4atX2unCR3dFB CN3cPlq+FLsYikew+jpHhMxQBUfLsCPYJaqZ52jyiY4d+QjhBin5ezqD+ve9Fu9CXIkoRN cQ/yt27kdxlbNBz9UdVaK7hGtsnZbMw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721381811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IwAbT+hLz3cEJT/mdZHYyhO6KSxk14OrtNWhk1NjB+E=; b=hUACanoQpyf3JnVVk+Xr9CYncNz6etswblcvanT6J4mnBLx66YT6+S+PikS6wFCuyKW+1A oInigqv/nwwEm0xx3AwscIxvEbdloYVvoga4v/RLkgBa9KHrPb30FZwF4kXRwb1lTFvMhx uOoOVUxzivD+b7Ljj2va1c3CwQFBqTE= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WQPbC3QF3zyN8H; Fri, 19 Jul 2024 17:32:23 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 7C2C818007C; Fri, 19 Jul 2024 17:37:08 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 19 Jul 2024 17:37:08 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , =?utf-8?q?Eugenio_P=C3=A9rez?= , Andrew Morton , Eric Dumazet , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , , , , , Subject: [RFC v11 05/14] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Date: Fri, 19 Jul 2024 17:33:29 +0800 Message-ID: <20240719093338.55117-6-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20240719093338.55117-1-linyunsheng@huawei.com> References: <20240719093338.55117-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf200006.china.huawei.com (7.185.36.61) X-Stat-Signature: 1owfn9gito9ir8xnp3p5o34xeg8yhnr1 X-Rspamd-Queue-Id: C273A4000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721381831-894769 X-HE-Meta: U2FsdGVkX18G00t840rfO5ahVbeoa/DKxV8jgFbM1yNnM1MiulACB/yz1bie0EH6039RChMF5FqoV94SP8x5dw2a7jw8zMNKMfPGTWGMKcxSQW/E/rWEztqNFS3JhMhChOzzOOqYtcUBiIXu4HSTCMXXxxz0XZMwgI83KTG97jsQzSnfUTTK238ZMOOkFE2mYwuSuTv+p7WGyX6rohaAeMTCMvKRqVmS2lfsoMEz1WogX8s11zltisHZEyZyS0IsykPB1m9XvqmzOoccfBwHohb2hbD4gX88OAE6n05A9JK1BzwuUDVn+LbOsFR300AuTavwJrRSe6VK6XPkiWvsNLR19a12IM8KCrxYkINRNniVWLWHKBxfUHL0IOUFz0m0TJzd+ecguSiP2J1b8PBiUUmLQR7egbSMbzjBEQRxxSGUUrTbkrdsIVJf3oj0qp4QcryEb6Az/NUUpc+wXmFqEf1pZ6dsc0u5pkDUtCIWOqN+mvJiDGHrDrN7PB+O0Lit6y+gqMpDcneuWNrENmUqupTg7TZY3YKm+kbKtTvvt64rMa8hHo3C9DGBgE5HsWWuc8Y3GzMzSX7ziW/MegyisxRcm5Mvazld5WwXNT+IRoAQuYmVZQKSC4mc6m0XV2QTp9grAcDifcqV5lwqRqwpmEkVmWvhiktWXqSKXkxybrr971BxxlzgVnSyxK7j1Uzr1eym0dAfU5XvfgjStje2PWiPuxHoma9Lbax85zRaqrB2cqLIuwiwyDu42SdiDsLiA4ZWNUJmN6q+25jl0zWwB6/CoDsIRzM3RCVzBQiVAogh9MIgPhXDlWO9yb7uaTY8sjeNky1GetTnkZ20nJ5o1Ua7lXjT79qhf7IW3NQOxHDIXXS097CLuAEaLYt/ZYVlzAnC7754jFg4rKA6krKfHHhU/EGL5yKd5JVJynhqVFmqJlxllgsijScWq1EqpJAcKBBBGiPaMl7Qma5rYA5 IXlgqnAX wmmMdHJgRJyZ47rZIsq7vdxt2N8/MO6Sgf3JBf9JTEySyHUYgjTUpcUwKd1Q3fA+b8sglNoAbwrf95z6v0ruPIHdYVdwsUkRfGEEy0E+RIOc3YOqQycLgiVBQctbysmehdRovGdUK/vZU0X5wM1QnpA42J/nV7LtUpBemQoTHz7mGzut76xtVzV47fadic9fwABxtnjak0OxGbKV4bgRQfFDho16sUSNipY21RrhutmGQELc/+RXw1oAT8VccmsjN/UZvq7CFbR8r1acbKPlMLcZAOrFKg4mh6r3V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use appropriate frag_page API instead of caller accessing 'page_frag_cache' directly. CC: Alexander Duyck Signed-off-by: Yunsheng Lin Reviewed-by: Alexander Duyck --- drivers/vhost/net.c | 2 +- include/linux/page_frag_cache.h | 10 ++++++++++ mm/page_frag_test.c | 2 +- net/core/skbuff.c | 6 +++--- net/rxrpc/conn_object.c | 4 +--- net/rxrpc/local_object.c | 4 +--- net/sunrpc/svcsock.c | 6 ++---- 7 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 6691fac01e0d..b2737dc0dc50 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -1325,7 +1325,7 @@ static int vhost_net_open(struct inode *inode, struct file *f) vqs[VHOST_NET_VQ_RX]); f->private_data = n; - n->pf_cache.va = NULL; + page_frag_cache_init(&n->pf_cache); return 0; } diff --git a/include/linux/page_frag_cache.h b/include/linux/page_frag_cache.h index 4c5079f232b5..ef1572f11248 100644 --- a/include/linux/page_frag_cache.h +++ b/include/linux/page_frag_cache.h @@ -8,6 +8,16 @@ #include #include +static inline void page_frag_cache_init(struct page_frag_cache *nc) +{ + nc->va = NULL; +} + +static inline bool page_frag_cache_is_pfmemalloc(struct page_frag_cache *nc) +{ + return !!nc->pfmemalloc; +} + void page_frag_cache_drain(struct page_frag_cache *nc); void __page_frag_cache_drain(struct page *page, unsigned int count); void *__page_frag_alloc_va_align(struct page_frag_cache *nc, diff --git a/mm/page_frag_test.c b/mm/page_frag_test.c index 9eaa3ab74b29..6df8d8865afe 100644 --- a/mm/page_frag_test.c +++ b/mm/page_frag_test.c @@ -344,7 +344,7 @@ static int __init page_frag_test_init(void) u64 duration; int ret; - test_frag.va = NULL; + page_frag_cache_init(&test_frag); atomic_set(&nthreads, 2); init_completion(&wait); diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 4b8acd967793..76a473b1072d 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -749,14 +749,14 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int len, if (in_hardirq() || irqs_disabled()) { nc = this_cpu_ptr(&netdev_alloc_cache); data = page_frag_alloc_va(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); } else { local_bh_disable(); local_lock_nested_bh(&napi_alloc_cache.bh_lock); nc = this_cpu_ptr(&napi_alloc_cache.page); data = page_frag_alloc_va(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); local_unlock_nested_bh(&napi_alloc_cache.bh_lock); local_bh_enable(); @@ -846,7 +846,7 @@ struct sk_buff *napi_alloc_skb(struct napi_struct *napi, unsigned int len) len = SKB_HEAD_ALIGN(len); data = page_frag_alloc_va(&nc->page, len, gfp_mask); - pfmemalloc = nc->page.pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(&nc->page); } local_unlock_nested_bh(&napi_alloc_cache.bh_lock); diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c index 1539d315afe7..694c4df7a1a3 100644 --- a/net/rxrpc/conn_object.c +++ b/net/rxrpc/conn_object.c @@ -337,9 +337,7 @@ static void rxrpc_clean_up_connection(struct work_struct *work) */ rxrpc_purge_queue(&conn->rx_queue); - if (conn->tx_data_alloc.va) - __page_frag_cache_drain(virt_to_page(conn->tx_data_alloc.va), - conn->tx_data_alloc.pagecnt_bias); + page_frag_cache_drain(&conn->tx_data_alloc); call_rcu(&conn->rcu, rxrpc_rcu_free_connection); } diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 504453c688d7..a8cffe47cf01 100644 --- a/net/rxrpc/local_object.c +++ b/net/rxrpc/local_object.c @@ -452,9 +452,7 @@ void rxrpc_destroy_local(struct rxrpc_local *local) #endif rxrpc_purge_queue(&local->rx_queue); rxrpc_purge_client_connections(local); - if (local->tx_alloc.va) - __page_frag_cache_drain(virt_to_page(local->tx_alloc.va), - local->tx_alloc.pagecnt_bias); + page_frag_cache_drain(&local->tx_alloc); } /* diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 42d20412c1c3..4b1e87187614 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -1609,7 +1609,6 @@ static void svc_tcp_sock_detach(struct svc_xprt *xprt) static void svc_sock_free(struct svc_xprt *xprt) { struct svc_sock *svsk = container_of(xprt, struct svc_sock, sk_xprt); - struct page_frag_cache *pfc = &svsk->sk_frag_cache; struct socket *sock = svsk->sk_sock; trace_svcsock_free(svsk, sock); @@ -1619,8 +1618,7 @@ static void svc_sock_free(struct svc_xprt *xprt) sockfd_put(sock); else sock_release(sock); - if (pfc->va) - __page_frag_cache_drain(virt_to_head_page(pfc->va), - pfc->pagecnt_bias); + + page_frag_cache_drain(&svsk->sk_frag_cache); kfree(svsk); }