From patchwork Mon Jul 22 17:29:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13738979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259EDC3DA59 for ; Mon, 22 Jul 2024 17:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82D7E6B0082; Mon, 22 Jul 2024 13:29:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DDE56B0083; Mon, 22 Jul 2024 13:29:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F616B0085; Mon, 22 Jul 2024 13:29:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 44B206B0082 for ; Mon, 22 Jul 2024 13:29:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E335E14199D for ; Mon, 22 Jul 2024 17:29:30 +0000 (UTC) X-FDA: 82368075300.20.A274669 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2051.outbound.protection.outlook.com [40.107.102.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 07FB420007 for ; Mon, 22 Jul 2024 17:29:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=oixHRNUy; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.51 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721669322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=i8Gzw7y7sG97NEPUr6qENMLG1Y85frlPpN/bV4VSYFs=; b=SYN63r1jbzzJcaYmWptnO135nq8ZsdzhFSTlotH9GGMAxtBVZXMTQXnbSfeXQEhSKTsVnd Y3W3vHIFmfyB+HFfvzU5M/zZrQDfDGIOr0YWYKgX7vOoOsyjShtz01QPNY7hkFUKPvqM+/ eNMawK/wjXkfWdU03c6ewOyiMjPRsmY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1721669322; a=rsa-sha256; cv=pass; b=mJayILNfNZGCVrw6h9snNEMp+tUtDx7PEjgCquip+qiRSD2poNpUvTm38R+Qh+t2HU492g F5G5CKYiL3RG99GaR4Iv06bC3uKaDDttbsrzoFtOlt39ML9PMjqJrxwbI21HBctXt93CnG YCmlmmCQFEqf73nZCrDLgEi5HoQVxCM= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=oixHRNUy; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.51 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kI2TQ9WSkW+wpvcuCMnkx7hAYfWnnHxMKCFberp7VBQTfRWyfYnw7K39KS6GsE3ewxo6qNe2FMPyrpKjI1pJ4QM5Vb0Q0xPEMrlrdHh6O8wshQU29Omlp5BsJDqabx1ev6OF/V75Dw7pajSjAdHxlQ1CefbXQ+dtbEKFXJdtPGIiwvXZ3G6PFi8ovpQbVNNEf8IkIxAWA8Q/LL7YQxE4GVtVXVakeo+LIG0KVXH0SZIBtSDZXSYOvRP+R2PTNlttiiZx/0tw268LaWo91fePZkEfP1SmIFYZrpxcHl/DkoVqK0HTmGrmebpDY0HX5DLJ11d8UodvOCkyf1L8qGxCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i8Gzw7y7sG97NEPUr6qENMLG1Y85frlPpN/bV4VSYFs=; b=AW5d3PRlWA4H4YnVIvJsJzlH5N6rnimKHBy68p5gtQGa/OtZocqatjH/LV57HjO1WOKTcZVCe4/9U5ZWbd7GeEC+D1DcLxfY7qUi18WHNArVlbFPCdpEalj2fWRcBdbBnbLmdDXIdAMQWFWUKW89dpmNbf38JFUDelUu+nQe/mIFoe3blkGy7xgE3Qbv0BiEGWj3bSJN+uK+MNpmqo92HdySs8Cbc6AbB/Lyl/FOZ09XteC+2bb4TykltV6vS3dRTKbkWlm1QThQj1gIqtPYvUA7i5SuWfbpxdPffWjvCIra4A0WN72LaC0svi8ghC2FJHUrPtvrMidyWrNUgWsNfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i8Gzw7y7sG97NEPUr6qENMLG1Y85frlPpN/bV4VSYFs=; b=oixHRNUyxtYJ8ZiT3DOVxm/ogEioAThIPzfNa8rkP0bdnMG2LaJMXcBCJJsrW6yf/U6A6ml0PSu3KUQpf4Fwg49ASVCjWMrYugfhATZ7GNDkcBLqieM55tXTYIcerk4iLA/zc+wp6WPkqnsj2DyOZMdfliWH6OpbnmWYOt8TSrFzJYBCQE+WtfUjQCw4KmE+mhg4oCJ1SyBnvxobjRmlhAxOoFZRZpYjr4gy71jk8Ef/qvhy8u2Ok0e1iucspoSGcM30Xam2qGinngvgdlmxAx3g1hdGLruc29spLp2z9Rm4Mf6//3qOV7PGSOYYSwW3RC32aD9MpmLLOOUo+FhAmA== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by SJ2PR12MB7944.namprd12.prod.outlook.com (2603:10b6:a03:4c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.14; Mon, 22 Jul 2024 17:29:22 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::f018:13a9:e165:6b7e]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::f018:13a9:e165:6b7e%4]) with mapi id 15.20.7784.013; Mon, 22 Jul 2024 17:29:22 +0000 From: Zi Yan To: Andrew Morton , linux-mm@kvack.org Cc: David Hildenbrand , "Huang, Ying" , Baolin Wang , Kefeng Wang , linux-kernel@vger.kernel.org, Zi Yan Subject: [PATCH v2 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() Date: Mon, 22 Jul 2024 13:29:15 -0400 Message-ID: <20240722172917.503370-1-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 X-ClientProxiedBy: BLAPR03CA0085.namprd03.prod.outlook.com (2603:10b6:208:329::30) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|SJ2PR12MB7944:EE_ X-MS-Office365-Filtering-Correlation-Id: 48175789-c3b4-4923-7a53-08dcaa73d35d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: ifPb+0xJDLfklnWWQRko1xOMmmsPe6+01/9ocyQWCtVdsSMS8zD5yL7GR5s+f/sHtUpUhAy5iytsNm6iIRL08u7y5MspDZnoT480DG7GfZUGZ5UrjDVOFgySuGTBh29KrXLYahOiqZ28hH9lBWxXvrpuot2y5+L7BW6mu9B+MM/yvGnTVqNlIbN/r0Qt7uNmJPm/+3FPAVsCF/72/u4EQnjCXiYxwejzdV349v293PypP1qpjNPLoaUe8eccg7J2OQ7N6Md6+UuaL/evVje3dSgktG8DzO3tCBb4pbQCf8z8iodmmMHwuo2eDyAD8a7ZlRCbDZuhaKjwf9mzGMSRhWNETGl3XqlUZLATOqL3lc70iYKoWMeLePNQPpmUejeP2iW9D7njG5yUt8zrKlL3aFx9i6iqUniXDQjnDjXhqc2UU8T4awlMwdckkLErdXA7oYdDHjgQ/qJgVwqSqXaaAwQ4pSdJ6rEe+uWHD2kmAYkOEYTQK5Lg8LQVuymVw2+9TM4pZSGa8do/t4r2+vVsqC0qjaErI/B6H0Yi2p3jaNTbjBGNiTtkl/p1Gv5TmjdNjEq6q26VlOGqjDd6GzHbkuZmKZDPyEOrgcpRXEao3UEkuz9bZ2O5RrWny2pr/nS2GWf1aTdyE/h0yRGQwkUGFXZq3026hgmDfyPPdwjjI2vlAJkPTVd0rVTDiOS/bZp9Hq6eOj0Sk0ByYbhbMueGBNw8Tr2xcrqySJpM60zWIAse07hgH+U/2FTik2/Y7rnMVARGR5T86NusGMdZAwC9biUUjXJxCrJ0r3jK9EcgW4JseWF5oeX1CZAJQv+wcvzT2xJLhz8kYkSUsKZEFdd5DSjvxzTXEo9nXQVNHODGR+4PLxmh3xZ70gJLV0OdkAKJMFH5+axU4XaUh1DonYItk+jBIdcXm0TqW7MiMNA1AzCAS+kR3QY07AcKQDvUB0g++jsyboy9kvWXdySTZ9uu1gkzqWjOoYYqHeT96v/Zhjip1einlEH34t6y81fv+H8g2gqeEV2NUrqrZ1/Ujn2iknQ9Lto0qLQSPZeSot2j4qNJcMuKwt0VtIFq0vron7XDimgpgIUa8q0CrdLE7gUVqK3SLYpwJjNlsWO+Orac9NgB+5AmGkWrMyEh2LwXCIobvq937KqFfG5U2ZsI+D2ywm0BprFrVNfjL879USw8phjSrfLIp8fWD3+pGfDCN9jORkXRu4RmgBLdOMZXsg4uhR1G5Q1OP5FwjggjGgw2nDVC9FkxZxNrq08Mh/IaN+DxmluTvmqLA1oMfLcFaucv23IvHJhVJ29SRynO9Z58renFtP3ssxo4ZAU33A3zLKbQNeIFzTJc3hKmeZuK3enr1A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tpwmDIS3jChw8UwWoWF08Uq2KmBjly6fuiRcb5rGpzBC21t/SIQWFAT3fHvC6j0Ud0IwRIrxK0Ll8lAV/XMrmD7rDnKQYcaGYq930vmrQLRXgvpzphrMScBrODK/OBPqWJ8ncR5AwbIK7+1TwoCrBh0s6Z7c2md52Drix+Ik89ac2nlTGMhFeu1l9D4dhf2jqztR0RxRosQx8mz49Mn/GKXUY7wNmqFSfq0rlrc3nf2GqrZfYzWlmciEQoyO2pRJCit1TUisLNSyYoqMe1nktNUxH93WRAvYf+a3oxqCODAygnuvH5XtjlYC/MqAwXzLRSKOr4MWuCRqFfs6yDXPxTU44xQskdP+r/tm3jdpUcpzGi4EROLLrPcca9Fq3pm8h2PCM0c/2IceR6WyiT9oo2tC+tEezzqXPJ0JooF1mWGgBCtHO+t0Obn/8bNuAjyiLbrYxOAJglXoIIOr+8Y0LL1OIfZt1+IGLyKCfMQGML7J55FvsW9w5LEtDhl24yj/QJqOs/OzzyxD5Qb2+bQ/glVFL/aNPzbQD8QeoyCBYp0TZ+hCQ08GFr+u5FOdzRiorafDuNpM75XbB3vhkufP19qlcKMV+9jhaWDBfUDBMyWayTikCFjjrgHpLjPyIOaIjLGKnCG72CEy6UPR3LyAiiT7x8JuuQLVfpEXUFZjIKx8x/CmRMASGN2jov1dfsDku03KIi+JEDTajqs7g1jVH6B6LZbkI09Ie+zTVhAnMJLxyDiZIFKW+HKMKgshLxgpr0+458HtMRZnB/Sa/GjbH9jCcOn6VKlqiao4y/pdIQpaxqJDFBAwmnTZAhp3eEnkdVU3FgfY6x42Zf2NDoL9bstOzUOaieXdsgOIlAHhaVh9UzSGfAjV+U2o54A5jnnRnUe1Cx3Vb/6+whsofI/p5ZvaF/2tRz49rS3gmEmJ60qjdv9PGftRFzpSamHcEKL+lqYZxQlBUZ71ADa+H2uOsygBg/ePv1e71E0a2CrvQVLTAFdnR8TVUroH+WPXXVHeeiMLIDO5u5kEsD/Y+sxlceZhXjEklbaL9oGxkDeKBbd8GODA4N4qUn7GeNuGbLX62se4mJMAVvmviOIvEaV99eXM192iqkda9N5hK15n7iM+PlCk/UrKoRwjFzwsK/OElkYcd0qqOQy30IeTAdTFamjyQ9XO3wArcP5CFp/45JoV/Erp6cFj+C0ESp/K/DAgAIMblYT65Rsp5dayWuFMeBK73IoAr9x7m4Gh5lwloquhGqe2Iwrwbb6WD2jwGEd5030nxyLxunQFyHLXhNq6eFFEsl22fj2SEjgumTX+w0r6q7Pg937b4h4Ls1ObbBQqs/u9CoRIlmcK/pJ2eP0FqDtQ3CEloFBezgb7Qso32thcsncXG5QtYcsPS7OR6EiTEb46ZWL/xKh21gDyIQrvXWz0udU4AqJM0u0wixQxomn1jL2zNosM3ikRE95e+i0AdMymhRKxLfrvwnLo/kMD2LFvd3zwhZj+GM9P5EensiunoB/O6vtFIKN0unPNQBQOVJ3Zxbdvh3g54XlRa8gM2dddqKJfdo1wniOEADCQkHs= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48175789-c3b4-4923-7a53-08dcaa73d35d X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 17:29:22.4941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: loKXtc20IkCMCkoNVdshOPqDOrFWX+DE28F7ruoiYfQa5NUoRvHPY6DmISLukdl4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7944 X-Stat-Signature: idukk89j7i8w49ck13quf8mophbekpg1 X-Rspamd-Queue-Id: 07FB420007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721669367-930864 X-HE-Meta: U2FsdGVkX1/PwQixUy7+UIRBADLrFfUWw42fWY8SFXCOLaofrGKw6ZmO9l+qfu2fYurJuPyr5e8sWI5JBzAwgmqCj+5s8dEeb0zRb7BCPHzpVzbwVv7Hcq0O4LYcM9MBB+XcmpxQgysgKPQh+nP2ZBW4N+sFnl1ql360PpLz5UckWMQTiG+Ai4Nka+66OMvICOGS6InHFg6RJQ+Xg6JlROfkhMWdDpFhRtDFpSb/iXATCT+O/r2I1hZXYuMEte/Ac+SPlRidLCaa/a3qeLi8fIbhaA34CM7hrHz3J2cB6bkzNMIs1BUkspj1l6wgLsQWfJIhuVphRBMjV9bNd7+Dz7B4fDSHq2UmytANJFIK+46xD0H2LRqsg37hlvW6IUqAkISdtE/oM1xAB8gotL0jYvezGaWwxSjgwHlGGvJY54gxf3HqZjQ1uuIZJ4958Ox/cSVZCEyM0Ww/5+/6Jj9nnqeLGaxaU8re9FAWDDSrwIIKPETfmMaTv2wOacB0szCF4F5tyD6IZroneWVDCje078rBi/UGwptlnai1gtcAfDj06WKVEX1eTDVJLjBhimonMlOZK1WhvuRwn5YaXUjUJfhbWMgDnMNCUBMXq1pRnIwpTtRw8oVwJIlOA6nUrzswOjbGS1A/rT0PvqD5bgLn7yeFHeHKg5MzypQHlVNlu3QZKMwztbf8L+OFYjMsLDkYDivD250u0uT2ZDegOXffx77CWbh0dTQbYH1/yReUZkznUlExXQtbBszGvMMPJWw5UEdrv4jmL3UFdiBGg+qH+WhsAkhbOzThP4N7xuNVeqvmtEY7THVV3s0qADXDo6Vj/5zdA0hqEX29ENdyB0Xs0B1+9nnUmEO6tKAwKUZ0zLXcgkGHl39kKXAQrt2xHSBWZWdn0V+xGpRvLfalJSdRpuCLpnqdZtMDgFWWRXcqgTX5RFU+Ti2ghAbawQyx8gs6hgP0KEYlKK69yir5GS/ TXMcrMY+ IWmta9+oZAfkPWeia236ACNW5ck8iKBHvOM0ZlK0Txv2PjQ9In9iGpz72QNpBRfORz3NRJouKFV3twFfCVaL3tcWr8UJff4j+cZxlPH4T50cM68SodYo+ZblBGfDOF5aQWhRpJE5/J+YFnsCeiV/G6PzqSGIJhgboPAQ0Xtr0t+x/LIfmqLE1BvnPO3Is5ZDLYaaQhUa8Ahad03fsFAKS4/1Vrsfcz9JrSQC5gaEWeYR4P4UixkROUW99wzcfAe5UHKxTQ5EWSh/ymqd68t6//JIXbe0phf+UHwECFiIH5Pj0e4m8DYEUwAmYf/mHcj74nklJ6VDe9fKCbf+Q1Eg7drWlNg29LHgUoqNkNlI6mx2+cBtLuMo9wBFPT5iAN4vk3o0MWbrlaNRslxP3V0o0m9sVlbFG/diqf30rY4CRhOujqZ/rZrmCL2USBSJWax1WPlKWgS5KReyidwllvciVhQSZ5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: last_cpupid is only available when memory tiering is off or the folio is in toptier node. Complete the check to read last_cpupid when it is available. Before the fix, the default last_cpupid will be used even if memory tiering mode is turned off at runtime instead of the actual value. This can prevent task_numa_fault() from getting right numa fault stats, but should not cause any crash. User might see performance changes after the fix. Reported-by: David Hildenbrand Closes: https://lore.kernel.org/linux-mm/9af34a6b-ca56-4a64-8aa6-ade65f109288@redhat.com/ Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") Signed-off-by: Zi Yan Reviewed-by: "Huang, Ying" Reviewed-by: Baolin Wang Acked-by: David Hildenbrand Reviewed-by: Kefeng Wang --- mm/huge_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f4be468e06a4..825317aee88e 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1712,7 +1712,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) * For memory tiering mode, cpupid of slow memory page is used * to record page access time. So use default value. */ - if (node_is_toptier(nid)) + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || + node_is_toptier(nid)) last_cpupid = folio_last_cpupid(folio); target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); if (target_nid == NUMA_NO_NODE)