From patchwork Tue Jul 23 06:48:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Ying Lee X-Patchwork-Id: 13739589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69EC5C3DA63 for ; Tue, 23 Jul 2024 06:49:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E27F36B00C3; Tue, 23 Jul 2024 02:49:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAFD36B00C4; Tue, 23 Jul 2024 02:49:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B966B00C5; Tue, 23 Jul 2024 02:49:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2B196B00C3 for ; Tue, 23 Jul 2024 02:49:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 44A6C161D49 for ; Tue, 23 Jul 2024 06:49:43 +0000 (UTC) X-FDA: 82370091846.08.ED221F5 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by imf15.hostedemail.com (Postfix) with ESMTP id 1EF5EA001B for ; Tue, 23 Jul 2024 06:49:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=QZmzfd7d; spf=pass (imf15.hostedemail.com: domain of kuan-ying.lee@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=kuan-ying.lee@canonical.com; dmarc=pass (policy=none) header.from=canonical.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721717319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SSby+veWhYFs/KPIxtuFQP9fWzklyucEzByPv4c+H1w=; b=xfCbEC0qI1F7WTRPnFy0Pu2giBiciRjBLZfQJqYeyiEWjrNSx8LJ/or4o1J3CsrtkY45WC 9DgUQ1uYVZ3+vS3Onr50cGiLYGi27M/OyTbSXS86PJotXLL35VWHbC938v+sZnY1/aGm3o 7uhADMK2NKDQ9xpbsYyTvSx3xnZIysU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=QZmzfd7d; spf=pass (imf15.hostedemail.com: domain of kuan-ying.lee@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=kuan-ying.lee@canonical.com; dmarc=pass (policy=none) header.from=canonical.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721717319; a=rsa-sha256; cv=none; b=Lzi6tF9iaIQSGWci38ehJ5+GqDdttHsG/uHjVhErGWIyFukmPG/P+7NTUqsexSqFN1sbgD TMaAwX/alNzP3Y1/DoCHd8vvFyjYkcn6Hc49aFRjxqWaM4gUliAbP++7dajGw8Atsu9MLq lKMCCFx9zqeT4br9YRFKyQdlpZTUlyE= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D90A0401AE for ; Tue, 23 Jul 2024 06:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1721717379; bh=SSby+veWhYFs/KPIxtuFQP9fWzklyucEzByPv4c+H1w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QZmzfd7dB0K8vSbyizDbW0rjiOZCmzKQDTD1DS/GKZn7AG4xAk4+d3g535VV4abbz ar3HW4NVPjvnOz/KGsXIgKxSammVFQ/gZvAe05PrQvJarHgI7lE31GkWK0QgL/9ZP+ I2T57fHCzxg+GP69ZOgA8sMLSdE+c5tm6ZpFxB9tS4AZA48/hi5sg7qBwIxkDkJzmE IEezJ0S+HDr+B8+aoXzEGt4obRJWKtEkyBSBlLpJigktps1XwOfO9cMDjD8QYbM3ZK SicFBUn+YyQtoglb5OsICfmePMbv2tICdaqTS39pdXpUt8kFAQxt8CrSS98A0dq8t4 hFdhb3jlihCJw== Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-7a242496838so450016a12.3 for ; Mon, 22 Jul 2024 23:49:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721717378; x=1722322178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSby+veWhYFs/KPIxtuFQP9fWzklyucEzByPv4c+H1w=; b=fm431D21XsOEz6AlfO0w3CYYL0v9WD4iDJGxm/wFhTu7T6US4/+RoF7srj6mBHpK9G xdoTU1g2CrBRBvpDJoHC1IbIgJ8LpRN0g5cJHY6cNG/YqFLpx2zPN7Hkl40WhPI4Edur YBdT2BIfgd6Fg7W//vE/KCcdrIC9TroVk4jfns53b7nweBDzZYOmSD9f33b1HRZz3dxh YZVOXXkUF8E51s08ZMkjbawTHn5uH07u4CkpzBg/pBMmlts2fLpE5AglzcM9hm7lE4tX iuqhVjVzZ019Eu4THuKz9s+JiMYG6AaOfKk1vOQN5+zm1AUHTZAi0rRyGylVhWMYhxPh l6Zw== X-Gm-Message-State: AOJu0YxyymkxQAZDs9nOgrwKtaL44ksGF4JTogngt8PGNoGFGArgW9GP VIINA4Dj3Ph9H+cAWsbuMAmm7hGu4hB99NWI3e9fQUb0uEePoeC7NJKC1/wuv2gPwOkBg/7IuY1 GqFJjxtS8ml5jaKDwdwlS7OzZf5K88jm41c6D/tflcQr+S882w2WoWEk4ZiD4KTde X-Received: by 2002:a05:6a20:6f04:b0:1c3:ff33:277e with SMTP id adf61e73a8af0-1c44f86c92cmr2110006637.32.1721717378103; Mon, 22 Jul 2024 23:49:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDabqAEkCpkyaJ7TFPUAZCurxHz2+fpzUWqrGvdUCtX2upCViYYzhYgk3ASQ8CzhkJfiBe6w== X-Received: by 2002:a05:6a20:6f04:b0:1c3:ff33:277e with SMTP id adf61e73a8af0-1c44f86c92cmr2109987637.32.1721717377759; Mon, 22 Jul 2024 23:49:37 -0700 (PDT) Received: from kylee-ThinkPad-E16-Gen-1.. ([122.147.171.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ccf7c5391bsm8354749a91.24.2024.07.22.23.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 23:49:37 -0700 (PDT) From: Kuan-Ying Lee To: kuan-ying.lee@canonical.com, Andrew Morton , Jan Kiszka , Kieran Bingham , Christian Brauner , Ian Kent , Miklos Szeredi Cc: linux-mm@kvack.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/5] scripts/gdb: fix lx-mounts command error Date: Tue, 23 Jul 2024 14:48:59 +0800 Message-Id: <20240723064902.124154-4-kuan-ying.lee@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240723064902.124154-1-kuan-ying.lee@canonical.com> References: <20240723064902.124154-1-kuan-ying.lee@canonical.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1EF5EA001B X-Stat-Signature: ky8ugo75bmcc3aj56rtgzmc5hjeo468n X-Rspam-User: X-HE-Tag: 1721717380-964617 X-HE-Meta: U2FsdGVkX18Ga/6zX+2G6cukIXMJmUzguPR+S7ajeI9QPTZiMLkP1gXAkv4zkc4mJC1Gkjj43d5zYSxmSu2V8+qg5eAC/cXo7W6eTlFfveJ49hwOGJJGVkp0GyortQHhfYCRkcCVSBx6m+l/obErT90I0VVtWkUpLicLr8IQ/8OopJ/+T1CptEg0qcaEdqEdsrORHuytiHnaGnDS5eH9ewmSJU+B7vhQvFJsgNIrUTQ/rPVIuyGXDozJ7Sr9TQpiW9Kfp1/2kOiQkldYqp/HULqHF4MNsxXQcAxySWsE06KgKlxNBB6HagBU3iYlAsQKnBhI2zwSwrn7KP2bEJ2CPo0fQaMWFH2xE0L1+S4ZECPrIojVlelcn+7NL8Fe3w+oLLy37WQK8vW363FJdObAx0mJ41UOAqQ+MIyOpZ1Gh5wGwJrhAQzSpL4YlYvpxtb9rVAyaV1ZyroJl+2Whjyrc7CSqITaLEgYmDKJtiBZV2wukGwWhqyx2ZsayKKjOTP11fNJc+HwQj2E8bBb+okgkmSMjHUiTJ0rzPKVKLWyYXu9uaNO1jrUHjEzp/bzDDGKlR11aCVvdqXVMW9qBdf/DrhrOrVvPrGw8gU0b8xF2YsckYjl7r5o86f4+TbY0qK1+mEj2n7tPSiayXy7viKvrxgDYLv3XxzXW24J6oGrFChCtBMNNZijrbBE1MnkKYDHiS0N8VDeWx3kxTaJpO+qNTMZlJiJ8CQjvFb51m4r/9R2B1dgO1/wF/O25lApv6bc15s+59aCPy3rJm/5s1YjUwZWQp9bF3HOukTxyecFvKo0m4RYn/xXOxEJb9f/Z2E5PXNKqlQggeB5Lsxs9dJHIbMMy9nw+ateMUUqw5ewu1gHyosgxLXieItEFiCQ3DVDOy20qOEar+jymW2bbRYa9O77R7NsPk9F65Dysft6vy+C2vmRjpzmqUVXfnW73/EPifdauLPrIhJfjTdd3wf UioxNUol kAnAZI3Vs8GD82y/9qHlyKZ+kIhrcgx3XqfO9QAsIQu8CWox8WGNm6BEIF5VP6qg+MAdgSHcjh95nv5yDsJLyF3NDIH10awQb5/zovhl7RfZj7UWlA/huAfOdnJc5Y2Dby93/Mreko2r60+2WczQHRQtN/5gaLubLJq9Dv+QT1tQVeOMsf6Cljob1lzoRgqQuqJtGitW+WshVvuM35f4klyWp6Lz6R8KCObHah0gyKpI3kXBY8c8gytEZcY5/9pLGWKlBt4CxZPfzYKF1b/HxhYHfmrbEz5JGtTLNmbdMs4cxMJKwSAJIKeNSfzuVOiNr9PtsSeSlc6EPygtD+1K7m92pYJV+t5rS8LOAE7kyt4sqx3ep77D4JwiqV+Jjst3GrmTo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (gdb) lx-mounts mount super_block devname pathname fstype options Python Exception : There is no member named list. Error occurred in Python: There is no member named list. We encoutner the above issue after commit 2eea9ce4310d ("mounts: keep list of mounts in an rbtree"). The commit move a mount from list into rbtree. So we can instead use rbtree to iterate all mounts information. Fixes: 2eea9ce4310d ("mounts: keep list of mounts in an rbtree") Cc: Signed-off-by: Kuan-Ying Lee --- scripts/gdb/linux/proc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py index 43c687e7a69d..65dd1bd12964 100644 --- a/scripts/gdb/linux/proc.py +++ b/scripts/gdb/linux/proc.py @@ -18,6 +18,7 @@ from linux import utils from linux import tasks from linux import lists from linux import vfs +from linux import rbtree from struct import * @@ -172,8 +173,7 @@ values of that process namespace""" gdb.write("{:^18} {:^15} {:>9} {} {} options\n".format( "mount", "super_block", "devname", "pathname", "fstype")) - for mnt in lists.list_for_each_entry(namespace['list'], - mount_ptr_type, "mnt_list"): + for mnt in rbtree.rb_inorder_for_each_entry(namespace['mounts'], mount_ptr_type, "mnt_node"): devname = mnt['mnt_devname'].string() devname = devname if devname else "none"