From patchwork Wed Jul 24 13:01:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13740915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAE6C3DA61 for ; Wed, 24 Jul 2024 13:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DEC86B008A; Wed, 24 Jul 2024 09:01:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78DC96B008C; Wed, 24 Jul 2024 09:01:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612236B0093; Wed, 24 Jul 2024 09:01:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 419AD6B008A for ; Wed, 24 Jul 2024 09:01:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DAAEF12093C for ; Wed, 24 Jul 2024 13:01:42 +0000 (UTC) X-FDA: 82374658044.04.E3F36B1 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2053.outbound.protection.outlook.com [40.107.220.53]) by imf04.hostedemail.com (Postfix) with ESMTP id D577F400AE for ; Wed, 24 Jul 2024 13:01:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=tchEVv18; spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.53 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721826063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RF4UiEA4wU82ykwfKNn44Zy0CR5GrMNLSl7SIWdKIUg=; b=TlH0qUjms9nRJM4P9l9PpHQ1rbVO6CtlxByJopEZ05BzwKeQKOEZzf4FV/CEumwX/1j+PM SG2pgrOrHwZ7lhQvVWSPNwF9ZhRionNYFkAloKIwJ9EIYPUSi6TvPWwPOQ9754QFMHLSyF yvWAT6EQju5K1XXtrxmBqPzcE16qs20= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=tchEVv18; spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.53 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1721826063; a=rsa-sha256; cv=pass; b=r/XcC3237+5WaDR2OycIeFtdhIlhjpmU0buslE4jeBmat1AeqgmrZVQf3emaOLWelMbiEt SdyG7wk3omEj5QA3nKyEICXfFY9i8dww5B68xI/SJNXQ2DW8qk+AzkCWsotI1fqNetmSVH QsY6Wzk0FXO0lpayAl7NGDC+KJWfJD4= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f9z4ZGbwwXS9S5F/jfmyudOgkHbciwouJoRA9UBNHyMGJHgOag1t3mBSVDbw1zAgsN3jpj+3ypfPbQRnbzIHq+NHW4j5xcgLFvxQUTAERetUbVzP9NPXr3kmDrILa6N5nsACCyL0BYrGbGV6mu08a6Lz69cKZQcdwtZtnM0sdxiQgFmfbNRYVa0D+2aEdJK4RAtzhW9yhewLtwlAJoGXsC4BzJKbAJx9oX7fd6myCQLaox1THurIGxdcygQvcK8NS5AGDSej06MNSRTWj20A9r6UoNCXgNHjA8qeKs3cL0/QAA6KaYA9nikPX3ivAQ8bOkXBALL6aEXXmGtnv9TF9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RF4UiEA4wU82ykwfKNn44Zy0CR5GrMNLSl7SIWdKIUg=; b=yolt4R2LgHQOAJsaubsZMxi6ppuEk8m1FucJ7dTBrSDYkWYpJ9JZeOevhNbausPa5vbvEhUXnnPmDVoEcu6J2WlpbUmcw5peOBz41+FQXOcN9nwNhc4ZKpETnMYzOmiUr1aREglRqaGRkyTrIZnL6M4EGnklN/JTxFO5aCqH0YqbaSrJaFyhZwMvrw0msNQC1ue0Ol++8AIztVhAtq4So6LYFY2ttrOFbaLJ/hBftXtpwZ3abmdh1s6NFBTYytE5FlJp8Lsn5NUY4LWv7HMs/l+QcZn/kQMaLiBkX93bv3dETZ5BtKgkMj4ijCCOUbW//a5QlXolLwPxnuVm8MwIuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RF4UiEA4wU82ykwfKNn44Zy0CR5GrMNLSl7SIWdKIUg=; b=tchEVv186QOETpCUKilziV2rEPCKlCE3Zlb9yx33o1d1GMK8TPpOwxUEfm+aySITGZy8Fcyo02kBC20XhNG5KqPuHBay5UAhUtj38j9jS509/lAX9/av6eshVNw9hhS+CWHOJ3Gf2KgMZsr3xAvqYiMIJYC8fI9LJzvKcJxn5wbi0562NYf+8tWIKvgElupGE3tCd3ygQfUMuIG8lHyDdiMnJ8CdViy14Lh1uqCwZNURXTRU4ss38eXRXl/TpwfGPik1HpksN84WP4qj/Kk3eZdUUVMMhxeSqQ9A9p7jPh8Ni6yAe5yTiLs526V1/7dqHu+jFg59FT313poKNc4QrA== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by SJ0PR12MB6709.namprd12.prod.outlook.com (2603:10b6:a03:44a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.28; Wed, 24 Jul 2024 13:01:20 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::f018:13a9:e165:6b7e]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::f018:13a9:e165:6b7e%4]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 13:01:20 +0000 From: Zi Yan To: Andrew Morton , linux-mm@kvack.org Cc: David Hildenbrand , "Huang, Ying" , Baolin Wang , Kefeng Wang , Lorenzo Stoakes , linux-kernel@vger.kernel.org, Zi Yan Subject: [PATCH v3 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() Date: Wed, 24 Jul 2024 09:01:13 -0400 Message-ID: <20240724130115.793641-2-ziy@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240724130115.793641-1-ziy@nvidia.com> References: <20240724130115.793641-1-ziy@nvidia.com> X-ClientProxiedBy: CH0PR04CA0026.namprd04.prod.outlook.com (2603:10b6:610:76::31) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|SJ0PR12MB6709:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f1ca61c-409a-49d5-ee69-08dcabe0b601 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: 4lVY2L5sPY1vBz9ZJcog+R5da7NaPth5CGMN0oPa96S1yTjWzAOk8x9MFe2Pt09Jn6rCxxdEvcP/omH9NeBPebdJJcASeSki8KwMELHn6OCcg8MroyB2miUNpT90EqABIV2fHF5YTkNppsKIfJYtUWTp6Ir9h5XhRyYobSFNr3ZiqedSSih6OB+yY6cG/YKDbZxVvdmNAiXNJO8yI8jdIbNUOy4DBiuCgbMJHDMyCizBWxmcezAR+5eRvuSPP+cRBTkNjBqlVgBacwIbE+7Jc+h5K5nTuGLmXwYu42PyHpzHhmo66o/D6fhuMPkT70X2I/qQLi+zX6a/Zv1FyLaZcPzGXmCVac4mN2n5ioyDq++0R8/GGgZtkkZXronYuEYtAlgwGDW8lFVv/L8+gNSDCOtZqoHnKseehiwHcIqScRCzzYBCWNcv2/AIf02Q6Newiqb65G4aK1BirUxZQe8cA/4X3HMlrkGig1JC3ehhEU6Jxv+aZT0Cpjmhiuwm6PGZzONRFQnKgppGibLGi1jLOcteWoznlMCv/ABfPoUedP1SNSDW7ZDxLoTxLMzq4IDQ/+Ixbcy27wVFxhtLz7FmgDyRWydtdKHG8E1EmLUyMvhTnXyAQMkENPNuajVk9Q72j/uvLeRErXfxwrPzm9HcBGV+C8TJJNvg/tQee4DHo8Tvr4NBczYaauW+F5WWFBCr2XUw9dspGDckx8krau7CDoBUjWuWJJ8UzyCJN4/86qQEDLu2/kgxu+9Xel3blB5Uh3Kgz2+79BGbLPwRNHTmZjYH4u4y3t+3IEWTNc5QfEJYcPfCeGmeKE1Mn/0iruZun39gmWseMtt6pRxfRRPZZbrExuPUBpbXzmfB17108FlnLV6+plIrIk10OHxyZYjY4S1beE9tu2hGhaROkglSU0OxvHhXPwkPW6w40L1bU4Ref69CHYCo9Yw6pi1U1fk2ko371enplLTkpSlK+kVXo6gFmlxh47kf5WWXRJlnw+HSS+HvFxeio+GjKHG1ZUypD9CK0Y2C8RkAo9qIJECdQkqvXAWziLPJiGnKHZeAHNvdFVkMSkL/pOJ2KvHYHxXIWJd3Ut17wGkPJTO4h+db3lhcrdleMK8u/8S643M7Wg1X7oLfGLKthvc9UO1FxF7clvM+KQdbW7NTpVybBoh35iDDWRspTNVUe8QZYMMzel4WOCs+Ku/WdZN6Nm+D6JHPM0A6CQUfJKeSho00feS4q37UHCSKl7GNrcea45wWSfM0FTbtx/cCipdliHMeJUlesUqLecG1+HxwrXLd/BNZ5Nv2dim3xAxKH6UpQytDHI18xXkdH5N2/QhZgod4LLHqCeVvnJSL2La5PdXyEsdJAA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k+BradzlQMkJcPuGzShRCMifRUJo8E8VQeYwim3XTATTZCxESEU0RslJvtihnZcZmPrWv6jDT8OttmeF6Fstowlfe+ll917bPcfF+wXS83M2bzG6m8YZIoxWdT75VA2dGvXSgcdGok9X5XRKDXPTfHVE/6tQf9LuHUplzcwW/9MVUD0iURx0Hyhqf5ZavxBtshF/MkbttYMvvyAOZEClIb43fi+HShotCkyrGN8adInWUTDnRXbwj+/GWHMwk2wuiJVS1FdlzHyVajarX7bKi6TC+PZ5UDB+BIofRWitZNMZbGUlIAhK95AiPp6JvSJwLNX6RM8jDa3mCeqUhytdvNJLqb7MZF+fY1BxVdiVbccIc0uBfcEK3fPoVBlI8+QPIhPxK4eOZbr1P7Of3oVz/4p1ufNZWguQmnWWCEQMV/xNWzSFOShPwRDZzGXexW4H16/1HwI2Oh9dNcKeJe64dYY3946ZWsIXDgz8i6hdvIqSJd/9+4zOK1wYvAt1GxSZJS/5ujZRS+fc3acVn0KUOP+2/ZoDrVfyy+7C6sIsiqWclWTsTXaRgKBxinXKAht8S8dGJF4F/QdFq03diNe/n4AKBwNXII5toDvinKS62KXH/Uiw7cKAlVlgisYWz3CbbSUZiPxN3j9Q2juDe8qki3RvAe9SZg0a/jbSVYpK1dRvYOIMpeqd0S2Tp0JPlzrukWGOfiOfOfk4MoJyheFMGjMEl29MbRz7hBhiSjl+FRWRPr9eCmSAqErHLNjs7mzmN5wasLpVcdUoZMVr/RD52RLToa65sjiTJDRQLTS6zyCjgWZ8Zlx/8x94ign1IoIi6HtJG658aq4OECtWzZb3NG0AE1VEPqFZPlCzEIorQ+A3eRvIIsZW6wHyDbKz3Pzc+KCClQjIzm8iIkcFMR9iG6qf2vfjCZ8RTPLPYfmW9AGAc+eDWWyGKQSIxhGc3316xqNCNjdkc+TPtLItpRFjQKQWvsJHeZ3vi23Xheb8TWUgDPWFUF7vnySF/KvqzLg++SW0Mhzc80o8Il+Yn0jYnRTf7JT38cBpnwvvj2xJswp4HVNWvvpcXXuZnu9BWIplXAcjS3B4DYRYsbH5nKCvRnKU048idoueRJjngS0YGB7jgSjszOmm6Qg14cfkD32LlAU1TLVSL5Dvi2AyAgTvoeBfTwzPJnPQeiSB5rgcF69sZg2GmmlH4vDRL/w3Vb4aycSfNRKWLsIGy4PPcg9Q2pPuHSXcVxYNzgcUGbSo2Qn86mS/2AwxmmPGMoUdOcMn0Rm0lX95cNaJDPpG3VZd3x/WkwD5YCNo7U5VBYSYV2wT2eKCyqIg14mvG3CVWx1OuuhmRJ2OUHO2AF1py41onQ89ZkcN4VdUbDqOhC/K6ftwh288xxZ6LhXVX7Hnu2X7XKQ1ffwxAXLqu/f7MAGcSiv2G0NrlcTImjimbjQtt5iZUHdp65lIV1ItGFsgKSSS3jBnFEZR0BdXXEpQoa4RTAmSoKcHPl1rIM68a2dj1PkT/te9GLjHEDfTHXTVSbJ9xaH/Ct0wUmo+6iHA7PUthiogvuJf3xFxMpdhFOdNK1k= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f1ca61c-409a-49d5-ee69-08dcabe0b601 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 13:01:19.5805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9y6nMqlNhwrk0oEiD/g1cVpkYSBaPTJTKg1G9uvxozmeVdRr2wfQCH407TShuFGM X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6709 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D577F400AE X-Stat-Signature: s84w7ortungee5t4gzd1xjsjyo3tjrbr X-HE-Tag: 1721826086-937293 X-HE-Meta: U2FsdGVkX18hNkFFPhfMv+lK+/90eCci/igI7JvjC8fhI7vLuJ8/hT+qps6JmzPxL9aALQVvG/XIetA541TawTsmznRxmHrxW0XG6a8qYwpPp1tQuSl5eluprTGeD/2c7zC1B6x9vzO3lfZJaeiBZEP79daZ4V8EoYkgBF4o7q1i2DDottZZFZFw9Wz37RqZ5lcVEIbKIFUXU2v18y5BTLDvKtw7PqCrEmFYrXBxmhKEiW18A+m3lnAq5x5A/3IAODEB0jlRpjDirNxHLZ/P6IHNepxqjVdtqBA1rEA8IXYDHfnLohlvx8sZdpDwXoGnbL6eRVXR62RUmhDcQqfi+txqzzM/fQJBtW5D9uGFY95aEeVA7voF5UqPZjKaeWNneUyIrZQKnaFU9vLNa3xJ+Ts3Pefu1vu7jPcAllEGBZalNH1qBP86tY7cuPkh7YT5rMfrM0ZpSw9gg6KuwDopet2EdhAUyw3vNhFB0B4nVaocen26TTUZTBJSHbPeZP9fC0E9FRoZn5xeHKsD1uFYBFItIctjtFdBMppMF7sR99POOYtyNChJGHP+JMpu73Vs4VqjVHOqyMfOcSekGpIAGawv2tkhP59Nb5rwMKBMjHsDdxQaQcoUoJKtOK27T64bF6PKAmpLN/n3vUS2Ujm9M4YdsfLoUFH3C9o4u1HEzNW5aMq5YINuCgm3jBSSFE0jobC0NafEKuI1UShdVeVaCf4kefsQ3pqNupftSizRXJcfwnC3opKPGjKyjC+X2uLDYzUb2hFESwx5lXuUtIoSUsGGF3u4KZ5Zr8xI49OhLMo74dRLmL9qK9zQjODaGwh5353JLGa1h26cMRtKdY/vxLlbKEgG3+Dlu0FByQGcWNveU/EQy7Z91ehoZqC3pR10as3z43p3jCgWznpy1cJIMjBcJRXUnhbAOqFEYSvPwPitO0uoGv+ftBcCqoXdFc9ABkSHcLrrgc/VJYQ33z0 53VKVc4w ti3IsGJ6X3CcCD8cL7VLVMQCArWb0EAATajFP7Zt2JDSHPEKqDcMjjTafLzZIX1pyANwd1YsSvzwuRrue3CcMGujzWiXzolFVdp+78D+GesuHUwb9WSJp9G62vTJANV+xjN3YfFsZJH2z8LFxqmLpKwMyfgiCoM4ILNZJ5ocX4PMRkwobZCt7nQGwTnmUluDvD2Gq8EmeLpv8Mg0C3jcbLmhrXfN6Dj8ZTJALduxOCnsRoriFumWTy5er1InVYs/QtGLHbiSy5etcusCV84RW4GWYpcd1keXbtiHr4EzRxeMO9Q6sC4wclRzaigKGVEvuhvId+Q6DB2g9/UfK+n4malVj/+Knn1/hkmEOrA9msJX++m9ztIj0RoUwc5aPONsWg53x6wGaKV5jNTNeAhgGFNNsMrowDC4Qaz8afZchkYAWZAM2+wXe1ruAyCacwgRE25s810TWtyCf68di+MEPOydigQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: last_cpupid is only available when memory tiering is off or the folio is in toptier node. Complete the check to read last_cpupid when it is available. Before the fix, the default last_cpupid will be used even if memory tiering mode is turned off at runtime instead of the actual value. This can prevent task_numa_fault() from getting right numa fault stats, but should not cause any crash. User might see performance changes after the fix. Reported-by: David Hildenbrand Closes: https://lore.kernel.org/linux-mm/9af34a6b-ca56-4a64-8aa6-ade65f109288@redhat.com/ Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") Signed-off-by: Zi Yan Reviewed-by: "Huang, Ying" Reviewed-by: Baolin Wang Acked-by: David Hildenbrand Reviewed-by: Kefeng Wang --- mm/huge_memory.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 88dffc0023b5..15234b2e252e 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1707,7 +1707,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) * For memory tiering mode, cpupid of slow memory page is used * to record page access time. So use default value. */ - if (node_is_toptier(nid)) + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || + node_is_toptier(nid)) last_cpupid = folio_last_cpupid(folio); target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); if (target_nid == NUMA_NO_NODE)