| Message ID | 20240725021643.1358536-1-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: hugetlb: remove left over comment about follow_huge_foo() | expand |
> On Jul 25, 2024, at 10:16, Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > > The comment is useless after commit 57a196a58421 ("hugetlb: simplify > hugetlb handling in follow_page_mask") since all follow_huge_foo() are > killed. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Reviewed-by: Muchun Song <muchun.song@linux.dev> Thanks.
On 25.07.24 04:16, Kefeng Wang wrote: > The comment is useless after commit 57a196a58421 ("hugetlb: simplify > hugetlb handling in follow_page_mask") since all follow_huge_foo() are > killed. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > mm/hugetlb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 0858a1827207..ba176240f764 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h) > > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > > -/* > - * These functions are overwritable if your architecture needs its own > - * behavior. > - */ > bool isolate_hugetlb(struct folio *folio, struct list_head *list) > { > bool ret = true; Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, Jul 25, 2024 at 10:16:43AM +0800, Kefeng Wang wrote: > The comment is useless after commit 57a196a58421 ("hugetlb: simplify > hugetlb handling in follow_page_mask") since all follow_huge_foo() are > killed. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 0858a1827207..ba176240f764 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -7503,10 +7503,6 @@ __weak unsigned long hugetlb_mask_last_page(struct hstate *h) #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ -/* - * These functions are overwritable if your architecture needs its own - * behavior. - */ bool isolate_hugetlb(struct folio *folio, struct list_head *list) { bool ret = true;
The comment is useless after commit 57a196a58421 ("hugetlb: simplify hugetlb handling in follow_page_mask") since all follow_huge_foo() are killed. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- mm/hugetlb.c | 4 ---- 1 file changed, 4 deletions(-)