From patchwork Fri Jul 26 16:05:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13742934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DBDC3DA4A for ; Fri, 26 Jul 2024 16:07:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0388F6B00A6; Fri, 26 Jul 2024 12:07:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F03B06B00A7; Fri, 26 Jul 2024 12:07:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D57016B00A8; Fri, 26 Jul 2024 12:07:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF5816B00A6 for ; Fri, 26 Jul 2024 12:07:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4189A1A1944 for ; Fri, 26 Jul 2024 16:07:03 +0000 (UTC) X-FDA: 82382382726.08.AAC9F13 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf07.hostedemail.com (Postfix) with ESMTP id 385D440030 for ; Fri, 26 Jul 2024 16:07:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722009972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRVpZL1Lw2Jv758lKlKvStlrYBAwWcY3FtEoaaNT51U=; b=NLng6bmK4FLDDwJMW91lUiaFYn5KS3n0cet+EhUpj7mPQ01HswFHvdPB9H+Qwx2lZ3pBFV YghRNVGm00nSjw/0viCjsIRvrIaoW567zuptt5IwcOXPjLncyafzVr37m927PSGSg0K0We eXmMC8U4NE1x4PCPF0t8Bly+NKtbCoQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722009972; a=rsa-sha256; cv=none; b=dDWgrPHjcmQTnuVa9QEpnxOBB6zGpjT2cr+QMkm1nRwMFlfXj22dfD11Qnj0h9zSssxnVB PNAIdztCIkTWnojmVQxaD5HCC8V7P0jnrc8Aw3ZW6lPqwftWcdiz7egYPXsVcRFFKYQt/x BaG7Gi0DJ5jaxlBL1mh8vH/Fiug5QL8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WVsyR4Hvxz6K9LN; Sat, 27 Jul 2024 00:04:31 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id 4AD32140B73; Sat, 27 Jul 2024 00:06:59 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.126.173.33) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 26 Jul 2024 17:06:57 +0100 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v10 06/11] cxl/mbox: Add SET_FEATURE mailbox command Date: Fri, 26 Jul 2024 17:05:50 +0100 Message-ID: <20240726160556.2079-7-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240726160556.2079-1-shiju.jose@huawei.com> References: <20240726160556.2079-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.173.33] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Queue-Id: 385D440030 X-Stat-Signature: ditq77czwbxznaoku4i16m69b7raq9oa X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722010020-215321 X-HE-Meta: U2FsdGVkX19p/9N2tGRgEhIe4388ZOgJ+m7lmhRNFwPHkwSFgotUEF9fd8y4qJEsGcT+sH28Qy38Xc9tLJzJINOsWh97eEb+XI3irBX1bN+PoXGrdviHaeh1ourcWRBmf5khw1QgGCdgKcWS99MpZNRiZmEeZvcou4GYXc9KvDfTVB4bV2cl3oAcgvqiUIkM6PgmWJ0UHbJuaDh+mz+pLqiHcw+sT+71G4mylwpiZaBEhBxW87bEQyrm2IZKgoOqZ2B+CqrgRpb1eHhtUjxe4EiQ27jk1q95FGOlxoAnQumuguEKStCugGAzpkM+vzQ8TR5O0lCHsqfyvpVDNqm4BAiGgiTL/pcbFFDMXOndF/kA5PuMBZU3givkprBCHNsny+6itdxp58hMCr2mlzfISTpRnokNbyXH6AkQeoXF1GYiG0As0gHPmgsqjgEBDiH2Po/J6saUpP7SnhE7qx3cAL4K/sFaDpL9M+QNW+TUabCKgsOsOL9kol6NdL8mycqlhz1/HQL00PjVWe3AREL/kdEoUU/dp5LoNF3unncajhfRRZgFm1lr7WqJhMXXeJK5EhtODQP8T9LDQhdXNskXx8JkscH/9u+kYO2YUHcqPP4qnOOzPcus5hrd+3PxBn2gtyUJzBEHhcbgzqmejascwHwpjlXW8pkOe3TJEFtSHUp1mK/vEFaW6JXmgBdAErAgnCM4ZYOx8LbbgFmL4HWG1HuMlE7ENasS1ulA17Ls31AtT3qGxbyGSeGfnOPOEHYl9Re7gsQoHbLR+r8pnOA/TyWXAw0NtYCfHz8MyIX7ZnB6NX6oHk5Vp81i5NrwdnFcOr7fTQ8EmbW53f58HMF+AlSulWpPKxGq5+AXzLiTmKh+ZwFBsP5Ox65DkWHqK2t9pfhy8uhit6OOLAhSGjn23braJ98201S44sgBMpW/86jXnCmJahFsNP/B3hwSyyYMDiaLUUtC3zTwQoO454a P/nHnkki H82CC1tGKNSF3rWef5wXMVpkZWRM/pPhtUiT04nuWPxbSK8ZHRjnhtUzqt0Z2Mzdj3EUjaeAFuUktH19qHvBHcwpZQhIELK6Mkp/U8Mtx7Ejf2cC3RgaOmSdbczKbkoa8qc0CFUlTeFG4jUVtn5HNCN0pJZcr7PCK1qkDKNexeiZhkqd5iHl+JrTUL1QkU7pUCwRUDOhoi48rDgHi3pWVktzSYJ74Zv1Ygpwt+XJdhGGEuj2bezG01SGjtYEqH8PcGx83okLGuXnpzcegEgUq/VDFAWS0IogAmJZaFr+wRYg79nI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for SET_FEATURE mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. CXL devices supports features with changeable attributes. The settings of a feature can be optionally modified using Set Feature command. CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 72 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 33 +++++++++++++++++++ 2 files changed, 105 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 989843bbf123..2f20d7b91520 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1391,6 +1391,78 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); +/* + * FEAT_DATA_MIN_PAYLOAD_SIZE - min extra number of bytes should be + * available in the mailbox for storing the actual feature data so that + * the feature data transfer would work as expected. + */ +#define FEAT_DATA_MIN_PAYLOAD_SIZE 10 +int cxl_set_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag) +{ + struct cxl_memdev_set_feat_pi { + struct cxl_mbox_set_feat_hdr hdr; + u8 feat_data[]; + } __packed; + size_t data_in_size, data_sent_size = 0; + struct cxl_mbox_cmd mbox_cmd; + size_t hdr_size; + int rc = 0; + + struct cxl_memdev_set_feat_pi *pi __free(kfree) = + kmalloc(mds->payload_size, GFP_KERNEL); + pi->hdr.uuid = feat_uuid; + pi->hdr.version = feat_version; + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; + feat_flag |= CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET; + hdr_size = sizeof(pi->hdr); + /* + * Check minimum mbox payload size is available for + * the feature data transfer. + */ + if (hdr_size + FEAT_DATA_MIN_PAYLOAD_SIZE > mds->payload_size) + return -ENOMEM; + + if ((hdr_size + feat_data_size) <= mds->payload_size) { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); + data_in_size = feat_data_size; + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); + data_in_size = mds->payload_size - hdr_size; + } + + do { + pi->hdr.offset = cpu_to_le16(data_sent_size); + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_SET_FEATURE, + .size_in = hdr_size + data_in_size, + .payload_in = pi, + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + data_sent_size += data_in_size; + if (data_sent_size >= feat_data_size) + return 0; + + if ((feat_data_size - data_sent_size) <= (mds->payload_size - hdr_size)) { + data_in_size = feat_data_size - data_sent_size; + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); + } + } while (true); +} +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index c70d2797e4c5..5fc71d623721 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -532,6 +532,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_GET_FEATURE = 0x0501, + CXL_MBOX_OP_SET_FEATURE = 0x0502, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -780,6 +781,34 @@ struct cxl_mbox_get_feat_in { u8 selection; } __packed; +/* + * Set Feature CXL 3.1 Spec 8.2.9.6.3 + */ + +/* + * Set Feature input payload + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 + */ +/* Set Feature : Payload in flags */ +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) +enum cxl_set_feat_flag_data_transfer { + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX +}; +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) + +struct cxl_mbox_set_feat_hdr { + uuid_t uuid; + __le32 flags; + __le16 offset; + u8 version; + u8 rsvd[9]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -918,6 +947,10 @@ size_t cxl_get_feature(struct cxl_memdev_state *mds, const uuid_t feat_uuid, enum cxl_get_feat_selection selection, void *feat_out, size_t feat_out_size); +int cxl_set_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);