From patchwork Tue Jul 30 12:46:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 13747383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE99FC3DA7E for ; Tue, 30 Jul 2024 12:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEBF46B0098; Tue, 30 Jul 2024 08:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D738C6B0099; Tue, 30 Jul 2024 08:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7A346B009A; Tue, 30 Jul 2024 08:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96F366B0098 for ; Tue, 30 Jul 2024 08:54:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 40D911C1086 for ; Tue, 30 Jul 2024 12:54:19 +0000 (UTC) X-FDA: 82396412238.27.6A4DBB7 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf26.hostedemail.com (Postfix) with ESMTP id 730A2140003 for ; Tue, 30 Jul 2024 12:54:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZHuMCkwd; spf=pass (imf26.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722343985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WMly8HhHGH4A9wPlKbdln8VuB1NNTIz/ItEPyhn23R8=; b=eRnAttfeDihBK04ugvz0Tjxy7RCHdGttyFcdf0jXvyhA0BOGdXo8IdQE7FgGAB99nowX96 5/MRFaUoprdMkzdSFh2Fa09fl/jyxihIQz+Q178TvXFTpDiF6Ar64Z8rdmpHSpR14p6B4I hFxCeuSPGUzYUAdok731A7v3QhrIAPY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZHuMCkwd; spf=pass (imf26.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722343985; a=rsa-sha256; cv=none; b=KSIZwebboTO29ysAthBxB6SFvks8bodlK5zLsdB39MQ1AT1vgbmvenv77wgxur0EhLEtgt fflPwK1DOdaUXg3Mj/rFvOBWbYV0KCYOaZCJq0yEyZvmbCJgt3ueuSYcIzejUWF54e4WwR kuVCkfptyNyIUbcVv7K2+PEKK3dsVaM= Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7a1e24f3c0dso270093085a.1 for ; Tue, 30 Jul 2024 05:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722344056; x=1722948856; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WMly8HhHGH4A9wPlKbdln8VuB1NNTIz/ItEPyhn23R8=; b=ZHuMCkwd4E29DrAj/3AGLCbCo9iDpa+rhdiXT3jtyKF4u8wAIIG5bF+4Kr4i32EwoW LU+r1T6rQpHLUfqrs9daSJ4OiDOWdiFsgTaSA9xVXNgLdllYWqPdQtPf22Str7NK4Rqd q1ncRpYtgyWgEHpZ65ZgvxWH2WSW3pDiUmdoJYb84jDiP9JMcKO0gshtvZEk5a2uXnLz o28IuwZc5VG9LTt86eiQJoz33p/ruY92nXOXM4dXZeWUztksgQnntuz1xh1YJr/3Fxet HJBbQSw6VadsA3+sNXWydm+qpe750g5ULwLbHx4WChMDivKDfhmWOL+0ZxYLOFAtI6DJ rjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722344056; x=1722948856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WMly8HhHGH4A9wPlKbdln8VuB1NNTIz/ItEPyhn23R8=; b=cYJBXvRaT9ccFXG5H8xLrnpTG3Z034QB/G/axF6C29/86cPREmK0dmWnhWKvBBvTvi MGRFwYG+McQOmgtWPslj2dEDT+tgStEbvvrbSuMOWwigr9LKMPBowxRi3nsY3ARdoLSu mM4LEl1iu124WsyzJkQIn66GLjHI3RubFFcXpFHBEu0uPZNLBFyiI5M3umcOlcoeEAu7 FXOt0Y3d0asHMdNd8A5H4n5+pOrtSSPg+6/AZV5jgZxKWY9q0lNDBJOio3Bpee4V49J0 DqmkipBDAXXrxGeU0RnG1fOS2x9mdC2i257/z8M5oQaipmz14AV4/ysiu1W+C/qDBQgS /f8w== X-Forwarded-Encrypted: i=1; AJvYcCVVXDoDaARJmAU0HyO14fhWKMdEg0keT2iaKB02It6CL9YqTrE3LqrKozJnprK4mItG8kfwtIfGtBDdQRASwzSkeQw= X-Gm-Message-State: AOJu0Ywx4mxiin9bXK2640v08qB5dXcyCVVc4hecEQ7NgKGy1vW3q5Ic UXzNDkn4ITZgKdChAaE3IhbKWoOHZ13twBxGtuH2jzk9PH8AkxuV X-Google-Smtp-Source: AGHT+IEmkurgjtLPaaaxi8bgqZN25LoWu8XIBbBu/DllgXvVyAnH9Zg7Q6mMTVSeKZ93YStrgiY5Rg== X-Received: by 2002:a05:620a:4507:b0:79d:751b:67b6 with SMTP id af79cd13be357-7a1e525458cmr1406226385a.16.1722344056416; Tue, 30 Jul 2024 05:54:16 -0700 (PDT) Received: from localhost (fwdproxy-ash-007.fbsv.net. [2a03:2880:20ff:7::face:b00c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1d7435577sm636521785a.96.2024.07.30.05.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 05:54:15 -0700 (PDT) From: Usama Arif To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Alexander Zhu , Usama Arif Subject: [PATCH 5/6] mm: add selftests to split_huge_page() to verify unmap/zap of zero pages Date: Tue, 30 Jul 2024 13:46:02 +0100 Message-ID: <20240730125346.1580150-6-usamaarif642@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240730125346.1580150-1-usamaarif642@gmail.com> References: <20240730125346.1580150-1-usamaarif642@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 730A2140003 X-Stat-Signature: xhzrq4yebrufsn9jy8dk4t7py5odttzx X-Rspam-User: X-HE-Tag: 1722344057-353933 X-HE-Meta: U2FsdGVkX1+wm7TWOeEvnKrAF0VTwD1rp6BR3u7z8QK3r1cStjS74BJ+TA7Et4AoMCoK7HTfSohEfXw6OKiQK5IuAlFqtsPIXQQzBRorxB8t5mpnZL5eZdtyllLBxu+968dVKR9ruANgPSsQGnWCNyYytPzzqsBeoa/aZxtkn/x3Sj/wG1bDEmbN6J6zyH/fM2PqJYYEP+GR48uJXHwEryK/lhepRqfd0xXQFee8kYRDX3bRjUcfzyu9OO0rrZesmcMtqwpREc7KQBNdlobmE2UulMUBCGAy7PXUhq2h293SAxZML6GjJk6JywYUVUa+c/jOoyIxLtJiHluF1NasEQzowKW23xMUCJ53MVfKphVZCe5EHV7UJHENMpdjVvl7h5PdvoI/1jlOSGQT4/i5G5CFcd8u0YT7leD2ivxIIY3gRtVcUnkSUll4ExYai2anFwrHq7yEnvCnUMahIdW1ywoDSmVV+c7NlyGzacgu3+JIwq/2gXIyWlIV+xextPvVYyf5o001Xh1CK27aE76SEMHvPMj1PHZLd/1ZVIhBpRQ1+r8zc7zc1SN1CGt46E3UOK8Zq5eHkgLUU+EQvTRbzy29HiuprYRGRrGudrmAlpziuc3DnIkEXxP3IgsJ0pVNUke93owCC5tnUpgDyYW8uHI4BOf2rYq6LjMNybgo/mFQ0Wfsyl5lY6u0EUiOJtoALuF3eEjqZ7VldzqVA+1cbATh1yKKa75BY3PgeSfcHqtBbQQrzEp5sT/7tJkFHn2ruzdeNgJhxP8KXo4lj50Sjelve2/K2AtzXNfp9Ij3C9c29X4keWLWT/X2IJ3zfyxrnRsgRfj203UVkf7l7/FyWsqsrCYcoFYIxLkJNqKEGoCfciSIvQAyR68bIahHQipGLOvl1KWoqBnbkY4EeoyJEK+qNsllfrggoJ+rWQsl5VOPMUD5N42d0tAaKEwRvIVmdEa66zf7rX1VvHPDtR7 xNSgPoxm SsOZ0xW4H5dLiEp5mbCKVx0mA42EylagjQK1Z2ErzkxpjtWykKHp8s8bRMWLvkIfkjVlJbcXAhb06kpVfANx6gOi3mGPinvYMFzSOrxSBLAmUFZ78x2Fh31QE6NvZOf6H7AH20pHO9LBY+QCqvEpow6u3IF6BGph1RhWd/uUtfgHarKFSdVtSK5fBzP/Bd1wSjxoB9HJdvb5LEuPiE/q8IXCdSMt2bPH8TyK7ZBwqQRP1HTYQAQgtTqUapN5HHdvirM991jd8mKkuDNyI9AokZufjFmb1kXFnBvMjv7KZHOBXQ8g3wr505UO7ihgfnNJMdQdg9qMv56UjYQ0CFeCibGRMp30DxKn33xIRR4VsokhMLSGR/vVvUwXpqkDV5DinU4AvtJ0/YDBs5UqERwxm/glv3gTioCOhYjqRQ5MtY0aF8HKJADa0/f5ZOBCxVQhRO/Q3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Alexander Zhu Self tests to verify the RssAnon value to make sure zero pages are not remapped except in the case of userfaultfd. Also includes a self test for the userfaultfd use case. Signed-off-by: Alexander Zhu Signed-off-by: Usama Arif Acked-by: Rik van Riel --- .../selftests/mm/split_huge_page_test.c | 113 ++++++++++++++++++ tools/testing/selftests/mm/vm_util.c | 22 ++++ tools/testing/selftests/mm/vm_util.h | 1 + 3 files changed, 136 insertions(+) diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c index e5e8dafc9d94..da271ad6ff11 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -17,6 +17,8 @@ #include #include #include +#include +#include #include "vm_util.h" #include "../kselftest.h" @@ -84,6 +86,115 @@ static void write_debugfs(const char *fmt, ...) write_file(SPLIT_DEBUGFS, input, ret + 1); } +static char *allocate_zero_filled_hugepage(size_t len) +{ + char *result; + size_t i; + + result = memalign(pmd_pagesize, len); + if (!result) { + printf("Fail to allocate memory\n"); + exit(EXIT_FAILURE); + } + + madvise(result, len, MADV_HUGEPAGE); + + for (i = 0; i < len; i++) + result[i] = (char)0; + + return result; +} + +static void verify_rss_anon_split_huge_page_all_zeroes(char *one_page, int nr_hpages, size_t len) +{ + uint64_t rss_anon_before, rss_anon_after; + size_t i; + + if (!check_huge_anon(one_page, 4, pmd_pagesize)) { + printf("No THP is allocated\n"); + exit(EXIT_FAILURE); + } + + rss_anon_before = rss_anon(); + if (!rss_anon_before) { + printf("No RssAnon is allocated before split\n"); + exit(EXIT_FAILURE); + } + + /* split all THPs */ + write_debugfs(PID_FMT, getpid(), (uint64_t)one_page, + (uint64_t)one_page + len, 0); + + for (i = 0; i < len; i++) + if (one_page[i] != (char)0) { + printf("%ld byte corrupted\n", i); + exit(EXIT_FAILURE); + } + + if (!check_huge_anon(one_page, 0, pmd_pagesize)) { + printf("Still AnonHugePages not split\n"); + exit(EXIT_FAILURE); + } + + rss_anon_after = rss_anon(); + if (rss_anon_after >= rss_anon_before) { + printf("Incorrect RssAnon value. Before: %ld After: %ld\n", + rss_anon_before, rss_anon_after); + exit(EXIT_FAILURE); + } +} + +void split_pmd_zero_pages(void) +{ + char *one_page; + int nr_hpages = 4; + size_t len = nr_hpages * pmd_pagesize; + + one_page = allocate_zero_filled_hugepage(len); + verify_rss_anon_split_huge_page_all_zeroes(one_page, nr_hpages, len); + printf("Split zero filled huge pages successful\n"); + free(one_page); +} + +void split_pmd_zero_pages_uffd(void) +{ + char *one_page; + int nr_hpages = 4; + size_t len = nr_hpages * pmd_pagesize; + long uffd; /* userfaultfd file descriptor */ + struct uffdio_api uffdio_api; + struct uffdio_register uffdio_register; + + /* Create and enable userfaultfd object. */ + + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK); + if (uffd == -1) { + perror("userfaultfd"); + exit(1); + } + + uffdio_api.api = UFFD_API; + uffdio_api.features = 0; + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == -1) { + perror("ioctl-UFFDIO_API"); + exit(1); + } + + one_page = allocate_zero_filled_hugepage(len); + + uffdio_register.range.start = (unsigned long)one_page; + uffdio_register.range.len = len; + uffdio_register.mode = UFFDIO_REGISTER_MODE_WP; + if (ioctl(uffd, UFFDIO_REGISTER, &uffdio_register) == -1) { + perror("ioctl-UFFDIO_REGISTER"); + exit(1); + } + + verify_rss_anon_split_huge_page_all_zeroes(one_page, nr_hpages, len); + printf("Split zero filled huge pages with uffd successful\n"); + free(one_page); +} + void split_pmd_thp(void) { char *one_page; @@ -431,6 +542,8 @@ int main(int argc, char **argv) fd_size = 2 * pmd_pagesize; + split_pmd_zero_pages(); + split_pmd_zero_pages_uffd(); split_pmd_thp(); split_pte_mapped_thp(); split_file_backed_thp(); diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c index 5a62530da3b5..7b7e763ba8e3 100644 --- a/tools/testing/selftests/mm/vm_util.c +++ b/tools/testing/selftests/mm/vm_util.c @@ -12,6 +12,7 @@ #define PMD_SIZE_FILE_PATH "/sys/kernel/mm/transparent_hugepage/hpage_pmd_size" #define SMAP_FILE_PATH "/proc/self/smaps" +#define STATUS_FILE_PATH "/proc/self/status" #define MAX_LINE_LENGTH 500 unsigned int __page_size; @@ -171,6 +172,27 @@ uint64_t read_pmd_pagesize(void) return strtoul(buf, NULL, 10); } +uint64_t rss_anon(void) +{ + uint64_t rss_anon = 0; + FILE *fp; + char buffer[MAX_LINE_LENGTH]; + + fp = fopen(STATUS_FILE_PATH, "r"); + if (!fp) + ksft_exit_fail_msg("%s: Failed to open file %s\n", __func__, STATUS_FILE_PATH); + + if (!check_for_pattern(fp, "RssAnon:", buffer, sizeof(buffer))) + goto err_out; + + if (sscanf(buffer, "RssAnon:%10ld kB", &rss_anon) != 1) + ksft_exit_fail_msg("Reading status error\n"); + +err_out: + fclose(fp); + return rss_anon; +} + bool __check_huge(void *addr, char *pattern, int nr_hpages, uint64_t hpage_size) { diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h index 9007c420d52c..71b75429f4a5 100644 --- a/tools/testing/selftests/mm/vm_util.h +++ b/tools/testing/selftests/mm/vm_util.h @@ -39,6 +39,7 @@ unsigned long pagemap_get_pfn(int fd, char *start); void clear_softdirty(void); bool check_for_pattern(FILE *fp, const char *pattern, char *buf, size_t len); uint64_t read_pmd_pagesize(void); +uint64_t rss_anon(void); bool check_huge_anon(void *addr, int nr_hpages, uint64_t hpage_size); bool check_huge_file(void *addr, int nr_hpages, uint64_t hpage_size); bool check_huge_shmem(void *addr, int nr_hpages, uint64_t hpage_size);