diff mbox series

[v2,2/2] mm: print the promo watermark in zoneinfo

Message ID 20240801232548.36604-3-kaiyang2@cs.cmu.edu (mailing list archive)
State New
Headers show
Series mm: print the promo watermark in zoneinfo | expand

Commit Message

Kaiyang Zhao Aug. 1, 2024, 11:25 p.m. UTC 
From: Kaiyang Zhao <kaiyang2@cs.cmu.edu>

Printing the promo watermark in zoneinfo just like other watermarks.
This helps users check and verify all the watermarks are appropriate.

Signed-off-by: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
---
 mm/vmstat.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Morton Aug. 1, 2024, 11:48 p.m. UTC | #1 
On Thu,  1 Aug 2024 23:25:48 +0000 kaiyang2@cs.cmu.edu wrote:

> From: Kaiyang Zhao <kaiyang2@cs.cmu.edu>
> 
> Printing the promo watermark in zoneinfo just like other watermarks.
> This helps users check and verify all the watermarks are appropriate.
> 

Well, I guess for a two-liner I'll let it go, but it would be better to
tell us *why* it "helps users", rather than providing an unsupported
assertion such as this.  In what scenarios has this proven useful? 
Details, details, details - spare us none.
diff mbox series

Patch

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 5082431dad28..4e2dc067a654 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1725,6 +1725,7 @@  static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 		   "\n        min      %lu"
 		   "\n        low      %lu"
 		   "\n        high     %lu"
+		   "\n        promo    %lu"
 		   "\n        spanned  %lu"
 		   "\n        present  %lu"
 		   "\n        managed  %lu"
@@ -1734,6 +1735,7 @@  static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
 		   min_wmark_pages(zone),
 		   low_wmark_pages(zone),
 		   high_wmark_pages(zone),
+		   promo_wmark_pages(zone),
 		   zone->spanned_pages,
 		   zone->present_pages,
 		   zone_managed_pages(zone),