| Message ID | 20240806112345.2387969-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] powerpc: Fix a config comment typo in asm/percpu.h | expand |
Le 06/08/2024 à 13:23, Jinjie Ruan a écrit : > [Vous ne recevez pas souvent de courriers de ruanjinjie@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > commit 0db880fc865f ("powerpc: Avoid nmi_enter/nmi_exit in real mode > interrupt.") has a config comment typo, fix it. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > arch/powerpc/include/asm/percpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/percpu.h b/arch/powerpc/include/asm/percpu.h > index 634970ce13c6..c836b16ce30d 100644 > --- a/arch/powerpc/include/asm/percpu.h > +++ b/arch/powerpc/include/asm/percpu.h > @@ -23,7 +23,7 @@ DECLARE_STATIC_KEY_FALSE(__percpu_first_chunk_is_paged); > (static_key_enabled(&__percpu_first_chunk_is_paged.key)) > #else > #define percpu_first_chunk_is_paged false > -#endif /* CONFIG_PPC64 && CONFIG_SMP */ > +#endif /* CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK && CONFIG_SMP */ The #if/#else/#endif section is small and doesn't nest additional #ifdefs so the comment is useless and should be removed completely. Christophe
On 2024/8/6 20:50, Christophe Leroy wrote: > > > Le 06/08/2024 à 13:23, Jinjie Ruan a écrit : >> [Vous ne recevez pas souvent de courriers de ruanjinjie@huawei.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> commit 0db880fc865f ("powerpc: Avoid nmi_enter/nmi_exit in real mode >> interrupt.") has a config comment typo, fix it. >> >> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> >> --- >> arch/powerpc/include/asm/percpu.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/include/asm/percpu.h >> b/arch/powerpc/include/asm/percpu.h >> index 634970ce13c6..c836b16ce30d 100644 >> --- a/arch/powerpc/include/asm/percpu.h >> +++ b/arch/powerpc/include/asm/percpu.h >> @@ -23,7 +23,7 @@ >> DECLARE_STATIC_KEY_FALSE(__percpu_first_chunk_is_paged); >> (static_key_enabled(&__percpu_first_chunk_is_paged.key)) >> #else >> #define percpu_first_chunk_is_paged false >> -#endif /* CONFIG_PPC64 && CONFIG_SMP */ >> +#endif /* CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK && CONFIG_SMP */ > > The #if/#else/#endif section is small and doesn't nest additional > #ifdefs so the comment is useless and should be removed completely. OK, I'll send v2 to remove it, thank you! > > Christophe >
diff --git a/arch/powerpc/include/asm/percpu.h b/arch/powerpc/include/asm/percpu.h index 634970ce13c6..c836b16ce30d 100644 --- a/arch/powerpc/include/asm/percpu.h +++ b/arch/powerpc/include/asm/percpu.h @@ -23,7 +23,7 @@ DECLARE_STATIC_KEY_FALSE(__percpu_first_chunk_is_paged); (static_key_enabled(&__percpu_first_chunk_is_paged.key)) #else #define percpu_first_chunk_is_paged false -#endif /* CONFIG_PPC64 && CONFIG_SMP */ +#endif /* CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK && CONFIG_SMP */ #include <asm-generic/percpu.h>
commit 0db880fc865f ("powerpc: Avoid nmi_enter/nmi_exit in real mode interrupt.") has a config comment typo, fix it. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- arch/powerpc/include/asm/percpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)