| Message ID | 20240816001216.26575-27-dakr@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Generic `Allocator` support for Rust | expand |
On Fri, 16 Aug 2024 02:11:08 +0200 Danilo Krummrich <dakr@kernel.org> wrote: > Add maintainers entry for the Rust `alloc` module. > > Currently, this includes the `Allocator` API itself, `Allocator` > implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's > implementation of the primary memory allocation data structures, `Box` > and `Vec`. > > Signed-off-by: Danilo Krummrich <dakr@kernel.org> > --- > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 42decde38320..560516b3aaf4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19925,6 +19925,13 @@ F: scripts/*rust* > F: tools/testing/selftests/rust/ > K: \b(?i:rust)\b > > +RUST [ALLOC] > +M: Danilo Krummrich <dakr@kernel.org> > +L: rust-for-linux@vger.kernel.org > +S: Maintained > +F: rust/kernel/alloc.rs > +F: rust/kernel/alloc/ It feels like we should use `mod.rs`. > + > RXRPC SOCKETS (AF_RXRPC) > M: David Howells <dhowells@redhat.com> > M: Marc Dionne <marc.dionne@auristor.com>
On Sat, Aug 31, 2024 at 01:57:12PM +0100, Gary Guo wrote: > On Fri, 16 Aug 2024 02:11:08 +0200 > Danilo Krummrich <dakr@kernel.org> wrote: > > > Add maintainers entry for the Rust `alloc` module. > > > > Currently, this includes the `Allocator` API itself, `Allocator` > > implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's > > implementation of the primary memory allocation data structures, `Box` > > and `Vec`. > > > > Signed-off-by: Danilo Krummrich <dakr@kernel.org> > > --- > > MAINTAINERS | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 42decde38320..560516b3aaf4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19925,6 +19925,13 @@ F: scripts/*rust* > > F: tools/testing/selftests/rust/ > > K: \b(?i:rust)\b > > > > +RUST [ALLOC] > > +M: Danilo Krummrich <dakr@kernel.org> > > +L: rust-for-linux@vger.kernel.org > > +S: Maintained > > +F: rust/kernel/alloc.rs > > +F: rust/kernel/alloc/ > > It feels like we should use `mod.rs`. The same would be true for: - rust/kernel/sync.rs - rust/kernel/net.rs - rust/kernel/init.rs - rust/kernel/fs.rs - ... Do you propose to change it for all of them? > > > + > > RXRPC SOCKETS (AF_RXRPC) > > M: David Howells <dhowells@redhat.com> > > M: Marc Dionne <marc.dionne@auristor.com> >
On Tue, Sep 3, 2024 at 2:03 PM Danilo Krummrich <dakr@kernel.org> wrote: > > On Sat, Aug 31, 2024 at 01:57:12PM +0100, Gary Guo wrote: > > On Fri, 16 Aug 2024 02:11:08 +0200 > > Danilo Krummrich <dakr@kernel.org> wrote: > > > > > Add maintainers entry for the Rust `alloc` module. > > > > > > Currently, this includes the `Allocator` API itself, `Allocator` > > > implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's > > > implementation of the primary memory allocation data structures, `Box` > > > and `Vec`. > > > > > > Signed-off-by: Danilo Krummrich <dakr@kernel.org> > > > --- > > > MAINTAINERS | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 42decde38320..560516b3aaf4 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -19925,6 +19925,13 @@ F: scripts/*rust* > > > F: tools/testing/selftests/rust/ > > > K: \b(?i:rust)\b > > > > > > +RUST [ALLOC] > > > +M: Danilo Krummrich <dakr@kernel.org> > > > +L: rust-for-linux@vger.kernel.org > > > +S: Maintained > > > +F: rust/kernel/alloc.rs > > > +F: rust/kernel/alloc/ > > > > It feels like we should use `mod.rs`. > > The same would be true for: > > - rust/kernel/sync.rs > - rust/kernel/net.rs > - rust/kernel/init.rs > - rust/kernel/fs.rs > - ... > > Do you propose to change it for all of them? I do actually think `mod.rs` is superior in general, but it's probably not worth changing it right now. Alice
On 04.09.24 12:15, Alice Ryhl wrote: > On Tue, Sep 3, 2024 at 2:03 PM Danilo Krummrich <dakr@kernel.org> wrote: >> >> On Sat, Aug 31, 2024 at 01:57:12PM +0100, Gary Guo wrote: >>> On Fri, 16 Aug 2024 02:11:08 +0200 >>> Danilo Krummrich <dakr@kernel.org> wrote: >>> >>>> Add maintainers entry for the Rust `alloc` module. >>>> >>>> Currently, this includes the `Allocator` API itself, `Allocator` >>>> implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's >>>> implementation of the primary memory allocation data structures, `Box` >>>> and `Vec`. >>>> >>>> Signed-off-by: Danilo Krummrich <dakr@kernel.org> >>>> --- >>>> MAINTAINERS | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 42decde38320..560516b3aaf4 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -19925,6 +19925,13 @@ F: scripts/*rust* >>>> F: tools/testing/selftests/rust/ >>>> K: \b(?i:rust)\b >>>> >>>> +RUST [ALLOC] >>>> +M: Danilo Krummrich <dakr@kernel.org> >>>> +L: rust-for-linux@vger.kernel.org >>>> +S: Maintained >>>> +F: rust/kernel/alloc.rs >>>> +F: rust/kernel/alloc/ >>> >>> It feels like we should use `mod.rs`. >> >> The same would be true for: >> >> - rust/kernel/sync.rs >> - rust/kernel/net.rs >> - rust/kernel/init.rs >> - rust/kernel/fs.rs >> - ... >> >> Do you propose to change it for all of them? > > I do actually think `mod.rs` is superior in general, but it's probably > not worth changing it right now. I forgot the reason for not using it, does anyone remember? --- Cheers, Benno
On 04.09.24 14:57, Miguel Ojeda wrote: > On Wed, Sep 4, 2024 at 2:51 PM Benno Lossin <benno.lossin@proton.me> wrote: >> >> I forgot the reason for not using it, does anyone remember? > > One of the reasons argued was that `mod.rs` is the same name > everywhere, and thus it is hard to notice the difference in some > editors and may be harder to "jump into" in history/tabs/etc. I don't usually open more than 2-4 files anyways, so it's not an issue for me. But of course people's workflow is different, does anyone have a problem with switching to `mod.rs`? I have another reason that it might be nicer, when I want to edit eg `init.rs` and I decide to directly open it with the editor from my shell, not using my fuzzy finder, then I need to press tab to select between `rust/kernel/init` and `rust/kernel/init.rs`. --- Cheers, Benno
On Tue, Sep 10, 2024 at 01:26:34PM +0000, Benno Lossin wrote: > On 04.09.24 14:57, Miguel Ojeda wrote: > > On Wed, Sep 4, 2024 at 2:51 PM Benno Lossin <benno.lossin@proton.me> wrote: > >> > >> I forgot the reason for not using it, does anyone remember? > > > > One of the reasons argued was that `mod.rs` is the same name > > everywhere, and thus it is hard to notice the difference in some > > editors and may be harder to "jump into" in history/tabs/etc. > > I don't usually open more than 2-4 files anyways, so it's not an issue > for me. But of course people's workflow is different, does anyone have a > problem with switching to `mod.rs`? I'm also not against it. I'd appreciate if a potential change doesn't interfere with this series too much though. :-) > > I have another reason that it might be nicer, when I want to edit eg > `init.rs` and I decide to directly open it with the editor from my > shell, not using my fuzzy finder, then I need to press tab to select > between `rust/kernel/init` and `rust/kernel/init.rs`. > > --- > Cheers, > Benno >
On 10.09.24 15:42, Danilo Krummrich wrote: > On Tue, Sep 10, 2024 at 01:26:34PM +0000, Benno Lossin wrote: >> On 04.09.24 14:57, Miguel Ojeda wrote: >>> On Wed, Sep 4, 2024 at 2:51 PM Benno Lossin <benno.lossin@proton.me> wrote: >>>> >>>> I forgot the reason for not using it, does anyone remember? >>> >>> One of the reasons argued was that `mod.rs` is the same name >>> everywhere, and thus it is hard to notice the difference in some >>> editors and may be harder to "jump into" in history/tabs/etc. >> >> I don't usually open more than 2-4 files anyways, so it's not an issue >> for me. But of course people's workflow is different, does anyone have a >> problem with switching to `mod.rs`? > > I'm also not against it. I'd appreciate if a potential change doesn't interfere > with this series too much though. :-) Sure, we can do it after the series. --- Cheers, Benno
diff --git a/MAINTAINERS b/MAINTAINERS index 42decde38320..560516b3aaf4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19925,6 +19925,13 @@ F: scripts/*rust* F: tools/testing/selftests/rust/ K: \b(?i:rust)\b +RUST [ALLOC] +M: Danilo Krummrich <dakr@kernel.org> +L: rust-for-linux@vger.kernel.org +S: Maintained +F: rust/kernel/alloc.rs +F: rust/kernel/alloc/ + RXRPC SOCKETS (AF_RXRPC) M: David Howells <dhowells@redhat.com> M: Marc Dionne <marc.dionne@auristor.com>
Add maintainers entry for the Rust `alloc` module. Currently, this includes the `Allocator` API itself, `Allocator` implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's implementation of the primary memory allocation data structures, `Box` and `Vec`. Signed-off-by: Danilo Krummrich <dakr@kernel.org> --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)