diff mbox series

[v5.1,01/19] mm/mmap: Correctly position vma_iterator in __split_vma()

Message ID 20240816111405.11793-2-spasswolf@web.de (mailing list archive)
State New
Headers show
Series Rebase v5 patchset to next-20240816 | expand

Commit Message

Bert Karwatzki Aug. 16, 2024, 11:13 a.m. UTC 
The vma iterator may be left pointing to the newly created vma.  This
happens when inserting the new vma at the end of the old vma
(!new_below).

The incorrect position in the vma iterator is not exposed currently
since the vma iterator is repositioned in the munmap path and is not
reused in any of the other paths.

This has limited impact in the current code, but is required for future
changes.

Fixes: b2b3b886738f ("mm: don't use __vma_adjust() in __split_vma()")
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
 mm/vma.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.45.2
diff mbox series

Patch

diff --git a/mm/vma.c b/mm/vma.c
index 84965f2cd580..02e4f7cf489f 100644
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -246,6 +246,9 @@  static int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *vma,
 	/* Success. */
 	if (new_below)
 		vma_next(vmi);
+	else
+		vma_prev(vmi);
+
 	return 0;

 out_free_mpol: