From patchwork Fri Aug 16 16:42:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13766593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDCEC531DF for ; Fri, 16 Aug 2024 16:43:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C78C6B0105; Fri, 16 Aug 2024 12:43:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 350CD6B0107; Fri, 16 Aug 2024 12:43:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E46C8D0095; Fri, 16 Aug 2024 12:43:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC3638D007E for ; Fri, 16 Aug 2024 12:43:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 72939160154 for ; Fri, 16 Aug 2024 16:43:32 +0000 (UTC) X-FDA: 82458679464.21.CD26942 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf20.hostedemail.com (Postfix) with ESMTP id 0C5AD1C001B for ; Fri, 16 Aug 2024 16:43:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723826573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QgZl+Bmxu5irEkJmBSRuXr/nILpva7a6CA0C6t5FM/I=; b=Tqs1GiVP01Ao2PxdmqeDLoI9kI0HMT60zWGj4Sq0HpzRPJ/kin+2qWvgEqNrGCFnZQLJPN Rc9gKt/OnH8qvnRgkZzPLcwhQKuBTQ1GxE8OwOyc2+gr/r/+7LuGKIT9NL1S60pGTaNAiM 9P/MUzqI5ICQwnjloU10PywHB4mA/Q0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723826573; a=rsa-sha256; cv=none; b=WDObE4KuykD3oi5kt1tzdeaqSLnwZ/u81iXWNJ8TCQ9ngWOWmIpGM1vNal3gUtNPb2myI5 Gt95COXCAkJCFKXkghMqb+Xsky3wwYLuaIGNXlquvIFXA7AhOvs9tVc7OvviSCfeGVnwje +8q0XaK+P/TUNtN3hmeVXApUis7oP7A= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WlnmD5Bkzz67Cwc; Sat, 17 Aug 2024 00:40:28 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id 02100140A70; Sat, 17 Aug 2024 00:43:27 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.48.148.43) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 16 Aug 2024 17:43:25 +0100 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v11 01/14] EDAC: Add support for EDAC device feature's control Date: Fri, 16 Aug 2024 17:42:24 +0100 Message-ID: <20240816164238.1902-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240816164238.1902-1-shiju.jose@huawei.com> References: <20240816164238.1902-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.48.148.43] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0C5AD1C001B X-Stat-Signature: z353pjqumq4jpzxrr6mrj48kcpcx53hx X-HE-Tag: 1723826608-483122 X-HE-Meta: U2FsdGVkX19Lvm10CoXXm+sW9fTd/qYpm6U+8xPhj4fzw/mjqpw+1RaM1TcPC6Tliw3EqUd66u0pxld8NquW/+1MDm8DRTvCrzt7ZYdSgsqQIRfO6RsySD9VnSsSw186Mn5UPKfD5ijPaZ4XuGdNAztcnyarAwTMofmJZGrzeYt0/clWc5tqcrDIdd29glaLrz+64+RyIAGkV1x8+6PVeNw8tO1tWIGZle2SjiHhQf3M9E+RRjLtKf+x6R2iZ0KUweo+Yq0OTKGPu7HMZ75v4PwToW91s9H5J/z1nKvPpp1XkYwj4VDZCcld1tLRtDxlZpdrrd1MAnNCfjsEkhJhMGt4UUkHKzTxzVpSqBtVC8KROO1Cir6ZHwwgzMUEFYtBhOAJDVoVUrPzGswQ2PK+RjfGWAbmqf3UupX5P5jzMAl437MFYO44ic3Js5QF9rr/DVIlM6MF3J6gMxO0LJqOFurZ2i7KEwQmMC7bhyoIAbVJ4pYuK3Y0/i2zoq8pmJI0VW9Bx2IoPYtazZTvLrywBHj2+ZxoShGSSb7GquhnOkwAZAhCZrqeCYMLGJMGEhk7+/3J/h33F5NrpztE2qS0xCiAw1PmzNUsipJ1uFKkMogAB3AOTPrXnFbdxhsF7hfKxnpqfr5PBLvewpNlIPDBiw/S/j98myxJBYCiPjwqpa7miN7QJj5MbpyZIaWGV1yCA3u4nEPNISHANvQtc/CoRW0unm8w6FrzkZGt2yKJa7n7orr2MXRoKavf5lRMER7BhPYHd0sY9BWMpl9/21pTXw0QF5qUO0ud44ZJmnyfICwKWfpJV++c8EkMi6xhgP7dXwKEbfTdCimk5qNG04wZTAlpmWtEMRCUNcdNjUws8kPbfbnqxVcnk4xAOvSdywUfK77dlQCj51LYSf/lj1Gh6eTq9yAC8uqSliA2TSnEZZfWlF7cOjy61bXtLD126u2VbCX369tJ27cAAssOvtG MtFr+IF6 TkZwu26sJAmXLHB3HKwQlwjTFRH/8QTDZBluHhDkWkukM8wyeawDk5WskbreUj4HTsaYv6PXEc2dbHFo6oWQiNvSutZ3jdIjXdNkTV00mOBVarK/KRqKA5B4J2mo58Hwvnna5HbHl6kBb0g0KSBW01YYU0DXodqbQ00HUIKIz83ngYyD5rBIhudSAyEEynYBN6uOFA3lL10iAF+FGUvCpmZ4IgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add generic EDAC device feature's control supports registering RAS features supported in the system. Driver exposes feature's control attributes to the userspace in /sys/bus/edac/devices/// Co-developed-by: Jonathan Cameron Signed-off-by: Jonathan Cameron Signed-off-by: Shiju Jose --- drivers/edac/edac_device.c | 178 +++++++++++++++++++++++++++++++++++++ include/linux/edac.h | 60 +++++++++++++ 2 files changed, 238 insertions(+) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 621dc2a5d034..635a41db8b5a 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -570,3 +570,181 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, block ? block->name : "N/A", count, msg); } EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); + +/* EDAC device feature */ +static void edac_dev_release(struct device *dev) +{ + struct edac_dev_feat_ctx *ctx = + container_of(dev, struct edac_dev_feat_ctx, dev); + + kfree(ctx->dev.groups); + kfree(ctx); +} + +const struct device_type edac_dev_type = { + .name = "edac_dev", + .release = edac_dev_release, +}; + +static void edac_dev_unreg(void *data) +{ + device_unregister(data); +} + +/** + * edac_dev_feature_init - Init a ras feature + * @parent: client device. + * @dev_data: pointer to struct edac_dev_data. + * @feat: pointer to struct edac_dev_feature. + * @attr_groups: pointer to attribute group's container. + * + * Returns number of scrub feature's attribute groups on success, + * error otherwise. + */ +static int edac_dev_feat_init(struct device *parent, + struct edac_dev_data *dev_data, + const struct edac_dev_feature *ras_feat, + const struct attribute_group **attr_groups) +{ + int num; + + switch (ras_feat->feat) { + case RAS_FEAT_SCRUB: + dev_data->scrub_ops = ras_feat->scrub_ops; + dev_data->private = ras_feat->scrub_ctx; + return 1; + case RAS_FEAT_ECS: + num = ras_feat->ecs_info.num_media_frus; + dev_data->ecs_ops = ras_feat->ecs_ops; + dev_data->private = ras_feat->ecs_ctx; + return num; + case RAS_FEAT_PPR: + dev_data->ppr_ops = ras_feat->ppr_ops; + dev_data->private = ras_feat->ppr_ctx; + return 1; + default: + return -EINVAL; + } +} + +/** + * edac_dev_register - register device for ras features with edac + * @parent: client device. + * @name: client device's name. + * @private: parent driver's data to store in the context if any. + * @num_features: number of ras features to register. + * @ras_features: list of ras features to register. + * + * Returns 0 on success, error otherwise. + * The new edac_dev_feat_ctx would be freed automatically. + */ +int edac_dev_register(struct device *parent, char *name, + void *private, int num_features, + const struct edac_dev_feature *ras_features) +{ + const struct attribute_group **ras_attr_groups; + struct edac_dev_data *dev_data; + struct edac_dev_feat_ctx *ctx; + int ppr_cnt = 0, ppr_inst = 0; + int attr_gcnt = 0; + int ret, feat; + + if (!parent || !name || !num_features || !ras_features) + return -EINVAL; + + /* Double parse so we can make space for attributes */ + for (feat = 0; feat < num_features; feat++) { + switch (ras_features[feat].feat) { + case RAS_FEAT_SCRUB: + case RAS_FEAT_PPR: + attr_gcnt++; + ppr_cnt++; + break; + case RAS_FEAT_ECS: + attr_gcnt += ras_features[feat].ecs_info.num_media_frus; + break; + default: + return -EINVAL; + } + } + + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ctx->dev.parent = parent; + ctx->private = private; + + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); + if (!ras_attr_groups) { + ret = -ENOMEM; + goto ctx_free; + } + + if (ppr_cnt) { + ctx->ppr = kcalloc(ppr_cnt, sizeof(*(ctx->ppr)), GFP_KERNEL); + if (!ctx->ppr) { + ret = -ENOMEM; + goto groups_free; + } + } + + attr_gcnt = 0; + for (feat = 0; feat < num_features; feat++, ras_features++) { + switch (ras_features->feat) { + case RAS_FEAT_SCRUB: + if (!ras_features->scrub_ops) + continue; + dev_data = &ctx->scrub; + break; + case RAS_FEAT_ECS: + if (!ras_features->ecs_ops) + continue; + dev_data = &ctx->ecs; + break; + case RAS_FEAT_PPR: + if (!ras_features->ppr_ops) + continue; + dev_data = &ctx->ppr[ppr_inst]; + dev_data->instance = ppr_inst; + ppr_inst++; + break; + default: + ret = -EINVAL; + goto data_mem_free; + } + ret = edac_dev_feat_init(parent, dev_data, ras_features, + &ras_attr_groups[attr_gcnt]); + if (ret < 0) + goto data_mem_free; + + attr_gcnt += ret; + } + ras_attr_groups[attr_gcnt] = NULL; + ctx->dev.bus = edac_get_sysfs_subsys(); + ctx->dev.type = &edac_dev_type; + ctx->dev.groups = ras_attr_groups; + dev_set_drvdata(&ctx->dev, ctx); + ret = dev_set_name(&ctx->dev, name); + if (ret) + goto data_mem_free; + + ret = device_register(&ctx->dev); + if (ret) { + put_device(&ctx->dev); + goto data_mem_free; + return ret; + } + + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); + +data_mem_free: + if (ppr_cnt) + kfree(ctx->ppr); +groups_free: + kfree(ras_attr_groups); +ctx_free: + kfree(ctx); + return ret; +} +EXPORT_SYMBOL_GPL(edac_dev_register); diff --git a/include/linux/edac.h b/include/linux/edac.h index b4ee8961e623..cc96f55ac714 100644 --- a/include/linux/edac.h +++ b/include/linux/edac.h @@ -661,4 +661,64 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, return mci->dimms[index]; } + +/* EDAC device features */ + +#define EDAC_FEAT_NAME_LEN 128 + +enum edac_dev_feat { + RAS_FEAT_SCRUB, + RAS_FEAT_ECS, + RAS_FEAT_PPR, + RAS_FEAT_MAX +}; + +struct edac_ecs_ex_info { + u16 num_media_frus; +}; + +/* + * EDAC device feature information structure + */ +struct edac_dev_data { + union { + const struct edac_scrub_ops *scrub_ops; + const struct edac_ecs_ops *ecs_ops; + const struct edac_ppr_ops *ppr_ops; + }; + u8 instance; + void *private; +}; + +struct device; + +struct edac_dev_feat_ctx { + struct device dev; + void *private; + struct edac_dev_data scrub; + struct edac_dev_data ecs; + struct edac_dev_data *ppr; +}; + +struct edac_dev_feature { + enum edac_dev_feat feat; + u8 instance; + union { + const struct edac_scrub_ops *scrub_ops; + const struct edac_ecs_ops *ecs_ops; + const struct edac_ppr_ops *ppr_ops; + }; + union { + void *scrub_ctx; + void *ecs_ctx; + void *ppr_ctx; + }; + union { + struct edac_ecs_ex_info ecs_info; + }; +}; + +int edac_dev_register(struct device *parent, char *dev_name, + void *parent_pvt_data, int num_features, + const struct edac_dev_feature *ras_features); #endif /* _LINUX_EDAC_H_ */