From patchwork Fri Aug 16 16:42:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13766596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4CEC531DC for ; Fri, 16 Aug 2024 16:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B7068D0093; Fri, 16 Aug 2024 12:43:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F39F8D007E; Fri, 16 Aug 2024 12:43:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F38668D0093; Fri, 16 Aug 2024 12:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C9E8F8D007E for ; Fri, 16 Aug 2024 12:43:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 695A9140118 for ; Fri, 16 Aug 2024 16:43:37 +0000 (UTC) X-FDA: 82458679674.27.B7CAB40 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf03.hostedemail.com (Postfix) with ESMTP id 6AB7820004 for ; Fri, 16 Aug 2024 16:43:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723826579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ePB1klFb0vx0WueODFfMsJXNqkz8W5Felq6yt1uZXA=; b=bYOP4WaN7pyngzYzZ5LMmLlrHnMnrApl/co1ohnaXoOOXQk1XeA0btUqisKNb+yFgPbpfM +yrDqD9+5ORhH/eQUYkCrfWAc+2Y08viffp7tFvmGke5R1z1TZKtzs9ZnxjAATeTDW5gly HqJGJLC9m8Vfg08efYTse6bjPFMc+wY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723826579; a=rsa-sha256; cv=none; b=zAlCeAI9lcfk5zxBFDifoApMiGQr8EVjMC41pBSDsH139Nm0FEEF8AqB0LxGCZSLSAHsTe fcU15rsRqO9WImn8+86Clz4CEMYZigh4xjiObak5yR9/D0j0J1qSJEKWwjG53EUub/SXD/ AZ9R0vdV6NLk5alZJvSy5s3AISNU7LA= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wlnlt3czQz6K5st; Sat, 17 Aug 2024 00:40:10 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id 7B00C1400D3; Sat, 17 Aug 2024 00:43:33 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.48.148.43) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 16 Aug 2024 17:43:32 +0100 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v11 04/14] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Date: Fri, 16 Aug 2024 17:42:27 +0100 Message-ID: <20240816164238.1902-5-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240816164238.1902-1-shiju.jose@huawei.com> References: <20240816164238.1902-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.48.148.43] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6AB7820004 X-Stat-Signature: ztwbx7ya35tiw1dm53en5kqttnphwgub X-HE-Tag: 1723826615-815775 X-HE-Meta: U2FsdGVkX1/o0hM5dHzsQzCYLDLThxkw71MdSQBgYwezll9o8o9LGULJKXqUf4AS/PftH7qeccVnooqB2DQ4rSQppBwD/0T5ijOlIUpJ660r7uyqQcrMb1qyZbqW3iXdEgxvB69hZuLi5gMx1LoaL6wylEJ812VAtgvlT4Ew/y1+J8b10t2zsImZXyHSuEU1tWF5sXmRBpg5aKRqEPx6u4SrsZc8tRZf3cg0rn4liUmTIHGrDV4IwTlXX1+PQfYJq2eiosLr13k73sg1fsJNiuzt9Lfie9xrjBKM/aa/b1t1rBoebF3767KznT51pOShH58+2llNpRO5bgDArn5FmZMUOyGITcktf3LLN870+26dW8yFB6qteKVMaAGjNEjD89wpPsQzEoDM5NdVeZZbUehI69N4UeeR2mcNBg+1L039Ttm/wT/CnZO3g3zl2wWsSbA8FLuM0Ru27JVtb7mKSYGTeEpeedhoLdzvjEa2rIVLW2tBeu7n6eYH6wKMKy/HO0L+06EsX+lFv1B8/lBBHx2pC8G8LJ3gjpCmiK4KopyR4f++PBPTG8U6gWwYo2QzhiIjV+22RXZrTv2/X/5V9/tgpoZ41/AOODhqMs7jlzm/DdanyLI/DhkloPh+Pq16cLGsy9PmHsZjg05Q8NeanRQwaIhPnltIN0DhXONWSKhYJj7XbNNMNv3jhgqWmcsGLK6yEKZ6VOuwjDue0/WNf3+fCtvLwK1kooOaMopTGN+YThMITo/s44oU9S+mW5we2bmSY3AthdwPvRov0J1MySG0dz9yTjSQDQgGqVZWRku0HfRr+s9Ejc9o4zu9Sd6k399B09UmFxfQYlVaIr0u4vpA/KP1u2p3uaLox0RL7MehhLU7Cn9qahMAX6mDpD10k8OyAW6XEEapXflgRmyQAf8WqY1sHWEu3kwnv+fYGN0nDDolSjyrSKeSWxxB1OlAuNK0FsbIYf4hVBo27IP sydxrFMF sTYBDlc3lwIMQhRCd8DwTk2C3/phQ/mlHO9+v41E+lcM4oyVXRT87GK+/mt91GRXqne/4dxudv4ZOmFps6QQmeSXuqjUgoOVLwGcGY6xc4SUh9KOibhIQCSEdalbSZluDLOUa7Fa8YDqJvnGoOEaZNxH+w66y2CH8IzOFMsT+T/UVJbdH0pBvfd2wNAW07zlpLO73bPV+e6rZktakl8iUCOmSO9ZMsS8Rp2ZuRSwb1uBrxoaYjlnWE0NWoD08HoVsvPYy79cIV9GLkbg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for GET_SUPPORTED_FEATURES mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. CXL devices support features with changeable attributes. CXL spec 3.1 section 8.2.9.6.1 describes Get Supported features command. Get Supported Features retrieves the list of supported device specific features. The settings of a feature can be retrieved using Get Feature and optionally modified using Set Feature. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 68 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 63 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 131 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 2626f3fff201..760fa3e1075f 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1324,6 +1324,74 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds) } EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + u32 count, u16 start_index, + struct cxl_mbox_get_supp_feats_out *feats_out) +{ + struct cxl_mbox_get_supp_feats_in pi; + struct cxl_mbox_cmd mbox_cmd; + int rc; + + pi.count = cpu_to_le32(count); + pi.start_index = cpu_to_le16(start_index); + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_SUPPORTED_FEATURES, + .size_in = sizeof(pi), + .payload_in = &pi, + .size_out = count, + .payload_out = feats_out, + .min_out = sizeof(*feats_out), + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + return 0; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); + +int cxl_get_supported_feature_entry(struct cxl_memdev_state *mds, const uuid_t *feat_uuid, + struct cxl_mbox_supp_feat_entry *feat_entry_out) +{ + struct cxl_mbox_supp_feat_entry *feat_entry; + int feat_index, feats_out_size; + int nentries, count; + int ret; + + feat_index = 0; + feats_out_size = sizeof(struct cxl_mbox_get_supp_feats_out) + + sizeof(struct cxl_mbox_supp_feat_entry); + struct cxl_mbox_get_supp_feats_out *feats_out __free(kfree) = + kmalloc(feats_out_size, GFP_KERNEL); + if (!feats_out) + return -ENOMEM; + + while (true) { + memset(feats_out, 0, feats_out_size); + ret = cxl_get_supported_features(mds, feats_out_size, + feat_index, feats_out); + if (ret) + return ret; + + nentries = feats_out->nr_entries; + if (!nentries) + return -EOPNOTSUPP; + + /* Check CXL memdev supports the feature */ + feat_entry = feats_out->feat_entries; + for (count = 0; count < nentries; count++, feat_entry++) { + if (uuid_equal(&feat_entry->uuid, feat_uuid)) { + memcpy(feat_entry_out, feat_entry, + sizeof(*feat_entry_out)); + return 0; + } + } + feat_index += nentries; + } +} +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_feature_entry, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index af8169ccdbc0..9939c771f642 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -531,6 +531,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_LOG_CAPS = 0x0402, CXL_MBOX_OP_CLEAR_LOG = 0x0403, CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -700,6 +701,63 @@ struct cxl_mbox_set_timestamp_in { } __packed; +/* + * Get Supported Features CXL 3.1 Spec 8.2.9.6.1 + */ + +/* + * Get Supported Features input payload + * CXL rev 3.1 section 8.2.9.6.1 Table 8-95 + */ +struct cxl_mbox_get_supp_feats_in { + __le32 count; + __le16 start_index; + u8 rsvd[2]; +} __packed; + +/* + * Get Supported Features Supported Feature Entry + * CXL rev 3.1 section 8.2.9.6.1 Table 8-97 + */ +/* Supported Feature Entry : Payload out attribute flags */ +#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) +#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK GENMASK(3, 1) +#define CXL_FEAT_ENTRY_FLAG_PERSIST_ACROSS_FIRMWARE_UPDATE BIT(4) +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_DEFAULT_SELECTION BIT(5) +#define CXL_FEAT_ENTRY_FLAG_SUPPORT_SAVED_SELECTION BIT(6) + +enum cxl_feat_attr_value_persistence { + CXL_FEAT_ATTR_VALUE_PERSISTENCE_NONE, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_CXL_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_HOT_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_WARM_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_COLD_RESET, + CXL_FEAT_ATTR_VALUE_PERSISTENCE_MAX +}; + +struct cxl_mbox_supp_feat_entry { + uuid_t uuid; + __le16 index; + __le16 get_size; + __le16 set_size; + __le32 attr_flags; + u8 get_version; + u8 set_version; + __le16 set_effects; + u8 rsvd[18]; +} __packed; + +/* + * Get Supported Features output payload + * CXL rev 3.1 section 8.2.9.6.1 Table 8-96 + */ +struct cxl_mbox_get_supp_feats_out { + __le16 nr_entries; + __le16 nr_supported; + u8 rsvd[4]; + struct cxl_mbox_supp_feat_entry feat_entries[]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -831,6 +889,11 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_type event_type, const uuid_t *uuid, union cxl_event *evt); int cxl_set_timestamp(struct cxl_memdev_state *mds); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + u32 count, u16 start_index, + struct cxl_mbox_get_supp_feats_out *feats_out); +int cxl_get_supported_feature_entry(struct cxl_memdev_state *mds, const uuid_t *feat_uuid, + struct cxl_mbox_supp_feat_entry *feat_entry_out); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);