From patchwork Fri Aug 23 06:20:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Ge X-Patchwork-Id: 13774633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74781C531DC for ; Fri, 23 Aug 2024 06:21:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F22DB80081; Fri, 23 Aug 2024 02:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6CD88007E; Fri, 23 Aug 2024 02:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D03A880081; Fri, 23 Aug 2024 02:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A81B28007E for ; Fri, 23 Aug 2024 02:21:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2F519140A3F for ; Fri, 23 Aug 2024 06:21:18 +0000 (UTC) X-FDA: 82482513036.29.7FCCFDA Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf11.hostedemail.com (Postfix) with ESMTP id C08DD40006 for ; Fri, 23 Aug 2024 06:21:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dpEap9qM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724394010; a=rsa-sha256; cv=none; b=3dIQqT/n+mqd9oXeJWbxV5Tx/hpWbuN0R2XOl3q5dXeIsXZ6S9X/gxJXiRuLxVDgDgNWZP 0WnBWUG8MCp/Kw/1BZLcQcME9i243F1qN/H0rHCdnL2AHqJyfTEDDn1VFQU5BS18AESrVY 7m0uk4L0T6xMcA7A+vQLCEAc3N26fGM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dpEap9qM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724394010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IaLM4r9F0h2ORPAVWBkvfTjggq9qCherBRJzxkFeUE8=; b=KYeHxyUediVYoSTTsqCKh8yBukw352OZem2epFmCagzpUaCqMAjVkJQ2GhoUauzU5gw9zQ quOZf2j4lo9OfwoCqXMt00cMEEDUVro/S28RKPksZMeBNIWqnMqt3VYTzi6xDnd2plFkrK z2kYeItDMXDsrbD6XkryQugc0aWP4qs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724394071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IaLM4r9F0h2ORPAVWBkvfTjggq9qCherBRJzxkFeUE8=; b=dpEap9qMcxSRukFGYOSK/BUA0w+Jn01PBwnuCRlDTxbMd0pa732PBGJbPJO0hFsgLeQGMq YY6ziKvt2jDkfkPZX0f6QvIzfo7EWVPBMALQRnSbIK4ppBE+TxSfRHNk2Zme/g+dee2Sc7 1m0ohJ3jCynxnaTQ4yWekBGiG7wxb2I= From: Hao Ge To: akpm@linux-foundation.org, david@redhat.com, kent.overstreet@linux.dev, linmiaohe@huawei.com, nao.horiguchi@gmail.com, pasha.tatashin@soleen.com, surenb@google.com Cc: hao.ge@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hao Ge , stable@vger.kernel.org Subject: [PATCH] codetag: debug: mark codetags for poisoned page as empty Date: Fri, 23 Aug 2024 14:20:02 +0800 Message-Id: <20240823062002.21165-1-hao.ge@linux.dev> In-Reply-To: References: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C08DD40006 X-Stat-Signature: x4jj4puz6d7cehdod6g9ihmy3cxfs97b X-Rspam-User: X-HE-Tag: 1724394074-627001 X-HE-Meta: U2FsdGVkX18leCCxNI07REQCER+RubiNuvVTdFgstckmKCOiBF0MYI7AF514FbxFIzhdydr5JCyJSh6b7WbLS6Iepm1r3Le2ueLslLvXMFG4K/zeJ03PzD6UuJ5XNPYpat+RV0kbthCN5Le9oyp/+eNLZPJRsWP8aVDKLNQVA7Dv6RmvcZmKjeWgrqDyd/VO1kO5zv+TzMKDOm+9+8dICnba11neYSXGtSSruIbZt/ZR5Tk6HAKJnHeq7ddjGO976NCbycyEhbxjmfmV27XIRgYQ0j6Nk+UkpswWN4FHae2DnxD5ULPcGRF1j3bDWNh2e2qjGy05suO8HC6aFHD7umAbLkou8YZCmdO3puWiuZOqdPRR5utFwTGBHFQPz3Qc+D3yvBQAwRcWXzDsaPpE17M4UJFFx07zeJYTMzTOlnN2xWRpPu/wsjHBZ05u1VlP4IOYLhDUd6Za8n8XSCWwldvmwWlbUI78R4vuzuCawZNFVz0WduE/oMNgNHMLC/dRMoOndwCzrt9BMCJKs0O0PYEbMATgtLGK24nvBB7rdEPSLR0Snj3s/EaT0viQ0ZQ76QdLkCp9k3UMeEsQeCthPDwp7K7psxthQCVBYZkrQ9XD/kv6ue2cScweOoSs4LnwB55w9mlM3zueTpOyNV5mFNkNUqtgzv1puqomyi1kzt0CGWJTpYimQn3W8lzg+sB7UnT1PYbyHAA9MGpq3HDU4DXU7DSgQhSv0j4pQb58YeivqQ2zkARUw+8HXHti8SBZHf+v8QVP8HLzuMbgccziCANDKFYjRIx784FX5QYiUV8EXDpRa2eWXPLvoMnCSQ5GnMal9WaMNmsGJ6UigUqnzEpipDzd279IHyaYdDhuipYgva+nR9pAxRqiaUlgncMBQn3miFitWcJBKlakGMyr+3QKzCGFoJ5/vYRsQ0lzEZG32NQJAkKuDyl2l6KQetHWCqzmFB9UZ8dbptHtYUq 1asSrowM dDdV1HfeYz2ndZXHHxXGsch89pgrw3ajDQuPnuAW9akxpA6R9Q/0vxlAzW89joUQixRsqNjoqjmaiGCTGDCZp4AoX8VNCvFc8/8sLv8Qb8AoYY0u2gojCS/asdQzwYpMT4k23UFDDvrnh9I/YGX4psV8SyTRQb85aMacFkcupiD/8fMSxOTmpT3hHB8Gm0tow/xvvgR+gcbJXknbddFjfP70I/dF7QZ7nU9MW01Bi1KdYBFjpatcMCaOzxJypSu14BeLzH0Ce990z3DE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge The PG_hwpoison page will be caught and isolated on the entrance to the free buddy page pool. But for poisoned pages which software injected errors, we can reclaim it through unpoison_memory. So mark codetags for it as empty,just like when a page is first added to the buddy system. It was detected by [1] and the following WARN occurred: [ 113.930443][ T3282] ------------[ cut here ]------------ [ 113.931105][ T3282] alloc_tag was not set [ 113.931576][ T3282] WARNING: CPU: 2 PID: 3282 at ./include/linux/alloc_tag.h:130 pgalloc_tag_sub.part.66+0x154/0x164 [ 113.932866][ T3282] Modules linked in: hwpoison_inject fuse ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_conntrack ebtable_nat ebtable_broute ip6table_nat ip6table_man4 [ 113.941638][ T3282] CPU: 2 UID: 0 PID: 3282 Comm: madvise11 Kdump: loaded Tainted: G W 6.11.0-rc4-dirty #18 [ 113.943003][ T3282] Tainted: [W]=WARN [ 113.943453][ T3282] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 [ 113.944378][ T3282] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 113.945319][ T3282] pc : pgalloc_tag_sub.part.66+0x154/0x164 [ 113.946016][ T3282] lr : pgalloc_tag_sub.part.66+0x154/0x164 [ 113.946706][ T3282] sp : ffff800087093a10 [ 113.947197][ T3282] x29: ffff800087093a10 x28: ffff0000d7a9d400 x27: ffff80008249f0a0 [ 113.948165][ T3282] x26: 0000000000000000 x25: ffff80008249f2b0 x24: 0000000000000000 [ 113.949134][ T3282] x23: 0000000000000001 x22: 0000000000000001 x21: 0000000000000000 [ 113.950597][ T3282] x20: ffff0000c08fcad8 x19: ffff80008251e000 x18: ffffffffffffffff [ 113.952207][ T3282] x17: 0000000000000000 x16: 0000000000000000 x15: ffff800081746210 [ 113.953161][ T3282] x14: 0000000000000000 x13: 205d323832335420 x12: 5b5d353031313339 [ 113.954120][ T3282] x11: ffff800087093500 x10: 000000000000005d x9 : 00000000ffffffd0 [ 113.955078][ T3282] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008236ba90 x6 : c0000000ffff7fff [ 113.956036][ T3282] x5 : ffff000b34bf4dc8 x4 : ffff8000820aba90 x3 : 0000000000000001 [ 113.956994][ T3282] x2 : ffff800ab320f000 x1 : 841d1e35ac932e00 x0 : 0000000000000000 [ 113.957962][ T3282] Call trace: [ 113.958350][ T3282] pgalloc_tag_sub.part.66+0x154/0x164 [ 113.959000][ T3282] pgalloc_tag_sub+0x14/0x1c [ 113.959539][ T3282] free_unref_page+0xf4/0x4b8 [ 113.960096][ T3282] __folio_put+0xd4/0x120 [ 113.960614][ T3282] folio_put+0x24/0x50 [ 113.961103][ T3282] unpoison_memory+0x4f0/0x5b0 [ 113.961678][ T3282] hwpoison_unpoison+0x30/0x48 [hwpoison_inject] [ 113.962436][ T3282] simple_attr_write_xsigned.isra.34+0xec/0x1cc [ 113.963183][ T3282] simple_attr_write+0x38/0x48 [ 113.963750][ T3282] debugfs_attr_write+0x54/0x80 [ 113.964330][ T3282] full_proxy_write+0x68/0x98 [ 113.964880][ T3282] vfs_write+0xdc/0x4d0 [ 113.965372][ T3282] ksys_write+0x78/0x100 [ 113.965875][ T3282] __arm64_sys_write+0x24/0x30 [ 113.966440][ T3282] invoke_syscall+0x7c/0x104 [ 113.966984][ T3282] el0_svc_common.constprop.1+0x88/0x104 [ 113.967652][ T3282] do_el0_svc+0x2c/0x38 [ 113.968893][ T3282] el0_svc+0x3c/0x1b8 [ 113.969379][ T3282] el0t_64_sync_handler+0x98/0xbc [ 113.969980][ T3282] el0t_64_sync+0x19c/0x1a0 [ 113.970511][ T3282] ---[ end trace 0000000000000000 ]--- Link [1]: https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/madvise/madvise11.c Fixes: a8fc28dad6d5 ("alloc_tag: introduce clear_page_tag_ref() helper function") Cc: stable@vger.kernel.org # v6.10 Signed-off-by: Hao Ge --- mm/page_alloc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c565de8f48e9..7ccd2157d092 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1054,6 +1054,14 @@ __always_inline bool free_pages_prepare(struct page *page, reset_page_owner(page, order); page_table_check_free(page, order); pgalloc_tag_sub(page, 1 << order); + + /* + * For poisoned pages which software injected errors, + * we can reclaim it through unpoison_memory. + * so mark codetags for it as empty, + * just like when a page is first added to the buddy system. + */ + clear_page_tag_ref(page); return false; }