From patchwork Fri Aug 23 19:04:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 13775726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB5CC5472C for ; Fri, 23 Aug 2024 19:05:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9572C6B027C; Fri, 23 Aug 2024 15:05:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B966B027E; Fri, 23 Aug 2024 15:05:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A5666B027F; Fri, 23 Aug 2024 15:05:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5DB0E6B027C for ; Fri, 23 Aug 2024 15:05:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 196891A143D for ; Fri, 23 Aug 2024 19:05:51 +0000 (UTC) X-FDA: 82484439702.30.8C3140C Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf10.hostedemail.com (Postfix) with ESMTP id 16D72C0018 for ; Fri, 23 Aug 2024 19:05:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DxjCTo/q"; spf=pass (imf10.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724439839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aiVexH2j1k9sFvPt9jGArMlV3SBSHlCMHUkgq1wlWgo=; b=h7MD46t0WCTUOI18hjlbS3AsskwBp7P/1NL21PwdT4fOAwccAgiMSuJ2OuC485nOlQd61Z ifmKtksYAIYJp+uvcNZscoH73R15Q/jWxIouDXvSlVibiPrMA3johv1PGhFgSD30r6sNHa gFQXkvrdxoMd2DeSkieOUmOeJM0Epls= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DxjCTo/q"; spf=pass (imf10.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724439839; a=rsa-sha256; cv=none; b=vhYRQCpwhu3M/veufbRY2/erJqDHgKdq7tGQ2v+k7j9KXElrxt/IJJIpRgMV7bcyol/s4a 6ECDj/PZYOcUQi8CAgXguweyAY7wtrVKcS98TwbYKf00L7BM7lyMwlYRFiTokT1H4bApBr lb66D6PMGVVZhz01fKHTCZmRlsh8fJ4= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-44ff7cc5432so17479181cf.3 for ; Fri, 23 Aug 2024 12:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724439948; x=1725044748; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aiVexH2j1k9sFvPt9jGArMlV3SBSHlCMHUkgq1wlWgo=; b=DxjCTo/q6RqzyZoGNyoKFhIt0OPOCBT5IZ+JRJR+PUTV/Qs7/c+b6P/6Av3DMa3cgk HGAS/qMWFasqWLVeEI/g1vUqNBtRkBPRbWn9TdTNbFfKavgtx15rRjoA6Mo5MBRhSqhY HLdni6kAjz/wd89ikL2CCx94ei3vqYGeQJ5mbPe/u24YHVHvhJYoy5XTHvT2hSPo2yTr 4nZzhji7JFRogk6XSXzA8e47hZPUiggOBVmVJjYCdg1ZdNJMGl5DVrqdJ/Q/k5GnhLYO HmxPa8DkeTj1eDF3AV/E+Voohuo1BrRKhqTGD0RouAGfQsEOAH6ROr7W4F0jCto78U2z 7bxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724439948; x=1725044748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aiVexH2j1k9sFvPt9jGArMlV3SBSHlCMHUkgq1wlWgo=; b=Gk1ApMSFJa2Gdc9c+wj0qfPcSfhnVShadXHrhXPHWAnXgbuDn1hlmwCKvkQmUyrY8L SaOTNM89p85ygQCsnf4oyHc87x5LBtswL4uR+C22PHZAL2ONz7spau3PLWMs5287yE9l VMr1ax3PX8ye247LBiwFHhf7izpfF8RaEgJlDtrL3244k7sR1xVN20f2mxoiOb0waurT SOKiTJGmB+ypUf6BFINchZl0QYs8OynS7gmNdiaoB+0v8Z01tbCq6ZQVueXb7siqg6qT EvAxKN/4CoDIZdt/EFe1Xq4XlU3eFD0wHyCx+OYa5LWw/VVvXMZMT9m6Spp1cRil4I4s 2j4A== X-Forwarded-Encrypted: i=1; AJvYcCWLHMtUTs1IcabbR57a9tA04jtZtW7eSSIKjH29wXtZnOpVCwN24lCuOWhmVDIELmmys2KREo2xSw==@kvack.org X-Gm-Message-State: AOJu0Yz1pG/E9xDPLhG8Wpd/vGBrhlXeoJ82osDveiYzXDL6Qg/FfLK+ M55kFvSeTxqyOhPlI2430ucEAHjXkiGlil1dWSjvczHgTEd4cjAW X-Google-Smtp-Source: AGHT+IFvZr3TGqZmBgSCALJLBRrd1whSJ7kwTO8AdQ4F1ejzeuSL8L8LZNOSIAtT/ZrnYyxamWOI5w== X-Received: by 2002:a05:622a:4805:b0:446:5368:cce4 with SMTP id d75a77b69052e-45509d37d36mr38680821cf.48.1724439947948; Fri, 23 Aug 2024 12:05:47 -0700 (PDT) Received: from localhost (fwdproxy-ash-013.fbsv.net. [2a03:2880:20ff:d::face:b00c]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-454fe1b7d2asm19823311cf.93.2024.08.23.12.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 12:05:47 -0700 (PDT) From: Usama Arif To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Usama Arif , Andi Kleen Subject: [RESEND v8 1/2] mm: store zero pages to be swapped out in a bitmap Date: Fri, 23 Aug 2024 20:04:39 +0100 Message-ID: <20240823190545.979059-2-usamaarif642@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20240823190545.979059-1-usamaarif642@gmail.com> References: <20240823190545.979059-1-usamaarif642@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 16D72C0018 X-Stat-Signature: 98ojphjgqqtbosksfyzkcr6j4ca1cafi X-Rspam-User: X-HE-Tag: 1724439948-866778 X-HE-Meta: U2FsdGVkX1/4LTg3ZuN/gdgmfdy/fqGQdHYm5yEO+1h4wj91wpMRwXdpm4xj+vhl0EikfjnTk+F4/ojLOZNNzjCNiFpJUIon7/erCIjrb4FIw+c1LRqvD/hMZ5+EmAODo6zWm3pP9MA8ZbXioGuTcVbDuhPN+VdFncW2NNO6L28KR9AEXHPum4XX3zP/aaNnZbLD23gcgQT+X+j19694NHBhzfGPKdHWQ9zZCLcXwdny3cHxnOTDXntGMab490rV0A9wFTdEzGC7CV9DUs36+N8sL5vvOvKFHWsdZc8rmy0qAPd2ocY0ru9F1b7L1xURjCjvOVz+u06a9OxANK06o4FFwBVzPjXcA9cJyjzVepZu/POz1FP8kgWSSd1L1GucyALHQxOfagMFHHDM9hBAVDtvAbzwr4O3wec4y0h20OJKYw8z9sB/YkBPFgoYaq4OQUY9S3noPjiSVzCoKxc5kGELxoOBSivTq/yUbCT5cd0bh83A8SuIuaa12b9AulohofCmvR2kDSL89qbpd2aOOIZdUU3aCOGUw8nELvbfLUEY/C4/W7e29dOS9/fSTBBjm3Upiigjs8v2bVyIfiG5i2l4rcg6KDq7n5NZ8foHZITcM6NWO6VsFXceBMwzSVMoPRlabfsrU1t221r5XR4GAqu12NAqhC+lbhNPcZLXkzZCT787FkIEuijbnERgzOVNBbge3emUpenOVTvzUo6YeDQzauzlCB+Yj91CDMNx1z0kpT5Cst/IMLd9A0LSD1UssIQP9cwlcv3hPfQsrv2QnUsPczwZFZLoaG/rH3rudFsSkLnvlWQnSj1WDNneKaeVxYGewAmvaKxuTqsZMk4TlHKf2ZqkkIOMYcJVAjE+nOT1Y/udGkPVaduZBevpKwmjjAJrgUjx/WUj2nTtvT6rT40SALdAFm44YCCP+R5xVfWuzyfj1koCOUS9b8fEqy18OzSFnTUWdLJRyO3oBGN +5lqg2IJ sAR9wfZ97Nkao1dm9iqjfVvsYZuhFYY3RNW+S1/CAzjxpZoG9P3ux/DxA22UMLj5ZNmJAPMUYyF8iC1/P5eRUVJ7qsB9aVq3xwgH7MvwEevjq2rMmzj2Nu1PvlUFMkfzD1ZGyrhn+NkZBFUegVCl7UhM06MaYXU2ab+3i52nwbi2NyN6/Unhhd9psSlIzd7uTbecUSVd11lJi5/ts38emKI2lOhsILzH0eR35GOq5EBbOZD7kL/QSIZ/XKSQDiQOXZoVTBNlMFwR7pl16+gX3rs8A+/14JnDYDw+fpHJuWJWQiF6GMqzthftVB7wt9RSc3Y3b7HjGyCNnV5sQP3sez36cPbDXnF9GgyYtRhAqM6eEAc2HjZXrWfMZs+dNYmjwdD+igJ01Q7YZygjdNLBxLITikmoFgZ4zpnc/v81V/ANnAdp9uXfQ+fj4dfMS9tam5CgtkEk5hEu6ShRq0dn1018jjir6gS/2aRh0V/HytBJuNzSRCNI4vJj8So0GpRHB3jiIPucDE3Uoum4TfBYWpg7RL2j39CEE0zOr7hku4Wf0EXQ1U613SE1ndR5R5yQi6n4PczSOMDZR/uuO8vekG4jYkojxp2lj1pPjNtyGzRzpymburE5LoJ5JU+ex5z68B7pAS06pgq+qXFa03e9/qL6jQL7jGyN66Uz9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Approximately 10-20% of pages to be swapped out are zero pages [1]. Rather than reading/writing these pages to flash resulting in increased I/O and flash wear, a bitmap can be used to mark these pages as zero at write time, and the pages can be filled at read time if the bit corresponding to the page is set. With this patch, NVMe writes in Meta server fleet decreased by almost 10% with conventional swap setup (zswap disabled). [1] https://lore.kernel.org/all/20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1/ Signed-off-by: Usama Arif Reviewed-by: Chengming Zhou Reviewed-by: Yosry Ahmed Reviewed-by: Nhat Pham Cc: David Hildenbrand Cc: Hugh Dickins Cc: Johannes Weiner Cc: Matthew Wilcox (Oracle) Cc: Shakeel Butt Cc: Usama Arif Cc: Andi Kleen Signed-off-by: Andrew Morton Acked-by: Johannes Weiner --- include/linux/swap.h | 1 + mm/page_io.c | 118 ++++++++++++++++++++++++++++++++++++++++++- mm/swapfile.c | 38 ++++++++++++-- 3 files changed, 151 insertions(+), 6 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 248db1dd7812..ca533b478c21 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -296,6 +296,7 @@ struct swap_info_struct { signed char type; /* strange name for an index */ unsigned int max; /* extent of the swap_map */ unsigned char *swap_map; /* vmalloc'ed array of usage counts */ + unsigned long *zeromap; /* kvmalloc'ed bitmap to track zero pages */ struct swap_cluster_info *cluster_info; /* cluster info. Only for SSD */ struct list_head free_clusters; /* free clusters list */ struct list_head full_clusters; /* full clusters list */ diff --git a/mm/page_io.c b/mm/page_io.c index a00e2f615118..b6f1519d63b0 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -172,6 +172,80 @@ int generic_swapfile_activate(struct swap_info_struct *sis, goto out; } +static bool is_folio_zero_filled(struct folio *folio) +{ + unsigned int pos, last_pos; + unsigned long *data; + unsigned int i; + + last_pos = PAGE_SIZE / sizeof(*data) - 1; + for (i = 0; i < folio_nr_pages(folio); i++) { + data = kmap_local_folio(folio, i * PAGE_SIZE); + /* + * Check last word first, incase the page is zero-filled at + * the start and has non-zero data at the end, which is common + * in real-world workloads. + */ + if (data[last_pos]) { + kunmap_local(data); + return false; + } + for (pos = 0; pos < last_pos; pos++) { + if (data[pos]) { + kunmap_local(data); + return false; + } + } + kunmap_local(data); + } + + return true; +} + +static void swap_zeromap_folio_set(struct folio *folio) +{ + struct swap_info_struct *sis = swp_swap_info(folio->swap); + swp_entry_t entry; + unsigned int i; + + for (i = 0; i < folio_nr_pages(folio); i++) { + entry = page_swap_entry(folio_page(folio, i)); + set_bit(swp_offset(entry), sis->zeromap); + } +} + +static void swap_zeromap_folio_clear(struct folio *folio) +{ + struct swap_info_struct *sis = swp_swap_info(folio->swap); + swp_entry_t entry; + unsigned int i; + + for (i = 0; i < folio_nr_pages(folio); i++) { + entry = page_swap_entry(folio_page(folio, i)); + clear_bit(swp_offset(entry), sis->zeromap); + } +} + +/* + * Return the index of the first subpage which is not zero-filled + * according to swap_info_struct->zeromap. + * If all pages are zero-filled according to zeromap, it will return + * folio_nr_pages(folio). + */ +static unsigned int swap_zeromap_folio_test(struct folio *folio) +{ + struct swap_info_struct *sis = swp_swap_info(folio->swap); + swp_entry_t entry; + unsigned int i; + + for (i = 0; i < folio_nr_pages(folio); i++) { + entry = page_swap_entry(folio_page(folio, i)); + if (!test_bit(swp_offset(entry), sis->zeromap)) + return i; + } + return i; +} + /* * We may have stale swap cache pages in memory: notice * them here and get rid of the unnecessary final write. @@ -195,6 +269,25 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) folio_unlock(folio); return ret; } + + /* + * Use a bitmap (zeromap) to avoid doing IO for zero-filled pages. + * The bits in zeromap are protected by the locked swapcache folio + * and atomic updates are used to protect against read-modify-write + * corruption due to other zero swap entries seeing concurrent updates. + */ + if (is_folio_zero_filled(folio)) { + swap_zeromap_folio_set(folio); + folio_unlock(folio); + return 0; + } else { + /* + * Clear bits this folio occupies in the zeromap to prevent + * zero data being read in from any previous zero writes that + * occupied the same swap entries. + */ + swap_zeromap_folio_clear(folio); + } if (zswap_store(folio)) { folio_unlock(folio); return 0; @@ -427,6 +520,26 @@ static void sio_read_complete(struct kiocb *iocb, long ret) mempool_free(sio, sio_pool); } +static bool swap_read_folio_zeromap(struct folio *folio) +{ + unsigned int idx = swap_zeromap_folio_test(folio); + + if (idx == 0) + return false; + + /* + * Swapping in a large folio that is partially in the zeromap is not + * currently handled. Return true without marking the folio uptodate so + * that an IO error is emitted (e.g. do_swap_page() will sigbus). + */ + if (WARN_ON_ONCE(idx < folio_nr_pages(folio))) + return true; + + folio_zero_range(folio, 0, folio_size(folio)); + folio_mark_uptodate(folio); + return true; +} + static void swap_read_folio_fs(struct folio *folio, struct swap_iocb **plug) { struct swap_info_struct *sis = swp_swap_info(folio->swap); @@ -517,7 +630,10 @@ void swap_read_folio(struct folio *folio, struct swap_iocb **plug) } delayacct_swapin_start(); - if (zswap_load(folio)) { + if (swap_read_folio_zeromap(folio)) { + folio_unlock(folio); + goto finish; + } else if (zswap_load(folio)) { folio_unlock(folio); goto finish; } diff --git a/mm/swapfile.c b/mm/swapfile.c index aff73a3d0ead..1cfb7c63cdcc 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -940,6 +940,14 @@ static void swap_range_free(struct swap_info_struct *si, unsigned long offset, unsigned long begin = offset; unsigned long end = offset + nr_entries - 1; void (*swap_slot_free_notify)(struct block_device *, unsigned long); + unsigned int i; + + /* + * Use atomic clear_bit operations only on zeromap instead of non-atomic + * bitmap_clear to prevent adjacent bits corruption due to simultaneous writes. + */ + for (i = 0; i < nr_entries; i++) + clear_bit(offset + i, si->zeromap); if (offset < si->lowest_bit) si->lowest_bit = offset; @@ -2607,7 +2615,8 @@ static int swap_node(struct swap_info_struct *si) static void setup_swap_info(struct swap_info_struct *si, int prio, unsigned char *swap_map, - struct swap_cluster_info *cluster_info) + struct swap_cluster_info *cluster_info, + unsigned long *zeromap) { int i; @@ -2632,6 +2641,7 @@ static void setup_swap_info(struct swap_info_struct *si, int prio, } si->swap_map = swap_map; si->cluster_info = cluster_info; + si->zeromap = zeromap; } static void _enable_swap_info(struct swap_info_struct *si) @@ -2660,11 +2670,12 @@ static void _enable_swap_info(struct swap_info_struct *si) static void enable_swap_info(struct swap_info_struct *si, int prio, unsigned char *swap_map, - struct swap_cluster_info *cluster_info) + struct swap_cluster_info *cluster_info, + unsigned long *zeromap) { spin_lock(&swap_lock); spin_lock(&si->lock); - setup_swap_info(si, prio, swap_map, cluster_info); + setup_swap_info(si, prio, swap_map, cluster_info, zeromap); spin_unlock(&si->lock); spin_unlock(&swap_lock); /* @@ -2682,7 +2693,7 @@ static void reinsert_swap_info(struct swap_info_struct *si) { spin_lock(&swap_lock); spin_lock(&si->lock); - setup_swap_info(si, si->prio, si->swap_map, si->cluster_info); + setup_swap_info(si, si->prio, si->swap_map, si->cluster_info, si->zeromap); _enable_swap_info(si); spin_unlock(&si->lock); spin_unlock(&swap_lock); @@ -2707,6 +2718,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) { struct swap_info_struct *p = NULL; unsigned char *swap_map; + unsigned long *zeromap; struct swap_cluster_info *cluster_info; struct file *swap_file, *victim; struct address_space *mapping; @@ -2829,6 +2841,8 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) p->max = 0; swap_map = p->swap_map; p->swap_map = NULL; + zeromap = p->zeromap; + p->zeromap = NULL; cluster_info = p->cluster_info; p->cluster_info = NULL; spin_unlock(&p->lock); @@ -2841,6 +2855,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile) free_percpu(p->cluster_next_cpu); p->cluster_next_cpu = NULL; vfree(swap_map); + kvfree(zeromap); kvfree(cluster_info); /* Destroy swap account information */ swap_cgroup_swapoff(p->type); @@ -3338,6 +3353,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) sector_t span; unsigned long maxpages; unsigned char *swap_map = NULL; + unsigned long *zeromap = NULL; struct swap_cluster_info *cluster_info = NULL; struct page *page = NULL; struct inode *inode = NULL; @@ -3428,6 +3444,17 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) goto bad_swap_unlock_inode; } + /* + * Use kvmalloc_array instead of bitmap_zalloc as the allocation order might + * be above MAX_PAGE_ORDER incase of a large swap file. + */ + zeromap = kvmalloc_array(BITS_TO_LONGS(maxpages), sizeof(long), + GFP_KERNEL | __GFP_ZERO); + if (!zeromap) { + error = -ENOMEM; + goto bad_swap_unlock_inode; + } + if (si->bdev && bdev_stable_writes(si->bdev)) si->flags |= SWP_STABLE_WRITES; @@ -3503,7 +3530,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) if (swap_flags & SWAP_FLAG_PREFER) prio = (swap_flags & SWAP_FLAG_PRIO_MASK) >> SWAP_FLAG_PRIO_SHIFT; - enable_swap_info(si, prio, swap_map, cluster_info); + enable_swap_info(si, prio, swap_map, cluster_info, zeromap); pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s\n", K(si->pages), name->name, si->prio, nr_extents, @@ -3538,6 +3565,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) si->flags = 0; spin_unlock(&swap_lock); vfree(swap_map); + kvfree(zeromap); kvfree(cluster_info); if (inced_nr_rotate_swap) atomic_dec(&nr_rotate_swap);