From patchwork Mon Aug 26 12:40:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13777860 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9126C5472C for ; Mon, 26 Aug 2024 12:46:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC15B6B04AC; Mon, 26 Aug 2024 08:46:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A22746B04AF; Mon, 26 Aug 2024 08:46:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 801F96B04B0; Mon, 26 Aug 2024 08:46:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5B2096B04AC for ; Mon, 26 Aug 2024 08:46:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 15047121076 for ; Mon, 26 Aug 2024 12:46:22 +0000 (UTC) X-FDA: 82494369804.03.2413EF0 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf12.hostedemail.com (Postfix) with ESMTP id 880504000A for ; Mon, 26 Aug 2024 12:46:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724676293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gV6KFTQV31H/w8/zs6OOQYJCUldLshy5X43K7n5w55I=; b=45Z9JyRrEnWJ1n+umDaFct/yTmYNlfisYtbz1iHMZUKw9Z9yoaTJEzhhyosTpbZtKhByw/ OCra7D5fEFPPdj8YUPa4OWJOqaf1S15pHSIzxKJn1JVTX6mXpgO7IALSCdWMIeluLbVU2x SH1mc8OqpO5yqINayDr5mA/I/ShWPtE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724676293; a=rsa-sha256; cv=none; b=Dw62JeHcWsMqWH8/TRXiZV16HQsmilkObgVSsHJoDdE9yGT+h8kB4294oZU4aBa7gKGybC noeUtZ1FkvrLbSUroBwsFnmVVe7F+eS3HU+XupZkQFikPZgJv4cqkFmicx5dH77EnJxSqD LKkNvacrTfBPMzYvgTQKWHTGD3c2KBc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Wsr304ZsSzfZ36; Mon, 26 Aug 2024 20:44:12 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 976E81800A5; Mon, 26 Aug 2024 20:46:15 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 26 Aug 2024 20:46:15 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Alexander Duyck , Chuck Lever , "Michael S. Tsirkin" , Jason Wang , =?utf-8?q?Eugenio_P=C3=A9rez?= , Andrew Morton , Eric Dumazet , David Howells , Marc Dionne , Trond Myklebust , Anna Schumaker , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Shuah Khan , , , , , , Subject: [PATCH net-next v15 04/13] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Date: Mon, 26 Aug 2024 20:40:11 +0800 Message-ID: <20240826124021.2635705-5-linyunsheng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240826124021.2635705-1-linyunsheng@huawei.com> References: <20240826124021.2635705-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.30.45] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 880504000A X-Stat-Signature: yg9du3b5trmw4g4ea7j95mid7nnqb7bm X-HE-Tag: 1724676378-905500 X-HE-Meta: U2FsdGVkX1/Bni7beqrrOIIEM3Nhf1ycxiIZ9W5/nmrJGTt9qP6EkE9/JevC0gDdbP1Woq1k1KMElSSwt7PG3KvNpaSPb+B/XCeuhriVeMEbTA6twya8amGpi2P4opW/LQpEcivZdi44yNqrQ5SxWxK6cnI02FYj5p10EGjEp9vB+x7uhVkTMgq9jAg5GPzbI1J1c351zN19OrhXxtXwSucclHHlB03D9O4aF9Q1s7vOFYJZhu1u0BklnmEiWAZNfWoVZ2yCboxBK/6pE+phqhD4ILHNGLK/5G3/LYQ6rWmovlALuMA/dRGjA+bCIvt9SWYu44t5rIrQqdv1Ow7URZvckeE0npddj1K/zcTEwui3OMKnNg67DEiEsiYHvbJAG/DDCi03k4sx5fvaZqbciRu61bUVkLF18e+bdvr+rtadAdgWAYbG7rJPNjsNfMihmnxIE3U47Ujx9W+VxD+QPknw0k6VWJ5i9Uykn41uKYt9yr2Vs9j8HZLSP+dePuhS0i1XSVl8LKMaFxu8eea3pDg9a+TPirbDsnq5WSORd5orHQcgr2r51GPWASCAmyFjbtEl0ijgHLDtcu/sFTlv+J/hJxeUopptxThQeZT+3qK7go7pQZOlD7am1tmEZnR1hAKiUGYUa/HV3mLSaONmgIBiqGOp/CuzmZpqIs2TDKg36N1ZZWATFnKx0a/F/XLiIc4BX7B0aPNdOGsmuinlhmOje4+CQX+nqZlqhLLC3VB6FaKIHGVzHa1Ov6fPblTF31pVVmpg6PJ5ikcwFwayu02FFmvykKyvDndo+DdGwZ7U8ZoRkvrpl7A5DwKTu5NXEfKb1EASpkCLf6ldcKx2HPbDXf9r/wvqI1gLKQJh8j7vnvwMFkHLVxtioXvC/HfZ1VVt8AVQ5NCNxpH085tOQNZZzRjH3iX2FoTsmqHv8FZY11NnmI+Ap4bz6Tmq3WrBKV5smNsdqhyA6tdh6X4 uI8vAXav NBL9XknwxU24OS3UU0eebh8YEBC8JhO4k91ah/vfqPjv2ty4Z7RjGSEA9ekWFExCgDCJnU7TFUGSsOI6Ko78f9jnHSKwBd7ZBt6J//vu7k1RDLeW6ZYlYUKv8D0Bxw69dUaS5SW68FWFuAc9vbblYczzIi6eICAb7nxib8eeOVC3mYg1yPa8/QHptqNEG/CS6aCIheHkUcWpDH9r277CSYSwGI/dFXxab6Od1aOWTWRzjksS2C3Szrx/sgavbPDkSLDYe/6MR9m7sV2C1X7bi55M7g8Zu3L3yr3exy7oit0CdtfeQpUXkOlsS+OUuB836o0xrdarLWM1zhovcGDO9poimDdbEFp+db2Ztqo6I9itcczi70E685dV7jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use appropriate frag_page API instead of caller accessing 'page_frag_cache' directly. CC: Alexander Duyck Signed-off-by: Yunsheng Lin Reviewed-by: Alexander Duyck Acked-by: Chuck Lever --- drivers/vhost/net.c | 2 +- include/linux/page_frag_cache.h | 10 ++++++++++ net/core/skbuff.c | 6 +++--- net/rxrpc/conn_object.c | 4 +--- net/rxrpc/local_object.c | 4 +--- net/sunrpc/svcsock.c | 6 ++---- tools/testing/selftests/mm/page_frag/page_frag_test.c | 2 +- 7 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index f16279351db5..9ad37c012189 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -1325,7 +1325,7 @@ static int vhost_net_open(struct inode *inode, struct file *f) vqs[VHOST_NET_VQ_RX]); f->private_data = n; - n->pf_cache.va = NULL; + page_frag_cache_init(&n->pf_cache); return 0; } diff --git a/include/linux/page_frag_cache.h b/include/linux/page_frag_cache.h index 67ac8626ed9b..0a52f7a179c8 100644 --- a/include/linux/page_frag_cache.h +++ b/include/linux/page_frag_cache.h @@ -7,6 +7,16 @@ #include #include +static inline void page_frag_cache_init(struct page_frag_cache *nc) +{ + nc->va = NULL; +} + +static inline bool page_frag_cache_is_pfmemalloc(struct page_frag_cache *nc) +{ + return !!nc->pfmemalloc; +} + void page_frag_cache_drain(struct page_frag_cache *nc); void __page_frag_cache_drain(struct page *page, unsigned int count); void *__page_frag_alloc_align(struct page_frag_cache *nc, unsigned int fragsz, diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 1748673e1fe0..9352fcf8cda3 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -752,14 +752,14 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int len, if (in_hardirq() || irqs_disabled()) { nc = this_cpu_ptr(&netdev_alloc_cache); data = page_frag_alloc(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); } else { local_bh_disable(); local_lock_nested_bh(&napi_alloc_cache.bh_lock); nc = this_cpu_ptr(&napi_alloc_cache.page); data = page_frag_alloc(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); local_unlock_nested_bh(&napi_alloc_cache.bh_lock); local_bh_enable(); @@ -849,7 +849,7 @@ struct sk_buff *napi_alloc_skb(struct napi_struct *napi, unsigned int len) len = SKB_HEAD_ALIGN(len); data = page_frag_alloc(&nc->page, len, gfp_mask); - pfmemalloc = nc->page.pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(&nc->page); } local_unlock_nested_bh(&napi_alloc_cache.bh_lock); diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c index 1539d315afe7..694c4df7a1a3 100644 --- a/net/rxrpc/conn_object.c +++ b/net/rxrpc/conn_object.c @@ -337,9 +337,7 @@ static void rxrpc_clean_up_connection(struct work_struct *work) */ rxrpc_purge_queue(&conn->rx_queue); - if (conn->tx_data_alloc.va) - __page_frag_cache_drain(virt_to_page(conn->tx_data_alloc.va), - conn->tx_data_alloc.pagecnt_bias); + page_frag_cache_drain(&conn->tx_data_alloc); call_rcu(&conn->rcu, rxrpc_rcu_free_connection); } diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 504453c688d7..a8cffe47cf01 100644 --- a/net/rxrpc/local_object.c +++ b/net/rxrpc/local_object.c @@ -452,9 +452,7 @@ void rxrpc_destroy_local(struct rxrpc_local *local) #endif rxrpc_purge_queue(&local->rx_queue); rxrpc_purge_client_connections(local); - if (local->tx_alloc.va) - __page_frag_cache_drain(virt_to_page(local->tx_alloc.va), - local->tx_alloc.pagecnt_bias); + page_frag_cache_drain(&local->tx_alloc); } /* diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 6b3f01beb294..dcfd84cf0694 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -1609,7 +1609,6 @@ static void svc_tcp_sock_detach(struct svc_xprt *xprt) static void svc_sock_free(struct svc_xprt *xprt) { struct svc_sock *svsk = container_of(xprt, struct svc_sock, sk_xprt); - struct page_frag_cache *pfc = &svsk->sk_frag_cache; struct socket *sock = svsk->sk_sock; trace_svcsock_free(svsk, sock); @@ -1619,8 +1618,7 @@ static void svc_sock_free(struct svc_xprt *xprt) sockfd_put(sock); else sock_release(sock); - if (pfc->va) - __page_frag_cache_drain(virt_to_head_page(pfc->va), - pfc->pagecnt_bias); + + page_frag_cache_drain(&svsk->sk_frag_cache); kfree(svsk); } diff --git a/tools/testing/selftests/mm/page_frag/page_frag_test.c b/tools/testing/selftests/mm/page_frag/page_frag_test.c index 4a009122991e..c52598eaf7e7 100644 --- a/tools/testing/selftests/mm/page_frag/page_frag_test.c +++ b/tools/testing/selftests/mm/page_frag/page_frag_test.c @@ -117,7 +117,7 @@ static int __init page_frag_test_init(void) u64 duration; int ret; - test_frag.va = NULL; + page_frag_cache_init(&test_frag); atomic_set(&nthreads, 2); init_completion(&wait);