From patchwork Wed Aug 28 03:03:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13780368 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB6AC5474A for ; Wed, 28 Aug 2024 03:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 944926B009D; Tue, 27 Aug 2024 23:04:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4576B009E; Tue, 27 Aug 2024 23:04:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 794BE6B009F; Tue, 27 Aug 2024 23:04:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 53EBB6B009D for ; Tue, 27 Aug 2024 23:04:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A2B4AB37B for ; Wed, 28 Aug 2024 03:04:46 +0000 (UTC) X-FDA: 82500161772.16.BC1C240 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 34F8D18001B for ; Wed, 28 Aug 2024 03:04:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kW3C+vfk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724814186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8OBLeQ9F541pwxbn8dEubiWANdxJtGv9ekHxWl5Hwac=; b=d/J9jJwA+/tYGo8Fno8EHbsTojLKhTeYmhlT3vjCc1vh1g4mpoVgSEJrchrGZfHKBTrhBY y+xZaBjiE3WSKNfghtTutvQEfTdZ6ExfE1TAW6QqDajNcH0MGErAtBGabH4YMWPzzMQq5v bRLE9ja9c7A5u3Bn0GRBUx/RzakZzOE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724814186; a=rsa-sha256; cv=none; b=TY0jS3WpZu/UWmXt1FC2nVAk65oMj93hECbBqd+hIEs1a1y3VNYSR6hpBPH0Qhj2sXn2Da /X07umywbRmhKqtk11eC0NykTN18t6RkJPELf3XEKCP0COrVl93uTpwDfUhbAy6dfHfbFv T+52h3bmbSlH8jdqtMnQqEiwVbsnWwk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kW3C+vfk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2d3c05ec278so4580392a91.0 for ; Tue, 27 Aug 2024 20:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724814283; x=1725419083; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8OBLeQ9F541pwxbn8dEubiWANdxJtGv9ekHxWl5Hwac=; b=kW3C+vfk+e+vDXeWiqL40KaNZfpjfEpgBWeYnx6ofSSqcuqhh/FK29DT1K4wKMFO6U nSTiJfCr7c9x1K/VB+dOp/BefJfz1SlPcFWZb+I7EcCBvxrMIbwhZaI/uHcK7ioL9uIm eHR+rxam7wo8/ao4XdDyt/kNIwtp+TMrr6WoNyjV/R4ApV6bjYelQSTCkTkHyKboNvlr CBQ/eB3FFjS2m+tZWpdmAA4AQVITIkkwTQV7W1l44Ejpw56TB0fS7NdOWbn6MyCPQV7b EsRzCranrgTTHbbhF5b9Kx+NRCevE3anKRtgbeu3bWvpSZzzwCu9ShgNLkxNxMgkMi14 7uZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724814283; x=1725419083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8OBLeQ9F541pwxbn8dEubiWANdxJtGv9ekHxWl5Hwac=; b=N1woHjOeVj4keqaugdxpXUnFD/Qjo10DSKZGg7IxDUjAroCLMb1kzerz1iDT/YE5VL n7xV8modctrW70G7cOsJiYBSZ9yvAQKEK8hTglB3ks6E+kUN+WJofo+BxL/sZRB8rYiV UjNJy43Wiszw168YmUomtmwWqXWAG7IF5kXSbfsTOQNSLyMH6si0WWf1nk4xvKQ4KGld bq8le9trflESMoi9o2/U6CfI3vYl1eOLKoVz0bkHWrZUygmubWPqvOTq5ZNK63BddmMT cjsUnXz+HGl5hct3YpwTmmNXtn+FtjezATkUApUsIMGzeCpzwJ2CjSNzdGKdRnrEhck7 R2zw== X-Forwarded-Encrypted: i=1; AJvYcCUd8n348DazZB17nKQolPbQEiUzMBYsgxEqRT3qFt6ZxiqglyzntPfzfZvl5Oz5wdgdj3KP1TQ6AA==@kvack.org X-Gm-Message-State: AOJu0YxsMtg1A5y8YpBHOpbmB25mk2WbotvPYWfrt9Bgg85LQUb1Znho uRu5YcZwrzx7EwEp8S6/Jg6dLCAAeFh7UjBghloBLCweq2FtxZ+Ows5amfwG X-Google-Smtp-Source: AGHT+IG9WCG/sJqfIUmD5L1QkWASIgz28eaxuJrS0TfQtB7xTFo8bkGI6Rj777tc/95CgBuyWlEpcw== X-Received: by 2002:a17:90b:390e:b0:2c8:e888:26a2 with SMTP id 98e67ed59e1d1-2d646bcd147mr17296354a91.13.1724814282792; Tue, 27 Aug 2024 20:04:42 -0700 (PDT) Received: from localhost.localdomain ([39.144.104.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445db8f6sm317977a91.1.2024.08.27.20.04.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2024 20:04:42 -0700 (PDT) From: Yafang Shao To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, alx@kernel.org, justinstitt@google.com, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: [PATCH v8 8/8] drm: Replace strcpy() with strscpy() Date: Wed, 28 Aug 2024 11:03:21 +0800 Message-Id: <20240828030321.20688-9-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240828030321.20688-1-laoar.shao@gmail.com> References: <20240828030321.20688-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34F8D18001B X-Stat-Signature: ttg7dox9umqibfy3fzjsaibxx9gseeex X-Rspam-User: X-HE-Tag: 1724814283-197491 X-HE-Meta: U2FsdGVkX19C0FkFinjA5I2kqc9+z/tVqfhgWY2pGACUtIPJAhMPxLfuGda0vHGR5C3FTEjeu2VLOobYES2UIkFr2Hd8eyaK2ViEsXTWWVfzRh46jz/e/uKOPijjE+GOds/8NcJuPbVaZKmSdu9Yb9Zjb83kjfLY6vVuD1ktlDi5Ernc4t+kczxIRFrz27YMe9r4uVi28VoZLZX2h4JHwYMmo3u2b7M5llvvm6Zzy2tOUMqFqAEplh50j6UGw65z8TQBjnlWHp8jjapigURWn24h2SykCV5HyWucWxejXwJOFR9J9ejAWDFHaxgV3GQQYRKWoDO2/F+SCKSI+gAEOwlvxO2ea41LjxcVOjmGwj8vB1UviKostWtLCPCNrE7mGj4AhxGNRQCRoLeUB6jFedXq4jGke4aio0NmD3Q3at+UHZN5bDxwlkz2GGwb9/TP1/5gR9iXTXDRg1x+RfVSOEZo4hoQqjSoQGCabdmDzppctZtxxNk2lqXlWzbNAmIBtGqxG1oUC8NNB5UqdSk/wOdL9FVf5qIUD/zturSEhD7GeUiudAY0eYzdDDMKz/ELbOaen1WqotHn0V5wmln4CNUoG/IOCb4rg69lKbifCul+mNWfEMX8FLQSj6R4ZUjl5Wf7uHOIo9EvxQwHBdJHEFw/AlywheEuD4eAuJSDzq6AG+PR5v2T1He+uNT8uOprBDTq47O6N5li3nMp8AGuLkLf5oua6KBcDinAF4yNLMUl4Uqf5a6Bru0b7y6XlaLZV6yq6vpqgaDOR7xLy9xsOzELXKSyE8fjRILqjaRXaqB0eSkqLxu3Z7kqe2Z6qVuIc2HyT0t7nt8JFcz6LiTsXUJR0Zgkr9jQImTD7hlPRO1yd27sy/toglOVAvyeQhsxMHN+1+wWrD8SjICtCT5iI6eK1hez/rl/LRMCcrdWmedcDp5hO2d+BTHaTT85Mo3vrbDEFtUeBYSP6bnj2w/ SrhTZ7r3 BbihjbIj6bRgCcdSsO2kQQQzum2qjSqtTvYa8HRXI9fLN24VeAe7fyBRRzuDq9qBi0inuzYWkPsAQEgHizDH+ggeeCplzcGvbh1KWDWsksQxPY3IDuihd6ER3ARo8s4GG8a6MbO1M/wrNuntj64MK4mSYPcymhtt8sNEQOF1RoQFcy75qXArTmjAk9zJuJznc6NtcmCLO/uA0cY/GwqupdlQ4/Plv866zq1NC9go2hvQqseD0w/bRjbgLtq2HYj41n2Xs8o81IB+SCBIzaiG8zRSz8p5tUl0VFgssfiqWq8vXL7eAJDKhagoEWLooXnBM5dr+gtF+S4l/2yhZx+tcKUzxOrsdTWA7hsp6LTXTVwLb/KozDZtvlLa3rumEgKHBPqkQcTOPdJKN9X66haIj3GLr7whFnNdw2M2b3mY6yifGSkjws3rMfNILfI1QNDx0QAb6LpC/bu9N9gxFdUcprDigAF23GI+kIvK1UQhlWhQKzeumQfKwX8jeRy5KWmBJjA05WeqkErT9dAl32/0lPQ9s1ZcvEZWH4ap15zN1aWYrBN6L96l2eSpbmxCxSzjcDc0I1yMiA0BhCXwYfbRatmWPPxmifs1EB6M4BCJZ6uotiwQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To prevent erros from occurring when the src string is longer than the dst string in strcpy(), we should use strscpy() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Acked-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Reviewed-by: Justin Stitt --- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 888aadb6a4ac..2d6993539474 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, INIT_LIST_HEAD(&fb->filp_head); fb->funcs = funcs; - strcpy(fb->comm, current->comm); + strscpy(fb->comm, current->comm); ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, false, drm_framebuffer_free); diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 96c6cafd5b9e..afa9dae39378 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -1412,7 +1412,7 @@ static bool record_context(struct i915_gem_context_coredump *e, rcu_read_lock(); task = pid_task(ctx->pid, PIDTYPE_PID); if (task) { - strcpy(e->comm, task->comm); + strscpy(e->comm, task->comm); e->pid = task->pid; } rcu_read_unlock();