From patchwork Mon Sep 2 03:00:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 13786677 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A6ECA101E for ; Mon, 2 Sep 2024 03:01:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B7CC8D0069; Sun, 1 Sep 2024 23:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 568E68D0065; Sun, 1 Sep 2024 23:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31DEE8D0069; Sun, 1 Sep 2024 23:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 14C4F8D0065 for ; Sun, 1 Sep 2024 23:01:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A3670A1908 for ; Mon, 2 Sep 2024 03:01:00 +0000 (UTC) X-FDA: 82518296280.09.333748C Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf03.hostedemail.com (Postfix) with ESMTP id DDB3D20009 for ; Mon, 2 Sep 2024 03:00:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X4n70cfF; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725246012; a=rsa-sha256; cv=none; b=VYRoLk7vVM4A8RJfKQtcS8rIX2CVY+ce8RHHqbgrLGd1uK2EI8agImaaUjA5iZMSkTac7f 5ArP6zflKmCZeMD4TNCPKxw4afOoZil8mcUwKjTab8cUMLPp3uHUqdi6RemRpLH1Ttx1Om oELpL81kjKMQs+yYqi4JyF9YK9LQpoo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X4n70cfF; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725246012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T07Izsq7HNgi0OoshzXXCt7DRFHrDmyIOgvlsgOO0Bo=; b=pw1YIvU1lgRIPftdOTtFNnHHqZi6tIKsf4LDl9lqbf8j8D3TdzRfViblCZKWuHZICan/0v 8BE7s16xUj1uE1EAZuUp3K3YWdW9yNqVC+1HdplCIy/oNrxKy7ql64ydauEEg3XiyX4iRr vKEhKZvALmXbMoizRFBc8GlfaRLzonE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1725246050; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=T07Izsq7HNgi0OoshzXXCt7DRFHrDmyIOgvlsgOO0Bo=; b=X4n70cfFPjEWgwx72wbY+12f0yRAh4ZNg8e4e7LLQyzDhSTfodG9K0zT90zSy6HS9BQ1P9tc14/qVclOkfiPwpV+0Gz3UM0qQbRkKslmldbAdKLUFliY1ap7Gw8zJRan7l6EkfzXxhr+S6iBgdKD/OXdDNivLiFgvZ1PgQ+FzbY= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WE1odp4_1725246047) by smtp.aliyun-inc.com; Mon, 02 Sep 2024 11:00:48 +0800 From: Shuai Xue To: bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, xueshuai@linux.alibaba.com, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: [PATCH v12 2/3] mm: memory-failure: move return value documentation to function declaration Date: Mon, 2 Sep 2024 11:00:33 +0800 Message-ID: <20240902030034.67152-3-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20221027042445.60108-1-xueshuai@linux.alibaba.com> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Stat-Signature: eqg3e7tjxhtdhr6kw68bdkgxkayqryhm X-Rspamd-Queue-Id: DDB3D20009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725246057-696524 X-HE-Meta: U2FsdGVkX19Hq3Prrm8GNOskqRCwtCA0WCIxyPCNN9nReNGf359rIiffzRvOrfzbAckBhDa43X2lhlxE8mOLaHO9nhsguGrSB83SZQ1rYYEakIDngm7cWigCBB36dydnDBWmjMdJnj0z6Vv3e6XNeC3YhSsLXwK6go9g1zrNNSONppNT12b6ZmIxX8aQJJuFDIfVgrCi0JOpoonm/ALufdwI6gF+zpqARprXOpwTPZ49Ffkte7gagdPpHWgrQU/FqeuPwN9OZTYw0wYaxWmvyENMd86qNhHiV+rEOn8/jJygpViV4msnC+8I3FBIUDrkzC63alabVDxBaNKzwxiObKMbYatGgBpfsGIVv5tA9QP9gMr9fJi+aFnKuRODk2j3lG1SZP15mEryGKjv+vfDrz7djV7q27khZvTlAjWufXvoZu1PF5XKIXC6ubkMh6NXniln1q+nszkcJi5aVSyAHTtmdFALPmyAtr/Ht8/EYHl7IwhrMeYmX+g/b+WrMbzKwOmCuqgCr4EvBfq2NcHgw8He2YbVqxsVpxQ6qvL5d0SixH3SyzZnI82Y+yKIm2RpmLSWdD/Nk91+Pu0gzMoeQUiGCjUtv1Rp0F5+FPZ0byKVWadgTQ0WjuaN7nlNBq+HW2ukDjwN18mt1xcMHEoi3hGiTeyB+9FFCPIvR0CnWEqOhipbqiLe2cUT/7vGD3QU6eRcJ16riIGNjUWBKJFBL6c0SVq0ZVZSVmwMBKY0nhbTHhbsNtoycpPZV8Bcw29x2qB1zvl0nzDexELAsZW6A2cHAjPGREtmVYi0M+VpFn3Hmo3CjWcsyDql3mDfQiInfa//S4RLtl2aYUKNk9AHZ+7VgTqAvjdJPv0ZCDpOgwQqtfWU46PFxH9+iczi3m+g5wBU10+3KM94cBHq7I9HC0HfhrrLzDYCK/WYrW7aJ8Ot/HzQXOQQrDC04Doj2ht7NtomSoj9k7Cwyz7iLkh 518c5ac0 vOEUyThn47guXGvQufLenku7S1lE1LMew9Z1YKfLkeB2I9Uu15qRTL8bKCXF7gcG04rxAJJg1U0tGruRvJl5TAndwknMmWaDidQ7K6YG1tPwBAq7Hr7WmRgngo13j0h9Z3FvA+chRGh9bKlgaTiit2sLuzynyqxsdOm0l6zgDPocUAhGH8M33mkqmkpTgTe6xKUo4HGevTWFlxmTx7rbD+5IpsPcwljT2UAZj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Part of return value comments for memory_failure() were originally documented at the call site. Move those comments to the function declaration to improve code readability and to provide developers with immediate access to function usage and return information. Signed-off-by: Shuai Xue --- arch/x86/kernel/cpu/mce/core.c | 7 ------- mm/memory-failure.c | 9 ++++++--- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index b85ec7a4ec9e..66693b6dd1cd 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1361,13 +1361,6 @@ static void kill_me_maybe(struct callback_head *cb) return; } - /* - * -EHWPOISON from memory_failure() means that it already sent SIGBUS - * to the current process with the proper error info, - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, - * - * In both cases, no further processing is required. - */ if (ret == -EHWPOISON || ret == -EOPNOTSUPP) return; diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 7066fc84f351..df26e2ff5e06 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2199,9 +2199,12 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, * Must run in process context (e.g. a work queue) with interrupts * enabled and no spinlocks held. * - * Return: 0 for successfully handled the memory error, - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, - * < 0(except -EOPNOTSUPP) on failure. + * Return values: + * 0 - success, + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, + * -EHWPOISON - the page was already poisoned, potentially + * kill process, + * other negative values - failure. */ int memory_failure(unsigned long pfn, int flags) {