| Message ID | 20240903034300.10443-1-bajing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | damon: access_memory_even: remove unused variables | expand |
Hi Ba, On Tue, 3 Sep 2024 11:43:00 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote: > These variables are never referenced in the code, just remove it. Nice finding, thank you! I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject prefix. > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> Other than the above trivial nitpick, Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > tools/testing/selftests/damon/access_memory_even.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c > index 3be121487432..a9f4e9aaf3a9 100644 > --- a/tools/testing/selftests/damon/access_memory_even.c > +++ b/tools/testing/selftests/damon/access_memory_even.c > @@ -14,10 +14,8 @@ > int main(int argc, char *argv[]) > { > char **regions; > - clock_t start_clock; > int nr_regions; > int sz_region; > - int access_time_ms; > int i; > > if (argc != 3) { > -- > 2.33.0
On 9/2/24 21:43, Ba Jing wrote: > These variables are never referenced in the code, just remove it. remove them? Add details on how you found this problem in the commit log. Send v2 with these changes. > > Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> > --- > tools/testing/selftests/damon/access_memory_even.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c > index 3be121487432..a9f4e9aaf3a9 100644 > --- a/tools/testing/selftests/damon/access_memory_even.c > +++ b/tools/testing/selftests/damon/access_memory_even.c > @@ -14,10 +14,8 @@ > int main(int argc, char *argv[]) > { > char **regions; > - clock_t start_clock; > int nr_regions; > int sz_region; > - int access_time_ms; > int i; > > if (argc != 3) { With these changes: Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c index 3be121487432..a9f4e9aaf3a9 100644 --- a/tools/testing/selftests/damon/access_memory_even.c +++ b/tools/testing/selftests/damon/access_memory_even.c @@ -14,10 +14,8 @@ int main(int argc, char *argv[]) { char **regions; - clock_t start_clock; int nr_regions; int sz_region; - int access_time_ms; int i; if (argc != 3) {
These variables are never referenced in the code, just remove it. Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com> --- tools/testing/selftests/damon/access_memory_even.c | 2 -- 1 file changed, 2 deletions(-)