From patchwork Wed Sep 4 10:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Brauner X-Patchwork-Id: 13790367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB3FCA0ED3 for ; Wed, 4 Sep 2024 10:22:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA9F8D024C; Wed, 4 Sep 2024 06:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1B668D0242; Wed, 4 Sep 2024 06:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABC8F8D024C; Wed, 4 Sep 2024 06:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C5408D0242 for ; Wed, 4 Sep 2024 06:22:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 494E9C0D6B for ; Wed, 4 Sep 2024 10:22:49 +0000 (UTC) X-FDA: 82526667258.10.6EF9AC0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 6BA8A40006 for ; Wed, 4 Sep 2024 10:22:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JRb8YchA; spf=pass (imf04.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725445272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iRXJ74JGXxhhieUoVKXM8YRkSn2Eta4kedrFgxgg5Y4=; b=IsIVDHqozageGHJKvt8SbQR8gDq62m/9MWjIIkGksWlGhwE79Ohjre0KXuK26Na0TetcEy inwmQ7LszsfwJHY4TtAw8V6lJ61FB5ZbRYITIHGCwAPn7/XR8bp9eI70AmWLaDWZ1Y90lC FSE7XKOzeT5SXN01oIj5C56kzvozxFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725445272; a=rsa-sha256; cv=none; b=a9rhr/Ib2LOgn0LdHdCTb3mweWiceXi9czHZ8+ChoL7Lc853SUE4fOrEf1Gv5E7NYZgt1X yXaeMOAXzAioL4C86ZuGANlXuvsUxLQCXkPDyo3OwnLwXRujhNxlSvHWpE7+KknxOvnTvt v66SDvwkaiAN3bq/ddWrBv0H72ty4G8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JRb8YchA; spf=pass (imf04.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2FC255C5720; Wed, 4 Sep 2024 10:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD028C4CEC2; Wed, 4 Sep 2024 10:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725445366; bh=ob7tfSkKKaOFfsUNw54A8NnR55QWcUPRYRE0hGJ3b7c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JRb8YchA1ASqQ3gjaPNCb2ql7VsuECo83v0Lq+OcjYRob92h21b4kbDsuHmjJqRZW qoSlLkVDQOxp2eAaBmMBDJ19GHaa/AAaD1r4SxRhIz4RQm1a1ONGWK/lFYPQDNafQ3 j7LA0AAPa4Zan7gvOn0W+nVU8RSDISc4ZRmuAKoXHPNA2jDH+On/sNA6mDW1anw+KL 4W54tzz2lLjzH42yg2+1h2f2SD6WBOQRajfBNgC5Mb/51bSWfOYXipxW/tHfzOaDjG E3iiNtpx601BMCVUfuwfr5VoFgpooZwUU1wPcE8rttxqQ/My7vpCohzgD/t9OKIBvt SL8JA2SyIL6Wg== From: Christian Brauner Date: Wed, 04 Sep 2024 12:21:19 +0200 Subject: [PATCH v3 14/17] slab: remove kmem_cache_create_rcu() MIME-Version: 1.0 Message-Id: <20240904-work-kmem_cache_args-v3-14-05db2179a8c2@kernel.org> References: <20240904-work-kmem_cache_args-v3-0-05db2179a8c2@kernel.org> In-Reply-To: <20240904-work-kmem_cache_args-v3-0-05db2179a8c2@kernel.org> To: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , Mike Rapoport Cc: Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christian Brauner X-Mailer: b4 0.15-dev-37811 X-Developer-Signature: v=1; a=openpgp-sha256; l=3146; i=brauner@kernel.org; h=from:subject:message-id; bh=ob7tfSkKKaOFfsUNw54A8NnR55QWcUPRYRE0hGJ3b7c=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTdMNl9h8VC/ZrFR6Mzc6ZER+rs5dr4x2dKw/Pwh95OW tcSTRtkOkpZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACYSf57hn45wDQOP2darxaJt NXwPNXi71KIeTUt7Nksl5J+fyc9l5xj+u3W69D4PXbsz+/GX+XE+Zgv5VPV9b/zcezK0m+nk2g/ 8TAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 X-Rspamd-Queue-Id: 6BA8A40006 X-Stat-Signature: 1d8aj38sgxkwgum8gbfdwbomf7dfmpeg X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725445367-892578 X-HE-Meta: U2FsdGVkX181Utwti0Uq/XMB3y2DUCSUJevNDHOINgu0WfnDX8gDPVxuppTZhjId6odmOnoKHXKfUNJxrToxh8yEAzPbtmeH3BjOTG8FmYrjwi8oI+JdTv+M9IgRHAlPTKdDS43cUBH7Zi5pkkW1HIqo2DaOd16gX8xfSshq/axctu5zJ74Pfted1BF7pG4xfP618o6Az+6IfhpXWktx90UWNa3PadwAhRw4Yyh9N96k3E0DCu7x3+hqG7muTjTPGU+DcdLpXIu1E2AVl8bD5J/sC7seDyKB0zeJRfg7SDpSSSRL0p3Uhheg0J+YDK3H5Oei36WP8Lbq2pFk9ZCstxaPMaVCBwv5kZKaqrggAxtnoxjTOs/itVv+nXxZciNGDoYzxuUJpoK4N++VwTShf5HEP1yxpj8zBWHiKooOn3E0IB9uFiLrIP4Qu/yX/FVqCbmuvx388MsLxgxoAAnp+Rxqzi0D1c7X0uY+QYL2UPmvgsIGh5sNEeHcQ9JJxhgJxUxHNXUwViXL1zLbuW1t3lcpCLlGL9YW7Vnn3pn/ajB6tvINXUJwSryCju7vIil1SpTtTHD0dDFdxFm84SxpBGHuasxUCUngajIlEMadcIsphaMcrZ4l3yMVMbj++k/kcYR4MG4bsKmGgDGodJso8j//recEsbdncP3QA8KzAnUeMXWDpYaCg7qGH26G9F1ye4uKtXlKA3YZt6cvfTJ9YzeYJEyyzBFZ8hgGA6bSO21r7bIKsHXimZwVIQvzVXsGL5wxnu2VS/byG0ZE1/OrjYxQEwjrlbe+WbzXQAFvD4K6xHLYCZNmbikNY9ja+CXk43pFb+3sUMVD/MooSZp1lwEjHTCxXDMs9slE6MBpzoK7lrRMOsjIOAqpGjBgl5TCT14QuTuQjpKDRT5a/mzGGPLCHpphZq0jBYsY7fAEkB/A7pYVXK3spN1eETIw+8VAIrgrr1vHPdyI1BnE9LH awLQB0GS 55394BESGLzg64Ye0s35ePKcyguZ1dUoMVTRNb3spAZLyg/3GTfZUsvt7Zj4m97EtXaEU/0pNMYsY+Mdlma7AyysBfBIi+dYMkkevI54m+foVlPUu6RXSV602D9hPtohuHh4YiSbnhQVdNncHoDR6Skh6+xW0c8ltnUgxQVnJBrA4iiuGisojOf2lhYLojNpnPBEOV70SlScTa4QByXVZ4DY+ugiUHJesP9vfqqAaBIw/K1usk7hGMW40UCFzebnuyM00/TIyJt6rl622iQX3AWLIhg2UchiLoPzSbNBoJVXAUTvHEqZHQJO8/t9S8NUyd58Whg1cyeipJRqUtolK2X0c36S4RsHHsZxx1s8GWQ9+0ZY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that we have ported all users of kmem_cache_create_rcu() to struct kmem_cache_args the function is unused and can be removed. Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Vlastimil Babka Signed-off-by: Christian Brauner --- include/linux/slab.h | 3 --- mm/slab_common.c | 43 ------------------------------------------- 2 files changed, 46 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index 4292d67094c3..1176b30cd4b2 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -270,9 +270,6 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name, slab_flags_t flags, unsigned int useroffset, unsigned int usersize, void (*ctor)(void *)); -struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, - unsigned int freeptr_offset, - slab_flags_t flags); #define kmem_cache_create(__name, __object_size, __args, ...) \ _Generic((__args), \ diff --git a/mm/slab_common.c b/mm/slab_common.c index 418459927670..9133b9fafcb1 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -420,49 +420,6 @@ struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, } EXPORT_SYMBOL(__kmem_cache_create); -/** - * kmem_cache_create_rcu - Create a SLAB_TYPESAFE_BY_RCU cache. - * @name: A string which is used in /proc/slabinfo to identify this cache. - * @size: The size of objects to be created in this cache. - * @freeptr_offset: The offset into the memory to the free pointer - * @flags: SLAB flags - * - * Cannot be called within an interrupt, but can be interrupted. - * - * See kmem_cache_create() for an explanation of possible @flags. - * - * By default SLAB_TYPESAFE_BY_RCU caches place the free pointer outside - * of the object. This might cause the object to grow in size. Callers - * that have a reason to avoid this can specify a custom free pointer - * offset in their struct where the free pointer will be placed. - * - * Note that placing the free pointer inside the object requires the - * caller to ensure that no fields are invalidated that are required to - * guard against object recycling (See SLAB_TYPESAFE_BY_RCU for - * details.). - * - * Using zero as a value for @freeptr_offset is valid. To request no - * offset UINT_MAX must be specified. - * - * Note that @ctor isn't supported with custom free pointers as a @ctor - * requires an external free pointer. - * - * Return: a pointer to the cache on success, NULL on failure. - */ -struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, - unsigned int freeptr_offset, - slab_flags_t flags) -{ - struct kmem_cache_args kmem_args = { - .freeptr_offset = freeptr_offset, - .use_freeptr_offset = true, - }; - - return __kmem_cache_create_args(name, size, &kmem_args, - flags | SLAB_TYPESAFE_BY_RCU); -} -EXPORT_SYMBOL(kmem_cache_create_rcu); - static struct kmem_cache *kmem_buckets_cache __ro_after_init; /**