From patchwork Wed Sep 4 10:09:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dev Jain X-Patchwork-Id: 13790324 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC19CD3431 for ; Wed, 4 Sep 2024 10:10:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 449286B02D2; Wed, 4 Sep 2024 06:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9966B02D3; Wed, 4 Sep 2024 06:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299996B02D4; Wed, 4 Sep 2024 06:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 045316B02D2 for ; Wed, 4 Sep 2024 06:10:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A7308A9E3E for ; Wed, 4 Sep 2024 10:10:03 +0000 (UTC) X-FDA: 82526635086.05.ADA621D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 041AA180016 for ; Wed, 4 Sep 2024 10:10:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725444524; a=rsa-sha256; cv=none; b=4khZrQmmCsty2EmBXw2ScXsyOG1ELj0iGDqqK+1StlXgNGq578xLMGyLxjYBfKR0wUmkq2 tJ8KivAQZLjtwlLI/z1W5Mfc9GjJmfoALKPaCRgXyR1xoemNkyEJUW9+kwjhsp7hD3Jy8O Q11+TM9s4To/fUQ/9O/KBkCNDW5omls= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725444524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IRVGZ9CRsut9l2cuB1HVMnUS+ev+twQi6bilqmv4LIY=; b=2VfTyFfIz760X2flUK5Z5THX3ssFD9PKYsYXN1nC9aSxvWAItq+wsH+zrxxPM/HGGvwDt/ CzyChsdXbQCztXxaZtKTXK/vATDNeW/4py2TlMDAoZGYVo4LQpOXu9ygfwcbt7Yu0HyB43 1ysEcEel0Dxx7wpez2/kWgp+zp7Oiko= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7DEC1FEC; Wed, 4 Sep 2024 03:10:27 -0700 (PDT) Received: from e116581.blr.arm.com (e116581.arm.com [10.162.43.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9251E3F66E; Wed, 4 Sep 2024 03:09:52 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dev Jain Subject: [PATCH v2 2/2] mm: Allocate THP on hugezeropage wp-fault Date: Wed, 4 Sep 2024 15:39:23 +0530 Message-Id: <20240904100923.290042-3-dev.jain@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240904100923.290042-1-dev.jain@arm.com> References: <20240904100923.290042-1-dev.jain@arm.com> MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 041AA180016 X-Stat-Signature: mzxxcmo3r5mcutcortwcurhq3hhruwao X-Rspam-User: X-HE-Tag: 1725444601-569112 X-HE-Meta: U2FsdGVkX19u+GltvFvxlKKmigHp+QHIYBJ+YNOeq0O3sq1RL2m+NAanKdHSJdYUJuVb8WiutqJLTP2ytPYUGaBWDkyu3rLTwavm92ZZaQ3cWNatVvht4A9vrrMQPoeNnnQbMExLVye6JBxX0ihK6bvFmVRP4gF19YOrxHyyR07OvtQeP3Xv4P8VGlnmWwHm/qTdbAdu6xg4QA7RBIn7ml8Z35r/p7LHlxTvzkK9/wHNPBkO93Dl+Smvxi12Yz3Ic6QzxwFgR60SOk8iLyFJVw1yZUOZjqgbQLPdfw2pZ95J5de9YLoPbNeaYJYGMplDHiR34ii6nHLghN0kpaXSlJbU/bFPbH45xoBqmRg2qxiFGjYXxqPukRnZxb+Sghn4H/FmA17DYfmImlBNcdO/aYsOn+C5XQvAhkrDuNC/o2s8eTzwryZS5qXz3lOo8ugBaLudxRSoWvo8Hqx80Qo8YPhX+TiFig1RWvghXiQZewdtbDdKnWBb94oh7FQIYrUAeNMpaUZJo9SihptmdZBJxKG6Vt2OMDWXgY2xZxrJ1TaWqxeuYTFfT2tYAPJqiGHA0MDevjq78teZDtLo02TnXL6JtKCd+ofgz8UOuhc1XDAjodUSKX4EDYhQo+E+RkedN+6coXJ+KaiPyD4pYCyNua/DdZKGdgUE3Aua9/JIcaRXnw1U7yvyU+pCGo2y8loDkeo4C+eazaTstJkBQXBLSmFjBKLaPcyoqbYNTK/4tVoJv+wynAkMWzC/DXCz7B8EcysTlWmSkbZjkaXM7JH+Kd96jFcQJgTa5xYkzTh97ryorwqsan7jvy3j5u1Ua1GHSaniGGeBd57bmStStz1iPfgmKWhaPQWwGpA4EVegG5gF0HKNlMz2wLQ+f9CKxlT2l562H+tYrZ7NrNfFoUgPsQ1N4xqDCar2lrTYbPEZCgO738qX1ULqlAxTG3Yfhr0P7sBvm02cCnCPEwN/BdD 2OLiGt5I 3GJ2u2pSfGKUxAMrYTqbyQY7RGZLwDJtEs+mAqI+RX+ZErt0Pp2v/0NsuhSexhlgRIYaW6MGMA6aGYGWLcKPUtnXy5ppr3DVC1bjuK6PcOkm4eO+d1cZd23BSrFs8kZvllwe4eE3xJuUtRaNTcECIo4uvSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Introduce do_huge_zero_wp_pmd() to handle wp-fault on a hugezeropage and replace it with a PMD-mapped THP. Change the helpers introduced in the previous patch to flush TLB entry corresponding to the hugezeropage, and preserve PMD uffd-wp marker. In case of failure, fallback to splitting the PMD. Signed-off-by: Dev Jain --- include/linux/huge_mm.h | 6 ++++ mm/huge_memory.c | 79 +++++++++++++++++++++++++++++++++++------ mm/memory.c | 5 +-- 3 files changed, 78 insertions(+), 12 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index e25d9ebfdf89..fdd2cf473a3c 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -9,6 +9,12 @@ #include vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf); +vm_fault_t thp_fault_alloc(gfp_t gfp, int order, struct vm_area_struct *vma, + unsigned long haddr, struct folio **foliop, + unsigned long addr); +void map_pmd_thp(struct folio *folio, struct vm_fault *vmf, + struct vm_area_struct *vma, unsigned long haddr, + pgtable_t pgtable); int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, pmd_t *dst_pmd, pmd_t *src_pmd, unsigned long addr, struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma); diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 58125fbcc532..150163ad77d3 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -943,9 +943,9 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, } EXPORT_SYMBOL_GPL(thp_get_unmapped_area); -static vm_fault_t thp_fault_alloc(gfp_t gfp, int order, struct vm_area_struct *vma, - unsigned long haddr, struct folio **foliop, - unsigned long addr) +vm_fault_t thp_fault_alloc(gfp_t gfp, int order, struct vm_area_struct *vma, + unsigned long haddr, struct folio **foliop, + unsigned long addr) { struct folio *folio = vma_alloc_folio(gfp, order, vma, haddr, true); @@ -984,21 +984,29 @@ static void __thp_fault_success_stats(struct vm_area_struct *vma, int order) count_memcg_event_mm(vma->vm_mm, THP_FAULT_ALLOC); } -static void map_pmd_thp(struct folio *folio, struct vm_fault *vmf, - struct vm_area_struct *vma, unsigned long haddr, - pgtable_t pgtable) +void map_pmd_thp(struct folio *folio, struct vm_fault *vmf, + struct vm_area_struct *vma, unsigned long haddr, + pgtable_t pgtable) { - pmd_t entry; + pmd_t entry, old_pmd; + bool is_pmd_none = pmd_none(*vmf->pmd); entry = mk_huge_pmd(&folio->page, vma->vm_page_prot); entry = maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); folio_add_new_anon_rmap(folio, vma, haddr, RMAP_EXCLUSIVE); folio_add_lru_vma(folio, vma); - pgtable_trans_huge_deposit(vma->vm_mm, vmf->pmd, pgtable); + if (!is_pmd_none) { + old_pmd = pmdp_huge_clear_flush(vma, haddr, vmf->pmd); + if (pmd_uffd_wp(old_pmd)) + entry = pmd_mkuffd_wp(entry); + } + if (pgtable) + pgtable_trans_huge_deposit(vma->vm_mm, vmf->pmd, pgtable); set_pmd_at(vma->vm_mm, haddr, vmf->pmd, entry); update_mmu_cache_pmd(vma, vmf->address, vmf->pmd); add_mm_counter(vma->vm_mm, MM_ANONPAGES, HPAGE_PMD_NR); - mm_inc_nr_ptes(vma->vm_mm); + if (is_pmd_none) + mm_inc_nr_ptes(vma->vm_mm); } static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf) @@ -1576,6 +1584,50 @@ void huge_pmd_set_accessed(struct vm_fault *vmf) spin_unlock(vmf->ptl); } +static vm_fault_t do_huge_zero_wp_pmd_locked(struct vm_fault *vmf, + unsigned long haddr, + struct folio *folio) +{ + struct vm_area_struct *vma = vmf->vma; + vm_fault_t ret = 0; + + ret = check_stable_address_space(vma->vm_mm); + if (ret) + goto out; + map_pmd_thp(folio, vmf, vma, haddr, NULL); +out: + return ret; +} + +static vm_fault_t do_huge_zero_wp_pmd(struct vm_fault *vmf, unsigned long haddr) +{ + struct vm_area_struct *vma = vmf->vma; + gfp_t gfp = vma_thp_gfp_mask(vma); + struct mmu_notifier_range range; + struct folio *folio = NULL; + vm_fault_t ret = 0; + + ret = thp_fault_alloc(gfp, HPAGE_PMD_ORDER, vma, haddr, &folio, + vmf->address); + if (ret) + goto out; + + mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma->vm_mm, haddr, + haddr + HPAGE_PMD_SIZE); + mmu_notifier_invalidate_range_start(&range); + vmf->ptl = pmd_lock(vma->vm_mm, vmf->pmd); + if (unlikely(!pmd_same(pmdp_get(vmf->pmd), vmf->orig_pmd))) + goto unlock; + ret = do_huge_zero_wp_pmd_locked(vmf, haddr, folio); + if (!ret) + __thp_fault_success_stats(vma, HPAGE_PMD_ORDER); +unlock: + spin_unlock(vmf->ptl); + mmu_notifier_invalidate_range_end(&range); +out: + return ret; +} + vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf) { const bool unshare = vmf->flags & FAULT_FLAG_UNSHARE; @@ -1588,8 +1640,15 @@ vm_fault_t do_huge_pmd_wp_page(struct vm_fault *vmf) vmf->ptl = pmd_lockptr(vma->vm_mm, vmf->pmd); VM_BUG_ON_VMA(!vma->anon_vma, vma); - if (is_huge_zero_pmd(orig_pmd)) + if (is_huge_zero_pmd(orig_pmd)) { + vm_fault_t ret = do_huge_zero_wp_pmd(vmf, haddr); + + if (!(ret & VM_FAULT_FALLBACK)) + return ret; + + /* Fallback to splitting PMD if THP cannot be allocated */ goto fallback; + } spin_lock(vmf->ptl); diff --git a/mm/memory.c b/mm/memory.c index 3c01d68065be..c081a25f5173 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5409,9 +5409,10 @@ static inline vm_fault_t wp_huge_pmd(struct vm_fault *vmf) if (vma_is_anonymous(vma)) { if (likely(!unshare) && userfaultfd_huge_pmd_wp(vma, vmf->orig_pmd)) { - if (userfaultfd_wp_async(vmf->vma)) + if (!userfaultfd_wp_async(vmf->vma)) + return handle_userfault(vmf, VM_UFFD_WP); + if (!is_huge_zero_pmd(vmf->orig_pmd)) goto split; - return handle_userfault(vmf, VM_UFFD_WP); } return do_huge_pmd_wp_page(vmf); }