| Message ID | 20240905153028.1205128-1-sunnanyong@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: thp: simplify split_huge_pages_pid() | expand |
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 67c86a5d64a6..c5349c2a8275 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3480,16 +3480,11 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, vaddr_start &= PAGE_MASK; vaddr_end &= PAGE_MASK; - /* Find the task_struct from pid */ - rcu_read_lock(); - task = find_task_by_vpid(pid); + task = find_get_task_by_vpid(pid); if (!task) { - rcu_read_unlock(); ret = -ESRCH; goto out; } - get_task_struct(task); - rcu_read_unlock(); /* Find the mm_struct */ mm = get_task_mm(task);
The helper find_get_task_by_vpid() can totally replace the task_struct find logic in split_huge_pages_pid(), so use it to simplify the code. Also delete the needless comments for the helper function name already explains what it's doing here. Signed-off-by: Nanyong Sun <sunnanyong@huawei.com> --- mm/huge_memory.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)