[v3,2/9] ext4: Use generic_ci_validate_strict_name helper

Message ID	20240905190252.461639-3-andrealmeid@igalia.com (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: =?utf-8?q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com> To: Hugh Dickins <hughd@google.com>, Andrew Morton <akpm@linux-foundation.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, krisman@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg <drosen@google.com>, smcv@collabora.com, Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>, =?utf-8?q?An?= =?utf-8?q?dr=C3=A9_Almeida?= <andrealmeid@igalia.com>, Gabriel Krisman Bertazi <gabriel@krisman.be> Subject: [PATCH v3 2/9] ext4: Use generic_ci_validate_strict_name helper Date: Thu, 5 Sep 2024 16:02:45 -0300 Message-ID: <20240905190252.461639-3-andrealmeid@igalia.com> In-Reply-To: <20240905190252.461639-1-andrealmeid@igalia.com> References: <20240905190252.461639-1-andrealmeid@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	tmpfs: Add case-insensitive support for tmpfs \| expand [v3,0/9] tmpfs: Add case-insensitive support for tmpfs [v3,1/9] libfs: Create the helper function generic_ci_validate_strict_name() [v3,2/9] ext4: Use generic_ci_validate_strict_name helper [v3,3/9] unicode: Recreate utf8_parse_version() [v3,4/9] unicode: Export latest available UTF-8 version number [v3,5/9] libfs: Create the helper struct generic_ci_always_del_dentry_ops [v3,6/9] tmpfs: Add casefold lookup support [v3,7/9] tmpfs: Add flag FS_CASEFOLD_FL support for tmpfs dirs [v3,8/9] tmpfs: Expose filesystem features via sysfs [v3,9/9] docs: tmpfs: Add casefold options

Message ID

20240905190252.461639-3-andrealmeid@igalia.com (mailing list archive)

State

New

Headers

From: =?utf-8?q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>
To: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	Jan Kara <jack@suse.cz>,
	krisman@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com,
 Daniel Rosenberg <drosen@google.com>, smcv@collabora.com,
 Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>, =?utf-8?q?An?=
	=?utf-8?q?dr=C3=A9_Almeida?= <andrealmeid@igalia.com>,
 Gabriel Krisman Bertazi <gabriel@krisman.be>
Subject: [PATCH v3 2/9] ext4: Use generic_ci_validate_strict_name helper
Date: Thu,  5 Sep 2024 16:02:45 -0300
Message-ID: <20240905190252.461639-3-andrealmeid@igalia.com>
In-Reply-To: <20240905190252.461639-1-andrealmeid@igalia.com>
References: <20240905190252.461639-1-andrealmeid@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

tmpfs: Add case-insensitive support for tmpfs | expand

Commit Message

André Almeida Sept. 5, 2024, 7:02 p.m. UTC

Use the helper function to check the requirements for casefold
directories using strict encoding.

Suggested-by: Gabriel Krisman Bertazi <gabriel@krisman.be>
Signed-off-by: André Almeida <andrealmeid@igalia.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/ext4/namei.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 6a95713f9193..beca80e70b0c 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2394,8 +2394,7 @@  static int ext4_add_entry(handle_t *handle, struct dentry *dentry,
 		return -ENOKEY;
 
 #if IS_ENABLED(CONFIG_UNICODE)
-	if (sb_has_strict_encoding(sb) && IS_CASEFOLDED(dir) &&
-	    utf8_validate(sb->s_encoding, &dentry->d_name))
+	if (!generic_ci_validate_strict_name(dir, &dentry->d_name))
 		return -EINVAL;
 #endif

[v3,2/9] ext4: Use generic_ci_validate_strict_name helper

Commit Message

Patch