| Message ID | 20240905190252.461639-5-andrealmeid@igalia.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tmpfs: Add case-insensitive support for tmpfs | expand |
André Almeida <andrealmeid@igalia.com> writes: > Export latest available UTF-8 version number so filesystems can easily > load the newest one. > > Signed-off-by: André Almeida <andrealmeid@igalia.com> > --- > > If this is the accepted way of doing that, I will also add something to > checkpatch to warn that modifications at fs/unicode/utf8data.c likely > need to change this define. I'd do it by special casing version == 0 or -1 to utf8_load. But the way you've done is just fine. Acked-by: Gabriel Krisman Bertazi <krisman@suse.de>
diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/utf8-selftest.c index 600e15efe9ed..5ddaf27b21a6 100644 --- a/fs/unicode/utf8-selftest.c +++ b/fs/unicode/utf8-selftest.c @@ -17,9 +17,6 @@ static unsigned int failed_tests; static unsigned int total_tests; -/* Tests will be based on this version. */ -#define UTF8_LATEST UNICODE_AGE(12, 1, 0) - #define _test(cond, func, line, fmt, ...) do { \ total_tests++; \ if (!cond) { \ diff --git a/include/linux/unicode.h b/include/linux/unicode.h index f73a78655588..db043ea914fd 100644 --- a/include/linux/unicode.h +++ b/include/linux/unicode.h @@ -16,6 +16,8 @@ struct utf8data_table; ((unsigned int)(MIN) << UNICODE_MIN_SHIFT) | \ ((unsigned int)(REV))) +#define UTF8_LATEST UNICODE_AGE(12, 1, 0) + static inline u8 unicode_major(unsigned int age) { return (age >> UNICODE_MAJ_SHIFT) & 0xff;
Export latest available UTF-8 version number so filesystems can easily load the newest one. Signed-off-by: André Almeida <andrealmeid@igalia.com> --- If this is the accepted way of doing that, I will also add something to checkpatch to warn that modifications at fs/unicode/utf8data.c likely need to change this define. Other ways to implement this: 1) Having a new arg for utf8_load() struct unicode_map *utf8_load(unsigned int version, bool latest) { um->tables = symbol_request(utf8_data_table); if (latest) { int i = um->tables->utf8agetab_size - 1; version = um->tables->utf8agetab[i] } } 2) Expose utf8agetab[] Having utf8agetab[] at include/linux/unicode.h will make easier to programmatically find out the latest version without the need to do a symbol_request/symbol_put of the whole utf8 table. --- fs/unicode/utf8-selftest.c | 3 --- include/linux/unicode.h | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-)