| Message ID | 20240909163223.3693529-2-mkoutny@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Followups to controllers' v1 compilation | expand |
On Mon, Sep 09, 2024 at 06:32:20PM GMT, Michal Koutný wrote: > Extern declarations have no definitions with !CONFIG_MEMCG_V1 and no > users, drop them altogether. > > Signed-off-by: Michal Koutný <mkoutny@suse.com> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
On Mon, Sep 09, 2024 at 06:32:20PM +0200, Michal Koutný wrote: > Extern declarations have no definitions with !CONFIG_MEMCG_V1 and no > users, drop them altogether. > > Signed-off-by: Michal Koutný <mkoutny@suse.com> Acked-by: Tejun Heo <tj@kernel.org> This one should go through -mm. If Andrew doesn't pick it up from this thread, it might be better to repost it. Thanks.
On Tue, 10 Sep 2024 10:05:57 -1000 Tejun Heo <tj@kernel.org> wrote: > On Mon, Sep 09, 2024 at 06:32:20PM +0200, Michal Koutný wrote: > > Extern declarations have no definitions with !CONFIG_MEMCG_V1 and no > > users, drop them altogether. > > > > Signed-off-by: Michal Koutný <mkoutny@suse.com> > > Acked-by: Tejun Heo <tj@kernel.org> > > This one should go through -mm. If Andrew doesn't pick it up from this > thread, it might be better to repost it. > Yep, thanks, I grabbed all four patches.
On Tue, Sep 10, 2024 at 01:19:00PM -0700, Andrew Morton wrote: > On Tue, 10 Sep 2024 10:05:57 -1000 Tejun Heo <tj@kernel.org> wrote: > > > On Mon, Sep 09, 2024 at 06:32:20PM +0200, Michal Koutný wrote: > > > Extern declarations have no definitions with !CONFIG_MEMCG_V1 and no > > > users, drop them altogether. > > > > > > Signed-off-by: Michal Koutný <mkoutny@suse.com> > > > > Acked-by: Tejun Heo <tj@kernel.org> > > > > This one should go through -mm. If Andrew doesn't pick it up from this > > thread, it might be better to repost it. > > > > Yep, thanks, I grabbed all four patches. Oh, I applied the latter three to the cgroup tree. Should be easy to figure out later. Thanks.
diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h index 56d7eaa982741..db2ebf8bea6c5 100644 --- a/mm/memcontrol-v1.h +++ b/mm/memcontrol-v1.h @@ -140,8 +140,6 @@ static inline bool memcg1_charge_skmem(struct mem_cgroup *memcg, unsigned int nr gfp_t gfp_mask) { return true; } static inline void memcg1_uncharge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages) {} -extern struct cftype memsw_files[]; -extern struct cftype mem_cgroup_legacy_files[]; #endif /* CONFIG_MEMCG_V1 */ #endif /* __MM_MEMCONTROL_V1_H */
Extern declarations have no definitions with !CONFIG_MEMCG_V1 and no users, drop them altogether. Signed-off-by: Michal Koutný <mkoutny@suse.com> --- mm/memcontrol-v1.h | 2 -- 1 file changed, 2 deletions(-)