Message ID | 20240923150756.902363-4-dhowells@redhat.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599ADCF9C72 for <linux-mm@archiver.kernel.org>; Mon, 23 Sep 2024 15:08:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF6346B008C; Mon, 23 Sep 2024 11:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA61D6B0092; Mon, 23 Sep 2024 11:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D686B0093; Mon, 23 Sep 2024 11:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A4D016B008C for <linux-mm@kvack.org>; Mon, 23 Sep 2024 11:08:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 376FD121358 for <linux-mm@kvack.org>; Mon, 23 Sep 2024 15:08:44 +0000 (UTC) X-FDA: 82596334968.12.0A7FFF5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 78FA91C0023 for <linux-mm@kvack.org>; Mon, 23 Sep 2024 15:08:41 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iSdFVGDI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727104034; a=rsa-sha256; cv=none; b=3fZ9qWrasEhvPyGUEmZF3p2pFBlCf32xIHddCRae1oYj5Z/By0b9T5iATLHtucWjODFALX t1/I0efn4s3KczmeSKJYkgs2W8s1a+T3VRHdyvXELqRrmyk8mRIoX1Tuk7+VbvkmenAAvK AVVYo46gJPXUaKtGIbsiBkpAjZfMQyA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iSdFVGDI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727104034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7sJs50CQB1rXW7Czy4aIaKRpcUNrb/d4a0miNhatVWk=; b=PeoCevdEjCHu8BIokm1FETh/nu3gCVRAB/hbHOd7pSB1SckVTJHaQVSCS4ylXRqIqdIBm/ 4B8CP1ZCcySorHXFvoBEbXazOlIIQO+/BALNHotjw19FlrhtsM197dqXrI8YrwtbKwZSv1 ZWlx/uiCPa425+pkO9jzCFDegVg6BU0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727104120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7sJs50CQB1rXW7Czy4aIaKRpcUNrb/d4a0miNhatVWk=; b=iSdFVGDIq+JGumIh5MtRiv5vZIUpNnW6TcvSsni3NVx005szsyfEjTzHdQJG+PFPkuRtf5 XdNlpoW+iRf4NB8XsvBc5INbj9csVpcQQRwX//TjAcLjroiGvjNJtCJXFe9UX1fBA0SehS 6KcqbhqnOK+5DWcByUZG3vNITeTgJnI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-MvVAiCEgPwSeBw7yfVwWvA-1; Mon, 23 Sep 2024 11:08:39 -0400 X-MC-Unique: MvVAiCEgPwSeBw7yfVwWvA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4E23195FE03; Mon, 23 Sep 2024 15:08:36 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.145]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C252F1954190; Mon, 23 Sep 2024 15:08:18 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Christian Brauner <christian@brauner.io>, Steve French <sfrench@samba.org>, Marc Dionne <marc.dionne@auristor.com> Cc: David Howells <dhowells@redhat.com>, Paulo Alcantara <pc@manguebit.com>, Jeff Layton <jlayton@kernel.org>, Matthew Wilcox <willy@infradead.org>, netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" <linux@treblig.org> Subject: [PATCH 3/8] afs: Fix missing wire-up of afs_retry_request() Date: Mon, 23 Sep 2024 16:07:47 +0100 Message-ID: <20240923150756.902363-4-dhowells@redhat.com> In-Reply-To: <20240923150756.902363-1-dhowells@redhat.com> References: <20240923150756.902363-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Queue-Id: 78FA91C0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4k8iaef4o1hsuuym4yg3xrku437mgaxz X-HE-Tag: 1727104121-114289 X-HE-Meta: U2FsdGVkX1/KHpsUymO8KSL8r2UWvjkyy7gP2gqYCl05Fs6EClfWyR3NOQWUeLrwQJNNhKDJJmzB6pYJVT21QGXcF0fR6Q6HwMLF7gBJUct0mIwUSR6tVuCZfCevuytVbHz8pNNHbF8zvLM37GQ1LghDZNe1qdJ1f3ZG0mNAvX8cQZsZn4FdPjZE3cgRVXJB3jtfzsjMfIfILBAg8GxHo9uDXc15fbZST91iHBnpdaLsgYD9bxus8Tq/lPuIsbITuflqEBOcQFXM5TFEhEHRoCxlKh3FIcSvCmiT2XGGnpYfwqXF45vNZQPSX65L2D6BdQ2+b3voyi/qjGJUvqwxyOBCnt55gPuXz05ANXPRalBxgp7tRzxCqOKDTQFdDm//sWGZahahuoiOp8SHBNbph2FDpHuKWHsVCKgROtCJSbD0xDDQknqp3ciDYB2fpwElY2cxdvhEDvOZQkM2naYcnVcaFgyp4qUbe2E9PZu57jD3uWeorPmnsv5USRPu/zJcCUmiVr3vBD7f7K50sYpSYHhrwVIOAg/45e9ELQevt1ytCNp3HYdIpxNdm8hvdM+2oPw4ke8URkPgxJraixHUkpXGcAYIXfQ5mGpsDH2TrLnWfh3NsJazsd81MK29J5/7J9wzmjxTmSVAr0jsD5d5kPlRWdMTXH4jcHcht+LV9f0HVnP/fpjHjQD8wm/UFJ6tXOeCfRktOrGFGr4s1IxzMpiHUrNvT/UCDUzo86Q/nIZ4KIkwCa5BwQAUF0i0PUyxKyOyU1YX/r5rIkIsgdOUiAG53zCkj5HWCXk/708khF/AbDDWyd2DX50DGYeL1O8wKWc3iCEfVhrRjROzIpQJqZeH1Gap7TE8PXLblQGKhBuPOgZLDbyuyQALMph8eh0mAn/Z91hA916gUrRhonrW1W1nrLF3wZkfPN670vtkx0yHHkS4gnHBn1MeEIfU3FCTQE/EhTisRaur005MKKm rj3bc+Ls rOJ524aEG7ziDmPiQqC1DUSSgNcBM/YJTdtz14P3p1yv4UaviHkbia0ng6z5Y4ozE/wzse+cSNA1i0l0HPUaTnOufKYYr6/P7MJn/2i2iJzjzcDsIC6YMKbdyqyo5LCNr5g1JY1Yiz6+nRZ0fcGFZXOQGsy+yMtcqV64SmljD9ydFTx6jvNE/BMs+zRvyKghYIKA6DcmsKFqE384fum09IEq5B+Ii9YA6dFdo6FUtyyPM7PVr9yN48OnJy4CHnjbVPAejcw4gVUtf2L0FSveRBjbb4JRrcDnob99nxS+4RNGGc5wHVW6KGzRm5kvaUIIBbjpo0IzwQxuuONZu98P+gmFN5i0lj+VwS41/7J9XhjVnR2cSvW8FDIzOUyWj/FuT2/JrrzYEjKrw4ciGnUxh5dOLneZ7ereSnE4ffAVjwVVl39NMQLr2xoodDn4zy3bSLlfFcy8hxiimelSufE7IyjOtDWAmv4NPcjhAaifiRCCwJBLF5zBCPFd5BINdFCsWGgH91Ict31r+pgp5bZbYyYNuDTUKACNPxjtRv0IdW6voI+CKjRGT1SzAg3SCbUSkJKa5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
netfs, afs, cifs: Miscellaneous fixes/changes
|
expand
|
diff --git a/fs/afs/file.c b/fs/afs/file.c index 1d30924cec5b..f717168da4ab 100644 --- a/fs/afs/file.c +++ b/fs/afs/file.c @@ -425,6 +425,7 @@ const struct netfs_request_ops afs_req_ops = { .begin_writeback = afs_begin_writeback, .prepare_write = afs_prepare_write, .issue_write = afs_issue_write, + .retry_request = afs_retry_request, }; static void afs_add_open_mmap(struct afs_vnode *vnode)
afs_retry_request() is supposed to be pointed to by the afs_req_ops netfs operations table, but the pointer got lost somewhere. The function is used during writeback to rotate through the authentication keys that were in force when the file was modified locally. Fix this by adding the pointer to the function. Fixes: 1ecb146f7cd8 ("netfs, afs: Use writeback retry to deal with alternate keys") Reported-by: "Dr. David Alan Gilbert" <linux@treblig.org> Signed-off-by: David Howells <dhowells@redhat.com> cc: Marc Dionne <marc.dionne@auristor.com> cc: Jeff Layton <jlayton@kernel.org> cc: linux-afs@lists.infradead.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/afs/file.c | 1 + 1 file changed, 1 insertion(+)