From patchwork Fri Sep 27 18:41:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Namhyung Kim X-Patchwork-Id: 13814486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F69CDD1D3 for ; Fri, 27 Sep 2024 18:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFCE26B012A; Fri, 27 Sep 2024 14:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAFCC6B012B; Fri, 27 Sep 2024 14:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D249A6B012C; Fri, 27 Sep 2024 14:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B719F6B012A for ; Fri, 27 Sep 2024 14:41:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C33E161470 for ; Fri, 27 Sep 2024 18:41:41 +0000 (UTC) X-FDA: 82611386802.05.2FDDEC0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id AF3F3A000D for ; Fri, 27 Sep 2024 18:41:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O0V0JRTC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727462482; a=rsa-sha256; cv=none; b=xCD2eFNyVDLElvfdr3VrQTw4mhNIBJDtl3FDKFcFgYGgggoEM3r7U8BUgoXvWfbLcDZZ1n vdyzRAJDs0WWGdpMJFk4bBRdTlVVIGIQ0n6to/hjYlt/1HQyCioVnIAg1CZcBCgfBjUReU 9b2t9iQ9ZuZuJ2slrjwkDmW2IiVgFXo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O0V0JRTC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727462482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=no3Y9dfUjM0/B/e2JZI2W+mflRPOSUm9cJ7aDFbhLNI=; b=376dhYnsWbjsiO2VIjgbiizsNMsW3GlX9Os31NaYsejHAuswpIOZ/3C3lBCWEPkIoub3Rm jiX9AaU0j4+xxfSQg//JBwnzXSF+Bji3d7VR0JwROHgr383iKtyAznMuhYONbURnp3qv/Z YBjJIiSWAYZTng7kjVegdFqFvObQUdA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DE80BA459E2; Fri, 27 Sep 2024 18:41:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5A2EC4CEDD; Fri, 27 Sep 2024 18:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727462498; bh=gSjsCO+yJeYz9Q0JxuHX0Iwg1Cw1ZvOjdo01YYnkwIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O0V0JRTCDe/wi56R1NflEXujgQBdOWrfznE7+vluy+tlpBux8OuX2VjTmiEIcWbEH TRE7muqFK7JcqDcg3FiisHUhxZdmBs6pIBLFv6tuVez+1psKp+nO2K0bk858ed5fo8 x4P8gaXsb4MnULmS8VvqfzKY9QPkn79ARxez5G6YdPtIr0kQboxI1U0E+1PhQRAvym Haicdh30Re2Dhap5VA9MGj9//kxcpDFifjilW46lTnD3b+PNWbbJVVJDg3p4FnFe3c ddg9JeOWBUGpkKaghbPKrpVUm3BiIjfFVr/m1E8qhHf7hwyJM9pRNLSYX/ifChdowt fCYi3t+ccwu7w== From: Namhyung Kim To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf@vger.kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Arnaldo Carvalho de Melo Subject: [RFC/PATCH bpf-next 3/3] selftests/bpf: Add a test for kmem_cache_iter Date: Fri, 27 Sep 2024 11:41:33 -0700 Message-ID: <20240927184133.968283-4-namhyung@kernel.org> X-Mailer: git-send-email 2.46.1.824.gd892dcdcdd-goog In-Reply-To: <20240927184133.968283-1-namhyung@kernel.org> References: <20240927184133.968283-1-namhyung@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: s7g81sfng5ni5tzzajkx9fb98hp4es7n X-Rspamd-Queue-Id: AF3F3A000D X-Rspamd-Server: rspam02 X-HE-Tag: 1727462499-611285 X-HE-Meta: U2FsdGVkX1/b3aKPSSye85NQ75ZREQ0FsgnoN5csH/tpZB3NR46oisIaEvYJSXUFkyjtnFnJnA/W6+fqoCppMG8T1wGInZ7NY8bkSWM+19aht18WzS95aHh3cU5UDKlFiFZinw20slzg18KxP6gEmTTvnYsg9ZDh83X1MXdk1aPkOjo8V90vPnrMI+IBh+PUTgjNQMhgMm330JMIKjtGDWIJJv6G5oGuPcUm+xI7UVdg+UWCwfn2FEHiRv4U+ocnh1lpMaPWwrjjzsCaBeOY9IdpN0uql82nuT7JQuFMg0sl1ZR6oc4TOTkZMoynuvS8RlD8zp20U55kuCI4ZXxo3Y4aY/RhXVSHZfI1iBCvtfAEBkwQMeoJ7vDonrOmfTvLvu4v9G35njUGcpqLraxqsUw7R9Si639cXW2kTvw0VfT9yKfjwXrkcLHqPXl4LE3iqeDf5dk01fhMa0DHWqShy4fXrk93BGRZ6z006wddrSyrQLSdwlpvlc/0p3al/XMGJoNDVXfys+AwiRyScNa/1XJQoe4WOVkgZqsxRvb/ouQrbh0MV75hc+bIgC3z66R5D6o/g63eFOj9Nvw4trn0wrOWK161+Hzsk24DcIuMUYlRUa5PQpzQdVXwkF7OrWKi0Jjet+BI74ZUew00BCRNMe8RKncF3wIkW/bLW1IvJqQgiIFpyN0EiZ/Ei45uSLzIWCqJEWyR4YnJokHjP8l1/Sw2tEeagR2oFnLmTb21sboKgN1AvkbhlRIm2Lyzl8M/ObyZvNIN/2D8tuZfwEDJB+XqQSjnne5zHNCFruVZ2Xiq2qiSTR9PKmC1NV3tdZvsTZpMX+1PqC/DmYDwvo2d2IcFpdFVypevvR4rdvdlq1Jvxa4Ne6nOQaj+OYV+r+gRsaPvcg68BYggaMRhV8V/hBzc56rADYwZ2W74phYoDFhyn/S8EISve3nX+I+8BCUhNGV5yGBs5ODTOlv9nY7 8NlwbNVI KWur/ZGNfqoaLuAJwBJ7DgXZKwdkvwXiohOl14qUiiqLHIkH7J1JgtbujHEexC75tqkTilM9YrVTOlGdFgzb++3My6/C48yLMBxtiZ29vkLFRFcRFfK6MvBRer96J1tR9YtYmy3bXAB1DJdhBmeMopyfKZ5EIkMOibp8fVKhcPNfj3q1a86gmtx0/ZhW+nCnr43YUD+ptduoZzHCEYa83mh5HkGpGkitJMpJBjJukrWgroP12d2uFIJm3q92EdRSBRsVrMySMgwarC/gdyIJZud5TeU/NaaI0HQ1iN6KZ7TSHL3AXyA3WZkNsUOwAyKyPQC3JoN0azX58praZEmGokrWVJjRymZ/m3p38F1RS2MS+JjPDe3vEih2xw4hzvUlOVWswXEpyqqrp/Tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The test traverses all slab caches using the kmem_cache_iter and check if current task's pointer is from "task_struct" slab cache. Signed-off-by: Namhyung Kim --- .../bpf/prog_tests/kmem_cache_iter.c | 64 ++++++++++++++++++ tools/testing/selftests/bpf/progs/bpf_iter.h | 7 ++ .../selftests/bpf/progs/kmem_cache_iter.c | 66 +++++++++++++++++++ 3 files changed, 137 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c create mode 100644 tools/testing/selftests/bpf/progs/kmem_cache_iter.c diff --git a/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c b/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c new file mode 100644 index 0000000000000000..814bcc453e9f3ccd --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c @@ -0,0 +1,64 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2024 Google */ + +#include +#include +#include +#include "kmem_cache_iter.skel.h" + +static void test_kmem_cache_iter_check_task(struct kmem_cache_iter *skel) +{ + LIBBPF_OPTS(bpf_test_run_opts, opts, + .flags = BPF_F_TEST_RUN_ON_CPU, + ); + int prog_fd = bpf_program__fd(skel->progs.check_task_struct); + + /* get task_struct and check it if's from a slab cache */ + bpf_prog_test_run_opts(prog_fd, &opts); + + /* the BPF program should set 'found' variable */ + ASSERT_EQ(skel->bss->found, 1, "found task_struct"); +} + +void test_kmem_cache_iter(void) +{ + DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); + struct kmem_cache_iter *skel = NULL; + union bpf_iter_link_info linfo = {}; + struct bpf_link *link; + char buf[1024]; + int iter_fd; + + skel = kmem_cache_iter__open_and_load(); + if (!ASSERT_OK_PTR(skel, "kmem_cache_iter__open_and_load")) + return; + + opts.link_info = &linfo; + opts.link_info_len = sizeof(linfo); + + link = bpf_program__attach_iter(skel->progs.slab_info_collector, &opts); + if (!ASSERT_OK_PTR(link, "attach_iter")) + goto destroy; + + iter_fd = bpf_iter_create(bpf_link__fd(link)); + if (!ASSERT_GE(iter_fd, 0, "iter_create")) + goto free_link; + + memset(buf, 0, sizeof(buf)); + while (read(iter_fd, buf, sizeof(buf) > 0)) { + /* read out all contents */ + printf("%s", buf); + } + + /* next reads should return 0 */ + ASSERT_EQ(read(iter_fd, buf, sizeof(buf)), 0, "read"); + + test_kmem_cache_iter_check_task(skel); + + close(iter_fd); + +free_link: + bpf_link__destroy(link); +destroy: + kmem_cache_iter__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/bpf_iter.h b/tools/testing/selftests/bpf/progs/bpf_iter.h index c41ee80533ca219a..3305dc3a74b32481 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter.h +++ b/tools/testing/selftests/bpf/progs/bpf_iter.h @@ -24,6 +24,7 @@ #define BTF_F_PTR_RAW BTF_F_PTR_RAW___not_used #define BTF_F_ZERO BTF_F_ZERO___not_used #define bpf_iter__ksym bpf_iter__ksym___not_used +#define bpf_iter__kmem_cache bpf_iter__kmem_cache___not_used #include "vmlinux.h" #undef bpf_iter_meta #undef bpf_iter__bpf_map @@ -48,6 +49,7 @@ #undef BTF_F_PTR_RAW #undef BTF_F_ZERO #undef bpf_iter__ksym +#undef bpf_iter__kmem_cache struct bpf_iter_meta { struct seq_file *seq; @@ -165,3 +167,8 @@ struct bpf_iter__ksym { struct bpf_iter_meta *meta; struct kallsym_iter *ksym; }; + +struct bpf_iter__kmem_cache { + struct bpf_iter_meta *meta; + struct kmem_cache *s; +} __attribute__((preserve_access_index)); diff --git a/tools/testing/selftests/bpf/progs/kmem_cache_iter.c b/tools/testing/selftests/bpf/progs/kmem_cache_iter.c new file mode 100644 index 0000000000000000..3f6ec15a1bf6344c --- /dev/null +++ b/tools/testing/selftests/bpf/progs/kmem_cache_iter.c @@ -0,0 +1,66 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2024 Google */ + +#include "bpf_iter.h" +#include +#include + +char _license[] SEC("license") = "GPL"; + +#define SLAB_NAME_MAX 256 + +struct { + __uint(type, BPF_MAP_TYPE_HASH); + __uint(key_size, sizeof(void *)); + __uint(value_size, SLAB_NAME_MAX); + __uint(max_entries, 1024); +} slab_hash SEC(".maps"); + +extern struct kmem_cache *bpf_get_kmem_cache(__u64 addr) __ksym; + +/* result, will be checked by userspace */ +int found; + +SEC("iter/kmem_cache") +int slab_info_collector(struct bpf_iter__kmem_cache *ctx) +{ + struct seq_file *seq = ctx->meta->seq; + struct kmem_cache *s = ctx->s; + + if (s) { + char name[SLAB_NAME_MAX]; + + /* + * To make sure if the slab_iter implements the seq interface + * properly and it's also useful for debugging. + */ + BPF_SEQ_PRINTF(seq, "%s: %u\n", s->name, s->object_size); + + bpf_probe_read_kernel_str(name, sizeof(name), s->name); + bpf_map_update_elem(&slab_hash, &s, name, BPF_NOEXIST); + } + + return 0; +} + +SEC("raw_tp/bpf_test_finish") +int BPF_PROG(check_task_struct) +{ + __u64 curr = bpf_get_current_task(); + struct kmem_cache *s; + char *name; + + s = bpf_get_kmem_cache(curr); + if (s == NULL) { + found = -1; + return 0; + } + + name = bpf_map_lookup_elem(&slab_hash, &s); + if (name && !bpf_strncmp(name, 11, "task_struct")) + found = 1; + else + found = -2; + + return 0; +}