From patchwork Tue Oct 1 16:06:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak Gupta X-Patchwork-Id: 13818434 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74AECEACE5 for ; Tue, 1 Oct 2024 16:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 557A52800BA; Tue, 1 Oct 2024 12:08:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50510280068; Tue, 1 Oct 2024 12:08:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D772800BA; Tue, 1 Oct 2024 12:08:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 15046280068 for ; Tue, 1 Oct 2024 12:08:26 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C2BE6140F0F for ; Tue, 1 Oct 2024 16:08:25 +0000 (UTC) X-FDA: 82625515770.08.8C5831E Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf10.hostedemail.com (Postfix) with ESMTP id BADB2C000D for ; Tue, 1 Oct 2024 16:08:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=AdmzexSG; spf=pass (imf10.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727798776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IhmPwONIKNZXNlLItF/RqS4Q7SWFxV+hpF07L6+CC7I=; b=c2K31PdK1NWVbr6wDnh77UPwdE9cLCx9B7e4mRrzCV5Henx25maHbB6zyVtSEOWeYBu4H+ ancng7rKl3wlCf83/G3+9C8sHyPgNeiej2CPzLdq9BOT14nW2UYnHVV7ZaSzV7bBvUnBwa lewSqGPtVWymcboQA1U885dTxs16ZiM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727798776; a=rsa-sha256; cv=none; b=lUVBWoH+8KxbYZrenz9AAR9dJl32t/vjx04ouMzC7weeMmyPQlHngbZ4flAVEquucgFTvr bkd0R4RCAz/Qy61bhJhmGbFttGc2PrujUC4b0uEowdDFalIn0m5FIlTESTc/TwmZiKlkxO iHXSTa1LZCiGjuqqZGchdv5U6/WeD4U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=AdmzexSG; spf=pass (imf10.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7c6b4222fe3so3826415a12.3 for ; Tue, 01 Oct 2024 09:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1727798902; x=1728403702; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IhmPwONIKNZXNlLItF/RqS4Q7SWFxV+hpF07L6+CC7I=; b=AdmzexSGwu1SLOHYMbpd4UnafW6EbCNsTxqh4wXrnJfls6b36KUJMnTaG1Y4rtQOd1 AT72m/p4HoJjGv4GTzliMDAFuaBrZ78Dsj8gQJq5D3fApzxDcNosGnToMuZxBX5+WPb7 yy4Vz3oGItWOlhm0hLxklryRMrzwOXdIA1ebOdr7BZT/xupruGzHQ9BL9BnxGSG5yvee j8GYKer8IZu0Xe/0Tot6ndUp6BbOfOpYPbvfVU0uqL8tW2CIHFzEBemQ5LCxpwBn+cQ0 eePiOt6QBnGROqmwuUAGzFVpmUXIBI//pqry3HknjBi9/3IXA7LksFRcoAhz1nco/TYN hCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727798902; x=1728403702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IhmPwONIKNZXNlLItF/RqS4Q7SWFxV+hpF07L6+CC7I=; b=kwZxW0i5ZR3jpNINjoYRR4FlUaODhCq31LlsmXWH88RancPaeRhf3932mRID4RkcXV UQPaK42YgZpV7fice2QZvpd1bJ8Sz6xc9LS8TcoREj+CMx22jtuK4ZnuWOtFmmuFCtkJ jWofx2DEr4ESkcsw9smkGfYCZwEcNW+gHCEJDPD0dyTyRgGE8cpe14WSXwVGQOrNWIcN mC43idN1Ipp4rhWCAY+XJXfg4+7tU1mDNpXCMMNTb0KcjClJ5Y6a2VY5L2nLbEi2/tsj 9yV8HmKaBy4Ydjokv43IBZZnhs7p+Zr4w2w435idS1i2Osx/4O2IBLpxRkcDaL3VrR+v N/jw== X-Forwarded-Encrypted: i=1; AJvYcCUlvVN+JvY3k/w7n0eOYPGDV1tdt451FpY5HOrEwFaXmibgsh4yzgQjkGfUjP9Ge85A4NTsUOTk2w==@kvack.org X-Gm-Message-State: AOJu0YwhJ2ZacJC+CiRmWOcMCPDl6mXD8U80m2k9bBqS765arAFqt2IR azACsSTarBx8bgQIRVFOFWEdrMS7HaPlyiiz/5GAdRhIc+cEzEufq5CI4aCOqMo= X-Google-Smtp-Source: AGHT+IGoHYwx0kgKc4DgNgP0JzAT3h8W5Ogawl58DVURujvW6qbBVCpds5FTC6xsaK05crpycEn+DA== X-Received: by 2002:a17:90b:33c2:b0:2d8:7a3b:730d with SMTP id 98e67ed59e1d1-2e1846a0525mr238965a91.21.1727798902396; Tue, 01 Oct 2024 09:08:22 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e1d7d47sm13843973a91.28.2024.10.01.09.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 09:08:22 -0700 (PDT) From: Deepak Gupta Date: Tue, 01 Oct 2024 09:06:36 -0700 Subject: [PATCH 31/33] riscv: Documentation for landing pad / indirect branch tracking MIME-Version: 1.0 Message-Id: <20241001-v5_user_cfi_series-v1-31-3ba65b6e550f@rivosinc.com> References: <20241001-v5_user_cfi_series-v1-0-3ba65b6e550f@rivosinc.com> In-Reply-To: <20241001-v5_user_cfi_series-v1-0-3ba65b6e550f@rivosinc.com> To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com, Deepak Gupta X-Mailer: b4 0.14.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BADB2C000D X-Stat-Signature: 5gifjgsfetizngutkzoyzo64yhy4yqnt X-HE-Tag: 1727798903-378437 X-HE-Meta: U2FsdGVkX1+fALdkiGiq+ORsgvIcDD0b91vnyaMW67a9JjWYSDigu3wiz3x25oV3Ql72IliHosulP7lXXSUPFL7nKVTIa7KMeD5uS0MObmXOCDbLDs76seNLDEE7t4IQWlHe3p9bUcVNKarepUOc6rBIAb4XF07oaT25YAC36dtbg1en1XiFb16voV62oeIMWMrBuUm/xxywZjAVCFZo2YmGKk+qBWq6ORxTKQAJGIIU4erF+a1uyCqdKYmYE2HzS110D9ge+AbCf6+c4MxQB8DHi3r+D3BGBOb1WhrMAubp0pEaVioRxFMRQoprdJ+UmutOO6I79h/whfvtWnq3Hv8/XLNjWANxycqidc3YgezHzyb1Nog+QX6SV3O/ZIhqXcxKDSYAlQtVHnsTHJjfFtkNryUpZmwa/ZA/MiKTOihRYLrBBsUY7RDuv6rLt4+Eyi53YCdeH8pXHN5r1Tkrwz0l76E4X/aB5WJQ6ov0MvIHx7xWajsvP8YoJjNDxoLfPVHTaeRer76WMIAevKPIHoGG52iaDlNV2GnVbX6M+iRqZoB2tLJLy2i7aO0lXgVwKk7KKmyo+Ewr6FRrhau82isXSxz05buNMdeDCm4sY/jtSp4OvjfwWzHP3WYwoJynNDfUeAlmNTEtI+fUY6gU/NZacRhijF3S+c4e1b7LbVIUqg3cFEKEAw73ofgIU+Aw4z5FPxa0TtGCjq1gpGAQoAG0DiUjsx89WKJjdXzTtyJBVNasjCNEPG4uxet4ucQO5FdXQLLeGIj8vhJVFJNKy1WkrAspfJsjPUC+tusk7qHb1nw9tfpgwst5X4pmfw8I2RwOZiC2Jj2D/ykNFKeha7N44jKrC24w6CvmMiwHXYKyhg82OGB/JsKLtLAM1wU6pbznIw0yonBe4j6gwS+oDxGGr4CFqzzCWstI1dipED0HrUGF9r9BicDRHXViOk6eXvSgNtDLjGAbYRUlfl2 hbmDbuGf lITl39y37O6imdz7NRfcCATqfAuCL5KmTXdbBiHWjR5xkWXHGYDB5p0rA4lTMUZGOxVjgnfFlM36Gvov95VsYn7DGeEeZpZOvEGNkqNe2vv7LX0lJFLnFKnNnMRDNSHm7sa/H/98P1rD4iVS710HOts1HQW15IYoxO91mOb3ADpZm3cuQCuaTXLzSdKvv8ndQSN2mprn3j/b0jqwpmQoAjUINrpzxbzKGcWGF9aWM6yA22xRs6D6MyBjtpNhtMMz8PaILjHxa/1P9qGL3211tfqFzHUtEnm90CF8sejgiuk0LoHT4Zmg/vRP0OdQFJoU6jfKr3ZslMiyaXcbciInnacsZR8KRZ+ku4bI5gf5Qi0disHg1WEIT9WVKTvL4IHNXI4agJ0X5Ls89ZmozKq59VK3+7Ugc8ittneXQkqGrlVEEn9FB8Rnj/8yQrdTSzgonBMJd2SmW/xBowh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Adding documentation on landing pad aka indirect branch tracking on riscv and kernel interfaces exposed so that user tasks can enable it. Signed-off-by: Deepak Gupta --- Documentation/arch/riscv/index.rst | 1 + Documentation/arch/riscv/zicfilp.rst | 115 +++++++++++++++++++++++++++++++++++ 2 files changed, 116 insertions(+) diff --git a/Documentation/arch/riscv/index.rst b/Documentation/arch/riscv/index.rst index eecf347ce849..be7237b69682 100644 --- a/Documentation/arch/riscv/index.rst +++ b/Documentation/arch/riscv/index.rst @@ -14,6 +14,7 @@ RISC-V architecture uabi vector cmodx + zicfilp features diff --git a/Documentation/arch/riscv/zicfilp.rst b/Documentation/arch/riscv/zicfilp.rst new file mode 100644 index 000000000000..a188d78fcde6 --- /dev/null +++ b/Documentation/arch/riscv/zicfilp.rst @@ -0,0 +1,115 @@ +.. SPDX-License-Identifier: GPL-2.0 + +:Author: Deepak Gupta +:Date: 12 January 2024 + +==================================================== +Tracking indirect control transfers on RISC-V Linux +==================================================== + +This document briefly describes the interface provided to userspace by Linux +to enable indirect branch tracking for user mode applications on RISV-V + +1. Feature Overview +-------------------- + +Memory corruption issues usually result in to crashes, however when in hands of +an adversary and if used creatively can result into variety security issues. + +One of those security issues can be code re-use attacks on program where adversary +can use corrupt function pointers and chain them together to perform jump oriented +programming (JOP) or call oriented programming (COP) and thus compromising control +flow integrity (CFI) of the program. + +Function pointers live in read-write memory and thus are susceptible to corruption +and allows an adversary to reach any program counter (PC) in address space. On +RISC-V zicfilp extension enforces a restriction on such indirect control +transfers: + +- indirect control transfers must land on a landing pad instruction ``lpad``. + There are two exception to this rule: + + - rs1 = x1 or rs1 = x5, i.e. a return from a function and returns are + protected using shadow stack (see zicfiss.rst) + + - rs1 = x7. On RISC-V compiler usually does below to reach function + which is beyond the offset possible J-type instruction:: + + auipc x7, + jalr (x7) + + Such form of indirect control transfer are still immutable and don't rely + on memory and thus rs1=x7 is exempted from tracking and considered software + guarded jumps. + +``lpad`` instruction is pseudo of ``auipc rd, `` with ``rd=x0`` and +is a HINT nop. ``lpad`` instruction must be aligned on 4 byte boundary and +compares 20 bit immediate withx7. If ``imm_20bit`` == 0, CPU don't perform any +comparision with ``x7``. If ``imm_20bit`` != 0, then ``imm_20bit`` must match +``x7`` else CPU will raise ``software check exception`` (``cause=18``) with +``*tval = 2``. + +Compiler can generate a hash over function signatures and setup them (truncated +to 20bit) in x7 at callsites and function prologues can have ``lpad`` with same +function hash. This further reduces number of program counters a call site can +reach. + +2. ELF and psABI +----------------- + +Toolchain sets up :c:macro:`GNU_PROPERTY_RISCV_FEATURE_1_FCFI` for property +:c:macro:`GNU_PROPERTY_RISCV_FEATURE_1_AND` in notes section of the object file. + +3. Linux enabling +------------------ + +User space programs can have multiple shared objects loaded in its address space +and it's a difficult task to make sure all the dependencies have been compiled +with support of indirect branch. Thus it's left to dynamic loader to enable +indirect branch tracking for the program. + +4. prctl() enabling +-------------------- + +:c:macro:`PR_SET_INDIR_BR_LP_STATUS` / :c:macro:`PR_GET_INDIR_BR_LP_STATUS` / +:c:macro:`PR_LOCK_INDIR_BR_LP_STATUS` are three prctls added to manage indirect +branch tracking. prctls are arch agnostic and returns -EINVAL on other arches. + +* prctl(PR_SET_INDIR_BR_LP_STATUS, unsigned long arg) + +If arg1 is :c:macro:`PR_INDIR_BR_LP_ENABLE` and if CPU supports ``zicfilp`` +then kernel will enabled indirect branch tracking for the task. Dynamic loader +can issue this :c:macro:`prctl` once it has determined that all the objects +loaded in address space support indirect branch tracking. Additionally if there +is a `dlopen` to an object which wasn't compiled with ``zicfilp``, dynamic +loader can issue this prctl with arg1 set to 0 (i.e. +:c:macro:`PR_INDIR_BR_LP_ENABLE` being clear) + +* prctl(PR_GET_INDIR_BR_LP_STATUS, unsigned long arg) + +Returns current status of indirect branch tracking. If enabled it'll return +:c:macro:`PR_INDIR_BR_LP_ENABLE` + +* prctl(PR_LOCK_INDIR_BR_LP_STATUS, unsigned long arg) + +Locks current status of indirect branch tracking on the task. User space may +want to run with strict security posture and wouldn't want loading of objects +without ``zicfilp`` support in it and thus would want to disallow disabling of +indirect branch tracking. In that case user space can use this prctl to lock +current settings. + +5. violations related to indirect branch tracking +-------------------------------------------------- + +Pertaining to indirect branch tracking, CPU raises software check exception in +following conditions: + +- missing ``lpad`` after indirect call / jmp +- ``lpad`` not on 4 byte boundary +- ``imm_20bit`` embedded in ``lpad`` instruction doesn't match with ``x7`` + +In all 3 cases, ``*tval = 2`` is captured and software check exception is +raised (``cause=18``) + +Linux kernel will treat this as :c:macro:`SIGSEV`` with code = +:c:macro:`SEGV_CPERR` and follow normal course of signal delivery.