From patchwork Tue Oct 1 14:59:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danilo Krummrich X-Patchwork-Id: 13818239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D914ECEACD5 for ; Tue, 1 Oct 2024 15:02:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71CA1680017; Tue, 1 Oct 2024 11:02:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CCB0280068; Tue, 1 Oct 2024 11:02:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5464B680017; Tue, 1 Oct 2024 11:02:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 36234280068 for ; Tue, 1 Oct 2024 11:02:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6B33CC161C for ; Tue, 1 Oct 2024 15:02:09 +0000 (UTC) X-FDA: 82625348778.21.C2B52E0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 01609140029 for ; Tue, 1 Oct 2024 15:02:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nGNHafod; spf=pass (imf23.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727794886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9yF5l6xGiLdefJbiGba5mRr5YQkAiNkzw7N98/YRvog=; b=ayhNnYe9EU9z+bff0g7zzY/RKpaSEBOJ2Ti7n95a7NQPc2CsbCDcKCApGrYKfi6eNxtK4E H14ROYeFrJZdGTILmu1qSGH7Y3gNgQe+xW07ln/JwIvu1hIWi4eugJB2PMYzzD6ygK5Svu J1FT3w5hckOXHZkjNGWSesx73UaGZxg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nGNHafod; spf=pass (imf23.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727794886; a=rsa-sha256; cv=none; b=gK9uFa4by1x5PfPqJ/b2vzi/aSgMICb/dYcWq3Jk+hvI5qwoOtPB5cZT4PG1s4YvDerH5P Mz4aaRNBhDUf6bQAaGyIZBT89Tn272mFSzal+wZVM7RbN4tiCM0BckRu0hPBTFYkS38lye ASU7C/CXZ5sQVsWRmT2bNMzhVHl1Sqo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DB9CBA40147; Tue, 1 Oct 2024 15:01:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC4E8C4CED2; Tue, 1 Oct 2024 15:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727794924; bh=IBiqOJrVjNjDKaz5y8ARXywOWvCMKwjrfiOMMbLXtzM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nGNHafodq7XknYv7/i2pTAp25DC5ZK511HvP8XWsqVDW0fljOyMXC2E8Bzk/2SQYw i/fhrcH1+9qNkX7R83YjSk0N0gdFBtaFSKNq6UD/tm71Ysiss2i5Er7l7BYAEUBeyP jmYW04fCdBlEYe7YJVwe0HtA5SCbRtylWdOi59quqtD73JeJqBrPtXHsDwZDOuXEWl sJT4/31+ZdjTn+Ip9nzI91i2NozgNhdbM75CvMk/8KLSMKM7wlRQnm7oA+iZkt2rA/ mAhKhaXNjg/cJPUWSF55SVFmMXVXBfrlGRedL4wBtZ32f52zqRsuIo8YnTzVmdecnB gX/vWBQhQ5oqw== From: Danilo Krummrich To: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Danilo Krummrich Subject: [PATCH v8 20/29] rust: alloc: remove `VecExt` extension Date: Tue, 1 Oct 2024 16:59:55 +0200 Message-ID: <20241001150008.183102-21-dakr@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241001150008.183102-1-dakr@kernel.org> References: <20241001150008.183102-1-dakr@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: pogqrpgwbypbum4o4bcyhwfdnsbo6ncq X-Rspamd-Queue-Id: 01609140029 X-Rspamd-Server: rspam11 X-HE-Tag: 1727794925-552007 X-HE-Meta: U2FsdGVkX1+62HntWwxD68/yANwBaMa4R05dYrGP3ooLvpRjZ6ByDcgDAYzYX9RcYUglPJBq2S/mp32r1C3lxPDNkEMqvEihg42smM3653T1A1V053jfqsPpUw05FCjUOC0lA+HrLqe+ub1qE73yMkycUEBTHcHN4JmwP68JlTBjMq5z0Yu/fRILOuMTnerjwXlcDqpx13mUnw8S+JOGkIp13wDdRgXVFsWy9zWyDMbee/HUDC59vI9LGhLb+lgz490nY9WXkrWiU5DqFCaHa7duUaOA5ZC5lN5PzaE6xVTjPnsuZQ33t68i89il8DGWpW7xJrSkPMKlqv5ribRWIKfAJBxpETib3I9LOjuDGIMemaDZw8KgR0Oz0iaa93J0LNXXWMYiNk0pu405TG9tOcJ2pwGUa2AqfdN3yrf2X0eGs7qHh3I7jWANmBnbKfn2494J6qQJidOUTTGwhzWTDzRPniv6todLiRSL/31z7fj84vls6nF99K23u5wzt4XHe/eTKA/wcXYgnlzN7VL3BU0e/c/2RaR2gL2I+Oel9Kr7vZDDJ/x8WtXS2YsnJweR9yMqbSh7zBgsMr0EFEOuWbrLsdnw2QKEGDQaBvEuTshaW3RrIh2M37aIzMqj5v4rS9iXI/RO4SsBhPpzxGdKt8xPyEsLhc7HGrCViK8vRZt6y768fVqBSVBNnC6n3j/XFv2+t1jTNtVj1pC70pnA0vxAJTTaeKcEEfcVF11CvsozvkAP1x4vG3CJGOqXJw+gm9CyhxGmnABWbz9BaLY6q1HbFdz78SP8D83uypgNBk0CRPiR8hhU5sI6zQy4x4xwas/QIEoaapZi3ulNP4QjTuBMXH2hLQGC7ftaabv4EDs7lYWSbXxJHPgAcOurPN1yT60IvHNEJbxyjPJDM07IEyiQkg1CERk9Z05e9fqMvsl1LenYVNc+5lzO4C3GOg757SY4i8Eprz4vxApfcJJ DwcXP539 YLXoXMZWWxM6HMDB2g0cjUQCzaYEYLit2kP3YGvXI2K49TlV4rbW5fP4v7i2AJZGjF8duQkJHIjHonSnCABcqTFMCe5iGH89aEC2ozgYD9337RkKPmCtI1KaRa3wpTkVmfAG/NjbjB9vII8bRW6+opDUOJ5pmTI8HazefmAF/wvZvP/dvBHmI/k/hjo7bztPCO+w4sgN7HF7cf0fYsDtF+5J3Qw1ldDJ3aOJScTbbMSrox7XTaeCUD08Vgp7W+aHDaH+ZIFWGqD3cF/JO5KtyrC3i9+8Y/vYERkLG3Cv32hLUAdQzgmG782Tc9hmqJ3wMY1aF2XoS7qAXK5wj8Keg/z6AH8r5thbbzS9MGYXuHeXCPL2NIpRPJn7MWWdDkOUfPUJb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that all existing `Vec` users were moved to the kernel `Vec` type, remove the `VecExt` extension. Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Reviewed-by: Gary Guo Signed-off-by: Danilo Krummrich --- rust/kernel/alloc.rs | 1 - rust/kernel/alloc/vec_ext.rs | 185 ----------------------------------- rust/kernel/prelude.rs | 5 +- 3 files changed, 1 insertion(+), 190 deletions(-) delete mode 100644 rust/kernel/alloc/vec_ext.rs diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs index 1d57bfe2acb1..e8955340fe62 100644 --- a/rust/kernel/alloc.rs +++ b/rust/kernel/alloc.rs @@ -7,7 +7,6 @@ pub mod kbox; pub mod kvec; pub mod layout; -pub mod vec_ext; #[cfg(any(test, testlib))] pub mod allocator_test; diff --git a/rust/kernel/alloc/vec_ext.rs b/rust/kernel/alloc/vec_ext.rs deleted file mode 100644 index 1297a4be32e8..000000000000 --- a/rust/kernel/alloc/vec_ext.rs +++ /dev/null @@ -1,185 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -//! Extensions to [`Vec`] for fallible allocations. - -use super::{AllocError, Flags}; -use alloc::vec::Vec; - -/// Extensions to [`Vec`]. -pub trait VecExt: Sized { - /// Creates a new [`Vec`] instance with at least the given capacity. - /// - /// # Examples - /// - /// ``` - /// let v = Vec::::with_capacity(20, GFP_KERNEL)?; - /// - /// assert!(v.capacity() >= 20); - /// # Ok::<(), Error>(()) - /// ``` - fn with_capacity(capacity: usize, flags: Flags) -> Result; - - /// Appends an element to the back of the [`Vec`] instance. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// assert_eq!(&v, &[1]); - /// - /// v.push(2, GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 2]); - /// # Ok::<(), Error>(()) - /// ``` - fn push(&mut self, v: T, flags: Flags) -> Result<(), AllocError>; - - /// Pushes clones of the elements of slice into the [`Vec`] instance. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// - /// v.extend_from_slice(&[20, 30, 40], GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 20, 30, 40]); - /// - /// v.extend_from_slice(&[50, 60], GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 20, 30, 40, 50, 60]); - /// # Ok::<(), Error>(()) - /// ``` - fn extend_from_slice(&mut self, other: &[T], flags: Flags) -> Result<(), AllocError> - where - T: Clone; - - /// Ensures that the capacity exceeds the length by at least `additional` elements. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// - /// v.reserve(10, GFP_KERNEL)?; - /// let cap = v.capacity(); - /// assert!(cap >= 10); - /// - /// v.reserve(10, GFP_KERNEL)?; - /// let new_cap = v.capacity(); - /// assert_eq!(new_cap, cap); - /// - /// # Ok::<(), Error>(()) - /// ``` - fn reserve(&mut self, additional: usize, flags: Flags) -> Result<(), AllocError>; -} - -impl VecExt for Vec { - fn with_capacity(capacity: usize, flags: Flags) -> Result { - let mut v = Vec::new(); - >::reserve(&mut v, capacity, flags)?; - Ok(v) - } - - fn push(&mut self, v: T, flags: Flags) -> Result<(), AllocError> { - >::reserve(self, 1, flags)?; - let s = self.spare_capacity_mut(); - s[0].write(v); - - // SAFETY: We just initialised the first spare entry, so it is safe to increase the length - // by 1. We also know that the new length is <= capacity because of the previous call to - // `reserve` above. - unsafe { self.set_len(self.len() + 1) }; - Ok(()) - } - - fn extend_from_slice(&mut self, other: &[T], flags: Flags) -> Result<(), AllocError> - where - T: Clone, - { - >::reserve(self, other.len(), flags)?; - for (slot, item) in core::iter::zip(self.spare_capacity_mut(), other) { - slot.write(item.clone()); - } - - // SAFETY: We just initialised the `other.len()` spare entries, so it is safe to increase - // the length by the same amount. We also know that the new length is <= capacity because - // of the previous call to `reserve` above. - unsafe { self.set_len(self.len() + other.len()) }; - Ok(()) - } - - #[cfg(any(test, testlib))] - fn reserve(&mut self, additional: usize, _flags: Flags) -> Result<(), AllocError> { - Vec::reserve(self, additional); - Ok(()) - } - - #[cfg(not(any(test, testlib)))] - fn reserve(&mut self, additional: usize, flags: Flags) -> Result<(), AllocError> { - let len = self.len(); - let cap = self.capacity(); - - if cap - len >= additional { - return Ok(()); - } - - if core::mem::size_of::() == 0 { - // The capacity is already `usize::MAX` for SZTs, we can't go higher. - return Err(AllocError); - } - - // We know cap is <= `isize::MAX` because `Layout::array` fails if the resulting byte size - // is greater than `isize::MAX`. So the multiplication by two won't overflow. - let new_cap = core::cmp::max(cap * 2, len.checked_add(additional).ok_or(AllocError)?); - let layout = core::alloc::Layout::array::(new_cap).map_err(|_| AllocError)?; - - let (old_ptr, len, cap) = destructure(self); - - // We need to make sure that `ptr` is either NULL or comes from a previous call to - // `krealloc_aligned`. A `Vec`'s `ptr` value is not guaranteed to be NULL and might be - // dangling after being created with `Vec::new`. Instead, we can rely on `Vec`'s capacity - // to be zero if no memory has been allocated yet. - let ptr = if cap == 0 { - core::ptr::null_mut() - } else { - old_ptr - }; - - // SAFETY: `ptr` is valid because it's either NULL or comes from a previous call to - // `krealloc_aligned`. We also verified that the type is not a ZST. - let new_ptr = unsafe { super::allocator::krealloc_aligned(ptr.cast(), layout, flags) }; - if new_ptr.is_null() { - // SAFETY: We are just rebuilding the existing `Vec` with no changes. - unsafe { rebuild(self, old_ptr, len, cap) }; - Err(AllocError) - } else { - // SAFETY: `ptr` has been reallocated with the layout for `new_cap` elements. New cap - // is greater than `cap`, so it continues to be >= `len`. - unsafe { rebuild(self, new_ptr.cast::(), len, new_cap) }; - Ok(()) - } - } -} - -#[cfg(not(any(test, testlib)))] -fn destructure(v: &mut Vec) -> (*mut T, usize, usize) { - let mut tmp = Vec::new(); - core::mem::swap(&mut tmp, v); - let mut tmp = core::mem::ManuallyDrop::new(tmp); - let len = tmp.len(); - let cap = tmp.capacity(); - (tmp.as_mut_ptr(), len, cap) -} - -/// Rebuilds a `Vec` from a pointer, length, and capacity. -/// -/// # Safety -/// -/// The same as [`Vec::from_raw_parts`]. -#[cfg(not(any(test, testlib)))] -unsafe fn rebuild(v: &mut Vec, ptr: *mut T, len: usize, cap: usize) { - // SAFETY: The safety requirements from this function satisfy those of `from_raw_parts`. - let mut tmp = unsafe { Vec::from_raw_parts(ptr, len, cap) }; - core::mem::swap(&mut tmp, v); -} diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs index 80223cdaa485..07daccf6ca8e 100644 --- a/rust/kernel/prelude.rs +++ b/rust/kernel/prelude.rs @@ -14,10 +14,7 @@ #[doc(no_inline)] pub use core::pin::Pin; -pub use crate::alloc::{flags::*, vec_ext::VecExt, Box, KBox, KVBox, KVVec, KVec, VBox, VVec}; - -#[doc(no_inline)] -pub use alloc::vec::Vec; +pub use crate::alloc::{flags::*, Box, KBox, KVBox, KVVec, KVec, VBox, VVec}; #[doc(no_inline)] pub use macros::{module, pin_data, pinned_drop, vtable, Zeroable};