From patchwork Wed Oct 2 18:49:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13820258 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5412CEACF3 for ; Wed, 2 Oct 2024 18:50:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39C806B0403; Wed, 2 Oct 2024 14:50:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34DE16B0404; Wed, 2 Oct 2024 14:50:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129C36B0405; Wed, 2 Oct 2024 14:50:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D86716B0403 for ; Wed, 2 Oct 2024 14:50:15 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 410C1C0E67 for ; Wed, 2 Oct 2024 18:50:15 +0000 (UTC) X-FDA: 82629552390.06.2A4827E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 0D30D1A001B for ; Wed, 2 Oct 2024 18:50:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fpAwcvtX; spf=pass (imf19.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727894884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWHXEakX0NYRflUYHZvCjby4t/YakqhmOgYli6I+wPI=; b=IPZATWJdf5VO4j/wZGgqijUfTSCv780aRxlcpmd4F+zMskxAaQYvx68vmIvHrblkCvg7kV LZfZyABUabj34nsfcClERbozS8iwNtAL0GoIDcDkcXdtsDQQAwJ9CAkMckng0oLbYq+LOq 8YySLoywVaeqbdLMw2UI5SICVripV/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727894884; a=rsa-sha256; cv=none; b=oVQpkGL9zaPjbPUZ793wuf9hWtISsVnKZmhrf1d496mYcl+E34JY0R+kJX76fQ6J5Q7ajS dnN4CmePlKfu86CCccEoFlkAfHmwhEgEZX/qDZ/RBH9Yua4dlEYYWxuGWqIJq6MQwXiOnv rb0HYZzmN9Uw2wa7C9vZ701bkTq/NAg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fpAwcvtX; spf=pass (imf19.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E0D015C4590; Wed, 2 Oct 2024 18:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5535EC4CECE; Wed, 2 Oct 2024 18:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727895011; bh=FAEtrer/wxauwCEIrxfqdGNO00oW6MLUKCATzsbfXLI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fpAwcvtXD8gfXd+PRfOJ+eqsAUC72UscmwOYTBkuWJzbNNB4lEzo1BS9ykVMuQnzL I1anPto2AGBaLRz0Q+v3kDGQ8gWnGoPQTXUPSI9cfLGMpD3YnDpElJIrvmztyv6fMA QkHfGNeYclB/Qh3WRx1AfgQR0AKMYASoueR/HIBIZI1s2l9Xk2eqtyQkwL7IEI9Ego z8V83SwLi6tetczfYZ8miK3HwZNhMdeRP5cZe9WWmUP8dRbxXA09wyqwaNZdzCUj54 bJ/UxGRxJ085xIavpXrM3j0Z8mU/0QaSxe60rs/RYwR4Ab5Gul1xTwAFM43qml1b0d ry3eRS2sLlcWQ== From: Jeff Layton Date: Wed, 02 Oct 2024 14:49:35 -0400 Subject: [PATCH v9 07/12] timekeeping: add percpu counter for tracking floor swap events MIME-Version: 1.0 Message-Id: <20241002-mgtime-v9-7-77e2baad57ac@kernel.org> References: <20241002-mgtime-v9-0-77e2baad57ac@kernel.org> In-Reply-To: <20241002-mgtime-v9-0-77e2baad57ac@kernel.org> To: John Stultz , Thomas Gleixner , Stephen Boyd , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Randy Dunlap , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Chuck Lever , Vadim Fedorenko Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Jeff Layton X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4023; i=jlayton@kernel.org; h=from:subject:message-id; bh=FAEtrer/wxauwCEIrxfqdGNO00oW6MLUKCATzsbfXLI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBm/ZXMjLTfOiELFgyyDhd7gxbf4QE/JplmWCrQl HH5l56MD7SJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZv2VzAAKCRAADmhBGVaC FTH4D/kBv/Pckw5cqhCOB6dqYpa9qps2pXUNeKu2ETbMkfkS9X4q8TDcK80iM/edS2D9zjeuEAx dlLzn6rHLiWHxyauX5kFVWDTjMISqrraFxbEX9RA1FI8Kr1OIJoYof20HadOT2uApXtnswJL680 NjBU3qCtIic1QfxkOs3kfme3JJ7lS917DSFkrEuwGKGCMfV2ug44Ka+EmlyRaTHgaMMT/yjqTKT Z3ECTJCfmKPRbpbrjvphcx5vMRKpngzgPq6tlDx8qvm0hGao4wNR+cl2g4sqGFvATw4x7C/BT6v mSAESlBpjD7XWrhL2IvmIP6NjtPjknSe84QJjoJTDWpAeo6YZ1DzWja546B7NfCfS63N7KJ4l2+ SRs9p4DneuGAgiH9xMkjR6Z7CpghFFebG2X7XeOOL7Qp9GR7VMiOvH859wZlSSMT/VHQStfhySU xgzaRuUDYuuFeDmShYt4BQ4n3eprchbdIWH9FlQ6LcH16YHY2jhkCHS8EkdEIfFk/idMVsGaIuw OhTptpcKtQ7BUB7DwnZ8OTq3UykDihR1UKba07UMvN3l5JRyO883UWIqauXfGygHnzK0ZBENuFO DkEoXCUxw3nxHTNqxHzaRdKWd4xbqcNWWrf/YtQj+A1TP7lia9MoZdQJwqzhmLEUnCClCNEoQTy 57Aq63B6eJV6wUQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0D30D1A001B X-Stat-Signature: rxr6cme57335cq7bik4f8qmtmppdogh8 X-HE-Tag: 1727895012-470163 X-HE-Meta: U2FsdGVkX1/ZHlEM0cR2+LD5d4bABti7LJHuxYqQjdY3oB1Agzf3mINEqSJ4oRviDcoEWxD8mlGkqkqSp6SX1g7STHou+Y0978V05ckf7G0I3020m66DVOgdkaluRSjV+Opp4nvmfagEnB+Jtnf5MYx2n+cn5DunVb2X6SS23jKf4AsQVRHOICQrUc/f8KBIi7CFh/2mDWDbzmIAnaYFxGH5Y9vCvSnqjsLil7oyWCzsO2BHvEh1FxrpS6NdO8TJoHb0ZskQl6rf+ub6fqgMazRyM1bKnEnETtR9ejSpm9Jl8u2FjqOpy8Yb/0GQMN6724Be5+kQfEOQrWv1P4xb7wnSXMYsu74H/AsPD56rdJV4rZY/wQ0cPlloLSq/ATnOsYDpZb10EjITOQvr6dJozp7R9ZqeiNbNnUdjMVhyx0DsK8P2fvOMp3RNI/lyrR5TU69+J2ZS8neeikOybS9d/x/+B4SKRRg9Yrcnu7J7ANurxado7nOt2RaluThkHeTMcJDAdAnkrhrLMldrkd5Jk8tp263iP7Emkxz/SDorWQ3TGjlNR38c/ln2gmmLYQJ2GFmESskQ8hnofoVD+2tgi1oO+gg68j++0zbB7zFUYFAW4IJ/YK6ItKx9ShKhD7R6ud7dhaYvjDvw3kY6gBn+s4+xNdB61erwFyzf/q9Ga2CiOBW19a/n0AUv810Cf7styQaLUJtkbxZd1b53LLTHbaWhaQGSpLaDm4wy3u6nkuRzH0wINP3DWk9WC2yXndgI6uLZB8P0BeEinV1PiTgU0BCu7nJgfGKXCVx+hgaorm/+oVGvtZMakHWJ/TRNC0k/YGW24vukDfDKGPs8eNdVzb7v0eu7oyfEChuvv+HHgoNQv801yN7UVo/FzauutM4aPrIAlRPrBro4mBGyYYniJxJCmekm/OVqqfcB9Blz59NarLDT7gZsOtd5t6XHzqbhVJ01FDlAB8muJuwC42o q8O5+eJC 9eeMg2Cgch+UxKSM0zXx9lw9DcpMgio6DAAwhtORcSSNDrQZXl0uMtMuZVkeUEB9NzofkN1kI++liMoGeNfcdwSay4HHz8FGHKBt/Q446DXcRhOTQL1xkWZMdefSU4KdfMEoJslf20kasd0mt8ntyHFNOusUfsZERFn2eqCJCgUPMzMC+y1GoJxZddoPMWY7oXAsPmp921HlymTEJitAo9Rkwlp+IY1hpI7bBM4A1N0YEF7I7rqwysVNms8U9JY/YI+PkO4B9p49LZ/JF4IOUn9G9aV07s2ojq836ELqsqSAr204RmHrtRcm8Zg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The mgtime_floor value is a global variable for tracking the latest fine-grained timestamp handed out. Because it's a global, track the number of times that a new floor value is assigned. Add a new percpu counter to the timekeeping code to track the number of floor swap events that have occurred. Display that as a fourth integer in /sys/kernel/debug/multigrain_timestamps. Tested-by: Randy Dunlap # documentation bits Signed-off-by: Jeff Layton --- fs/inode.c | 5 +++-- include/linux/timekeeping.h | 1 + kernel/time/timekeeping.c | 1 + kernel/time/timekeeping_debug.c | 13 +++++++++++++ kernel/time/timekeeping_internal.h | 9 +++++++++ 5 files changed, 27 insertions(+), 2 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 0223f8ec3cfb..1edac9ab1ecc 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -145,9 +145,10 @@ static int mgts_show(struct seq_file *s, void *p) unsigned long ctime_updates = get_mg_ctime_updates(); unsigned long ctime_swaps = get_mg_ctime_swaps(); unsigned long fine_stamps = get_mg_fine_stamps(); + unsigned long floor_swaps = timekeeping_get_mg_floor_swaps(); - seq_printf(s, "%lu %lu %lu\n", - ctime_updates, ctime_swaps, fine_stamps); + seq_printf(s, "%lu %lu %lu %lu\n", + ctime_updates, ctime_swaps, fine_stamps, floor_swaps); return 0; } diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h index 7aa85246c183..84a035e86ac8 100644 --- a/include/linux/timekeeping.h +++ b/include/linux/timekeeping.h @@ -48,6 +48,7 @@ extern void ktime_get_coarse_real_ts64(struct timespec64 *ts); /* Multigrain timestamp interfaces */ extern void ktime_get_coarse_real_ts64_mg(struct timespec64 *ts); extern void ktime_get_real_ts64_mg(struct timespec64 *ts); +extern unsigned long timekeeping_get_mg_floor_swaps(void); void getboottime64(struct timespec64 *ts); diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index ebfe846ebde3..e8b713e8ce55 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -2488,6 +2488,7 @@ void ktime_get_real_ts64_mg(struct timespec64 *ts) if (atomic64_try_cmpxchg(&mg_floor, &old, mono)) { ts->tv_nsec = 0; timespec64_add_ns(ts, nsecs); + timekeeping_inc_mg_floor_swaps(); } else { /* * Another task changed mg_floor since "old" was fetched. diff --git a/kernel/time/timekeeping_debug.c b/kernel/time/timekeeping_debug.c index b73e8850e58d..b731621ad811 100644 --- a/kernel/time/timekeeping_debug.c +++ b/kernel/time/timekeeping_debug.c @@ -17,6 +17,9 @@ #define NUM_BINS 32 +/* incremented every time mg_floor is updated */ +DEFINE_PER_CPU(unsigned long, timekeeping_mg_floor_swaps); + static unsigned int sleep_time_bin[NUM_BINS] = {0}; static int tk_debug_sleep_time_show(struct seq_file *s, void *data) @@ -53,3 +56,13 @@ void tk_debug_account_sleep_time(const struct timespec64 *t) (s64)t->tv_sec, t->tv_nsec / NSEC_PER_MSEC); } +unsigned long timekeeping_get_mg_floor_swaps(void) +{ + int i; + unsigned long sum = 0; + + for_each_possible_cpu(i) + sum += per_cpu(timekeeping_mg_floor_swaps, i); + return sum < 0 ? 0 : sum; +} + diff --git a/kernel/time/timekeeping_internal.h b/kernel/time/timekeeping_internal.h index 4ca2787d1642..f53e76d5ee7c 100644 --- a/kernel/time/timekeeping_internal.h +++ b/kernel/time/timekeeping_internal.h @@ -10,9 +10,18 @@ * timekeeping debug functions */ #ifdef CONFIG_DEBUG_FS +DECLARE_PER_CPU(unsigned long, timekeeping_mg_floor_swaps); +static inline void timekeeping_inc_mg_floor_swaps(void) +{ + this_cpu_inc(timekeeping_mg_floor_swaps); +} + extern void tk_debug_account_sleep_time(const struct timespec64 *t); #else #define tk_debug_account_sleep_time(x) +static inline void timekeeping_inc_mg_floor_swaps(void) +{ +} #endif #ifdef CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE