From patchwork Fri Oct 4 15:41:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danilo Krummrich X-Patchwork-Id: 13822631 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B6BCF884B for ; Fri, 4 Oct 2024 15:43:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8526B00F2; Fri, 4 Oct 2024 11:43:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B322C6B00FE; Fri, 4 Oct 2024 11:43:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AA586B00FF; Fri, 4 Oct 2024 11:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 75F2F6B00F2 for ; Fri, 4 Oct 2024 11:43:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2BBD01C6BE7 for ; Fri, 4 Oct 2024 15:43:58 +0000 (UTC) X-FDA: 82636340556.22.E88CFF9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 5BD61180014 for ; Fri, 4 Oct 2024 15:43:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Eoyarmk2; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728056540; a=rsa-sha256; cv=none; b=6+93JcTX5WyDzqjKaRZCTEVbe0rs+clHYqr08WJsIfue+FixYbFt7L/YZ/Bi+OHbpoQ7YK gFMRJyv0/EjUQenPdrUA0bw8NqMRIzbpgFP9WaRpAPA7HB+vZ2ouOZSEOxwYXiyK5Bqr+b YRrsdyocxls8PWvnmB38Q+argAX3OPk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Eoyarmk2; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728056540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9yF5l6xGiLdefJbiGba5mRr5YQkAiNkzw7N98/YRvog=; b=eXywVDQqUoJh+jrjGxVCUXxWKywT+4KbbxBrexmrT6xQ1kt4ZCEL8bNJ3nBRLbLeUqk27T 0f4F9wK0lVV3ad6XUzt1ozz2GidrfkUcnUOUSxJexVXAnzXqrJG7+qQLwtTgGiQrP607kj 0mws+NQbq+ft8L/VQROY79YzfwYmpPs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 20DFA5C5DBF; Fri, 4 Oct 2024 15:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F8FEC4CEC6; Fri, 4 Oct 2024 15:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728056634; bh=IBiqOJrVjNjDKaz5y8ARXywOWvCMKwjrfiOMMbLXtzM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eoyarmk2KG+SUowJp1Ym3nmczdQguqMr0OdYG7jPc+BocVKELOy8LxEfTgsE0tCkr vQFSiX5Al0/2nZGX+YX/CN2ALD6iKOcaMI+jhF/QaqftyRR3HgtKeGIa66ouPwtc9l xj8JDKWOH+votd53/VlKzJkOFMBTM0uIIqIl/SJQZphZ4WYMTg8O12Uv6gfc/96l0U 61hS72Nae9c1eBYKHK89CtolEehenOPW9u6JhYWCIZKD0mRbEPTzWf6mI7SWxAN6no sEJq5k938MgzzxC465odYDYyPopbvfh1vYZXbO3wEBq9QCvpvpVtvIJIziKW2cTq5J uEsB/gO7OfdZg== From: Danilo Krummrich To: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Danilo Krummrich Subject: [PATCH v9 20/29] rust: alloc: remove `VecExt` extension Date: Fri, 4 Oct 2024 17:41:24 +0200 Message-ID: <20241004154149.93856-21-dakr@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20241004154149.93856-1-dakr@kernel.org> References: <20241004154149.93856-1-dakr@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 5BD61180014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w7t8ctwjw3irk1ee5nd8974b6x8km7nh X-HE-Tag: 1728056636-435250 X-HE-Meta: U2FsdGVkX19MpIjH9+sMMZUXRC7hEqpcOiTPP3z3XMyFRxXPhAfyN8OFkwxceWmzQwyhXb7tBgHTC+Tgiv0Vf2qkx9sfHHofVZO+aSfta6VGTOxYEqqBpyDpF53HSVzl0BEQjUF0LqazfPiuKLUoPtpja1RFIuTyEaG6tG+bCLOX7NG/RuVfGhR7Py1MzUMPp4wvGY8lsP5ZsdiBUjqpvHQJ3XYoPx/jDO4JW/4Z5T4M1Ufu0rY/6lpkAhezYNEniE1w/y4RwheUu3o3ypZo1TcAvdOH4I5J+/E4lIbkJqaWXHceVLDZkwKI3baET+n5YDT0ctKkY/NxtilcrI720GYLkf3QNgyM1qy9ZocUMJ0qzUOvjAqVQspsIQgezhv/Kd8QgEDLe7ZmFojBOGoLyEHFYWYKXPKD459tYzwv/ar83fewK8+1fyl/8HR1T6X/76fvb18yEeArIn1QL4M+Bd5CJWWKtMU0Nx9nynbhoCYhyq0eaGzo7gNo668RcfyMqPCFUuLgGS+HPOOzANeCxb+7b5VNAG6liaX5893IERr5jLUIt8Uaonbej1rV9/xJsXRKVQ3FX95y8S0xQqIklf4xzT46k3zyea5CM+Iatxr/uvbsz04e75nfRWFR3iAGssIDvR8vExXGDLY5sCCre4CD0sm/u8nGAZFK5A937OwVc6cGjSU9a5NNZ3FHScWP8hZ4YwLlplGd0tnT34dW2wFgeKoxxHvWO9+n8qIj/HaJ3xKGdpowl3WMqGyLJbQl61+n5EuD0O/ehX9+GzuDqu+gOOPGmunZLh+lJRJrtsvW4r1xCfxmjYbItsUL36vVTJtwGWKawf8GXnk9cEOkF04Q5VTx21uQJOKvlJUKLD8clizGrUsl6DUAX0Sxt0U+EZPI/ej6oYil1Sv7blKHA3WYqgajIGWSRaYtDXm9DEGUvQvJhWBdxGWZepA0sdLlXWMnmGQwScq/ff2E44a jJr5BPsX 0E8PHGz7fRiaECQJADHOAj+ZAdBneWk6/iMVFOuFhHlEwGYmzvA0mIkuSJCwfGXuINjaNIEuursuSFQhHqCR+260g3mFdLU4tY5Tk+DAo8g4DZ/1NfrXpeMK6ftZzHVUiX01UyReghY031r/JbzWScV5YsFivTxo5dXt9At1CElsemgjMklPhhhu3shw3Vf8GuZO75PSTGjr+nWKMFJp6uQMSahUEc3diWuFOSbDZpzYI9wU2VR3HmMIFybqZzwuxG1KUPMl1S4+YVDKFOMuRRws6G3Mli0I6xMUS/DvwyvvKlZ0ouQrTaU2w16Yl5ljRFWsLOrIJ/nKI3iYrtwJ+/4ugP7zkc3KOS4Vj/WjW09EHvLX0umVlHApvjjPgNIUDdk5E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that all existing `Vec` users were moved to the kernel `Vec` type, remove the `VecExt` extension. Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Reviewed-by: Gary Guo Signed-off-by: Danilo Krummrich --- rust/kernel/alloc.rs | 1 - rust/kernel/alloc/vec_ext.rs | 185 ----------------------------------- rust/kernel/prelude.rs | 5 +- 3 files changed, 1 insertion(+), 190 deletions(-) delete mode 100644 rust/kernel/alloc/vec_ext.rs diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs index 1d57bfe2acb1..e8955340fe62 100644 --- a/rust/kernel/alloc.rs +++ b/rust/kernel/alloc.rs @@ -7,7 +7,6 @@ pub mod kbox; pub mod kvec; pub mod layout; -pub mod vec_ext; #[cfg(any(test, testlib))] pub mod allocator_test; diff --git a/rust/kernel/alloc/vec_ext.rs b/rust/kernel/alloc/vec_ext.rs deleted file mode 100644 index 1297a4be32e8..000000000000 --- a/rust/kernel/alloc/vec_ext.rs +++ /dev/null @@ -1,185 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -//! Extensions to [`Vec`] for fallible allocations. - -use super::{AllocError, Flags}; -use alloc::vec::Vec; - -/// Extensions to [`Vec`]. -pub trait VecExt: Sized { - /// Creates a new [`Vec`] instance with at least the given capacity. - /// - /// # Examples - /// - /// ``` - /// let v = Vec::::with_capacity(20, GFP_KERNEL)?; - /// - /// assert!(v.capacity() >= 20); - /// # Ok::<(), Error>(()) - /// ``` - fn with_capacity(capacity: usize, flags: Flags) -> Result; - - /// Appends an element to the back of the [`Vec`] instance. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// assert_eq!(&v, &[1]); - /// - /// v.push(2, GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 2]); - /// # Ok::<(), Error>(()) - /// ``` - fn push(&mut self, v: T, flags: Flags) -> Result<(), AllocError>; - - /// Pushes clones of the elements of slice into the [`Vec`] instance. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// - /// v.extend_from_slice(&[20, 30, 40], GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 20, 30, 40]); - /// - /// v.extend_from_slice(&[50, 60], GFP_KERNEL)?; - /// assert_eq!(&v, &[1, 20, 30, 40, 50, 60]); - /// # Ok::<(), Error>(()) - /// ``` - fn extend_from_slice(&mut self, other: &[T], flags: Flags) -> Result<(), AllocError> - where - T: Clone; - - /// Ensures that the capacity exceeds the length by at least `additional` elements. - /// - /// # Examples - /// - /// ``` - /// let mut v = Vec::new(); - /// v.push(1, GFP_KERNEL)?; - /// - /// v.reserve(10, GFP_KERNEL)?; - /// let cap = v.capacity(); - /// assert!(cap >= 10); - /// - /// v.reserve(10, GFP_KERNEL)?; - /// let new_cap = v.capacity(); - /// assert_eq!(new_cap, cap); - /// - /// # Ok::<(), Error>(()) - /// ``` - fn reserve(&mut self, additional: usize, flags: Flags) -> Result<(), AllocError>; -} - -impl VecExt for Vec { - fn with_capacity(capacity: usize, flags: Flags) -> Result { - let mut v = Vec::new(); - >::reserve(&mut v, capacity, flags)?; - Ok(v) - } - - fn push(&mut self, v: T, flags: Flags) -> Result<(), AllocError> { - >::reserve(self, 1, flags)?; - let s = self.spare_capacity_mut(); - s[0].write(v); - - // SAFETY: We just initialised the first spare entry, so it is safe to increase the length - // by 1. We also know that the new length is <= capacity because of the previous call to - // `reserve` above. - unsafe { self.set_len(self.len() + 1) }; - Ok(()) - } - - fn extend_from_slice(&mut self, other: &[T], flags: Flags) -> Result<(), AllocError> - where - T: Clone, - { - >::reserve(self, other.len(), flags)?; - for (slot, item) in core::iter::zip(self.spare_capacity_mut(), other) { - slot.write(item.clone()); - } - - // SAFETY: We just initialised the `other.len()` spare entries, so it is safe to increase - // the length by the same amount. We also know that the new length is <= capacity because - // of the previous call to `reserve` above. - unsafe { self.set_len(self.len() + other.len()) }; - Ok(()) - } - - #[cfg(any(test, testlib))] - fn reserve(&mut self, additional: usize, _flags: Flags) -> Result<(), AllocError> { - Vec::reserve(self, additional); - Ok(()) - } - - #[cfg(not(any(test, testlib)))] - fn reserve(&mut self, additional: usize, flags: Flags) -> Result<(), AllocError> { - let len = self.len(); - let cap = self.capacity(); - - if cap - len >= additional { - return Ok(()); - } - - if core::mem::size_of::() == 0 { - // The capacity is already `usize::MAX` for SZTs, we can't go higher. - return Err(AllocError); - } - - // We know cap is <= `isize::MAX` because `Layout::array` fails if the resulting byte size - // is greater than `isize::MAX`. So the multiplication by two won't overflow. - let new_cap = core::cmp::max(cap * 2, len.checked_add(additional).ok_or(AllocError)?); - let layout = core::alloc::Layout::array::(new_cap).map_err(|_| AllocError)?; - - let (old_ptr, len, cap) = destructure(self); - - // We need to make sure that `ptr` is either NULL or comes from a previous call to - // `krealloc_aligned`. A `Vec`'s `ptr` value is not guaranteed to be NULL and might be - // dangling after being created with `Vec::new`. Instead, we can rely on `Vec`'s capacity - // to be zero if no memory has been allocated yet. - let ptr = if cap == 0 { - core::ptr::null_mut() - } else { - old_ptr - }; - - // SAFETY: `ptr` is valid because it's either NULL or comes from a previous call to - // `krealloc_aligned`. We also verified that the type is not a ZST. - let new_ptr = unsafe { super::allocator::krealloc_aligned(ptr.cast(), layout, flags) }; - if new_ptr.is_null() { - // SAFETY: We are just rebuilding the existing `Vec` with no changes. - unsafe { rebuild(self, old_ptr, len, cap) }; - Err(AllocError) - } else { - // SAFETY: `ptr` has been reallocated with the layout for `new_cap` elements. New cap - // is greater than `cap`, so it continues to be >= `len`. - unsafe { rebuild(self, new_ptr.cast::(), len, new_cap) }; - Ok(()) - } - } -} - -#[cfg(not(any(test, testlib)))] -fn destructure(v: &mut Vec) -> (*mut T, usize, usize) { - let mut tmp = Vec::new(); - core::mem::swap(&mut tmp, v); - let mut tmp = core::mem::ManuallyDrop::new(tmp); - let len = tmp.len(); - let cap = tmp.capacity(); - (tmp.as_mut_ptr(), len, cap) -} - -/// Rebuilds a `Vec` from a pointer, length, and capacity. -/// -/// # Safety -/// -/// The same as [`Vec::from_raw_parts`]. -#[cfg(not(any(test, testlib)))] -unsafe fn rebuild(v: &mut Vec, ptr: *mut T, len: usize, cap: usize) { - // SAFETY: The safety requirements from this function satisfy those of `from_raw_parts`. - let mut tmp = unsafe { Vec::from_raw_parts(ptr, len, cap) }; - core::mem::swap(&mut tmp, v); -} diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs index 80223cdaa485..07daccf6ca8e 100644 --- a/rust/kernel/prelude.rs +++ b/rust/kernel/prelude.rs @@ -14,10 +14,7 @@ #[doc(no_inline)] pub use core::pin::Pin; -pub use crate::alloc::{flags::*, vec_ext::VecExt, Box, KBox, KVBox, KVVec, KVec, VBox, VVec}; - -#[doc(no_inline)] -pub use alloc::vec::Vec; +pub use crate::alloc::{flags::*, Box, KBox, KVBox, KVVec, KVec, VBox, VVec}; #[doc(no_inline)] pub use macros::{module, pin_data, pinned_drop, vtable, Zeroable};