From patchwork Mon Oct 14 10:58:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13834687 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC610D1A443 for ; Mon, 14 Oct 2024 11:00:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B93B6B00A5; Mon, 14 Oct 2024 07:00:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640B06B00A6; Mon, 14 Oct 2024 07:00:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50A7E6B00A7; Mon, 14 Oct 2024 07:00:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 29D2F6B00A5 for ; Mon, 14 Oct 2024 07:00:28 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5681680D3C for ; Mon, 14 Oct 2024 11:00:21 +0000 (UTC) X-FDA: 82671913884.01.AC6E779 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 39080C001B for ; Mon, 14 Oct 2024 11:00:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728903484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P0Pjm4UAl0+EiWZfuspcZJKa6yxJiEhvXEi1XSb1a9E=; b=f+P+eNTpte7FBcNbMV/9MYU6AIXPjzaMKrGwGIzQtcMBYJqMuuL3MY/ULFa4qwMAQ3DZrx VoKDlrwOP5CzO8/hN22poY/tTivCga4S5lK+540ipd3m3WvH9GTweRT6FuGxh4KtekvzY1 i6fQw0Od81Xc0XApdUdA7IG/3hb6JNM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728903484; a=rsa-sha256; cv=none; b=R1firzMuTrgLMLQdwRn9VHzEA//NKsPaTywLlDi8U9mhqEX70Z74atSVd6536owN1xDXA9 lZR1+5Avo3QIgMx8+Gh2XV4F0vEZqClI03vH8EWv/lLKaiZTL7XD3Wwcg41IjHFm6hgMs8 UM+mLDtvWKwp1fh1N/NiDKPo6DqjOrk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5428F1684; Mon, 14 Oct 2024 04:00:55 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16F953F51B; Mon, 14 Oct 2024 04:00:22 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Baoquan He , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon Cc: Ryan Roberts , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1 19/57] crash: Remove PAGE_SIZE compile-time constant assumption Date: Mon, 14 Oct 2024 11:58:26 +0100 Message-ID: <20241014105912.3207374-19-ryan.roberts@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241014105912.3207374-1-ryan.roberts@arm.com> References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Stat-Signature: e5p3dimteztp8tzkwrdkfce7mhaishbp X-Rspamd-Queue-Id: 39080C001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728903619-703064 X-HE-Meta: U2FsdGVkX1/7I7EIzXv0173+V3YbT3Ii51s0coBb2IesasK92lWn1pYcsg0pX5iMyS4ExOWA0hHeJAYDKS4TZYPhBffVmXUeNpiv3JSsuXmCnlgBtsvtuznoL0g/+CzuyPOJJ8ZgRQbnYphWCYd/yUIHoISerrC2JZrdP77zWlrTRmARM9d/KC8AaCo3cGqC9xzJWxhydcV7IPfSYeuXX6OOOFamZr1AQuHhMjggiQm98kP9pg4vTY3NhBJppmLzc5hswbB6yHTHz5lR3/7ADC4MrBOBm1US5i35I/mciHUmZRpN/BMeK0xxjK6A0jitYp4ZQQKGV/f8FXG/u//htewz9iLBJ3MrFaF8hzgPw8kjKE7wCEJM71oyNwy3d+bfc+5fNc4kyxF3DcZzPcQHNEM7FiErFTlZIR6xqOg6u2h5KpT6VFCIQeahh2cRcjgjoa3d2yn8mpqDeIkz1NapAnJFJVy8f6wzQcRaKnWsR1oPKfj4n9suFxUvc9JHQY5x9cm7ABtNbESyuqPWPaltF2h25ginHOFBJFUGdBI7V9D9A8pwzImZHhWr0N9zrDvek0wtE1SCtsiDFHbXFP3ERNXGqcgDhhP6BrRu/VRIHmhDZD9FWKrXl3hKy9/VpQIezlViry0/DDpvudFIJ2L76RUkl98/FPBy1MLCcfj4fAsKyTViC5+VS/2ppKM9nODll2otFQgR41hLoTYe9bTxcfY8TbR4zuGMNMSTU8+b7mtZ8TBUcd9tEfNmQXlebqiwMRBhNTcrF11sEta95HImYox8JyRYQlsksB8NiA6fkB+mKn4Po7Aq1YHHusG5MbwCMCH2T5azCGS3u7u6TkO1TDniZwX9z6H9eSn+f3zrJW7DRsIpDNR97i7IC3fja+m0R7+wwLB/TQoSae90sur2A/ljY+4PBfZTiYs7Prj98TGZyarMnNkZG1bzhtDovs+QNl+jH/qoYTboQOk3sSh ihqHeJSD yQHkLA8EURflE1HZajmk6D3rAXjfgJuCYMOR7FuT3cOGnLNo91Is8okPzNv0FSNGZ4OrZ4lrCVqzty+3AoK72XSmIeHJPTD/tMwqouPK0Tmr91JfXoxlAVx62bHzvFrLtCOVkFdQaLBBD6jmM6BRdIbF3GPmbAM7Ky4KZ65bpQvv9YMnOB4cRcoQVoIOQi42cZ90HQOPZAI1R/aK86MIPzyDYtbCsJyTZz2EQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To prepare for supporting boot-time page size selection, refactor code to remove assumptions about PAGE_SIZE being compile-time constant. Code intended to be equivalent when compile-time page size is active. Updated BUILD_BUG_ON() to test against limit. Signed-off-by: Ryan Roberts Acked-by: Baoquan He --- ***NOTE*** Any confused maintainers may want to read the cover note here for context: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ kernel/crash_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 63cf89393c6eb..978c600a47ac8 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -465,7 +465,7 @@ static int __init crash_notes_memory_init(void) * Break compile if size is bigger than PAGE_SIZE since crash_notes * definitely will be in 2 pages with that. */ - BUILD_BUG_ON(size > PAGE_SIZE); + BUILD_BUG_ON(size > PAGE_SIZE_MIN); crash_notes = __alloc_percpu(size, align); if (!crash_notes) {