From patchwork Thu Oct 17 14:25:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13840113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD51D374A2 for ; Thu, 17 Oct 2024 14:25:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A8E36B0085; Thu, 17 Oct 2024 10:25:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 757E16B0088; Thu, 17 Oct 2024 10:25:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 629DA6B0089; Thu, 17 Oct 2024 10:25:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 33B396B0088 for ; Thu, 17 Oct 2024 10:25:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 580051C72D3 for ; Thu, 17 Oct 2024 14:25:22 +0000 (UTC) X-FDA: 82683317220.18.EE4A3F3 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf03.hostedemail.com (Postfix) with ESMTP id C2A4820003 for ; Thu, 17 Oct 2024 14:25:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729174987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=XUp1MsaxdMLoBfMlgArenmiFJ9md4P9fe8wZYAf0hOY=; b=ckLjyfhAQ8WsAANgBlW4vS1UmGN7AYAPU4+yv1KPXWKA8Jla+RBG7EiprdztNDarfMiTGb ixkqv3h1fuz2c6M7owPR+Is1t/8fQRhKuv9HAc6eb+0Kk9+jZ2urGBOapDSOZatsOmetSv 11UHlq2qzH6iCQUhVYJgBTJ0GABT4V0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729174987; a=rsa-sha256; cv=none; b=wc01w4hJ/8arPH2OUwFlGanjSHKR8c+jfGpZ1Vmo32S6uskQYWll8Dzn2iqvIa21OD0kCA vnx6i6bf6WY6CQN/ZQ5tV9JM2bXjXg70ZTE7OE4/0CH2/ImFr3/AGc0puAoWShJenjmIuS mM7l+mwAO5DH+AWC4gPjuZV4yGQqR7k= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4XTqnd6z9Pz1T8gt; Thu, 17 Oct 2024 22:23:33 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id F3EFB18009B; Thu, 17 Oct 2024 22:25:27 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 17 Oct 2024 22:25:27 +0800 From: Kefeng Wang To: Andrew Morton , Hugh Dickins CC: David Hildenbrand , Baolin Wang , Matthew Wilcox , , Kefeng Wang Subject: [PATCH] mm: shmem: avoid repeated flush dcache in shmem_writepage() Date: Thu, 17 Oct 2024 22:25:03 +0800 Message-ID: <20241017142504.1170208-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C2A4820003 X-Stat-Signature: zoedfounk417osxtrcxbaunzu3zsxn5x X-HE-Tag: 1729175126-913103 X-HE-Meta: U2FsdGVkX18oI6aImF9BYqQToUNmcCceLjv1mU7wuvJw8ZzMtltGhqYL/8ShuW6QQiXxiCk/FBjx5vsvk8xFQuuaBjoNa35EPW0legyHCnv1Vk9gwIOr/gNIsNZ2CkASWUaed/gJp+PHm/oXMLQ0/O86Zcyk+mIjfnPydkWDwsUTYu+UqFt7FX7LMcj0vxJ1kv1Ws39q30bDqUD0odvL0ZamXdewEA4MGxv8s6s80uzwHZOEG/HxeOy2DUgpnEfcNWHUvjBJdBBPWuzeNWLD4qvROL0CF+EJe2IicsUdGFYyzt05Shdf13VPL90w0dH/PBa1ZS5XfwnKqtZvf6lVFT59h7CKAd/t2xuwY+ynyO84aqxl7JFU0KMgEltR4Evz0j4uE2A3H7O6e44EeRwKqrVPywT/oUVnH8hNz3IopdtudGUjDAp+5NqDbwx1xGb6QoybJi+Majh3KG5nvoRUSHfckIVACvUJl1KmZm3SWHsTaPa4+Dj0rtiDRsmGq5CJP4Xuc/T4f+yxVPVo62b23yOnVu09cbsw8egpHybZON6bv0hFz+o1C2PkRxenNbAoEOg/7+vjr6H05SZVRmWNTB79L3F6iUVUAsukaycArPC9g2Un/Cdzb/DtKdEVwQ5kXwrB5X4fnxoaXD565P8N2YBTJxfRU6FVgPCnIhS+qT0YEQjfkg9xjW2L7VdcNSrK4yLZ/ySfvhbuTsoG0mxEALYCvL4eCMVLAhuvDh2u1cvIR0YH8srMyA7+9lAEuhtdxz55a9qpplmpKo2Keg0l7OF/wZXFAiigvuVR2Tv9MeLqbfp8T+SsrCK9fPv5LyfSl5ESZY8hSwhTs87AAK8tTyNlvkRLCPTo9sugk1OG1VlhntBReAQ96gfxnfgBCxXgStdc4/AOsV/N8+/FAF7oKwfVIvLijw5f8//MiQwVXmmkVmm+kywXQ7/X12omnO00zJetmRedlg10UN5osEB gCKFiCAl cYK1Rza6L2Jy7xK2HDmjls4xPhhjyTGsU7ndaVc+4r6szr74oVdDfjCNo5cIfMRewFsqUPg7Ui/8Yv/OQqdxXo3wt63r6iE9eMO0Wqew6UdqlZ4VBu45yjjSfTht5vb3Gtef8bYg2wQrhnXny2m9LDSx8D2gV0/CztQUAYzzQXBU1ZLS+ULErXqbdHL/6jWVXQexI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio_zero_range() already flush dcache inside, so remove another flush_dcache_folio() in shmem_writepage(). Fixes: f530ed0e2d01 ("shmem: convert shmem_writepage() to use a folio throughout") Signed-off-by: Kefeng Wang --- mm/shmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 163ca6107bbd..bd5ba016567d 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1533,7 +1533,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) goto redirty; } folio_zero_range(folio, 0, folio_size(folio)); - flush_dcache_folio(folio); folio_mark_uptodate(folio); }