From patchwork Mon Oct 21 16:37:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 13844437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6496BD15DBB for ; Mon, 21 Oct 2024 16:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8552D6B008C; Mon, 21 Oct 2024 12:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 804DA6B0092; Mon, 21 Oct 2024 12:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A56F6B0095; Mon, 21 Oct 2024 12:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4BD266B0092 for ; Mon, 21 Oct 2024 12:37:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 321251619B0 for ; Mon, 21 Oct 2024 16:37:35 +0000 (UTC) X-FDA: 82698165732.11.EE83C32 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf23.hostedemail.com (Postfix) with ESMTP id 43219140005 for ; Mon, 21 Oct 2024 16:37:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=htpsQRv8; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf23.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729528620; a=rsa-sha256; cv=none; b=t9NnJC/2C2AMNQB2FOhi2k+JOrkDGhMu8ljBqAgz+baDHhKjoUhWfyn4UO+DeaCCLiXXv4 W5O+7US2/GOOS7/Gk/X32sGlIimS2EZeqjq0xLAh5G3cvRvzmJ5dK4J4FU+v5E1nqx7eCy v3ivD7FMBUjpIOxr+o2akFQv7Ufvn+o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=htpsQRv8; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf23.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729528620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdXGjKgs/rhRe8l19F01/brI44jeC/ablpb8vlTIOo4=; b=exgKWhGMK+HOt9e1k0pi3WZ8xEK7cyZvcb+J8dBatAIVY8An6oBS/Ik4dlWak5NKKAT2A6 3BsBBQ1T2AJnc9B00KGypaMr7SULk+Rp/Of+G0ejSCQWBYPvc9XpbWX+TZVLnwWmxa+36g C/k5RIFZQrAvu0ickS8ALlxKQiGUjWk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sdXGjKgs/rhRe8l19F01/brI44jeC/ablpb8vlTIOo4=; b=htpsQRv8/js4yHpaG1piv1c4Hv NHNUWc+pkc3mBPO5T68D4cNjjpjP0Rl7v1cJ+4EWzTVdbfawo8BtBEnSbSYAUIa3pAWQQpPf+sA47 6mj33mGgynQTvSiBvpJKx67Rb3MMNAPQJZEfNohKIpuWtoYcjtnjHpUEiFqfm4Q5v8jygXKZb4Htx EddtzcoEllFmljbnX6S5FAO+goy7Gu+iw+wisXgV8l9hLVLbP3Qa+oLNQGFZ2o5fm3MPgnnIhwvw/ OZsrCCBNfJ+daFre0ewfTcDWzFDOlxtDb22Q3LZemdwcmeqQalNya0XkOzAseXR8zPy9Rx4hYmWFf 4i8Eg/RA==; Received: from [191.204.195.205] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1t2vPe-00DECf-OQ; Mon, 21 Oct 2024 18:37:46 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= Date: Mon, 21 Oct 2024 13:37:18 -0300 Subject: [PATCH v8 2/9] ext4: Use generic_ci_validate_strict_name helper MIME-Version: 1.0 Message-Id: <20241021-tonyk-tmpfs-v8-2-f443d5814194@igalia.com> References: <20241021-tonyk-tmpfs-v8-0-f443d5814194@igalia.com> In-Reply-To: <20241021-tonyk-tmpfs-v8-0-f443d5814194@igalia.com> To: Gabriel Krisman Bertazi , Alexander Viro , Christian Brauner , Jan Kara , Theodore Ts'o , Andreas Dilger , Hugh Dickins , Andrew Morton , Jonathan Corbet , smcv@collabora.com Cc: kernel-dev@igalia.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Gabriel Krisman Bertazi , =?utf-8?q?Andr=C3=A9_Almeida?= X-Mailer: b4 0.14.2 X-Rspam-User: X-Rspamd-Queue-Id: 43219140005 X-Rspamd-Server: rspam01 X-Stat-Signature: mqkma8b4db6t3heeea8yz8c11kbm71nb X-HE-Tag: 1729528661-273708 X-HE-Meta: U2FsdGVkX1991eeELr1L0oNkXv+4buanhAOyrcGwm4HcqSdHEokciExt8OJQjD06oFqu72cwZYCAyi7d/xCRmlU+4RcqNKIJVfc8/SSJ0rslb4n8eCfee2XSqQDx9gHjkMaaoyB7XFLKCiwSjhzh89+QCyO6w2nY+buVqapAMXWrEzTVeAdeg1iXdTiF5zY2vHRCmfhV9ffltLSWO00aFcUOZynlG/bn3WFQtApHIy9YBitAE47PwHI7YVL4zJy/oc/g+fgTOAmZ7tNoZE3dEH6/2gv39HxaTscChXaWdG6dUK4pVvgAyG7elRECLMRXU50acXIGZsBLEggyNa8A9ztLhCCdZQjqyJyFgk+Fg3HbLXLy45mac8OCdUGZRUcb9TfhqnQd4qFSNJ+/8D/pbsNCAf9BIOq0pubDMbjpy55uokSgZzyjsbTmYroeattP7Nm+XOyQRDkQHISQQhs8zA1SVBlSewFhrpkHPCmaXXNNT9mrIvah7WS8ZhIbJyYQ6Mk+U78lWlwr/kVYSgL7CoioG7JxJH56hguR5TSqBA9qKw+G3i7BGMzapzI5u0GkYlbm6kPpIwyK4B4eVoYrGFRV0h5plQB5mPtrHHe6HvA4Mk6IbIQT5TEv6EIMqKOAiGFDFMdg6E3ioGnN216DMpC0qTZ6XIMs1aFdMwsvVHYypFHNIg8vwPZkvvUbw3qHS5eGkd62rbV4Og3BxTcKT+b8b4rBa/7BVUkOTYGILkd5y25cbzMiwV2AHCHKMGJPyA+U92NWoRnsrkXxfNEeIfc3Vh53am6hUgbyS0dqn+qZOTgmgqYSsUmgf2vCPHkRqvgXt8mki8oVm1s8mI7mNw/DZdjtZEOECZv06r6NchGcze1z65gCwA17NPQ6gAnwFJZAaFZUpZtn66G4oXXoBAHoHpzrbJsRkWgPdvgm0xTB++y2VzMJw7Ok55ni8Rw4uImnob1ENcRWcY7cM/g kko9xPUO 57MEv+5njSg3DBNkUCHCS4Zr9mBxA0c19BrGUlg03Vae9f7f6q25f1o6N4/Xx0zHtJj/w7BDkhu7KA5RcmRwqxqwKjx6aGw4d0nVximjyMtzJlALyqcmiaKHtVRw6J4EYtYaxYqUFZgcutKLYfISShBFcqBWBxuLQyw0LshFYRDCsQa0/4HriYbRk9acr0WY/5FAROUxGb/V0ioOdsqpnAoo8K9LhKM0l3xS7UV6N/2WlwMspcbN+v5a6SjvR7SloK1P0Rz70Zu5vUUcXN0weLNofvRygA2hPXUrlTIPTLm6cqnhRyGrWjVXZN2kqZ2c3GBJn0XJ5RLorSgkiCyRMSuuDZj1NZHguU2EmrqbfiBzqNxtarEhzlg3YSicf/CqZ1BzHosANaVtBjjEaTqzc728RIj2345UpHKDwPUc+kRxYRRg8IgfYzGbSboza+Ty9cXbpXfUr187eMzY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use the helper function to check the requirements for casefold directories using strict encoding. Suggested-by: Gabriel Krisman Bertazi Signed-off-by: André Almeida Acked-by: Theodore Ts'o Reviewed-by: Gabriel Krisman Bertazi --- Changes from v4: - Now we can drop the if IS_ENABLED() guard --- fs/ext4/namei.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 790db7eac6c2ad5e1790e363e4ac273162e35013..612ccbeb493b8d901c123221ef6573457193dd16 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2395,11 +2395,8 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, if (fscrypt_is_nokey_name(dentry)) return -ENOKEY; -#if IS_ENABLED(CONFIG_UNICODE) - if (sb_has_strict_encoding(sb) && IS_CASEFOLDED(dir) && - utf8_validate(sb->s_encoding, &dentry->d_name)) + if (!generic_ci_validate_strict_name(dir, &dentry->d_name)) return -EINVAL; -#endif retval = ext4_fname_setup_filename(dir, &dentry->d_name, 0, &fname); if (retval)