From patchwork Fri Oct 25 15:11:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13850941 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6C6D0BB56 for ; Fri, 25 Oct 2024 15:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 207D56B009F; Fri, 25 Oct 2024 11:13:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B79D6B00A0; Fri, 25 Oct 2024 11:13:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07F7D6B00A1; Fri, 25 Oct 2024 11:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DCD746B009F for ; Fri, 25 Oct 2024 11:13:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EDE1340AD1 for ; Fri, 25 Oct 2024 15:12:52 +0000 (UTC) X-FDA: 82712466144.20.6D28C91 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DC8F24001A for ; Fri, 25 Oct 2024 15:12:37 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OnNY6ntw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729869129; a=rsa-sha256; cv=none; b=I0HCGgTk14D3Y9TjrrgH8a1GdGibbFFhcJ7L1YGlIFW3GU/8LcTi+agBGgA1IxMqxtmjKR itebxWiDS6r3po4Am4KALpY5j5THXDQ9UURNpOSgdJ7CNryKSJJBTw3ANkja84ag+n+6wl R1uQuZxYcVeD5uJVz++umsMEh0igJKs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OnNY6ntw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729869129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ACGdF21cKkvnMHoeXpjOJK7M5S4ojlG1Lcv7sY6UCa8=; b=efiLj5udKaNYxd8Q5vA5PAtvA6YRM7OlDIZd9Zrto/HcxcPNjBgrMQaYLwTYFTCJ4RhE9w 02RMsUuusEs5PNH34ujccDSJ6CEo6ajZjS9eJe34HYgXgwo2QYZyWTp4E43oWsJlZsbAyH oYpM+SuRoPPXoHMkFhs1mMUiPgSkowc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729869181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ACGdF21cKkvnMHoeXpjOJK7M5S4ojlG1Lcv7sY6UCa8=; b=OnNY6ntwDB+Olu4i4hvV0IllRDENwj64Nj+JLUC1/Gi8m5ycVYXpU20vsKxvk1Wpl07KBx okcDvQyK18COUcZk9dL+eDffNqrEBtJqRzcL9VCA1ex+6PwzVVtFdv36LN8uU2xWqyHCCd TNmI1gv75HuaOa3Kychz4e4DPGsTSSU= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-JyKffLwLP4WOg7IrO6F-yg-1; Fri, 25 Oct 2024 11:12:58 -0400 X-MC-Unique: JyKffLwLP4WOg7IrO6F-yg-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC5061955F35; Fri, 25 Oct 2024 15:12:53 +0000 (UTC) Received: from t14s.redhat.com (unknown [10.22.65.27]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 93CD030001A7; Fri, 25 Oct 2024 15:12:45 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Baoquan He , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: [PATCH v1 08/11] virtio-mem: mark device ready before registering callbacks in kdump mode Date: Fri, 25 Oct 2024 17:11:30 +0200 Message-ID: <20241025151134.1275575-9-david@redhat.com> In-Reply-To: <20241025151134.1275575-1-david@redhat.com> References: <20241025151134.1275575-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: DC8F24001A X-Rspamd-Server: rspam01 X-Stat-Signature: 6mtzezxtpy68txxo1qma1163squ5skgi X-HE-Tag: 1729869157-892948 X-HE-Meta: U2FsdGVkX1+vJAtR9i5dNLe457lDEn0L9um6WGGfh7PwGFcG5pd5WT2aooIoRwsrXnu2kLwdnSnM5rNGI14pIeVNyAhsetpL8/Z5KutGp0aWNQoDj0GKQCajruXi/iGfqW/8zmqWkfJS0egZ2+oD3bwcTabyIKEhajxBSNZteMXontRuilecCMVCVjxqB9SpNQRHtwNpzQIuPXTG66NIGfVrB6L1om/uhKP/ywVdx9CmJGMHDu1HVPF1VqCLR0Asky/oJm41GKRDjQAItEyHImzLJzDcV1BPJPuqg+RQhrl6Fto+ShPXWJ5N2xKTNC0vUEH8sarXGA+6u2/izQIwSuZOGiuULQrL5H/AkN0Fdtb5+eQD8lGRVC79PjnujXMzu1iawJx0NtNKDCezmO1AE2BbMDZUE92PtJDGboD8n7txGxWV04YT3xIKgd1jPQZfJdn5/p4kH9YWc+FIpxK7RKlPpi1p1zqGFY6DeoI3HdKyQNUUd7hNhHGk/zI7es1/XIe8Zl00MK2vy6ltlYiGITn1gh58wmws0syFW+L9ynAOmbjGVruTmM9+8FRLBQpol1NzC7iK8vP94K4C0QR6BJhOb/V5KuLCC7MdH6l9WPj/TC9fDksvqNFNuCyvE4tiMdb5qFoGKSW3J8Wx44xMbuTJhO+zmsVmXcwx4awMppEdiXgWZqBN1BImOqxX3KJZym/oDtygMfAdigAn97J2fSbkXgq1nxHS9v7AbRW5L/vZ1dsGMXdE5qYmL9B/c0wWkzJo1IwQmKlXVtvTrI2107Em9go/J9ANrdo8URj6n4i07z+kyZaXVAwkB2H00drQQ4AAzQovLbURx886C8cjfY70giaU97Vb4yv1TaPm5Hr+mt/XRIpE3vV3l3sI7nwYsnxVSk+xV9TiNFxJlK01xpjA7gyHTbAp/qz6qb5Si51V2wc8SLSNE9WlX6gZB/Nemtl1rz0c7IY0tR15fgR PSSNQr8W qslwXtfBmGteSK1U5EdalN6Q0/TeIvYQ8EZ60ZS2Ek9tW6dmt+fynYWofT9CfP7wM3GTvdgIcuzLYSQljEDFxqKy3qHxmmLy67Gz8XyvWaz8tu8GddT380wMRL8oXx78ClNdMVzfTaK/KPlZJXwvnGP8yZzJBc6BJiwuhB06inFSX3DCU8v2deb4bS4LnmeVLnjyMFualmGHjZJE8r6hDapySjLXKwpO2yIamxkvss95AJvDFds1YVa0hfjk0UITAFhXLkRKwvfqB0WLgAtji8vl096gk0TV/KR1vmlYmsVf7wMDq0KBSSbLUuSlUuzSpaX9BYEVkjoUhvKs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After the callbacks are registered we may immediately get a callback. So mark the device ready before registering the callbacks. Signed-off-by: David Hildenbrand --- drivers/virtio/virtio_mem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index b0b871441578..126f1d669bb0 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -2648,6 +2648,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) if (rc) goto out_unreg_pm; + virtio_device_ready(vm->vdev); return 0; out_unreg_pm: unregister_pm_notifier(&vm->pm_notifier); @@ -2729,6 +2730,8 @@ static bool virtio_mem_vmcore_pfn_is_ram(struct vmcore_cb *cb, static int virtio_mem_init_kdump(struct virtio_mem *vm) { + /* We must be prepared to receive a callback immediately. */ + virtio_device_ready(vm->vdev); #ifdef CONFIG_PROC_VMCORE dev_info(&vm->vdev->dev, "memory hot(un)plug disabled in kdump kernel\n"); vm->vmcore_cb.pfn_is_ram = virtio_mem_vmcore_pfn_is_ram; @@ -2870,8 +2873,6 @@ static int virtio_mem_probe(struct virtio_device *vdev) if (rc) goto out_del_vq; - virtio_device_ready(vdev); - /* trigger a config update to start processing the requested_size */ if (!vm->in_kdump) { atomic_set(&vm->config_changed, 1);