From patchwork Fri Oct 25 17:13:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13851077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B59C0D149D6 for ; Fri, 25 Oct 2024 17:14:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BC8C6B008A; Fri, 25 Oct 2024 13:14:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91DDE6B008C; Fri, 25 Oct 2024 13:14:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7971C6B0092; Fri, 25 Oct 2024 13:14:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D0856B008A for ; Fri, 25 Oct 2024 13:14:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 790E3160E2A for ; Fri, 25 Oct 2024 17:14:06 +0000 (UTC) X-FDA: 82712772366.09.4A25F74 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf07.hostedemail.com (Postfix) with ESMTP id 843B540018 for ; Fri, 25 Oct 2024 17:13:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729876313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NYFLWJU/nJ/Qpvgtx8myvYL2TtifOyxWJTmJpbGDZeg=; b=3uKUJLlPTpEh9tIjlXZpDprpt3sLUD9bWutTY/5oOBTzzZboDlz2M2sZ61L9uz7xSxAa4E 2oQxsYbs2LrOnKqnlY2+aJiET9FIsmExRVDEgwPyplBw5jyNyKHG5BGMcmYGIq8ymoE6mA jUVqigz/ghDk9KAK9s+pTgXzUWG7gx8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729876313; a=rsa-sha256; cv=none; b=y94a9oksc1C+x93PdrVhtqzzZG3BPVcDpShJz/4OJj9D8R0pVzjBzLTGwBuYAjWhrkMk1H boDgl0ptHwqu3se4SaQSClse35NP6QZrKWPraaS15UXNkanfWtZMWNemt9pBTqzg5NCcBy NHpAZ+IETrwrTppVCLzQ3T516yr9H2U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XZq5c67TLz6LCgg; Sat, 26 Oct 2024 01:09:40 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id 50864140A86; Sat, 26 Oct 2024 01:14:24 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.48.151.104) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 19:14:22 +0200 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v14 01/14] EDAC: Add support for EDAC device features control Date: Fri, 25 Oct 2024 18:13:42 +0100 Message-ID: <20241025171356.1377-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20241025171356.1377-1-shiju.jose@huawei.com> References: <20241025171356.1377-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.48.151.104] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To frapeml500007.china.huawei.com (7.182.85.172) X-Rspamd-Queue-Id: 843B540018 X-Stat-Signature: mex6ju7ji1gcasp9yg8izhqyyihpag1a X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729876439-261015 X-HE-Meta: U2FsdGVkX184gakkrvbvKiyKWzeVH/Klg9y/ZoRwZ34HUiueNUYd2sMJctz7c2+CduN0TAAx78QspYiR15xutglVB0Ed6vkDfH89RlYq/Qu1I3yp3gWgrzsACjnGmMevUtA1DNUT/lbygXEz+Z92baCpcp7c9SegsanvPM8X9ygbvUXIHmJqB2YQgqkx8wlMUSIqTWBT1BRxEu6pYTEZoHnbtrVdzCh4ecs96fP+egEUhnzvrx+I+3OV3SOyZjs+Cc2tUCRwICMfDI4G4qoxqJZQ/zXYJLfcdu3TZx2CPa4OqE1gDyz5YDZEHn0h14oRFHjGWkPSNW3K10LAeh8n5Jt+6iyAGGdHIsc/e1pbZGAeS/4+HRj1w3dpoaCAzouBNOH4NoiJGZFjzrphzWM3nubpMjcV5yooi6obaTi2eOHzTTRKoa5po2QnOePfp2mlYYNWgIz/tBOQRdm6dhplfY+aJ1MJzjZ5b3/W5J+8/PczSVJshQStFX1HvFiTNJNj3gMhVNBpKh2m2FU/qj2jSwj0fhicG6json7vvrSD1z9aLVG6+m/nsIwoaowfG43zrjRvGlYGym6n3NSRGS/R8qwXQhhNlKToKyT+oUFYEDEARAwSD1JHdHx45XIDXyk0vmpxOCW+WtE2za2B4D2TzHvePa2aCdcziurmAYwdT8rY3epsjJvmqWLIE5hD9qrOBlBSzWYNmU7veCDKlpQJSChGIYs6E5JpJoznvekXP2pa0n3udn3W+C+Jzxj7WGCEfAVSqqP37uwRzdSBc8eEZEqQHp2TauyS/tdPELya3u5VGdAQGocpPVXnp0GGeDJSyiAFqZPycttHQ4729WHoTAVYSRoXlYjX3isAXzmvws9l2IP3l/rr+09xJIXz+2YcfQWmJX6mytBwrlBtOufU4OkpsEtZZA0UvY+mUBhafarWPHJYpQVEGQtehibKPxQ40FdPiCJOIGcTqr4yeF0 dTrGQXPt vPT2dYJsvJUrKC2uK84DTkbmEWY+tJzV+0b2hT4o4mr7bO9UcY/A/pXzZuEhM7inecxiWA9ongXyQSDOkw5RTsYRT/BbZXm0rNVO/CD0We1waHT6tY0Re0JvJG2O+nl9zkduOW6gyY8tKUkT5X4bxvLYhpYhyJ0fCI8w6L4o0RUfkFSui/xGDKXafc9H7JyxeybUYKO6+iqhOUALHgtBVq0q8Hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add generic EDAC device feature controls supporting the registration of RAS features available in the system. The driver exposes control attributes for these features to userspace in /sys/bus/edac/devices/// Co-developed-by: Jonathan Cameron Signed-off-by: Jonathan Cameron Signed-off-by: Shiju Jose --- drivers/edac/edac_device.c | 101 +++++++++++++++++++++++++++++++++++++ include/linux/edac.h | 30 +++++++++++ 2 files changed, 131 insertions(+) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 621dc2a5d034..e9229b5f8afe 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -570,3 +570,104 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, block ? block->name : "N/A", count, msg); } EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); + +/* EDAC device feature */ +static void edac_dev_release(struct device *dev) +{ + struct edac_dev_feat_ctx *ctx = container_of(dev, struct edac_dev_feat_ctx, dev); + + kfree(ctx->dev.groups); + kfree(ctx); +} + +const struct device_type edac_dev_type = { + .name = "edac_dev", + .release = edac_dev_release, +}; + +static void edac_dev_unreg(void *data) +{ + device_unregister(data); +} + +/** + * edac_dev_register - register device for RAS features with EDAC + * @parent: parent device. + * @name: parent device's name. + * @private: parent driver's data to store in the context if any. + * @num_features: number of RAS features to register. + * @ras_features: list of RAS features to register. + * + * Return: + * * %0 - Success. + * * %-EINVAL - Invalid parameters passed. + * * %-ENOMEM - Dynamic memory allocation failed. + * + */ +int edac_dev_register(struct device *parent, char *name, + void *private, int num_features, + const struct edac_dev_feature *ras_features) +{ + const struct attribute_group **ras_attr_groups; + struct edac_dev_feat_ctx *ctx; + int attr_gcnt = 0; + int ret, feat; + + if (!parent || !name || !num_features || !ras_features) + return -EINVAL; + + /* Double parse to make space for attributes */ + for (feat = 0; feat < num_features; feat++) { + switch (ras_features[feat].ft_type) { + /* Add feature specific code */ + default: + return -EINVAL; + } + } + + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); + if (!ras_attr_groups) { + ret = -ENOMEM; + goto ctx_free; + } + + attr_gcnt = 0; + for (feat = 0; feat < num_features; feat++, ras_features++) { + switch (ras_features->ft_type) { + /* Add feature specific code */ + default: + ret = -EINVAL; + goto groups_free; + } + } + + ctx->dev.parent = parent; + ctx->dev.bus = edac_get_sysfs_subsys(); + ctx->dev.type = &edac_dev_type; + ctx->dev.groups = ras_attr_groups; + ctx->private = private; + dev_set_drvdata(&ctx->dev, ctx); + + ret = dev_set_name(&ctx->dev, name); + if (ret) + goto groups_free; + + ret = device_register(&ctx->dev); + if (ret) { + put_device(&ctx->dev); + return ret; + } + + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); + +groups_free: + kfree(ras_attr_groups); +ctx_free: + kfree(ctx); + return ret; +} +EXPORT_SYMBOL_GPL(edac_dev_register); diff --git a/include/linux/edac.h b/include/linux/edac.h index b4ee8961e623..e19706311ec0 100644 --- a/include/linux/edac.h +++ b/include/linux/edac.h @@ -661,4 +661,34 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, return mci->dimms[index]; } + +/* EDAC device features */ + +#define EDAC_FEAT_NAME_LEN 128 + +/* RAS feature type */ +enum edac_dev_feat { + RAS_FEAT_MAX +}; + +/* EDAC device feature information structure */ +struct edac_dev_data { + u8 instance; + void *private; +}; + +struct edac_dev_feat_ctx { + struct device dev; + void *private; +}; + +struct edac_dev_feature { + enum edac_dev_feat ft_type; + u8 instance; + void *ctx; +}; + +int edac_dev_register(struct device *parent, char *dev_name, + void *parent_pvt_data, int num_features, + const struct edac_dev_feature *ras_features); #endif /* _LINUX_EDAC_H_ */