From patchwork Fri Oct 25 20:39:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13851554 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40986D149F3 for ; Fri, 25 Oct 2024 20:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3D306B0085; Fri, 25 Oct 2024 16:40:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CECE66B0088; Fri, 25 Oct 2024 16:40:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8DE06B0089; Fri, 25 Oct 2024 16:40:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 98B246B0085 for ; Fri, 25 Oct 2024 16:40:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FED480FCC for ; Fri, 25 Oct 2024 20:40:22 +0000 (UTC) X-FDA: 82713292620.11.6EFA569 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 548ABA002D for ; Fri, 25 Oct 2024 20:40:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WewJYQn8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729888797; a=rsa-sha256; cv=none; b=EAnjUnxLJnxRT2Aw5/0Qc8V5NMRuPwm6XIFLPHroWQCX/8mtJw+bXnbAJDAZpJ7Sj2CT1H 3GW801ukY9LD+4XbKU+IqVZQkDk7Aw1S7O28IUFsYycsQwhcHc3XixQo6NsOulxFsva98q zrZP3h/NCLleRZK9S+71eYb+s3tfhVU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WewJYQn8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729888797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SueMPOdHep9t3PCuklU6bVWhougpE6WyFc4wdjmYJYc=; b=6m0k7vApBwOsIAgJ4no91XlDIlVHTnoInpXI2jXE3vGhMnPukPTHjHEHVWgH1pxCG0wRJL HxYWElDARmBBOMmRx1twq1WEZOydd3DXZIMq6PAsiOksmNkjIiQdnl4dnrQvWGGvcUEhjo bRI5zElRv7W4M9et/wICfZbH/ZTy+Gc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729888837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SueMPOdHep9t3PCuklU6bVWhougpE6WyFc4wdjmYJYc=; b=WewJYQn8F99QqJN+pT0W+axPXBQ0JEjGnw8twnIrL/qK7wWvvBi8PpKqFIpELS0TNJrIc2 mvFVWPd9ZWbttuwc30V9KLhvWfXmn3qsPFrzSxvKcs43Bzo7uxAzslU/+9IWvzqnKKoKEL kBt5kq3NYYF2KSeXhbrVKBANHN3pHpU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-uukyL2R_PNGmxVmD_0NbMA-1; Fri, 25 Oct 2024 16:40:31 -0400 X-MC-Unique: uukyL2R_PNGmxVmD_0NbMA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3DB31955F25; Fri, 25 Oct 2024 20:40:27 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.42.28.231]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 886E6196BB7D; Fri, 25 Oct 2024 20:40:21 +0000 (UTC) From: David Howells To: Christian Brauner , Steve French , Matthew Wilcox Cc: David Howells , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner Subject: [PATCH v2 01/31] netfs: Remove call to folio_index() Date: Fri, 25 Oct 2024 21:39:28 +0100 Message-ID: <20241025204008.4076565-2-dhowells@redhat.com> In-Reply-To: <20241025204008.4076565-1-dhowells@redhat.com> References: <20241025204008.4076565-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Stat-Signature: di1tbus588rkwt8nm7kpd4iq6gdrbycy X-Rspamd-Queue-Id: 548ABA002D X-Rspamd-Server: rspam02 X-HE-Tag: 1729888817-146086 X-HE-Meta: U2FsdGVkX19SQN+9s9KrMTx6eKleYZ8s3XG7CKiXVDeCRWapxNg/LMb1rsBOkzVlD7o1YIQ5Xi7JG/2Bwxn9WTSvQicdsuSvrnuRzkEmK9EB0QMb/YoOWB7CHrteZtHHVkRYL8SMc3MakM9GHRLDgrGP2G20LjSSs38MdrVmCopLa5e62fhyLTwSWezHBHOrtR51t4/wJNyX+T6SXBZx38zjSpxhXHzq6ULQYcLlWdedbt06CJ25QXMmr5LXTZxd3UWiGltCPUwAYWWUA3DbnmckmKeti5YNsV6u/Wonl/JNOacKx5jGYBO3jxlrl8XJ66ZTtMtd5LEHyywY2PWKNZixAPkil2hvfbKVdFYCvTWHp3n2Ka6X1GnzwHqm4D/Ht7Ojz+RsQUf0LIyg1fzLByS+2H02j+AXGVTo/hIjOLBa1bk1XqFXbzQVkjB1KeCdLQh04dyk3fHWsiB01F/sF2ac0ZGsWgfwn2DuWsjWN6HFJKQ+GlCi3dtONp72Zn3WHOEYCRgVbf5YePKJoWzvjW4VGP7qlUEp01sohIVelRIE+dPBt9zeh62mZR2kdMo4CK2KKw1uqujozBF5ccIkhhfwCYnzouxn1diajppef3vdEJuZ2RN2XUMx4nSkfH8K7clVM1OUh4j8t+rJqn1oX6bYqIQlxpART4a3gRb48El0AGq3qL6DTB45VTnm3r9xMJS3q1z7Ijke7OICZK+w+WV8SzHAP8alsZPIw4/kyRRAfY6eEY8hSZQY28DO+fzFZ1vTbni6jfRLgCTTE3uYJ4pYirTn2bOoDemo3H8zZqZu5L/Ph4m3EebWe5YuSp1MPOB5X+h9ouiO2TI/hzQfOwbab3qb8DqyXW3An3i5l/nPbsMWeVzQcK8DvfhpOMRyMZ9zzfS5w+KP1zETI2BqMF5fGmC9OHrNIsmTP5WXl4Wb9L1LYfcbVNmiLb1VaPSmAT7u1ecTPezs5E52MQ/ TsY9SUdx u2OPk8noWO18iQxywhZt7ALw7q+6UQyReVySeJN4ZjD6Jrc869AIFlS7x0C9KAi7BvqnnGtTMEu59wGwUWlFoFkNstKdrJwFxqnAH/nA+4xZXIrShDQntTss590B0lZwI28FJqP1PD29c1pulWg0LLJAH7UEzSXpcpT7VGS93z5DHSVEnYzvwEeOievYTtaaUUNPC288bBrRb3bi2mBw7wF+YWk+FSG8vFaU2sUqbK6pH4pEwsOhOoQNwetCt9UDVRIRuUU1uyUqEVWIdBm59ow2IZEH+UW+60a4fvBqluTWl8TQsBpVkNHk4Aw/pJMRdJxQoNXVWdKmkCJF3SktXpazCvJwgtBTvZ+VTU/yPJ5htp5o/eTaAzCtvunolG8zKMnMdR8QT+l7srjUXpD6ZXNF7jpAKdpPiso1Vi7HFCHoChTU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Matthew Wilcox (Oracle)" Calling folio_index() is pointless overhead; directly dereferencing folio->index is fine. Signed-off-by: Matthew Wilcox (Oracle) Link: https://lore.kernel.org/r/20241005182307.3190401-2-willy@infradead.org Signed-off-by: Christian Brauner --- include/trace/events/netfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/netfs.h b/include/trace/events/netfs.h index 69975c9c6823..bf511bca896e 100644 --- a/include/trace/events/netfs.h +++ b/include/trace/events/netfs.h @@ -450,7 +450,7 @@ TRACE_EVENT(netfs_folio, struct address_space *__m = READ_ONCE(folio->mapping); __entry->ino = __m ? __m->host->i_ino : 0; __entry->why = why; - __entry->index = folio_index(folio); + __entry->index = folio->index; __entry->nr = folio_nr_pages(folio); ),