From patchwork Fri Oct 25 20:39:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13851560 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583F3D149F2 for ; Fri, 25 Oct 2024 20:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDA246B009D; Fri, 25 Oct 2024 16:41:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3DF06B009E; Fri, 25 Oct 2024 16:41:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD246B009F; Fri, 25 Oct 2024 16:41:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9E9D86B009D for ; Fri, 25 Oct 2024 16:41:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 58B8341020 for ; Fri, 25 Oct 2024 20:41:05 +0000 (UTC) X-FDA: 82713293166.17.A75B4A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 7BFEC4001D for ; Fri, 25 Oct 2024 20:40:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cegr4rVU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729888748; a=rsa-sha256; cv=none; b=w9+dovpLNk7vSGAGPwRzGmVbQWM01M9zkthzM1dDO02z8Us15QZhuICbC/3GhGvECqRPLh yL+mRU8hJXdBqSSY+V/y6MCFsA4+4UrH6gu+nBt/7ZQhCbqPQ6Rmp0my3FUzsyFBQHZMGF Xi1boSM0sA+qm09plsON5kKXnIsXmkQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cegr4rVU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729888748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3twVFG043O59vporSoGB49KW0yXOb7j0HiRw4sYWo4=; b=7pD5kSNegJqlepf1BpNUIYl2m0wvoeCaAJnnx4a0ivnz32qB7y7P52Pjp8hHyIQrlyo1wU f5YtS9ZZDctX0NmLJpm8hjar9y+4nI7HH34Ygd08IFoORV5h9ZbA7Uke2TloVwMfLPXneh 9mSh6P8iaCNE84ZQYZlNu1KFBL1Cfx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729888873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X3twVFG043O59vporSoGB49KW0yXOb7j0HiRw4sYWo4=; b=cegr4rVUmZTdbfG5ijRGvP7wKMOxwPnMmgFFSDNh4cWT2VOr+aME1laNJysdYRx0oPmXfj 9RRjdrFKUP4GjJa1c1vpOnSVSTnJkm1iouO4kliQC0wzv1hserK7DWF34aHBBbBUVnnC+b q8v4NRCmbf7yYsIVOoqpMfj9ZTz17DI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-34faPH3xNsWQq86naFTt-w-1; Fri, 25 Oct 2024 16:41:12 -0400 X-MC-Unique: 34faPH3xNsWQq86naFTt-w-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E8E41955D4E; Fri, 25 Oct 2024 20:41:09 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.42.28.231]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 56A8A195607C; Fri, 25 Oct 2024 20:41:04 +0000 (UTC) From: David Howells To: Christian Brauner , Steve French , Matthew Wilcox Cc: David Howells , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: [PATCH v2 07/31] netfs: Make netfs_advance_write() return size_t Date: Fri, 25 Oct 2024 21:39:34 +0100 Message-ID: <20241025204008.4076565-8-dhowells@redhat.com> In-Reply-To: <20241025204008.4076565-1-dhowells@redhat.com> References: <20241025204008.4076565-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7BFEC4001D X-Stat-Signature: mc63whqdq61z1wzzofduyiqn3fym6w3g X-Rspam-User: X-HE-Tag: 1729888858-413268 X-HE-Meta: U2FsdGVkX1+Qi5dZrTMK3eCMD5EPZjt3X2vtvhpWm62v59qYGdey+FklME1iHw016bFK/RPobtXIQl8WWTFC5N3AeosLxVeXWb/kV5x86TAF026rJUrg3QSFpUYFxxz/g+XfHZES9WX/K0svKyDV+oZLQbTCZygZAAj38tEuG4EMQLVK+Rs3/UTKmCM2dHrwX4q6eu94Q7k8FDdYzZ6YKOVCybtISyXxRUa8JcYT5yahIIeoQCXpvZO5kE1IIVzXtAfEoyVz+UoswFQ52Cxb2T6RZfqpkNpzlGXh/fB0Fpz7jprLA22pceljsMaZ4h9r1vF+CgkETNHYuXVTtMkwfAUUGx7odQY6nS9Iq1vsRjaWlmUNXtfhnb0dPDQWZB9fz8OI6ZCep5BeCw7boVihN3z0mPKFBCHqfhfXSftESrMe3f8V7g+kjhekTfkZJI5HIVQWzMaFCAyrFw/CU1ZWUTcg26wmihGZZNY/WuUHdmIhJNr/1FDHbBbFnloOG38KDcZiAyjMZejFwf/Y4aqUKn8ICCBhkIsgkx/lY4NYPRU2MQKx7WcI/IE5yUcobJ/rdNgxEfwbLtvZawmJX7kWFrz7wsSHfCWyjOI+DVmflhZTJARsUZBe7LU6wMtudj6GY14tIP0q1Uro/V8ppPFyKqXJuX+fP1aSVfLUZd5q2CaMbNY5K2twkyJfx1hZ0JJe00Q1XVv076DDxeaSQbBbmxEaT0ck52Q7qFZYgsldG6nWomFcTWoip0ttD36Tn383CDQG/L4J88VCoqyKK3ZxuD8HeIyslMgwSYG5pOgxRjb8fHClq560oFWiy7/uimHssQpbsl6bB5KFbvGJDtQnxxCg0VmRG/p+fZDqk/pcMCMMPQUtcmiD6KdTY947YH6nBmq/axXqJA9mv2V3b0X1rg5RnoewGPmFnZF+c4D2F3T8SaDIhXrfoWU4SI3DGege6DToWtzCP05tTtFOJby 2JZzmn2/ 4KJNLcB2DuZdCPE/i5Oq0dogq9G0HjGhp6v5c92We7XYOIkKqyWPJPIUhGwuOD9H+WeJAOwsEvKLFIf1PhvGy2iRkQk0yFLHKXMuKVHCMXvV67fSUn2KCnRvdKH3jx2Gkdoz6WbaYRI8UpCiZlAj9RPOLPamU16ZD2oRycPP1ior12fosz5wALsh3sjb/TdAA+pCN0BQCxKNpJxDcQen/GCBV4jadljJqJeOwEeHJAQcioaOG3hGXLPusbe4Tq5a4blPLQJ03U/7qeCrKozBCTeo3roohLqbzWrjaB3fzeVHksXbmZDdAGlE4ph8W5B7Dey0rI8VpaOGSyv7Bx5CpB4n9siRMPva38aVtogTsniJv5i+AkwbjHFS2i0LL45rOXuDuwoJEjKuhtZ05NbFyKYBKnjTfKNdtOAPTf6XyIT4GB7QnvnlAd09E6ClQe8mUas2wVrRQIf3Y/h0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: netfs_advance_write() calculates the amount of data it's attaching to a stream with size_t, but then returns this as an int. Switch the return value to size_t for consistency. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/internal.h | 6 +++--- fs/netfs/write_issue.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h index ccd9058acb61..6aa2a8d49b37 100644 --- a/fs/netfs/internal.h +++ b/fs/netfs/internal.h @@ -178,9 +178,9 @@ void netfs_reissue_write(struct netfs_io_stream *stream, struct iov_iter *source); void netfs_issue_write(struct netfs_io_request *wreq, struct netfs_io_stream *stream); -int netfs_advance_write(struct netfs_io_request *wreq, - struct netfs_io_stream *stream, - loff_t start, size_t len, bool to_eof); +size_t netfs_advance_write(struct netfs_io_request *wreq, + struct netfs_io_stream *stream, + loff_t start, size_t len, bool to_eof); struct netfs_io_request *netfs_begin_writethrough(struct kiocb *iocb, size_t len); int netfs_advance_writethrough(struct netfs_io_request *wreq, struct writeback_control *wbc, struct folio *folio, size_t copied, bool to_page_end, diff --git a/fs/netfs/write_issue.c b/fs/netfs/write_issue.c index 993cc6def38e..c186221b45c0 100644 --- a/fs/netfs/write_issue.c +++ b/fs/netfs/write_issue.c @@ -271,9 +271,9 @@ void netfs_issue_write(struct netfs_io_request *wreq, * we can avoid overrunning the credits obtained (cifs) and try to parallelise * content-crypto preparation with network writes. */ -int netfs_advance_write(struct netfs_io_request *wreq, - struct netfs_io_stream *stream, - loff_t start, size_t len, bool to_eof) +size_t netfs_advance_write(struct netfs_io_request *wreq, + struct netfs_io_stream *stream, + loff_t start, size_t len, bool to_eof) { struct netfs_io_subrequest *subreq = stream->construct; size_t part;