[v3,02/33] netfs: Remove call to folio_index()

Message ID	20241106123559.724888-3-dhowells@redhat.com (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: David Howells <dhowells@redhat.com> To: Christian Brauner <christian@brauner.io>, Steve French <smfrench@gmail.com>, Matthew Wilcox <willy@infradead.org> Cc: David Howells <dhowells@redhat.com>, Jeff Layton <jlayton@kernel.org>, Gao Xiang <hsiangkao@linux.alibaba.com>, Dominique Martinet <asmadeus@codewreck.org>, Marc Dionne <marc.dionne@auristor.com>, Paulo Alcantara <pc@manguebit.com>, Shyam Prasad N <sprasad@microsoft.com>, Tom Talpey <tom@talpey.com>, Eric Van Hensbergen <ericvh@kernel.org>, Ilya Dryomov <idryomov@gmail.com>, netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner <brauner@kernel.org> Subject: [PATCH v3 02/33] netfs: Remove call to folio_index() Date: Wed, 6 Nov 2024 12:35:26 +0000 Message-ID: <20241106123559.724888-3-dhowells@redhat.com> In-Reply-To: <20241106123559.724888-1-dhowells@redhat.com> References: <20241106123559.724888-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	netfs: Read performance improvements and "single-blob" support \| expand [v3,00/33] netfs: Read performance improvements and "single-blob" support [v3,01/33] kheaders: Ignore silly-rename files [v3,02/33] netfs: Remove call to folio_index() [v3,03/33] netfs: Fix a few minor bugs in netfs_page_mkwrite() [v3,04/33] netfs: Remove unnecessary references to pages [v3,05/33] netfs: Use a folio_queue allocation and free functions [v3,06/33] netfs: Add a tracepoint to log the lifespan of folio_queue structs [v3,07/33] netfs: Abstract out a rolling folio buffer implementation [v3,08/33] netfs: Make netfs_advance_write() return size_t [v3,09/33] netfs: Split retry code out of fs/netfs/write_collect.c [v3,10/33] netfs: Drop the error arg from netfs_read_subreq_terminated() [v3,11/33] netfs: Drop the was_async arg from netfs_read_subreq_terminated() [v3,12/33] netfs: Don't use bh spinlock [v3,13/33] afs: Don't use mutex for I/O operation lock [v3,14/33] afs: Fix EEXIST error returned from afs_rmdir() to be ENOTEMPTY [v3,15/33] afs: Fix directory format encoding struct [v3,16/33] netfs: Remove some extraneous directory invalidations [v3,17/33] cachefiles: Add some subrequest tracepoints [v3,18/33] cachefiles: Add auxiliary data trace [v3,19/33] afs: Add more tracepoints to do with tracking validity [v3,20/33] netfs: Add functions to build/clean a buffer in a folio_queue [v3,21/33] netfs: Add support for caching single monolithic objects such as AFS dirs [v3,22/33] afs: Make afs_init_request() get a key if not given a file [v3,23/33] afs: Use netfslib for directories [v3,24/33] afs: Use netfslib for symlinks, allowing them to be cached [v3,25/33] afs: Eliminate afs_read [v3,26/33] afs: Fix cleanup of immediately failed async calls [v3,27/33] afs: Make {Y,}FS.FetchData an asynchronous operation [v3,28/33] netfs: Change the read result collector to only use one work item [v3,29/33] afs: Make afs_mkdir() locally initialise a new directory's content [v3,30/33] afs: Use the contained hashtable to search a directory [v3,31/33] afs: Locally initialise the contents of a new symlink on creation [v3,32/33] afs: Add a tracepoint for afs_read_receive() [v3,33/33] netfs: Report on NULL folioq in netfs_writeback_unlock_folios()

Message ID

20241106123559.724888-3-dhowells@redhat.com (mailing list archive)

State

New

Headers

From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>,
	Steve French <smfrench@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
	Jeff Layton <jlayton@kernel.org>,
	Gao Xiang <hsiangkao@linux.alibaba.com>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Marc Dionne <marc.dionne@auristor.com>,
	Paulo Alcantara <pc@manguebit.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	netfs@lists.linux.dev,
	linux-afs@lists.infradead.org,
	linux-cifs@vger.kernel.org,
	linux-nfs@vger.kernel.org,
	ceph-devel@vger.kernel.org,
	v9fs@lists.linux.dev,
	linux-erofs@lists.ozlabs.org,
	linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>
Subject: [PATCH v3 02/33] netfs: Remove call to folio_index()
Date: Wed,  6 Nov 2024 12:35:26 +0000
Message-ID: <20241106123559.724888-3-dhowells@redhat.com>
In-Reply-To: <20241106123559.724888-1-dhowells@redhat.com>
References: <20241106123559.724888-1-dhowells@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

netfs: Read performance improvements and "single-blob" support | expand

Commit Message

David Howells Nov. 6, 2024, 12:35 p.m. UTC

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

Calling folio_index() is pointless overhead; directly dereferencing
folio->index is fine.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20241005182307.3190401-2-willy@infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 include/trace/events/netfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/netfs.h b/include/trace/events/netfs.h
index 69975c9c6823..bf511bca896e 100644
--- a/include/trace/events/netfs.h
+++ b/include/trace/events/netfs.h
@@ -450,7 +450,7 @@  TRACE_EVENT(netfs_folio,
 		    struct address_space *__m = READ_ONCE(folio->mapping);
 		    __entry->ino = __m ? __m->host->i_ino : 0;
 		    __entry->why = why;
-		    __entry->index = folio_index(folio);
+		    __entry->index = folio->index;
 		    __entry->nr = folio_nr_pages(folio);
 			   ),

[v3,02/33] netfs: Remove call to folio_index()

Commit Message

Patch