From patchwork Fri Nov 8 10:39:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 13867919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC75ED5E157 for ; Fri, 8 Nov 2024 10:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFEB16B009A; Fri, 8 Nov 2024 05:42:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A88426B009D; Fri, 8 Nov 2024 05:42:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2916B009F; Fri, 8 Nov 2024 05:42:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6739E6B009A for ; Fri, 8 Nov 2024 05:42:28 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 15E66C01EC for ; Fri, 8 Nov 2024 10:42:28 +0000 (UTC) X-FDA: 82762587222.27.1C84244 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf04.hostedemail.com (Postfix) with ESMTP id B7C6A40011 for ; Fri, 8 Nov 2024 10:41:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xdgOfCvu; dkim=pass header.d=linutronix.de header.s=2020e header.b="VHh+O/Et"; spf=pass (imf04.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731062460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5s/mGxOR1k0iGJwjIgx4Nn5xFVAEP6Fy1K6QavY6cWI=; b=tk9kNQ/KhDbcxkTjOZzQG93LroXrNKwxP6+4N+1pn118TvOx49ZuRQzNUIE0YtNWI9s9wj Qh9248uqqdS/y+OhiX8OapFzdUnv+kpbMkqrpMggznd+JZGAUGGwqZPadhcJfPhE7DyG9f fF2/10osNKmOGitt+h51X55lcdpj3FE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731062460; a=rsa-sha256; cv=none; b=DR5wOB51n7neaxm90YWTkYGkY2CXlw7zmhD8feg4yjOeGocMj7gSlkvhI4cer8PEpsMC6L A4o/Lii88AWYIgUqgk03HBBfu3iSlPK85Cb84WZWZ47je6WJaY0RVuubE8MRwI1jmiXWSU IapqAVydUzDcTEyoac1c2PFtBOY17dE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xdgOfCvu; dkim=pass header.d=linutronix.de header.s=2020e header.b="VHh+O/Et"; spf=pass (imf04.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1731062544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5s/mGxOR1k0iGJwjIgx4Nn5xFVAEP6Fy1K6QavY6cWI=; b=xdgOfCvuilQldzQOMpNfqbhLBJWQ8hWgfi7YAXGqIUVsXt8dH2HKhMMZK1UbFE9QY6fyIt Ndu0wL+sCgqAC/jf70Ab7g3JUc+RIBuysBK44EcaCDJDT6QpDFHGFZyaI9tYZrJRVNE0lH 1rvDfnBEtTP6crwTrkM2orUoU4mRhm015yD54+bkX+3gmce+fqFYPLFiSYlI4gn3V7gkBc X843XtQxebo2ejvgd4+2eT99hArk1xL+U1CP8B3rFM4QTQx9MG1wmepd/myNImYUo38nYr SB702ECMD7Wr1hbu4ix/ZGEtwoN9OAKQ5fZgPEdov9XmG257QZwRqDb8c9qcPQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1731062544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5s/mGxOR1k0iGJwjIgx4Nn5xFVAEP6Fy1K6QavY6cWI=; b=VHh+O/EtWZ3A16mOSU7KTf672Jd4VxY+gi5vSUz+Zg2VvhVa/0tjSabgMacEJVyXoKHUPJ JWW3RE0D3a8cazBw== To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" , Boqun Feng , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au, Sebastian Andrzej Siewior Subject: [PATCH v3 4/4] scftorture: Use a lock-less list to free memory. Date: Fri, 8 Nov 2024 11:39:34 +0100 Message-ID: <20241108104217.3759904-5-bigeasy@linutronix.de> In-Reply-To: <20241108104217.3759904-1-bigeasy@linutronix.de> References: <20241108104217.3759904-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Rspamd-Server: rspam10 X-Stat-Signature: w1epnty8misrng75c55ja66e7f4iqz8e X-Rspamd-Queue-Id: B7C6A40011 X-Rspam-User: X-HE-Tag: 1731062499-268809 X-HE-Meta: U2FsdGVkX1/b+b300mF4ROg/SrsYH6ocbwsC1uDr5ChwrdLS1FkOJ9Cv+silrUEfkHnO+9RcwNvIEz4QfwwXShCCbkKbVCdmyyJ+l7PQNCJhohpSR8n4vu/U5EQ6W9wOQLC+jdSY85B5Bf0TMR/xEWaB7UVmtf6dDjceeKaWSijCQY9Y1iT/vmr+eVZTmP+AtadpEl2M9H2FmaglQ5/Tpf2iBm4l7H0XWa9CYilBmkkdKVH7lCHWF5pNH6CL2lTD/b6GggVsJY4Wus85b9J1GYUjdpXcFYxRZmpkiClHv7lG9itj3pOIkYgI6i7DVUu0U/NKbYOlD3IZeUhz5r8denAFBJy/Jqpedp9uzHfSFKg357dja4YqfnrmS9fTWA2Ws1dwz7olSxW8HMVpNLxwjnZ42X4YCecv/GQRLAkQhkZiS/vrodTJCafmyIE1J0ebqboO7c2CUYO2JbrjFafGcbofstFPWh2qJZp2/VA8GpyozTZQgoL0tj7W3rjVgF7LGDWcM5QtRX4QvcDEUjWNHLi8ia2Ab/MJ9HeeYgKAvUwPhzwlpcwyAeSZRHMxThXbDkQKvEqbsuoU/mh5S9Nd+XBC5JVDYe7NiUm0vp3Lirg0KzPaX1lhVFPVFOfei9bg/G2thK5GoRSWbEfups4W8miEfagDDPa5mUbaXcTYcFV0W+i43dQQycjCWcxtdmZdbDyl1CdnVOcHaBCBa9+lkup2Z7v1VbDPW+nbqsjvhfc/g/RgAnf1dbHj0pR5e+T24FjsXK+XHlSEOCR5TYv0j+1hJ51ns7Qkp6ad9JdcNxw+YHOMSw83MN6J6sILEKtH5koSD1+LmNTEQh0PZCJexnntvpLzH6VE7J75ZHuLHjaJlShy03TcEa9tl2PcthzZhSNQJSdEMMmlu+sQkzHua6RSXa0Z588fljXH6leZdKH40wsSel1lB7iub9v/RoPj8dz3Q89LrqbGE8NtJ/v fWmaQkw2 th6DEFEzNEGlxN9szzyYgLbGoPP1OQZaSMEHpjJpCA/oEZKJimVorhwV0RjjNQB4yArfdIn46D9gomeML3VVzVQROodngChm9REKFytr+0xiP60cT4WK4TAKgOHxPBAOrkbX3oTt3BJ2Kf4aE9GMcbqzPuhZdVQJ8c8gTqCvVF18yIu47PgCK7N9WJsEDTWmR4kKpTrnhmqjGvGjV6OgslpD9DsIM9nozhC4pVOBLpr71C4eyFCHZDkfTvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: scf_handler() is used as a SMP function call. This function is always invoked in IRQ-context even with forced-threading enabled. This function frees memory which not allowed on PREEMPT_RT because the locking underneath is using sleeping locks. Add a per-CPU scf_free_pool where each SMP functions adds its memory to be freed. This memory is then freed by scftorture_invoker() on each iteration. On the majority of invocations the number of items is less than five. If the thread sleeps/ gets delayed the number exceed 350 but did not reach 400 in testing. These were the spikes during testing. The bulk free of 64 pointers at once should improve the give-back if the list grows. The list size is ~1.3 items per invocations. Having one global scf_free_pool with one cleaning thread let the list grow to over 10.000 items with 32 CPUs (again, spikes not the average) especially if the CPU went to sleep. The per-CPU part looks like a good compromise. Reported-by: "Paul E. McKenney" Closes: https://lore.kernel.org/lkml/41619255-cdc2-4573-a360-7794fc3614f7@paulmck-laptop/ Tested-by: Paul E. McKenney Signed-off-by: Sebastian Andrzej Siewior --- kernel/scftorture.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index e3c60f6dd5477..eeafd3fc16820 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -97,6 +97,7 @@ struct scf_statistics { static struct scf_statistics *scf_stats_p; static struct task_struct *scf_torture_stats_task; static DEFINE_PER_CPU(long long, scf_invoked_count); +static DEFINE_PER_CPU(struct llist_head, scf_free_pool); // Data for random primitive selection #define SCF_PRIM_RESCHED 0 @@ -133,6 +134,7 @@ struct scf_check { bool scfc_wait; bool scfc_rpc; struct completion scfc_completion; + struct llist_node scf_node; }; // Use to wait for all threads to start. @@ -148,6 +150,31 @@ static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); extern void resched_cpu(int cpu); // An alternative IPI vector. +static void scf_add_to_free_list(struct scf_check *scfcp) +{ + struct llist_head *pool; + unsigned int cpu; + + cpu = raw_smp_processor_id() % nthreads; + pool = &per_cpu(scf_free_pool, cpu); + llist_add(&scfcp->scf_node, pool); +} + +static void scf_cleanup_free_list(unsigned int cpu) +{ + struct llist_head *pool; + struct llist_node *node; + struct scf_check *scfcp; + + pool = &per_cpu(scf_free_pool, cpu); + node = llist_del_all(pool); + while (node) { + scfcp = llist_entry(node, struct scf_check, scf_node); + node = node->next; + kfree(scfcp); + } +} + // Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print(void) { @@ -296,7 +323,7 @@ static void scf_handler(void *scfc_in) if (scfcp->scfc_rpc) complete(&scfcp->scfc_completion); } else { - kfree(scfcp); + scf_add_to_free_list(scfcp); } } @@ -363,7 +390,7 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra scfp->n_single_wait_ofl++; else scfp->n_single_ofl++; - kfree(scfcp); + scf_add_to_free_list(scfcp); scfcp = NULL; } break; @@ -391,7 +418,7 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra preempt_disable(); } else { scfp->n_single_rpc_ofl++; - kfree(scfcp); + scf_add_to_free_list(scfcp); scfcp = NULL; } break; @@ -428,7 +455,7 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra pr_warn("%s: Memory-ordering failure, scfs_prim: %d.\n", __func__, scfsp->scfs_prim); atomic_inc(&n_mb_out_errs); // Leak rather than trash! } else { - kfree(scfcp); + scf_add_to_free_list(scfcp); } barrier(); // Prevent race-reduction compiler optimizations. } @@ -479,6 +506,8 @@ static int scftorture_invoker(void *arg) VERBOSE_SCFTORTOUT("scftorture_invoker %d started", scfp->cpu); do { + scf_cleanup_free_list(cpu); + scftorture_invoke_one(scfp, &rand); while (cpu_is_offline(cpu) && !torture_must_stop()) { schedule_timeout_interruptible(HZ / 5); @@ -529,6 +558,9 @@ static void scf_torture_cleanup(void) kfree(scf_stats_p); // -After- the last stats print has completed! scf_stats_p = NULL; + for (i = 0; i < nr_cpu_ids; i++) + scf_cleanup_free_list(i); + if (atomic_read(&n_errs) || atomic_read(&n_mb_in_errs) || atomic_read(&n_mb_out_errs)) scftorture_print_module_parms("End of test: FAILURE"); else if (torture_onoff_failures())