Message ID | 20241108173236.1382366-16-dhowells@redhat.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791D5D64072 for <linux-mm@archiver.kernel.org>; Fri, 8 Nov 2024 17:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 059A76B00B9; Fri, 8 Nov 2024 12:34:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0070C6B00B8; Fri, 8 Nov 2024 12:34:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA1E6B00B9; Fri, 8 Nov 2024 12:34:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BBDA26B00B6 for <linux-mm@kvack.org>; Fri, 8 Nov 2024 12:34:45 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 474A580ED4 for <linux-mm@kvack.org>; Fri, 8 Nov 2024 17:34:45 +0000 (UTC) X-FDA: 82763625840.01.426D333 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id DBEA41C0021 for <linux-mm@kvack.org>; Fri, 8 Nov 2024 17:34:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FNzrnEzn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731087223; a=rsa-sha256; cv=none; b=W2HNplMbEyx7BvMnevefofWC8sjbYHILkbe94a5no41/SuRBSKgyuwCiWTZmneO1/qqNxS iZAMzmFihrxFHXoDZP2ulO3lalCUg8JZXLVlGnFX6DCxAJEjr2teWd/1gi97jUqR8gFwfM RBCbeW0MXYiAKlOqQguxt2PgsEhTHyE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FNzrnEzn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731087223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HO1trrAUxh6ged928OSrE9rZIbGVfYli8k1F5yQtGbY=; b=b8p2JjFlNZHxRn+z0yWohA7EG4NrGXmN7cMOXaoE0jWUlIGIxT9jDjAekNsp1yW8RbD5ju w1IiEAlVV3itBa8TEn0+zDxgScrENr2RMG7gTIWlZlE3tFsb9aCXCs5PqJpvDiR4KzEfTu 7UcoHwUw1382hqJrJLYCD0RTtH+/fOo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731087282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HO1trrAUxh6ged928OSrE9rZIbGVfYli8k1F5yQtGbY=; b=FNzrnEznkWJ2ruQYl1vUf7wqkp+KfLond0AtTxMJEgWJ8VmBACXuhu3uGlhEbQ2M01b37t EGwiVCV6rx/qMYKZ62oK6y0OlTKs1Vt/Q00OFZFg+eWQKv9tsJB9G/PrIHpfPyiAaPOUBB 0UGVyizeQqxQv0KIt027KCcRbp+cLKI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-qOuK97hKMEujosWEowMyUg-1; Fri, 08 Nov 2024 12:34:38 -0500 X-MC-Unique: qOuK97hKMEujosWEowMyUg-1 X-Mimecast-MFC-AGG-ID: qOuK97hKMEujosWEowMyUg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 973B21955F43; Fri, 8 Nov 2024 17:34:34 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.42.28.231]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1545D3003B71; Fri, 8 Nov 2024 17:34:28 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Christian Brauner <christian@brauner.io>, Steve French <smfrench@gmail.com>, Matthew Wilcox <willy@infradead.org> Cc: David Howells <dhowells@redhat.com>, Jeff Layton <jlayton@kernel.org>, Gao Xiang <hsiangkao@linux.alibaba.com>, Dominique Martinet <asmadeus@codewreck.org>, Marc Dionne <marc.dionne@auristor.com>, Paulo Alcantara <pc@manguebit.com>, Shyam Prasad N <sprasad@microsoft.com>, Tom Talpey <tom@talpey.com>, Eric Van Hensbergen <ericvh@kernel.org>, Ilya Dryomov <idryomov@gmail.com>, netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 15/33] afs: Fix directory format encoding struct Date: Fri, 8 Nov 2024 17:32:16 +0000 Message-ID: <20241108173236.1382366-16-dhowells@redhat.com> In-Reply-To: <20241108173236.1382366-1-dhowells@redhat.com> References: <20241108173236.1382366-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: DBEA41C0021 X-Rspamd-Server: rspam01 X-Stat-Signature: qr9xqq8wwurgt1z9wwtardfdijx67ufx X-HE-Tag: 1731087266-783243 X-HE-Meta: U2FsdGVkX18gRGi/pphrUaLnIfiSf4yBLN0rIjRp0eW7LXOXgmbw2zGOO7LSfM3wr+y6ziYAOUXzNunS+33lkz+TKaUZRuzsPtRHAv2edkpNHnAm8rj29xZkw/S1heT2sseWSNg/1JA/WGDv0lSnvSVc9YlHs3Cfgv6XBebdlN6F4SUAm8Tjy9uXkGIUP3et+KMm06dzxcOhMswbvRXG9wCN6MSy0PtBPFCeR84XdiWRPtiUCZgjFaHfMmtaD4MoIE55nwNX+dSMPMWtdaBIfqlsaE6g8QamFfHCcUhVsulgqMoqUSo5++yVwRaflHYTJQ09BjnOVDBrfHhTSrUtPaSa5QxxoiQzAJB9GT1SfGO2kQICyhZIU9o5SbN5MQGobZ3fAe1arAToMFf9pe4YGfW4EE5bvZpPBrplKW+57YCD6BD2o1gvLjTWXcFV/EEh1SqPEmGB8JNN7QoaCMc2k+07uqZbkR/hPOR//iQrc7ozSGud0CcKh4UrNtXhhBoJHu2fe2jjC5VUA3hN0KfYz5lZABkTIF0srRhBp6JrSKfgTjYydd8fFLQfHS4rXoxTD/XPyIQDM5OlS+7fLwmWSPNkPX6vD0LpsAMKDPlCNW1q1blGrj8omjhVowxfV7mv//JAGmx8yzGiOrqnWxdhTPJUba9G5bkqVaT90mghO6NSYcVrUMET616+WfLkP7PavASDOHXd9mlvpnzwgD2OnbUIJgOfP522YfZx2JFf4nGNbW5fvMQ9giHoa40hE1gmpPolQ25/boQ81QeyEEjD2UqUe2mtuT6PSw4PQ21BJ6uHnG7a55Nxtk/J5lV0Hk7WPCMyF0vGju3Vjzcrk+unYpVACuNC54v3XpVUHGwO59rhaxXMgmS9n5QWdEW7MDi1Nz34jdfrCAfso5mz6L2JuKYU6w9VmfXf0JFBzSnSCoVcvquH8ijODvtyr1FiR+tozVIL2jOmmL2seCm64lv UKiiLe5+ DvbyMQkPTmkaDUFPYWt9kbpMfduum7CshWdcoKm4mv8Ahe2GTSpnrqInVLzMxVwsvur0aGFFBkCCjUO7V7tlWkdERmBSjjYSSsPBrGokuu9XBHEvDv7Av/dijv6ufZkmSdtyGu71iTr7QZIXpXl2XEnaGKitnuCr5kFHrjyWtutnQgWJ05Co5IA8LZ4m48CIw7xZV/gkTbdl0mr5P/ubxCWxnvqXo/MZeGj4pBkLLd6sulURk/s90td3rc1uDQ9LrgV0rQz70+L49LyzdnqzOTNnJep5DniSD80ipPQeHXVtMtJYvFya2K4e8crOpVL2cjXa1yjvZXp2KHc6CkM2OFLne7sP8P+gnnloN17JKopqPp7teJWlneHLn5+xlIt0phG802uu1Hxl6mUBI03dWMjvgt5KBs+DfT4/GMphhHKR852cSUVbdB039d6F2l1JabrQjwzF2HTUKJPTHtwjTRDUrWaDLsTZc5c+TNhi+f20l/j+Gbbz98/WtOgMuDXqjdmzE81ZBXZNswR8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
netfs: Read performance improvements and "single-blob" support
|
expand
|
diff --git a/fs/afs/xdr_fs.h b/fs/afs/xdr_fs.h index 8ca868164507..cc5f143d21a3 100644 --- a/fs/afs/xdr_fs.h +++ b/fs/afs/xdr_fs.h @@ -88,7 +88,7 @@ union afs_xdr_dir_block { struct { struct afs_xdr_dir_hdr hdr; - u8 alloc_ctrs[AFS_DIR_MAX_BLOCKS]; + u8 alloc_ctrs[AFS_DIR_BLOCKS_WITH_CTR]; __be16 hashtable[AFS_DIR_HASHTBL_SIZE]; } meta;
The AFS directory format structure, union afs_xdr_dir_block::meta, has too many alloc counter slots declared and so pushes the hash table along and over the data. This doesn't cause a problem at the moment because I'm currently ignoring the hash table and only using the correct number of alloc_ctrs in the code anyway. In future, however, I should start using the hash table to try and speed up afs_lookup(). Fix this by using the correct constant to declare the counter array. Fixes: 4ea219a839bf ("afs: Split the directory content defs into a header") Signed-off-by: David Howells <dhowells@redhat.com> cc: Marc Dionne <marc.dionne@auristor.com> cc: linux-afs@lists.infradead.org --- fs/afs/xdr_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)