From patchwork Mon Nov 11 23:37:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 13871497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EFAD3ABFA for ; Mon, 11 Nov 2024 23:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E1576B00E5; Mon, 11 Nov 2024 18:49:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 119DF6B00E6; Mon, 11 Nov 2024 18:49:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED5966B00E7; Mon, 11 Nov 2024 18:49:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CBABF6B00E5 for ; Mon, 11 Nov 2024 18:49:13 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 882D8C191A for ; Mon, 11 Nov 2024 23:49:13 +0000 (UTC) X-FDA: 82775457366.28.2C2EFF5 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf03.hostedemail.com (Postfix) with ESMTP id C03AB2000A for ; Mon, 11 Nov 2024 23:48:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=NBsRF9fh; spf=pass (imf03.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731368779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LL88Qd2tMlsmBvcuEyGfQPoq7EBSjG4mmD1oB3CTmL4=; b=tyLfkpokH2JpSbNxGhKv0ng1zTTzleCRtNRZe5/XXzuj45txIQ1mgp0RCSqsnWUjxuDhm+ iK8WmEGe6DksD2idGHFpH6dnkAoNgMIE+so5YcBt223WfY0e3C7sJ9G9uiT2t7LPdO179c M0GfL5TtL0N6qzzRUNR9UlbUZI7PN2M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=NBsRF9fh; spf=pass (imf03.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731368779; a=rsa-sha256; cv=none; b=S7n950sZdqlbz76s0FhnEDrapkauEDL3iACkEdImyZyzz3j6GKfu0+rctDZTzT0f4JdFkD NnV3UN375kBU1N/7vvmmMGvN5q36Mx803gaZKNcTFebDwsnFOx/zDYmve3vW0Evdjwq2Tv VomWdPJcWqVnLL799Fe9RLE6B3tFpb8= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-720d14c8dbfso4843549b3a.0 for ; Mon, 11 Nov 2024 15:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731368950; x=1731973750; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LL88Qd2tMlsmBvcuEyGfQPoq7EBSjG4mmD1oB3CTmL4=; b=NBsRF9fh4U0120nIZzIZYUqq1lgIsaJIymUqHiIrMtmimrHum7iYKjCmw+L9QrMLt2 NZs6/WtdUwvPTC4ZbUOLkWOGzBjLVe8LoGKI2Gs8aN1nq4xBgN6ytNN11VcE5NR1o8IG Nq+me4/cecyYhmzt2/6Xk7tNPhk7STjZRlh0xMVoKaVio8dypv9TTlGXm8IuWTbQcJ3H 92sYt0vd0yqNp0K2EG3jGdCvqnXk3DrMaGoWrmH8eIZe5kWcXD+xLWRVuce8dX75mP/z rq/NGzT0xdSHOpp+cqR9jHjGjfuKdy+0h+Iw/e5D1G2b2cOtwduij8uP6YfOjSmFBKu2 JwoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731368950; x=1731973750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LL88Qd2tMlsmBvcuEyGfQPoq7EBSjG4mmD1oB3CTmL4=; b=g8j2weBMCxcIkyKiYZUC0/ytRrXNg9uyh6YCd6eRW2fPF+arm91FPCNE0pxQnfgSzS 5bWqpkxCnU2Gvqfm5kG2gfrRCVZ7yfJNl8RVI11GPm2E9witXUoJqo5QTshm4byXSBhr DDe/OJcSUyuj8NaTiHP+IBs3yEowY9fYwTfVT2HelLJDJ/ZlTvNVLwRIqHfF/rklOEza Z5ZDRdOjUWDFb4RXBxHJtAxB0x+IbpYgVud3S8uGmpQ71zwnu9cXCM7nps1mbDyUcKis bIqjA2caO8/WvmGzEAKnkkS6MNhPW6bmiZTxBXShnr6zQ8tY4LTAEt5X5BQVm7jMBzlF a9Lw== X-Gm-Message-State: AOJu0YxQEQ4hxgYncAI9SchsgHHuAvb2JwWcoTmsWCowA0PRiewr2I4F cLk+gAzYIIOe1/pTlPNNHWpmyXK1qT6Nns8Oo2DtYKZ2Yt3hJGHi5VLrfjY5i1eQaRiy/rclxoO +cjc= X-Google-Smtp-Source: AGHT+IGxdsMu1dfGOYWXi1R28aWFhjsN5Q3I34Dwpy3CjKRXcDtvBr7LZlUVTVK3RyQbj+sGtC8u7g== X-Received: by 2002:a05:6a00:3a29:b0:71e:680d:5e94 with SMTP id d2e1a72fcca58-724133510d7mr19932677b3a.19.1731368949731; Mon, 11 Nov 2024 15:49:09 -0800 (PST) Received: from localhost.localdomain ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724078a7ee9sm10046057b3a.64.2024.11.11.15.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 15:49:09 -0800 (PST) From: Jens Axboe To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Jens Axboe Subject: [PATCH 14/16] xfs: punt uncached write completions to the completion wq Date: Mon, 11 Nov 2024 16:37:41 -0700 Message-ID: <20241111234842.2024180-15-axboe@kernel.dk> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241111234842.2024180-1-axboe@kernel.dk> References: <20241111234842.2024180-1-axboe@kernel.dk> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C03AB2000A X-Stat-Signature: nk3iw7jqi7a1a4ykzno1way1aixfsizu X-Rspam-User: X-HE-Tag: 1731368932-347957 X-HE-Meta: U2FsdGVkX19Ndp/yfVkBvs1aYGXq/g5NasTBVD+1nrpOCenxLJSHwA94jT75etKRTxMZUx+IixbHolRDDDZAHhQuiphQUoAxdeJR16vqRTggsKTsflnIkoTK+3EexjE2YtxTh7/lKCXY/L/OjlxJWmcg3f7qSRsfx/7NeSZ0B6MNZ8tx5o118C+r+mk2J8WL6AR5gImp8NOtFWLIzpsPwFO8SCQ7Sz8vQQp7QsfmghytX9H2wQLU++RWvkFzh8SMA146mqF8bgYVEVVxK6UYYHzPBUQj8lCfwpy5sZnwFaZHtvcj12n7HP6t19VLaXWhJi/EUdrrVloUPoOZ69igFMPxAcjPPNgyzVfW7gn6rFaKlExiEfLt4icpoQS56q9Jin1vcVleDsQIdXBUiPqPTeK+WYUV9+82alDGKiBapP7fwP4UaL8qEUabV+ioL4ebWG9fKzjCZ2CqYQsWsMB5IFk7EuLOoQp6kXkojkbGEaHtH+1G9pDsx6SJPx7XtpdsVWimvsgHFiiyQ9qw34jkjQ1U4B7ZDkl6P8yu8KiN7YD9Igqnfdf3ALJLDN99+czggHpgDPnTRmyUFJigtBhnfVbYPcqXCb/p5krn8fiXhXZ7iL84FZONW27EJRssj0yWAFL02jjrNQZv3SY2ugt/bCUAOFUFa4+aSXjFxul2t7oxkTFmopWgXiinPlOOTqjeT0wU1Cv9BIvFJFiQoDL6KEfhypR0mi2DCQnEJC1jj/AN0sm44k7niTmrjb6nkS6bB+achHimL7mWN9eYCN0ZjiZuDWQSYdOs+iZONxS7/F6MQVP4iwgvlGBi0KN5IXxIw7Xwslo6pRH588vkQ0Yiyh+U0IyEtXo18p0t1ObUyngk9Ng1EXNTwFm1tayCRO7VGSUtkrRUzzELZJfxVUnHoSIAOT0hzs/fcH1Gy0/+KBxCuEi2JDTxc9pv63cLMPYie9tX0V9iS+AtGjLmjud cICP96ih 68JceMK48HZx+bJ9yrx3yteUTTH/f5J2cb+VYBgUxiim9IR0I6ZhjAQABeG3n6JQIE4eangPTsU9gUpKdjM0GZt9l/IUqpqsIhpyDNbodxE6sGBnRM6AvN2AMijQsaXnxGv4SSr8fvQrhde/7bMTDpLeByXKMjuXU1IUpg4Ylmu2eZaZivfqYJUQTZ2VERsN0UqDup2Xr0t2iGoFzDitkoHcF2CDiDpDBAE4Ze8LBUHc0qauROJO2KzJlL2RagBRXqRm05tX3P5mQtHH23eJgnqpa8wwsN/k2P/XwMvyuTmUI6LiIAoyQ8AlNt4SvPcjK5B0GkkZkJ2SDGFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.034356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: They need non-irq context guaranteed, to be able to prune ranges from the page cache. Treat them like unwritten extents and punt them to the completion workqueue. Signed-off-by: Jens Axboe --- fs/xfs/xfs_aops.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 559a3a577097..c86fc2b8f344 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -416,9 +416,12 @@ xfs_prepare_ioend( memalloc_nofs_restore(nofs_flag); - /* send ioends that might require a transaction to the completion wq */ + /* + * Send ioends that might require a transaction or need blocking + * context to the completion wq + */ if (xfs_ioend_is_append(ioend) || ioend->io_type == IOMAP_UNWRITTEN || - (ioend->io_flags & IOMAP_F_SHARED)) + (ioend->io_flags & (IOMAP_F_SHARED|IOMAP_F_UNCACHED))) ioend->io_bio.bi_end_io = xfs_end_bio; return status; }