From patchwork Thu Nov 14 10:01:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oleksandr Natalenko X-Patchwork-Id: 13874803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5AAD65C68 for ; Thu, 14 Nov 2024 10:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8BFF6B007B; Thu, 14 Nov 2024 05:01:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3B646B0082; Thu, 14 Nov 2024 05:01:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2A6C6B0083; Thu, 14 Nov 2024 05:01:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B658A6B007B for ; Thu, 14 Nov 2024 05:01:50 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A688ACE79 for ; Thu, 14 Nov 2024 10:01:50 +0000 (UTC) X-FDA: 82784257164.19.626EABD Received: from prime.voidband.net (prime.voidband.net [199.247.17.104]) by imf12.hostedemail.com (Postfix) with ESMTP id D798D4072A for ; Thu, 14 Nov 2024 10:01:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=P8NbYm2E; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf12.hostedemail.com: domain of oleksandr@natalenko.name designates 199.247.17.104 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731578326; a=rsa-sha256; cv=none; b=qLyjg9fn8eAjI2jlT9NG1fAlM+PZtvMBTuQdc9voJKDQxph+3uLdhiL+epoxhcMd5JY+c/ k63q3Uaq3/sw7+62xaIYrSK2wIy1rvnu+V5Uj4Z4bKTuznEke2OP8VNIbAAH/veLXN+fHH AaoJZkcInXvDLj5dXZ/uRW+V5olS4Xc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=P8NbYm2E; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf12.hostedemail.com: domain of oleksandr@natalenko.name designates 199.247.17.104 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731578326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=b6kOasXKOb7vqjNpZjqu3R9kaf6Rf+hRFr9lWZXsLb4=; b=ARdVAGjnXKo4g7aCX1B9Lo95iUKOfy7wE6dTzkUr6+ZeXUWkBqtEAZrzA1lMPK8fpLpTg+ LxicHZOiTkoHM+WgT1WYQiFEzzuEWPXB3uIN1DbW0qCPI/ViAAp44s/XCMz9vidlFglhHw cSji4QUZxKhGQhh84bURCfoXRB+jXYU= Received: from spock.kanapka.home.arpa (unknown [212.20.115.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by prime.voidband.net (Postfix) with ESMTPSA id 51C7B635B045; Thu, 14 Nov 2024 11:01:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1731578501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b6kOasXKOb7vqjNpZjqu3R9kaf6Rf+hRFr9lWZXsLb4=; b=P8NbYm2E/CHhWSOLEm0J6zGlrzJhFpPwpzB1XyFmpk9rnGi1ZAl1BLwov23ZZbn1PTECts ChUkCbV+Cw4YbkXHGaFxlSCHd3HK4eEzc0LlPznjsHYMlCu8bKnLkbsOO7CJPxbGni2SCr 5CVSXHvvNfXIIhcYWL8fPB35EVTHlRY= From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Wladislav Wiebe Subject: [PATCH] tools/mm: fix show_page() build error Date: Thu, 14 Nov 2024 11:01:40 +0100 Message-ID: <20241114100140.406416-1-oleksandr@natalenko.name> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-Stat-Signature: 81xi479ryw1kipp71gwx5mi1sbkcxrrh X-Rspamd-Queue-Id: D798D4072A X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731578483-364547 X-HE-Meta: U2FsdGVkX1+qlV3jQqUqZqDkBbSyNaKGP3VgmUVEcIRdaxkqMgphJFYYtsmSFdXbyHNqX5Bx6cU1ge+vJxBCdPXzQYHeHcg/+IdbYIR66vq5tEnx5XS+CGKGpPmX6p7ISows1xgUFfUi8NoeYAg/sw1nYq0fALeA5lpLxkhGLZ0btGv0G1+NZFvxNDBRpdA3dWqdBWJUs40XSjrCqB9xon150O86+VJkgXFHtOZE72IwKJ9SM6CYf6y4BsrnFl/GdwppPe1Jkeu7blyX4I3BZdkHMKScDAaeZVdNqqD3rAhU+0X0NXlDcL4F13x7aWjP6JpkxpVmFaHFZwmIn6JnK/87KgWkOcGfJLJ10sVnYnXcX75VT0LRbyHe6FA9zkDFI9CHcdRNCwaajOt9p5+C4nnWP9BQnzCRqqKP+OlVDaq/yQ5rLoaPG2eWK8glDsc8UKwewWE8C3smQO44p7x4RFfew9xIRFQZ9Tp6hRiTUCBj/rbH660dokHSCtv9U4UO3aLavP18ELKC2UlXZV1dGYIAR2FTtme6lBAKFcbeX7CHGzhfB9rbUrVXUclPwwtW8UGzDRE+o96vUC+pnT2CpMcmw/9BVsP5H52/OA9T4Ps1/xpjnqdD8cjulpr3yETJVsCg5ljsEko1GcZIPR05yqoCqkNDDAAVrH6oQDWT92Mkent1gaRDzQTidh/YH5NVROVpAUjaOzVw5w3VDN/OSyoIroNzTOBA8l2Jb0VoEhsXLHAUWlZeih6KVVKZmTx6pwfnRepjSAdMRsdDKVQkRuxWxZDIFmEES18aZnzHYumMoboWwgbKSEWqfnJVQ429BId4B3Iws76LAV0nJJatRBGfLUexjYKn7Do5lcmBX1x+Y7yj8fv+/o0mIO1G8vpCpWAN9Cyo8qLK3ncfRxCOUBR/6Qypr0H2vvCX13pwvDYuFbx8AB02opubzqm+xBdfTiXbgzw/FGt2nBg8q7X vgaCYP5d I53LQLub6yzV6WQQzwvZeXJsieZp1T9kNg1QVn8VgT10qrGDA0KStCU5GCFykT38Q8Z9aqucf67BJlbISqyvigod3Z1sIIzdanK4EGfHWPOmAj/V9jNPxyWpRHIfmGY8iTBA1f8ybcwAZ3R1jAiMaTSKkHU2Zm+x7XLFjR1c2fGZTSDD+uZZ6vTK4Dp6j3+eqTedeJnRL+KR/r1UhTP5kcb312NhVK6K3NpwbRU+KETD48iUvNgLECgBPPu4QVMjXONaa3HeHz7bhW/699z7XXNq3z3+FeLHZLIhz+J/SsQUaCBIzjqrgpoGg6aphYfFx09CrbtOIEZUVPVhEpXziBwgvBKEGtzs1nsGCZ94P5nn7VTBdXa8572MkJyix3Aj7TUw/gxKf8t5QiHBUDL2kemqcZeiBrS5gfvSfmJbmtPXUHtIv9EJkzW6Iq2FMgAhzOqlrZnQnrXE8qNNsvCIaX5ZlwW6NkHo6/DFt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: At one point I needed mm tools for debugging but couldn't compile them due to the following error: gcc -Wall -Wextra -I../lib/ -pthread -o page-types page-types.c ../lib/api/libapi.a -pthread page-types.c: In function ‘show_page’: page-types.c:423:49: error: expected ‘;’ before ‘if’ 423 | printf("@%" PRIu64 "\t", cgroup) | ^ | ; 424 | if (opt_list_mapcnt) | ~~ page-types.c:416:65: warning: unused parameter ‘mapcnt’ [-Wunused-parameter] 416 | uint64_t flags, uint64_t cgroup, uint64_t mapcnt) | ~~~~~~~~~^~~~~~ make: *** [Makefile:23: page-types] Error 1 Trailing ; was forgotten, so add it. Fixes: ece5897e5a10 ("tools/mm: -Werror fixes in page-types/slabinfo") Signed-off-by: Oleksandr Natalenko --- tools/mm/page-types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c index 6eb17cc1a06c5..bcac7ebfb51fd 100644 --- a/tools/mm/page-types.c +++ b/tools/mm/page-types.c @@ -420,7 +420,7 @@ static void show_page(unsigned long voffset, unsigned long offset, if (opt_file) printf("%lx\t", voffset); if (opt_list_cgroup) - printf("@%" PRIu64 "\t", cgroup) + printf("@%" PRIu64 "\t", cgroup); if (opt_list_mapcnt) printf("%" PRIu64 "\t", mapcnt);