From patchwork Thu Nov 14 15:34:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshvardhan Jha X-Patchwork-Id: 13875273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6E8D68B33 for ; Thu, 14 Nov 2024 15:34:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 178306B00B6; Thu, 14 Nov 2024 10:34:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08A606B00B7; Thu, 14 Nov 2024 10:34:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1E266B00B8; Thu, 14 Nov 2024 10:34:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C32D06B00B6 for ; Thu, 14 Nov 2024 10:34:50 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6A29C121364 for ; Thu, 14 Nov 2024 15:34:50 +0000 (UTC) X-FDA: 82785097458.16.09EA610 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 4CC26180014 for ; Thu, 14 Nov 2024 15:34:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=oiZVkx+A; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf16.hostedemail.com: domain of harshvardhan.j.jha@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harshvardhan.j.jha@oracle.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731598310; a=rsa-sha256; cv=none; b=7t6cpjFrfYgB7ZCcziulpmi2mksfF1kYa0dWH8l2Tf9OB595kq2p6Fhd1aaQVBgl88QKSE gXtswRODABNjqK4Ea7UEIZEp/mokJrVSYhPZNLHVvtiMArSgepCv8PIq+JbAkelx2MBlK8 IzYLAnWFcJ690KqDVYQzAsagu7oJ2Ig= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=oiZVkx+A; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf16.hostedemail.com: domain of harshvardhan.j.jha@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harshvardhan.j.jha@oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731598310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a4TSD9p/Lv2y0y9US8f/wZ0ZmSdcoyCHbSQIaHkj/Z8=; b=YdTqvdrgDq1vMMZ0Pl2M89oVpEjTMITc9TZ3U2mlcK4nLL64a9fDneCxkU/hpUx6fgLil3 ry6GTPvt05D6B9nO5a/ktbwLJe1vHlWam/roeUgfD4+WmT86mrBColddWBnCvntjAUU/lG /CCoADUDqEwT9nAIAAop16y43eGV1cU= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AED5wBi002334; Thu, 14 Nov 2024 15:34:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2023-11-20; bh=a4TSD 9p/Lv2y0y9US8f/wZ0ZmSdcoyCHbSQIaHkj/Z8=; b=oiZVkx+ABWSNdowD/1TRN cTBUnPSIXklHr2/txH0vI6WNIFKSOCYQJInqzVtZ9UzxJ+OtyScKamvvWk/YAXUG QW6OTRaxSmfoBecoLmim8HfFJIREcHKxNqICQtp2LtSGnFjMw/E6D1q/OhyPVue6 euHUyqEjYFjEcbbbot5aDLfH58fPio0ecodWz6wWeY22m1uviSNFsTi5rkb50eWH WjAB/LFbJxihok7cDb40m8vPP6sM2ZBPi+axWcyA8fqEuzFEQufAhp2hhmQbW3pr TVzAeZMsDFWN2xL3nYLXdJnNciIFh5Dq8qTe5hm1Sa5eVx+M9A88I9R1EJm3Iqbi w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42t0k5hcw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2024 15:34:47 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AEEXxPs001157; Thu, 14 Nov 2024 15:34:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42sx6bb006-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Nov 2024 15:34:46 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4AEFXvhx031217; Thu, 14 Nov 2024 15:34:46 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 42sx6baywk-3; Thu, 14 Nov 2024 15:34:45 +0000 From: Harshvardhan Jha To: akpm@linux-foundation.org Cc: harshvardhan.j.jha@oracle.com, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 5.4.y 2/4] mm: fix ambiguous comments for better code readability Date: Thu, 14 Nov 2024 07:34:41 -0800 Message-ID: <20241114153443.505015-3-harshvardhan.j.jha@oracle.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241114153443.505015-1-harshvardhan.j.jha@oracle.com> References: <20241114153443.505015-1-harshvardhan.j.jha@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-14_05,2024-11-13_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411140121 X-Proofpoint-ORIG-GUID: A0m90aDvdgZNeH48KCkGkYZmqzRYi-7h X-Proofpoint-GUID: A0m90aDvdgZNeH48KCkGkYZmqzRYi-7h X-Stat-Signature: 8wxq1wmkebnxez8m13ndwonetfe9ys8k X-Rspamd-Queue-Id: 4CC26180014 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731598444-894137 X-HE-Meta: U2FsdGVkX19JIRhv7LMo7V9mR2ic3zH1rb9TdKFqenbUyurhv+3XvZGFaVBplhHC1HhU2bg6PZEdJpJEIUwsv7OGZ2ueGgycVttJFRYAjrnaUECOVO3zjDGhKPtvb23gQmIHD9sjfFl/wX0mw8yB04ptfu5dL4Ri4H2u9E79KpO60y5ubs+lBbd7zdztkign0seb9lRjmLDEHK4DtmsdmoltGeG9LCzhvxv8LmuAly/KCqp7MoLJAFOip80nt8KP2Q7OZDOBXheKxTQIVGcnKLzX5fnpcSdU8OAkdjGuTJPMRwgahIvnf1hD0ZZ6UiRrsWqg3AzCEG7rWZniUESWPpIk1MHt3l3ZshWXxU9XCQEzz2Yoj/4bFvpFRSS2hokqMegLfo0/5pjZW1Cwf0fpdMvbl08hVELbnMmH/z1DqVH8iYNd9dvXoVDOuQRDR5cdm59AZ0OUHRugqeG4KuCRvFHBkFH0nEN9frOpZ20I1RVqttuQLNYSqyhPGLIvNZ+zPjwwfXvFEKzQxe+0aUY/aCHW32ymvJ6ECfuFL7U4sVccwOVUTVBPn6svtN2sp/zTnq15bkNgkPd1hJFisozKgF2RIqJ+YW3m1hCCKlnpK4BcGewnMqz9Ba5NfdH6r7HXOWU6Mj9P9Yd4BJtJGwhNj/e71qEENf/VUeEf3esvhb5+HQHPXezmBM98oQQ4ZhfqLq5tsogwmURDNveVe+5FDi2+7UmJuuxABGDHXlJk3tZwlVGofmaFr/44WlNMhqghnX64tP8qMvMZ5NMNvBznG0PLF6OUJO5CezDnqYBi5APjnLVlJEfoXlarToiu8U0KjUJQM4CpSSOQga0ciSN7piFzcgZFAhO6Vyk9Ej5OYZS//VUToOeWTL4QTe53adh0lP4t+f37qb8DQD+2SwZqZlML0Ze3+At69fT1+ejRb7CDoZ/rsq21i3MvtYemIFtcc2WtHO2xms5paFihO6U jyoAguFp LCFROCO3+twFMyLW+lBJS52YGbPPPGka8u9NzSAfOID+dLzjph0LRpkI80leHO6Mino9C6nQK2MpVXv0wy+dUyJmjYIsckot7cK7v6f0wUnwYhRG+2cDIvYb/RA1T0aF1bNdfWlDe14U9h1jyqfvBtI/WHRc0/RL1p/R6clB5FcMjrBTDpj9wdHnTpaEzC2b5j/5MajePPHv5jm2MC0ZpHCo3lXEb947yTXKbvB/Y1aijUZiz2lQyGVCMwQSl6IdIBiZWGY91HnK6I6iHXNzBWduWU0ARY1edqoMu6cf+0O4skK69XYP7xhnnKTQuKIvj+oZY/hNSAjcKv0u0jhXTP7oO5W/xOr/T0MFOVfvPQrynliNV0vwHk5orXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: chenqiwu commit 552657b7b3343851916fde7e4fd6bfb6516d2bcb upstream The parameter of remap_pfn_range() @pfn passed from the caller is actually a page-frame number converted by corresponding physical address of kernel memory, the original comment is ambiguous that may mislead the users. Meanwhile, there is an ambiguous typo "VMM" in the comment of vm_area_struct. So fixing them will make the code more readable. Signed-off-by: chenqiwu Signed-off-by: Andrew Morton Reviewed-by: Andrew Morton Link: http://lkml.kernel.org/r/1583026921-15279-1-git-send-email-qiwuchen55@gmail.com Signed-off-by: Linus Torvalds (cherry picked from commit 552657b7b3343851916fde7e4fd6bfb6516d2bcb) Signed-off-by: Harshvardhan Jha --- include/linux/mm_types.h | 4 ++-- mm/memory.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 2b3b2fc1cb33f..afbe3056a8d7c 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -284,8 +284,8 @@ struct vm_userfaultfd_ctx {}; #endif /* CONFIG_USERFAULTFD */ /* - * This struct defines a memory VMM memory area. There is one of these - * per VM-area/task. A VM area is any part of the process virtual memory + * This struct describes a virtual memory area. There is one of these + * per VM-area/task. A VM area is any part of the process virtual memory * space that has a special rule for the page-fault handlers (ie a shared * library, the executable area etc). */ diff --git a/mm/memory.c b/mm/memory.c index 238064ef73ae8..50503743724cc 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1922,7 +1922,7 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd, * @vma: user vma to map to * @addr: target user address to start at * @pfn: page frame number of kernel physical memory address - * @size: size of map area + * @size: size of mapping area * @prot: page protection flags for this mapping * * Note: this is only safe if the mm semaphore is held when called.