Message ID | 20241115-converge-secs-to-jiffies-v1-14-19aadc34941b@linux.microsoft.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4402CD68BDB for <linux-mm@archiver.kernel.org>; Fri, 15 Nov 2024 21:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B3BA6B00A0; Fri, 15 Nov 2024 16:22:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8396A6B00A1; Fri, 15 Nov 2024 16:22:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61A046B00A2; Fri, 15 Nov 2024 16:22:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 32F9D6B00A1 for <linux-mm@kvack.org>; Fri, 15 Nov 2024 16:22:53 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F39C9403EA for <linux-mm@kvack.org>; Fri, 15 Nov 2024 21:22:52 +0000 (UTC) X-FDA: 82789601664.09.10D54E6 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf30.hostedemail.com (Postfix) with ESMTP id CD3A880003 for <linux-mm@kvack.org>; Fri, 15 Nov 2024 21:21:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=DBa8qjnf; spf=pass (imf30.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731705533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTcGWD0h0ZDgyuZTU2DPl12ZGyATdibDkhzA92Hlf6s=; b=6veteZMi4YUEHtycBRqP3qDMEObm0hAQoKsFNoDzj9drhvbpmt/hWwqUlZZsJWTjw8QNnc w5ooAWPiywLo8wAukSLz/nUUO0n26P+yhoeo/pEvKMgJDl6xrGtm0/CK2uia13t+wfRgRK kZH7v2TFDqEfcw5Q42VR5q4aGWM/Zww= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=DBa8qjnf; spf=pass (imf30.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731705533; a=rsa-sha256; cv=none; b=bkpzcKDBoxPavm9nTarkdyn4bOWbPCxWEStM4nWoqtj+wzV3Ry3i2VAcyfxndNGqoMrW6+ gJVLsd1VbCBqey101t8aNO2G5QQyTknC0z1cQZkdplZQLj3Q/oJlV5O7+pzNyFbvkIb6mA ci8TnXwHPUCpSpjSRWU73D5BmJEHnuY= Received: from eahariha-devbox.internal.cloudapp.net (unknown [40.91.112.99]) by linux.microsoft.com (Postfix) with ESMTPSA id DA1F220BEBD5; Fri, 15 Nov 2024 13:22:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DA1F220BEBD5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731705765; bh=YTcGWD0h0ZDgyuZTU2DPl12ZGyATdibDkhzA92Hlf6s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DBa8qjnf5MNMswOkSvV0JQ0FZ5Ed99ngIFRkSTMDnQu36t8YmBRJOYBHSU3QDj3se Fc7TuS2jcyT4LTDRPo4wVBYTyNbI1RA/bW4apXI30r4Q7ECcxM6eooQMWk2K6CFIVq CFABxdq7HpjQyK3+DUwbjslOaeOI5LwZ/vHYLMt0= From: Easwar Hariharan <eahariha@linux.microsoft.com> Date: Fri, 15 Nov 2024 21:22:44 +0000 Subject: [PATCH 14/22] gve: Convert timeouts to secs_to_jiffies() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20241115-converge-secs-to-jiffies-v1-14-19aadc34941b@linux.microsoft.com> References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> In-Reply-To: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> To: Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik <kadlec@netfilter.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>, Julia Lawall <Julia.Lawall@inria.fr>, Nicolas Palix <nicolas.palix@imag.fr>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Russell King <linux@armlinux.org.uk>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>, Ofir Bitton <obitton@habana.ai>, Oded Gabbay <ogabbay@kernel.org>, Lucas De Marchi <lucas.demarchi@intel.com>, =?utf-8?q?Thomas_Hellstr=C3=B6?= =?utf-8?q?m?= <thomas.hellstrom@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>, Jeroen de Borst <jeroendb@google.com>, Praveen Kaligineedi <pkaligineedi@google.com>, Shailend Chand <shailend@google.com>, Andrew Lunn <andrew+netdev@lunn.ch>, James Smart <james.smart@broadcom.com>, Dick Kennedy <dick.kennedy@broadcom.com>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, =?utf-8?q?Roger_Pau_Mon?= =?utf-8?q?n=C3=A9?= <roger.pau@citrix.com>, Jens Axboe <axboe@kernel.dk>, Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Andrew Morton <akpm@linux-foundation.org>, Jack Wang <jinpu.wang@cloud.ionos.com>, Marcel Holtmann <marcel@holtmann.org>, Johan Hedberg <johan.hedberg@gmail.com>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Florian Fainelli <florian.fainelli@broadcom.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Xiubo Li <xiubli@redhat.com>, Ilya Dryomov <idryomov@gmail.com>, Josh Poimboeuf <jpoimboe@kernel.org>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Lucas Stach <l.stach@pengutronix.de>, Russell King <linux+etnaviv@armlinux.org.uk>, Christian Gmeiner <christian.gmeiner@gmail.com>, Louis Peens <louis.peens@corigine.com>, Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Naveen N Rao <naveen@kernel.org>, Madhavan Srinivasan <maddy@linux.ibm.com> Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen <anna-maria@linutronix.de>, Easwar Hariharan <eahariha@linux.microsoft.com> X-Mailer: b4 0.14.2 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CD3A880003 X-Stat-Signature: 3do8a1hdxxf1hjfuwwmyiiai7ceted9e X-Rspam-User: X-HE-Tag: 1731705684-426275 X-HE-Meta: U2FsdGVkX1+9ENEhmbmV4EMBJ89EZwmc3NXfXR2JmXvkPWZQuZOJWSC38+fgCgyV9UhjM+S/AfQ9mVfLcW70S7ZmeG8Hw4sT11In7b7RZx4SpTF5u8D1wtJwf+Qooqbh7J+5w8z5ZInLrqvn0lCYLHr3zfKaQSEy8tAwupSXOiIuXSxlND56weUVLMP4qNotLrqgMLyjDKIUBbL0K2Dsqz73B/Nvv7ya9e9Q9aOTfWqx2aVfUBGZAaLLX5lTvznj4h5lIsmBVdyywwIKohYJdAj8iZMphu998d3dvdHqGTMZPGwiAIq9rVluW3taVE8MNMdC68FbQ19hOoY5DGZ7RK6Mzvk16RKcfjOKi8aGDpbgMZnuH0kIPzEhJTd1DR4+0YhFlx2IqiBaINUbM8XLW+8KiAKLkLsbMNPcFOjWUWMtn8mMf/Z6HW+NI+OyOShAXFyz7b6TlN06OK1lQSnJeD35B4bS0YIxZ2F5vngrnEJC9uvNbBr0r4c3r4fxYbQf6GTcFYRfiQpWtDI4zBiHXdMk3B8KLT7kniKmmGBz0LypUnpOCKgfJ7X+bNWSvCXr9091wEJQ1x8/N2txBCqJBU89OyvFefU2bVsQOOWh8S1OZCiNZEuEYNzkiRwDW2HYGuEDKzL6suqFrWXDPDfHoABma8Mz37JN1TgnCIVRO0kkmExE8/VhpCYEM2wB5GqA1STFgwpKeOYSON1oZUEl94AtInZcmN+apizUUNr6uv6Bf+TkRPrYc6vsCsNwhPdJhSxqYCFk9jmykqoQ4MoJ5NRUK1skop0HpP9WWxmRQfNxEKo5gvMsPNubXXzz7lfwa1vG/56Nhw4o/4daGgJTGHtlzSMFPEkg9TvCK2Nsg/WRvn69u6hTwlWTh6j6jlctrfs078z6khaPvrhNUsdhBbmgZ5IzOw2jW5fVYBSIjt0+xuQoQMxjZ5t88g5bMAUruYZPTJyzUqGwah9AtL4 FlXhHEci iasJkDr9dAPH3OgeoheQstnRoYXigYSWI8sSGqTowWP17Q9rmjDG0u8Juv8ZG9j9mZtdwt/4vQTXdQQt4Zlyq8ZdSF3WbyoKSg8CX0VT+eCEmRVQKPcItgg5V0z3xvrHMi96g3RAHV4RaQPbAJgszjiyI6q+J+s3l18rh/9Epn7CNkycjpmZHNaRrksIn+OECSQjpLRECfu9vbhfn3IcYsnp0JLrppVg2OBYoj8qEVuMQWvV87Da4sMQdeFcq7bRTxcOOxhF8pcjliROnsqeOmoNjMJrch/+28AI8D3dboxiD/ercXsvB7xr7ZnOTn7XfBZViMf0YtRnobpHgPb39nCVnWianbX0axgjhuw8a7qayH2RHgdXImWXKqy3l4VyYUWcUbgfHKmQ7WEfAA0rvsbFsCwS04+7NCnR7dIFqn17rHNmKUGkQBelB/VwsfSx4SVPQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Converge on using secs_to_jiffies()
|
expand
|
diff --git a/drivers/net/ethernet/google/gve/gve_tx_dqo.c b/drivers/net/ethernet/google/gve/gve_tx_dqo.c index f879426cb5523a7e150f363b5e57b9d472b5817c..394debc62268aadf2579f9b516e045cb48287e7c 100644 --- a/drivers/net/ethernet/google/gve/gve_tx_dqo.c +++ b/drivers/net/ethernet/google/gve/gve_tx_dqo.c @@ -1146,8 +1146,7 @@ static void gve_handle_miss_completion(struct gve_priv *priv, /* jiffies can wraparound but time comparisons can handle overflows. */ pending_packet->timeout_jiffies = jiffies + - msecs_to_jiffies(GVE_REINJECT_COMPL_TIMEOUT * - MSEC_PER_SEC); + secs_to_jiffies(GVE_REINJECT_COMPL_TIMEOUT); add_to_list(tx, &tx->dqo_compl.miss_completions, pending_packet); *bytes += pending_packet->skb->len; @@ -1191,8 +1190,7 @@ static void remove_miss_completions(struct gve_priv *priv, pending_packet->state = GVE_PACKET_STATE_TIMED_OUT_COMPL; pending_packet->timeout_jiffies = jiffies + - msecs_to_jiffies(GVE_DEALLOCATE_COMPL_TIMEOUT * - MSEC_PER_SEC); + secs_to_jiffies(GVE_DEALLOCATE_COMPL_TIMEOUT); /* Maintain pending packet in another list so the packet can be * unallocated at a later time. */
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)