From patchwork Sat Dec 21 06:31:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kanchana P Sridhar X-Patchwork-Id: 13917678 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0081EE7718C for ; Sat, 21 Dec 2024 06:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655026B0089; Sat, 21 Dec 2024 01:31:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 603466B008A; Sat, 21 Dec 2024 01:31:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A1E46B008C; Sat, 21 Dec 2024 01:31:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2E3166B0089 for ; Sat, 21 Dec 2024 01:31:26 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6ABAC0A12 for ; Sat, 21 Dec 2024 06:31:25 +0000 (UTC) X-FDA: 82917993186.07.ECAEBF1 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf24.hostedemail.com (Postfix) with ESMTP id 3FF6E18000A for ; Sat, 21 Dec 2024 06:31:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZVD0ORu5; spf=pass (imf24.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734762657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3rPPGLrxyrK3EPMkpoxCITeN6Dqq/YdbbcRfprMcTU=; b=S0w+d6ZiyFB8v2hX/bomBzYsgoH/zJjrZe0zltDSa+P0yX8fsTye3X89xNfZoD9VQBnRFh NF3STgBtiTf9GVnDFdIo1MDxCXNsp4QMWdFhSaBOYAE4P8/ZE+Z1QwfwsmJG6T/pTRsBzF k4/xSdQTX2Fq8R4WAJvMBjon9O9P6Jw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZVD0ORu5; spf=pass (imf24.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734762657; a=rsa-sha256; cv=none; b=dGU4umdk39j1PzTS3/so5BmxpTLUtnYvm6dor9by0Rn6/7tM/FgE5IjjA6965ctGGFdrcO rCvLvWjGrhetefvKEVBA55YH3QE+spdD6JlnqeOVgA43r4YG0j4Kljnf7qVfGuLF7xIeeR oEqov+Z6VXBkVDT7rlRPx0NMtYT8wZw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734762684; x=1766298684; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+lL68B5VDme0ssy20KVs9HZUu1uuo/887sCYSoPmBdw=; b=ZVD0ORu5N0ga5j6Pbou7APhYfVDJBmcQUSgOVQbQSJQOom0IbHgSrLVY olQXL4Y1lGycXoKW+GKTEuO1pM+74zBx8ZLE53tVQj0lVGhYKCundmHsR l9ldpTEIEu+vEptqeDOF6njbYSK77M0C58pX1VQAI9B7O9IwnsNBkYT4R Is8j8pJ8pgmK8tff0wvnaXbJ0ERkHFlDg8/plwA7PYSRuFmSXY7M6yrDB 4K5xMH/eqRj1UQdWgz1psGjW9DV/R2SpRzTVO5i/jKeQYqZiFSR/4Xj6K 5A/jLFZqvdetq/sJrPzN5rt3eB5Lg1lm5Ly5C9FXB2ipFILmPtKFq9bSo A==; X-CSE-ConnectionGUID: t9UvPmKOSqCTpBU79bUSZw== X-CSE-MsgGUID: Z9cfg/rlTwS2BmtYR222zQ== X-IronPort-AV: E=McAfee;i="6700,10204,11292"; a="35021625" X-IronPort-AV: E=Sophos;i="6.12,253,1728975600"; d="scan'208";a="35021625" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 22:31:20 -0800 X-CSE-ConnectionGUID: 6HJLpaqhT0G57N/dxD4MSQ== X-CSE-MsgGUID: rOfRcOvhRUKUfVOelk1HHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="99184578" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa007.jf.intel.com with ESMTP; 20 Dec 2024 22:31:20 -0800 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Date: Fri, 20 Dec 2024 22:31:09 -0800 Message-Id: <20241221063119.29140-3-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> References: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 3FF6E18000A X-Rspamd-Server: rspam12 X-Stat-Signature: ghi8iazbetp3h79sohsn9sqkgn15h87d X-Rspam-User: X-HE-Tag: 1734762679-816521 X-HE-Meta: U2FsdGVkX1+QDpu+j8DK7dooLHJeCbEFDbv+nY84ZHCn8zN08WkZqIQTC4DU0e1n7ZGByqwkZe/RoExrF4preJstw5KJS24Bh09skbPRvqG1IwfBDLsOVirmb7/QsRyx7Jj954NRxqP9hAG7yV44mJ8WUt9Z17H8w0Jopzt8K7oYYmi3mfYumjisKIjcPmfTVrODUktCbDZMmCMvAgUI98yTs4Fle0BXH3rF4rv9gEttcUDEJQi7D9ckUmK/jLlRGLpgej0lujifQxkLlD2AV0IEP43mL9ogyyf4CXxlSUoyhKJpLlrPGiIDmC802L+OMTc9R01qRxjYNL55H8oaXIbNZo2B2xeHVTtzyMxTUlSdSrRgQUfA5818iYOqVa2xC8Ww37HYwwFKjFirtKBGUzoU5DsiuLeVJKZ6hjQmoh+jilm6oydoNS9oxrr7NyVBxo8/hjIglMaF6ImBFIO+5ndgrw+k4YJPLdmSTWFgFhGQpryIhES4V+PH3QMctWsO4l19M7R3I0b1CtaMETn4H+R8RFjiIGMHH//m7B/hKvES6293BFyUIgZU9ZDLxhxHzinnyERJF1zdB33EZdlgCGQfd6NUU/pE520PJqm+zLYgAbL8CX/WgZYuFMWFIkNikDeFd4vSAUqVUnJUC/2Hu0vnZHDzqOlC3BkK+APfXq57rvpoC9viWMQdgoMv8Zk6OgXJ9XH23w9mV+pPZiF/ZZFrEbpxpi9iDmiNKGXHQoAHqF+pz+Vh7Oisyg5SJyzCQp9QozbQRDsrvmZvXefmGjH+Ty9NINSpCpHR/pt7n39bFErzyG2GG65JHUnqVYczJ1jkf3LAy4A+EWoHktFSon1glG5yWBQmwVOBD7K7Q5W90F0c8HpkgPQRqpPtiR+5YcyBH/4Qgc4P6kDc3BVJiDyK73qpXTns9WEKM9UBPmCp1OLNapggmYB5rOYaI1qeIt7T5LBoCTx1m+y0C68 SB2INajJ 7g5jQe9i8V8N7bVVIrX7U1XdMnHyEYal/AaM1cgPOU3ZQ+2p7lLp95SxNhB3SazbgIlgNzmHKsdR9H1XTTFvtpePROV55WoC+qoYdQG65C5gLsQt8qKgfwsUHCkTLDe5fhMETZgQDG6H9RsgVfpsNsejMoURZmDBWt+P837riMtZW+XeEJ3LjFlwHng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This commit adds get_batch_size(), batch_compress() and batch_decompress() interfaces to: struct acomp_alg struct crypto_acomp A crypto_acomp compression algorithm that supports batching of compressions and decompressions must provide implementations for these API. A new helper function acomp_has_async_batching() can be invoked to query if a crypto_acomp has registered these batching interfaces. A higher level module like zswap can call acomp_has_async_batching() to detect if the compressor supports batching, and if so, it can call the new crypto_acomp_batch_size() to detect the maximum batch-size supported by the compressor. Based on this, zswap can use the minimum of any zswap-specific upper limits for batch-size and the compressor's max batch-size, to allocate batching resources. This allows the iaa_crypto Intel IAA driver to register implementations for the get_batch_size(), batch_compress() and batch_decompress() acomp_alg interfaces, that can subsequently be invoked from the kernel zswap/zram modules to compress/decompress pages in parallel in the IAA hardware accelerator to improve swapout/swapin performance through these newly added corresponding crypto_acomp API: crypto_acomp_batch_size() crypto_acomp_batch_compress() crypto_acomp_batch_decompress() Signed-off-by: Kanchana P Sridhar --- crypto/acompress.c | 3 + include/crypto/acompress.h | 111 ++++++++++++++++++++++++++++ include/crypto/internal/acompress.h | 19 +++++ 3 files changed, 133 insertions(+) diff --git a/crypto/acompress.c b/crypto/acompress.c index cb6444d09dd7..165559a8b9bd 100644 --- a/crypto/acompress.c +++ b/crypto/acompress.c @@ -84,6 +84,9 @@ static int crypto_acomp_init_tfm(struct crypto_tfm *tfm) acomp->compress = alg->compress; acomp->decompress = alg->decompress; + acomp->get_batch_size = alg->get_batch_size; + acomp->batch_compress = alg->batch_compress; + acomp->batch_decompress = alg->batch_decompress; acomp->dst_free = alg->dst_free; acomp->reqsize = alg->reqsize; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index eadc24514056..8451ade70fd8 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -43,6 +43,10 @@ struct acomp_req { * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. + * @batch_compress: Function performs a batch compress operation + * @batch_decompress: Function performs a batch decompress operation * @dst_free: Frees destination buffer if allocated inside the * algorithm * @reqsize: Context size for (de)compression requests @@ -51,6 +55,21 @@ struct acomp_req { struct crypto_acomp { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); + bool (*batch_compress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages); + bool (*batch_decompress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages); void (*dst_free)(struct scatterlist *dst); unsigned int reqsize; struct crypto_tfm base; @@ -142,6 +161,13 @@ static inline bool acomp_is_async(struct crypto_acomp *tfm) CRYPTO_ALG_ASYNC; } +static inline bool acomp_has_async_batching(struct crypto_acomp *tfm) +{ + return (acomp_is_async(tfm) && + (crypto_comp_alg_common(tfm)->base.cra_flags & CRYPTO_ALG_TYPE_ACOMPRESS) && + tfm->get_batch_size && tfm->batch_compress && tfm->batch_decompress); +} + static inline struct crypto_acomp *crypto_acomp_reqtfm(struct acomp_req *req) { return __crypto_acomp_tfm(req->base.tfm); @@ -306,4 +332,89 @@ static inline int crypto_acomp_decompress(struct acomp_req *req) return crypto_acomp_reqtfm(req)->decompress(req); } +/** + * crypto_acomp_batch_size() -- Get the algorithm's batch size + * + * Function returns the algorithm's batch size for batching operations + * + * @tfm: ACOMPRESS tfm handle allocated with crypto_alloc_acomp() + * + * Return: crypto_acomp's batch size. + */ +static inline unsigned int crypto_acomp_batch_size(struct crypto_acomp *tfm) +{ + if (acomp_has_async_batching(tfm)) + return tfm->get_batch_size(); + + return 1; +} + +/** + * crypto_acomp_batch_compress() -- Invoke asynchronous compress of + * a batch of requests + * + * Function invokes the asynchronous batch compress operation + * + * @reqs: @nr_pages asynchronous compress requests. + * @wait: crypto_wait for acomp batch compress with synchronous/asynchronous + * request chaining. If NULL, the driver must provide a way to process + * request completions asynchronously. + * @pages: Pages to be compressed. + * @dsts: Pre-allocated destination buffers to store results of compression. + * @dlens: Will contain the compressed lengths. + * @errors: zero on successful compression of the corresponding + * req, or error code in case of error. + * @nr_pages: The number of pages to be compressed. + * + * Returns true if all compress requests complete successfully, + * false otherwise. + */ +static inline bool crypto_acomp_batch_compress(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_compress(reqs, wait, pages, dsts, + dlens, errors, nr_pages); +} + +/** + * crypto_acomp_batch_decompress() -- Invoke asynchronous decompress of + * a batch of requests + * + * Function invokes the asynchronous batch decompress operation + * + * @reqs: @nr_pages asynchronous decompress requests. + * @wait: crypto_wait for acomp batch decompress with synchronous/asynchronous + * request chaining. If NULL, the driver must provide a way to process + * request completions asynchronously. + * @srcs: The src buffers to be decompressed. + * @pages: The pages to store the decompressed buffers. + * @slens: Compressed lengths of @srcs. + * @errors: zero on successful compression of the corresponding + * req, or error code in case of error. + * @nr_pages: The number of pages to be decompressed. + * + * Returns true if all decompress requests complete successfully, + * false otherwise. + */ +static inline bool crypto_acomp_batch_decompress(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_decompress(reqs, wait, srcs, pages, + slens, errors, nr_pages); +} + #endif diff --git a/include/crypto/internal/acompress.h b/include/crypto/internal/acompress.h index 53b4ef59b48c..df0e192801ff 100644 --- a/include/crypto/internal/acompress.h +++ b/include/crypto/internal/acompress.h @@ -17,6 +17,10 @@ * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @get_batch_size: Maximum batch-size for batching compress/decompress + * operations. + * @batch_compress: Function performs a batch compress operation + * @batch_decompress: Function performs a batch decompress operation * @dst_free: Frees destination buffer if allocated inside the algorithm * @init: Initialize the cryptographic transformation object. * This function is used to initialize the cryptographic @@ -37,6 +41,21 @@ struct acomp_alg { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + unsigned int (*get_batch_size)(void); + bool (*batch_compress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages); + bool (*batch_decompress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages); void (*dst_free)(struct scatterlist *dst); int (*init)(struct crypto_acomp *tfm); void (*exit)(struct crypto_acomp *tfm);