From patchwork Thu Dec 26 10:45:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 13921231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01B3E77188 for ; Thu, 26 Dec 2024 10:45:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C12C6B0089; Thu, 26 Dec 2024 05:45:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 871166B008A; Thu, 26 Dec 2024 05:45:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7122A6B008C; Thu, 26 Dec 2024 05:45:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 51E8E6B0089 for ; Thu, 26 Dec 2024 05:45:45 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CBCA545450 for ; Thu, 26 Dec 2024 10:45:44 +0000 (UTC) X-FDA: 82936778610.11.973FDCB Received: from flow-a3-smtp.messagingengine.com (flow-a3-smtp.messagingengine.com [103.168.172.138]) by imf30.hostedemail.com (Postfix) with ESMTP id 1DE3080007 for ; Thu, 26 Dec 2024 10:44:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=dCBf+Vxt; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="E sdqqA/"; spf=pass (imf30.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.138 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735209923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Yi1afU0PcTb7IjinI272SW/UZ4NmwHY4mwQ9VbR8Ac=; b=WYzrJkUPE3qsHvdYX4c+LB34zD82/KqeQPat9BtMMipq2qhV3q5pyEc3+AR1crvAI1BDDH a0ujfvV8QUQ4VbJIthl0v8o0i0ebshbaEvblnL9mEVo2R+FBx2SlIIm2A8jNSeyBczodVh CUCUXpQ7+t/BFBhtON+TrYBiwlm6N2A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735209923; a=rsa-sha256; cv=none; b=6tW5pDhTbfekHUv6XukkcCjTIDVGGFa0uToxPIofNyyBIrL7fS6A3clko8lTWW7AVYMaKM k+ByBR4f7nL9YWiiyqppyt/EiXIh96ttSGFSmUDCC4UdgYa50xgzDqQ7wdqzXefkwjcwPP m1n9ZwmLtFtHwClb3G8uvgYVRYfl7z0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=dCBf+Vxt; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="E sdqqA/"; spf=pass (imf30.hostedemail.com: domain of uwu@coelacanthus.name designates 103.168.172.138 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailflow.phl.internal (Postfix) with ESMTP id 46FB82005BD; Thu, 26 Dec 2024 05:45:42 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 26 Dec 2024 05:45:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1735209942; x=1735217142; bh=4Yi1afU0Pc Tb7IjinI272SW/UZ4NmwHY4mwQ9VbR8Ac=; b=dCBf+Vxt0Q646hDRolC6zJ6C88 +ZhD1IpfUsijZnoiA5aZ2XUwsmgasaOb7N05rwVyBRTK6geX6Z+h+k1MbEBL6/Vo aWM38NW6r/XbiZc1Rg818AGwpQyTVQ9wNgYxSvFAVHXKwOFdlX5ovssgi134aUm3 A73KNStxjD3oDx2uE0OW2PWZzUoFjxi4p27e65BzAPy3R7oX1doGhAhEbeq8to6A 27yv0FP1FXTlbiNuG60/4Ug0sns+j/YLuevhQt2M/g04uDMCsjFheprLg3LtALne iK/qjCip+ZHZrNmPfjryDiyzh/aNQeTQ3f9rqjlG5NWtwI6LBxpFGXrEGu2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735209942; x= 1735217142; bh=4Yi1afU0PcTb7IjinI272SW/UZ4NmwHY4mwQ9VbR8Ac=; b=E sdqqA/7GxYT3zyblIBwCs4vDbPencIe5YPgwgvZuHxmCk+LBK0hByllqgP5/ELId HdCSWoKCtalCxcDEXB1cZWNIz4ppUTnT61O1DNtOhHJfQx4umI6GvK3R9zifGr9q DcXXDGdGGloSdLj+L8/m6RmbxTjYs6HeKzhdc8VrVz6gOsy6MsnuB/5yImh559WN ALPS6HPcsP/6aA3ANJiYrhfHbnDgpwSEhx8L6B+R8GNeDC/AjEBw1iJbX0XhYwPF Nia/qmnO+sRPkC/lvHpBsKL7ivaggC+GqKOJAEoP/gAfpjOQ3MV5ylDPy7vpwbCD BSu4OJKtcbAhPNk1ZSMbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddukedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdej necuhfhrohhmpeevvghlvghsthgvucfnihhuuceouhifuhestghovghlrggtrghnthhhuh hsrdhnrghmvgeqnecuggftrfgrthhtvghrnhepiedugeffhfdtueduudefhfefhfehjeej hfeukeehffefuefgueevteeiuedvtdefnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuhifuhestghovghlrggtrghnthhhuhhsrdhnrghmvgdp nhgspghrtghpthhtohepvdeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehfvg hlihigohhnmhgrrhhssegrrhgthhhlihhnuhigrdhorhhgpdhrtghpthhtoheprggsohhl ohhgnhgrsehrvgguhhgrthdrtghomhdprhgtphhtthhopehufihusegtohgvlhgrtggrnh hthhhushdrnhgrmhgvpdhrtghpthhtoheplhhinhhugidqrhhishgtvheslhhishhtshdr ihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnuhigqdhmmheskhhvrggtkh drohhrghdprhgtphhtthhopehlihhnuhigqdhkshgvlhhfthgvshhtsehvghgvrhdrkhgv rhhnvghlrdhorhhgpdhrtghpthhtohepkhgvvghssehkvghrnhgvlhdrohhrghdprhgtph htthhopegrjhhonhgvshesvhgvnhhtrghnrghmihgtrhhordgtohhmpdhrtghpthhtohep shhhuhgrhheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Dec 2024 05:45:40 -0500 (EST) From: Celeste Liu Date: Thu, 26 Dec 2024 18:45:10 +0800 Subject: [PATCH v3 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification MIME-Version: 1.0 Message-Id: <20241226-riscv-new-regset-v3-2-f5b96465826b@coelacanthus.name> References: <20241226-riscv-new-regset-v3-0-f5b96465826b@coelacanthus.name> In-Reply-To: <20241226-riscv-new-regset-v3-0-f5b96465826b@coelacanthus.name> To: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Andrew Jones , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Celeste Liu , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=6180; i=uwu@coelacanthus.name; h=from:subject:message-id; bh=RwziARy9LYogiNaY+tRNajVYbC8xlhPLfEfHo/RnxWo=; b=kA0DAAoWT2Qv82QkrXgByyZiAGdtM8KgQ1i1ZpH3yT+h91v9V4Ml592+z4QJ6bXiI5L5+PGi1 Yh1BAAWCgAdFiEEbnQE+QnSzYu9iLeKT2Qv82QkrXgFAmdtM8IACgkQT2Qv82QkrXj/uwEAiD+r uHX0W2AEe+ETcnP3pFvrPjh7a8vn/lXycVs5DDMBALCLKLmjd2KucK8JkpLyekJvdojEp7TzDND XeXMJ8pkG X-Developer-Key: i=uwu@coelacanthus.name; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1DE3080007 X-Stat-Signature: tp8eg5e86tg59pmgtnbozmuainu1uah9 X-Rspam-User: X-HE-Tag: 1735209862-772640 X-HE-Meta: U2FsdGVkX1+tPV2+EmC3xsWGjN1R+oyLLNuXDgPxIt4iA3QHGr9Cx7SOmU9aigaoct/Gr43/ovIssW/TcRmN+R4bNfzOSqQSSCdCdKQ5dL0uZ7p38cRKGZLKC3LYAi+qV6tGlMJclwfhh6y4DxDNv/lonVFRSBtysa9dkAk9F9Fv+fd7DZqq+QuuuAOA6hKRonHtHhpm36i2PDaKSgvahQSImwsoravHURg6aCCV6n5ghDMUDS7r5CDt52MgStlWRAWr+Dm5GlDuCrd1d06arvwSMwqEwcK1ZG5zlySjUzQcxv19nJLufErNc6Zn4nMIaHqsb7DL6upL8rp1gfYXZqEu/vLIOZ0b7HGAC7vArLWoEWOWmsbVOJzavW6QgJRYSxZdVfBpeEBaZGy5U2nemK9p3dNEY4tpEGdTMfo4EmdRbQyC1iP4JjoTyzGBe2EYV2rjyPDOP/0VrcmxBT3aAERpjBETFQMe+EemB78EnEtRW8Z5U0yyn3EEofcL89MuucNplQnebxlLILHcvchPnCfeg6hv77pEfFqRhX+JAhV9hisD/JQmkkpUuu6+jCaAlo+/3O7lYQ7k4ac/vmJOAbl+qJ3jPSmB2QdSExXrZFIM9O/wTFOESVb0lEramCGwJwS0KzA4N0oX08jfEB+qlOkF7q+5rIuqwfkXONNwPmRce5SVpKZ48//rWQJO/GRDMoz8918Im5WZYIRt9S6TU+Hkor6RnY11K8UdUh3j61t3/fi9dBvGqmKdxaR4DQA0YzGhmgL1g7FqU5dJZ4J0CKBXnLBuEmaqdQfb/tZzlj2AQkPSZj1EbyVC/bG5wSVVX1OYff/MNVVkrjgU/nQZeIbif8QqT2eKwmFlkLTSTIXCOftL0v/EwF5++9w3EzazBNL34tEmm96EBCgMwdZVZJAqm5PSYpNWVxROo71FHgpMP7V4gDoyY0dpmE5f5qSVXCDmziG+WI/YIRHet5G fM2iL2Pu qbc9C/loPyFr0hlBemjpT52L/uCibReTeuXqwLcWpBwd7DB/oE5aZ79NyaIrcyVTAgU3hgagHrwf5Y52fufVnpf6su1TFFE2Ox0sY9NdjQspNLGppZ62HgVdQDohqMRdWIGdYFjFceLRwLK8GhgQgB49qGfjLQc/raVccroGeObVU/idZdH+MkaYEgVeVVjmAkfpc8QRhS5q8ZyE2ou0MjNGBhbgURLrx8L/1XhMfvdgBAI5s0OKZn57X0YgbChaZLBbyGs0HicER7FhNlxtezOOn7OSk+xxNilH69lpyh3tRiY1jQsrLBy+2evRr3ogyVMpUs5j4AOmFQxRjjUfcmmc8zxzLbks7KcRNCiuMuFv2bZUUEUoNXM6imuRXf08FaU/aMCMu0zF3QseXrmHBYGYMgENkw7joYD3bGs6BWWfqmDomSuvC5sKcH2puZL2a83ETqRXR+ssBAruWHo2TZjaZ3VOWeSg6UOvFFE+DpCJ4/+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This test checks that orig_a0 allows a syscall argument to be modified, and that changing a0 does not change the syscall argument. Co-developed-by: Quan Zhou Signed-off-by: Quan Zhou Co-developed-by: Charlie Jenkins Signed-off-by: Charlie Jenkins Reviewed-by: Björn Töpel Signed-off-by: Celeste Liu --- tools/testing/selftests/riscv/abi/.gitignore | 1 + tools/testing/selftests/riscv/abi/Makefile | 5 +- tools/testing/selftests/riscv/abi/ptrace.c | 151 +++++++++++++++++++++++++++ 3 files changed, 156 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/riscv/abi/.gitignore b/tools/testing/selftests/riscv/abi/.gitignore index b38358f91c4d2240ae64892871d9ca98bda1ae58..378c605919a3b3d58eec2701eb7af430cfe315d6 100644 --- a/tools/testing/selftests/riscv/abi/.gitignore +++ b/tools/testing/selftests/riscv/abi/.gitignore @@ -1 +1,2 @@ pointer_masking +ptrace diff --git a/tools/testing/selftests/riscv/abi/Makefile b/tools/testing/selftests/riscv/abi/Makefile index ed82ff9c664e7eb3f760cbab81fb957ff72579c5..3f74d059dfdcbce4d45d8ff618781ccea1419061 100644 --- a/tools/testing/selftests/riscv/abi/Makefile +++ b/tools/testing/selftests/riscv/abi/Makefile @@ -2,9 +2,12 @@ CFLAGS += -I$(top_srcdir)/tools/include -TEST_GEN_PROGS := pointer_masking +TEST_GEN_PROGS := pointer_masking ptrace include ../../lib.mk $(OUTPUT)/pointer_masking: pointer_masking.c $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ + +$(OUTPUT)/ptrace: ptrace.c + $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c new file mode 100644 index 0000000000000000000000000000000000000000..c89343cb4abc7da57f83879ecce619f503c438bb --- /dev/null +++ b/tools/testing/selftests/riscv/abi/ptrace.c @@ -0,0 +1,151 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../../kselftest_harness.h" + +#define ORIG_A0_MODIFY 0x01 +#define A0_MODIFY 0x02 +#define A0_OLD 0x03 +#define A0_NEW 0x04 + +struct a0_regs { + __s64 orig_a0; + __u64 a0; +}; + +#define perr_and_exit(fmt, ...) \ + ({ \ + char buf[256]; \ + snprintf(buf, sizeof(buf), "%s:%d:" fmt ": %m\n", \ + __func__, __LINE__, ##__VA_ARGS__); \ + ksft_exit_fail_perror(buf); \ + }) + +static inline void resume_and_wait_tracee(pid_t pid, int flag) +{ + int status; + + if (ptrace(flag, pid, 0, 0)) + perr_and_exit("failed to resume the tracee %d\n", pid); + + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee %d\n", pid); +} + +static void ptrace_test(int opt, struct a0_regs *result) +{ + int status; + pid_t pid; + struct user_regs_struct regs; + struct iovec iov = { + .iov_base = ®s, + .iov_len = sizeof(regs), + }; + + unsigned long orig_a0; + struct iovec a0_iov = { + .iov_base = &orig_a0, + .iov_len = sizeof(orig_a0), + }; + struct ptrace_syscall_info syscall_info_entry, syscall_info_exit; + + pid = fork(); + if (pid == 0) { + /* Mark oneself being traced */ + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); + + if (val) + perr_and_exit("failed to request for tracer to trace me: %ld\n", val); + + kill(getpid(), SIGSTOP); + + /* Perform exit syscall that will be intercepted */ + exit(A0_OLD); + } + + if (pid < 0) + ksft_exit_fail_perror("failed to fork"); + + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee %d\n", pid); + + /* Stop at the entry point of the syscall */ + resume_and_wait_tracee(pid, PTRACE_SYSCALL); + + /* Check tracee regs before the syscall */ + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) + perr_and_exit("failed to get tracee registers\n"); + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) + perr_and_exit("failed to get tracee registers\n"); + if (orig_a0 != A0_OLD) + perr_and_exit("unexpected orig_a0: 0x%lx\n", orig_a0); + + /* Modify a0/orig_a0 for the syscall */ + switch (opt) { + case A0_MODIFY: + regs.a0 = A0_NEW; + break; + case ORIG_A0_MODIFY: + orig_a0 = A0_NEW; + break; + } + + if (ptrace(PTRACE_SETREGSET, pid, NT_PRSTATUS, &a0_iov)) + perr_and_exit("failed to set tracee registers\n"); + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) + perr_and_exit("failed to set tracee registers\n"); + + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_ENTRY, &syscall_info_entry)) + perr_and_exit("failed to get syscall info of entry\n"); + result->orig_a0 = syscall_info_entry->entry.args[0]; + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_EXIT, &syscall_info_exit)) + perr_and_exit("failed to get syscall info of exit\n"); + result->a0 = syscall_info_exit->exit.rval; + + /* Resume the tracee */ + ptrace(PTRACE_CONT, pid, 0, 0); + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee\n"); + +} + +TEST(ptrace_modify_a0) +{ + struct a0_regs result; + + ptrace_test(A0_MODIFY, &result); + + /* The modification of a0 cannot affect the first argument of the syscall */ + EXPECT_EQ(A0_OLD, result.orig_a0); + EXPECT_EQ(A0_NEW, result.a0); +} + +TEST(ptrace_modify_orig_a0) +{ + struct a0_regs result; + + ptrace_test(ORIG_A0_MODIFY, &result); + + /* Only modify orig_a0 to change the first argument of the syscall */ + EXPECT_EQ(A0_NEW, result.orig_a0); + /* a0 will keep default value, orig_a0 or -ENOSYS, depends on internal. */ + EXPECT_NE(A0_NEW, result.a0); +} + +TEST_HARNESS_MAIN