From patchwork Thu Dec 26 22:14:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13921477 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A09DE77188 for ; Thu, 26 Dec 2024 22:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87DBE6B0083; Thu, 26 Dec 2024 17:15:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DC886B0085; Thu, 26 Dec 2024 17:15:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655C36B0088; Thu, 26 Dec 2024 17:15:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 499DF6B0083 for ; Thu, 26 Dec 2024 17:15:03 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9747120E69 for ; Thu, 26 Dec 2024 22:15:02 +0000 (UTC) X-FDA: 82938515646.04.DA8A742 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id C3151180003 for ; Thu, 26 Dec 2024 22:14:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aZ+ftHr1; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735251261; a=rsa-sha256; cv=none; b=HOcFBlx8CTC8XOv4zu4DERXXntUESIzNr2uwhzgrn2PuXKjhb7EAvd02qPwvLfyWzvtoYA LIxISwnqwnI8RZhyPKUf2XCgYFJEpAkUSuhAW2gwhAEyv/1LNTwEfKBNC02PfoIW7IAcvA S5aqStU9/Mnzzk9rxG4kcF+a2JlNHbY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aZ+ftHr1; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735251261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EmZ1Xw+mxIMQURnVRUBr1sZ6X6QaneW36HGmzgSgXFk=; b=sjC40VtOm9uGdUWbRHXxGWLV4QUaRjZt854pdwZFElVVED773v7/EzCqU6ZF7u3q0LOffR TVZjG2/ZqBmpimgQ/7t95WFdMF7pwAOTcw/IWtM+gT+6Q7VZWFHNGWK07tCfSMAdv1gxbl FPviMq17bGZ+xo5EmEq4lostJdrwjEs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 94E945C61EF; Thu, 26 Dec 2024 22:14:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8D6C4CED3; Thu, 26 Dec 2024 22:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735251300; bh=BqfFuozL0F0mxvXeJ3OdZ9G2Y0SIHcS2uBA23Vwog2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aZ+ftHr1CkAH5F63FDXtw0/BlvymU//usYo7FSrg35NHQ1sYDG48BuoNLXlHBZcsI hn8XzMUIJRlJZW13Bn6vnDqyHQtTJXKhomujUWTXi3SjjR0YQRGeW7qxs4O4akLgTA eELMnCRHUJ5GlQ0J4b8ds3pHxVNxRopSGsRkr9p9IIIIbSbylGw+uSvbETncTDMQZz 5uH/Da7PfzmNxtiUyvEVNRjehKnEyFLZY3n3DWaGIBjBWga6bW/3z7f8tAPzwtrnSC bMPOiWeRL3btA7IXiJ5xDPRnqZPfN/MBeej8hcQedLut33s1yd2jCAlTlcOpTpJ0ng WYDj6Qh9EfzjQ== From: SeongJae Park To: Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 01/10] mm/damon: fixup damos_filter kernel-doc Date: Thu, 26 Dec 2024 14:14:36 -0800 Message-Id: <20241226221445.78433-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241226221445.78433-1-sj@kernel.org> References: <20241226221445.78433-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: C3151180003 X-Stat-Signature: jt1uh9otj1zrae47cp1jyqhetoqu8pkd X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735251295-830500 X-HE-Meta: U2FsdGVkX19nlAFEkp9tRHqTLd78mE2Bo/8MdT6I0amUEoiY4yH1oUVYGbRTynhVHpZMYk/N/BIOjg/6Jwkyo+OL+hpIrgjTHTSb8GK83NsO1zKDi1RQNZiWm+YZIWIatMwBEUcu/v/ZtfZFFpCkoOwzSaS8nzEk88gHHiIqmewOAn8bgKdiAdsAn8jYVUibHeHSCiCLKwWGTgbfHL0TcdI1pO8J2O1wUIU5VrtsFjqIbSjXfvA+NMCwJVftIOsn/p75tuEL6xVmSGjKSafLRRK1mtPrLamIbKx5/chcGdrmxPGT5Z28ICRraBHAbNZBMHZ4eOsZrx5Q7XKpnBYvNMjVaj3I+xO4SnCObeyVlu2O899lvEMK+glGTzaZtVTRbfNiTbwPnK5eBCFhUuhLR9UWGUcyyPHLPtu6DVvP98qJQN/S+1yYJhyxy1EGfuVNpXycPrafqpVmji8rnAsQA3y3qn6yco39lMY5KD5ptJqFUpUGVd//m7XgaKp4+YhfzRNf4JkPMQZutpnZL2vUPJ0BLq44Zy03tINJrFhIGyaE+mVbbkHBtvftnHZ/xoMfy5zzlsdPIpEZGtT6FvDoAXxorXbZfRHmZ9ww5g2EWBMGwoIdgXRW9h6gXV3uWquZ7jOeiHy2dDT7Al7ta1V1cz/OJJK2LV2B578MPtHuLf5VstiUh4wG4m6oQgnf+MiI1HzfqCh2cxTGMofYLT+xscV+59Alze+kFkqhLUK/vMDcFptlHvIi0gKXY3NbDo3TLk1itAp56+rSRZ5KFb8kLXU3+Up36K3FkFE2gK9imo4efB9PZApyhH8SOqpX9DQimH9zClfYyl4bgfygCSpoc+xym+y5h5qB3YyzcqilEkaT/KBVtlEQTKbIVskdNb2WbqjJo/4h42AvFDa/zIN6qn/VqyH9dJ8I4w0P4Zq/9w2Uq1mmtgMjoUAF3TVZo32zLyR3xIhcKEcYEo6Rh8j 0FaKeRHD UXqvtthsfSpJElMIhXtfQhl0YVM5pAm3oW0snZfwsX6diQKGk56GOVZrCfYW+aUm6wXIUzCG3waQz8Ay/LAkQcm6TsJ6e8LSwoFWJDQZHHBtfaTpUwjp5G0j04qI6rLRMiELStDyqjvpMeMkQlJjdx2ebftCmYLQR5SOTe1Ft00fp6Dv2HYdVbBHpehApQDgJMNXn+gMEoBBkRS8/yTkLbbJ0XcYEr41XQm/u0Nw98uRXQHOParpkT4ch4oQ61P6P/zvacqIrcLsbX15b4ytRZwqxbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment is slightly wrong. DAMOS filters are not only for pages, but general bytes of memory. Also the description of 'matching' is bit confusing, since DAMOS filters do only filtering out. Update the comments to be less confusing. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 18449b5c45df..15f098372672 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -347,8 +347,8 @@ enum damos_filter_type { /** * struct damos_filter - DAMOS action target memory filter. - * @type: Type of the page. - * @matching: If the matching page should filtered out or in. + * @type: Type of the target memory. + * @matching: If the @type-matching memory should be filtered out. * @memcg_id: Memcg id of the question if @type is DAMOS_FILTER_MEMCG. * @addr_range: Address range if @type is DAMOS_FILTER_TYPE_ADDR. * @target_idx: Index of the &struct damon_target of @@ -357,9 +357,10 @@ enum damos_filter_type { * @list: List head for siblings. * * Before applying the &damos->action to a memory region, DAMOS checks if each - * page of the region matches to this and avoid applying the action if so. - * Support of each filter type depends on the running &struct damon_operations - * and the type. Refer to &enum damos_filter_type for more detai. + * byte of the region matches to this given condition and avoid applying the + * action if so. Support of each filter type depends on the running &struct + * damon_operations and the type. Refer to &enum damos_filter_type for more + * details. */ struct damos_filter { enum damos_filter_type type;