From patchwork Fri Dec 27 21:08:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13922135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAB0E77191 for ; Fri, 27 Dec 2024 21:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C850D6B0082; Fri, 27 Dec 2024 16:08:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0D7F6B0083; Fri, 27 Dec 2024 16:08:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86A66B0085; Fri, 27 Dec 2024 16:08:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8C9E56B0082 for ; Fri, 27 Dec 2024 16:08:31 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39FB4A1C3C for ; Fri, 27 Dec 2024 21:08:31 +0000 (UTC) X-FDA: 82941976320.22.9EB5B33 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id DC76418000E for ; Fri, 27 Dec 2024 21:08:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tnUJit8n; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735333689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EmZ1Xw+mxIMQURnVRUBr1sZ6X6QaneW36HGmzgSgXFk=; b=Ks93IvfeKhwLvxKjKwrEHjXAcyCzMmvC2bFH3n2cmct0HE6jwrDAkvVFq45MfmJivFpKXZ ip53iL3OKU1oDtHHyPzuOP7W09vbulfJ2I8Hi6OPjND7QFp5H/kT9btTIBjYnMJ7B2L4gM o5TkpHfwITZWOdfiqE2ET/sb/V1IE/w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tnUJit8n; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735333689; a=rsa-sha256; cv=none; b=SFFuDgCac5A3Z7Qs1Jq6OdxeVMwl8fSr/l9GujogpnJq0h1bEkOHfZw+VIPFFjzw4I0GC4 1BWCCmE1ZBlytec9XJb5+bRU8/BqWUN4onOR2WVIv6NaczL+AC/tiAoY4+xzWDX0AEn8cW Y86A2N4QuQKfj4Ne8RBfthvjA3vqhsE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E78655C5972; Fri, 27 Dec 2024 21:07:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC4CAC4CED4; Fri, 27 Dec 2024 21:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735333708; bh=BqfFuozL0F0mxvXeJ3OdZ9G2Y0SIHcS2uBA23Vwog2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tnUJit8naTGjkWHL3DW4n2LgDjBhljJs3/AlXhk8vOKW2ODhnwksLa4AD6FosMtt/ CxxsY20yI4KKTgSOye90gFHjilVnGOYBnKXpH9lNWDVmyrXjPq66bqMkSDqc/+cBNe DEfb7ufAsYr4jf1XHfvVHDTuDS+ZacbU91Vs63RITRROYhr+vjDeavZkEygd5WnVMu vYm21Ke3on1fFF+z7XVlgEQsKYxG9YBib5wdq+cqKCo5SJLlx2dGm3Q9I/9+2aUAeC n8SSjpFZTjnnP1hPlkN4jjfJUtYwDrkL732B2av7ax7t2sHP8/UEJp6fRO/0EWoCMB UM0X07Znk6JDQ== From: SeongJae Park To: Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 01/10] mm/damon: fixup damos_filter kernel-doc Date: Fri, 27 Dec 2024 13:08:10 -0800 Message-Id: <20241227210819.63776-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241227210819.63776-1-sj@kernel.org> References: <20241227210819.63776-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: DC76418000E X-Stat-Signature: rji8n7hmigi413d7ujqfew38yt993549 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735333703-165006 X-HE-Meta: U2FsdGVkX196ZCZIoP4mn+yN6ZixNlSlZqINkBwBnczqv7YBm7jw97CMdpCK0N8NFeFbiSV4G1QTQuWh+9F9FXMRxFIB1uT8Qbsfe+oBUNRuWaiP0YzxfcH+rOgphyfhvUJT6EMyGdIqHWopOenZc6NCsmUmS7yTfbBs1l5FMBuGTvplrA29y7ka/oWgSRfNNfh9ZmAIW/h9lWysvbCoeK7NxVc/3vVtf7uMGNt6xpD93tB+GlZVhJwD6ODo/Ge+nVTFFjJ+ophFQLhVvbkCmnM0gK5My1SIXpvUv42j8ODimlpcwWw13Qr519+5AKlfbUYSw7cGOLCkJf/sdG8WGYrpk5961AzXLodLW2qIJGdBjsoElG1YRh7L2+If/HQrJuqm09SmkA6Uw4+POhq8YZva0DLCLM64sITKO54nC3zSLMLDpxcLfHfw1Jyj83wJWPEvqJA+cbY0648Ji+ki1LnPLAqs1/RHwe2vdXlfJEMsZmck05TRNn3WCcFvjUYibdvY2X6M5VYXgkq0ARdrmBtTKUufInPOtNSQiOThRL3DF4udTYHhiyeY40mGeE0g51e2KN/LiwJX1nxEweMl3i9/ImFWXZnY0ugLFNn6X7SbvqEWigydW9O7R4HdBcEOkYsC1T/OPkfvCdPAy9s02/mad0jl/8sQK4HxZwp8pLoQDhvZA9RzID80H/ramXXHn8EtYvMwUBMMhODs1nAH9UaKgAjkfU3F+z6Ztr2QOi/cBQTydV8s0d2az8CCccjbmKAiBJPNW8ZBaMrwwuT20f8Qgz9YuPNlOlgWMZ4ph3J2YYay3McoQ3RHOfL/jsw/ysgOZYGvphV71Dy1HJm/9dEpUR6KhBBc+kulJvYLnfXp8BLa5CnRy/VxIjLFkxT5ImYm+gW2+xOBsB7+CKDVpz+DDdSgFGMVGxkSDqCvtbCC1jooIK1D+j/vJL6IZUYWcvpLUPcye4xEQ6CbpJw spf2TKEG 1ACEw8Oyh+23c8LpifvZObGPHgec+iW/DwtFUqkF+RePN3rok9P2KLgCiM8jXnFgx9bzsbiiCFDV/zqgbXosJbreI4oSsXRvSPOsg0HLAV2q2d5SjRGg0U77iZPrUMbqvl2pybAQ4pVfp1LXzmjXXhMLn6juRmc5IoyY3j2gi2hHs6E/bVZkmHqfsxej1mOaQDkmnw9YMp565dB1/SiTNHCAAlbFZhgmJ5gDq4zOXVEC3O/PhZkQb/3HZC5eSQcLiBfGCEwJheH/IXNr65rvkLaVHxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment is slightly wrong. DAMOS filters are not only for pages, but general bytes of memory. Also the description of 'matching' is bit confusing, since DAMOS filters do only filtering out. Update the comments to be less confusing. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 18449b5c45df..15f098372672 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -347,8 +347,8 @@ enum damos_filter_type { /** * struct damos_filter - DAMOS action target memory filter. - * @type: Type of the page. - * @matching: If the matching page should filtered out or in. + * @type: Type of the target memory. + * @matching: If the @type-matching memory should be filtered out. * @memcg_id: Memcg id of the question if @type is DAMOS_FILTER_MEMCG. * @addr_range: Address range if @type is DAMOS_FILTER_TYPE_ADDR. * @target_idx: Index of the &struct damon_target of @@ -357,9 +357,10 @@ enum damos_filter_type { * @list: List head for siblings. * * Before applying the &damos->action to a memory region, DAMOS checks if each - * page of the region matches to this and avoid applying the action if so. - * Support of each filter type depends on the running &struct damon_operations - * and the type. Refer to &enum damos_filter_type for more detai. + * byte of the region matches to this given condition and avoid applying the + * action if so. Support of each filter type depends on the running &struct + * damon_operations and the type. Refer to &enum damos_filter_type for more + * details. */ struct damos_filter { enum damos_filter_type type;