From patchwork Tue Jan 7 20:17:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13929577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666BDE77199 for ; Tue, 7 Jan 2025 20:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3EE06B0093; Tue, 7 Jan 2025 15:18:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C8C96B0095; Tue, 7 Jan 2025 15:18:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CAF16B0096; Tue, 7 Jan 2025 15:18:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F6D86B0093 for ; Tue, 7 Jan 2025 15:18:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E186480D0B for ; Tue, 7 Jan 2025 20:18:11 +0000 (UTC) X-FDA: 82981767582.24.CF0D471 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 5732DC001B for ; Tue, 7 Jan 2025 20:18:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sjMBpWAI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736281090; a=rsa-sha256; cv=none; b=oEy7EwvmE/b0Ab0JiQbf2EszfxeYy4xzvZyg1/fzOjyAkqj4xvmxysoQzafmm1RpxLwc8M VgoWck6wLaoAMdJoMkMWumi8dm64aQYC02mm9B3nrG3EuVyj9TaD+2zvn+x6Bdgkr9u0vq plf/j0RfHeJKMIk389yscL1VNP5lFx4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sjMBpWAI; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736281090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d5J1AIHTYlUmXrjLKn82T8Uz9hRFE/DgF4ayh9KaOgg=; b=7MoWVonTjwjJDOaYdUpCodzVqYoCwGkAvcK9Axxt5ChkisC+St/u4qmkjmNGNLDM/x3eCq YIhY7xkU8M5/xOS60JV2p5mPIGmnDD+soXNw43ysC/ms/RGb3If0jKtjB3fVFZErOJXQpT AJ4n8/UrBAsnJQK4WYiBPsAkPYseZQg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F3480A41CF2; Tue, 7 Jan 2025 20:16:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B874C4CEDE; Tue, 7 Jan 2025 20:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736281089; bh=97I76lDfvaM6L2LOAAduyShBBxqQhcZ1zQRaRPWTvuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sjMBpWAIL0F+1FBB03PXptlqXI5T1nzKca9WFZ4dkXqiSWkqFFNLPc5FewJragYFo PHRjacKSyjgfSmKHiElJMUHk+Ispxlbfx4rXzxWPsIIP5YOGUvOQGgKU/+sUWL9eA0 a7h4Xm/ZxaZ7/whlpg0x3PXzW70D517Oozp/7iBdzkJ0qCrBa0ag+fKEQY7bpfdKqO hhBcnVqucCBCsivL3cu3sWicCS3EtgbNMEOeCvpLBPIcVR8GEymQDsMurSfo/71k+a 8mDcL1f6i5mJ8fbP/FHPEuEs/pv2tKww3/ovQRMwFUSBSDa2YJx9kVxqlASSrP63++ tedpPoOWjAODg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 01/10] mm/damon: fixup damos_filter kernel-doc Date: Tue, 7 Jan 2025 12:17:30 -0800 Message-Id: <20250107201739.79484-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250107201739.79484-1-sj@kernel.org> References: <20250107201739.79484-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5732DC001B X-Stat-Signature: 1fk1arsqzy69s7m3buw5uwygyqxumipm X-HE-Tag: 1736281090-318350 X-HE-Meta: U2FsdGVkX18I0sRNglG8nORgNnpFI+XefndcFOVjVjVgOf6d3Si7Uii/Tubww8J0s5TDlPePVAYIas4We4cDMHcEibaxdk2vFTp1ZJmFKpz0K40I26DsmeRuKv8UsufjUcARAKBzygiGl4iQKjckB6lg+MNOeJkOu9Sh/y7jAJc5pjKj+0MYXVQk+FnUrGzLuKY06DpR954lZ7EVix5bgi3z2nksU1PBYIPLPQUHVa6jBtLquBvUy8pkwGPtSoBuMMX7pBEBATnbi15aalXztekirUy61UikE6vt1jugA7XBc1fGy6v5/g6iy6I0dAlYdzdYYzR78hlvounRa+6gwlCXxfFeRnTo064QSNSn9i0vEKP4s4ClacyGNcJmYMvKaD1IEo1GcmDvVV+lbsyBnALKUEnDhyUvXuxkUkHz1g37oi4gWrb/SM4PW1iOpOn/jgcnKP8i7+0g4pZQQ6xbRBx4EYGTrYpLSA3PfFEbsG8o8AeIJ2Gkx69X5kvGAuIuQ8KESPEiTdsluN+Suexvv9ADQBMK29eT6160DYoZRCNbPUfmvw3jay+W6Qu1hslB84rYs+7ZpVedjgw/Vl1zzVvffZdqRjyEp18YnIhbVhqWniY2TY9POUuCiHGWa5mUsqi0qYks5YkVSNbf3vzzBcONEpQiF4xMc0z/5rKGYbwSTrsXS0fI2OCSzNEJRctgvAmhUFYk1ylGGat5cAV1cRgBiWIZbBpxN5/mt7r6zOspAcx9XoTUiTP7qEVtndROrJ5gMeBD3p18NK1pw6OnKNg57c+nDcOvEOL7+ifLj2N/QPYfdujmsND0teZf3+7q+A5xOMp7uwV5qR7Q/xpv/Hi7pRnWMeEFBTKpLVIQd4hjfzLfvMPcvu0eglwbejuyL39nonAh75MY23ur1BnWBoM96isEDvWmYtrv+ZZ20958wz60sDBa+p5I9KFZTmadGTutkZoB1EirumH20QL rJEVKMuW QG/ehRcldMg9gIMtZyX9z5yyS3RLrCZcuZkwn9RVU3Oy4KD/Gs5CzB01/Qeno1t7O706RSxrNyQeHtK9CjwZTBF/LNXYcST5AWIgOEVeamezuIU87ywPWuF/fc6h4o/YSbLMYXpIzot3mhgUoCeCFHMSntLEEN8rC3cgUJe5sLjw5aPD4zNUm4Pi/+uaZCoXa6wMKvMX2xHOFE0lJrnY71EplPSLscTLFTbngggu3ID9zyYFCth0TGFSeugzlmPpO2ETgMsj4+y6HDjHNC1GoEJeHgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment is slightly wrong. DAMOS filters are not only for pages, but general bytes of memory. Also the description of 'matching' is bit confusing, since DAMOS filters do only filtering out. Update the comments to be less confusing. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 298b1a831e62..72afba74ac6d 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -347,8 +347,8 @@ enum damos_filter_type { /** * struct damos_filter - DAMOS action target memory filter. - * @type: Type of the page. - * @matching: If the matching page should filtered out or in. + * @type: Type of the target memory. + * @matching: If the @type-matching memory should be filtered out. * @memcg_id: Memcg id of the question if @type is DAMOS_FILTER_MEMCG. * @addr_range: Address range if @type is DAMOS_FILTER_TYPE_ADDR. * @target_idx: Index of the &struct damon_target of @@ -357,9 +357,10 @@ enum damos_filter_type { * @list: List head for siblings. * * Before applying the &damos->action to a memory region, DAMOS checks if each - * page of the region matches to this and avoid applying the action if so. - * Support of each filter type depends on the running &struct damon_operations - * and the type. Refer to &enum damos_filter_type for more detai. + * byte of the region matches to this given condition and avoid applying the + * action if so. Support of each filter type depends on the running &struct + * damon_operations and the type. Refer to &enum damos_filter_type for more + * details. */ struct damos_filter { enum damos_filter_type type;